Re: [PATCH] Fix XineramaQueryScreens for reverse prime

2016-03-10 Thread Timo Aaltonen
09.02.2016, 00:23, Adam Jackson kirjoitti: > On Mon, 2016-02-08 at 14:17 +1000, Dave Airlie wrote: >> On 4 February 2016 at 23:06, Jan Burgmeier >> wrote: >>> Bugzilla: https://bugs.freedesktop.org/92313 >> >> Reviewed-by: Dave Airlie >> >> though it might be nice to have some more info from the

Re: [PATCH xserver 2/2] glamor: Source pictures are always depth 32

2016-03-10 Thread Timo Aaltonen
08.03.2016, 22:18, Adam Jackson kirjoitti: > On Tue, 2016-02-23 at 17:19 +0900, Michel Dänzer wrote: >> From: Michel Dänzer >> >> We were using the destination pixmap depth to determine the source >> picture format. >> >> Fixes incorrect text rendering with some MATE desktop GTK3 themes. >> >> Bug

Re: [PATCH xserver] glamor: Make context current in glamor_pixmap_fbo_cache_put

2016-03-10 Thread Dave Airlie
On 11 March 2016 at 13:21, Michel Dänzer wrote: > From: Michel Dänzer > > Without this, we may be manipulating the context of another screen. > > In a system with two GPUs using glamor, this fixes lots of > > (EE) glamor256: GL error: GL_INVALID_OPERATION in glBindTexture(non-gen name) > > spew s

[PATCH xserver] glamor: Make context current in glamor_pixmap_fbo_cache_put

2016-03-10 Thread Michel Dänzer
From: Michel Dänzer Without this, we may be manipulating the context of another screen. In a system with two GPUs using glamor, this fixes lots of (EE) glamor256: GL error: GL_INVALID_OPERATION in glBindTexture(non-gen name) spew since 0b4c0c75 ('glamor: Replace "finish access" shader with tex

Re: [PATCH] glamor: add glamor_finish API

2016-03-10 Thread Michel Dänzer
On 11.03.2016 08:22, Dave Airlie wrote: > From: Dave Airlie > > Some drivers are calling glFinish, they really should be doing this. > > This also is needed for some reverse prime scenarios. > > Signed-off-by: Dave Airlie > --- > glamor/glamor.c | 9 + > glamor/glamor.h | 1 + > 2 fil

Re: [PATCH 2/2] glamor: use write only for putimage in some cases

2016-03-10 Thread Michel Dänzer
On 11.03.2016 10:17, Dave Airlie wrote: > From: Dave Airlie > > Ilia pointed out that xlock -mode wator is slow, this speeds it > up by avoiding the ReadPixels on every frame. > > The current criteria for putimage is > > a) ALU copy operation > b) planemask all set > c) region is contained insi

[PATCH 2/2] glamor: use write only for putimage in some cases

2016-03-10 Thread Dave Airlie
From: Dave Airlie Ilia pointed out that xlock -mode wator is slow, this speeds it up by avoiding the ReadPixels on every frame. The current criteria for putimage is a) ALU copy operation b) planemask all set c) region is contained inside pCompositeClip Signed-off-by: Dave Airlie --- glamor/g

[PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

2016-03-10 Thread Dave Airlie
From: Michel Dänzer [airlied: rebased onto master - I left WO alone as it's more like the GL interface review suggested changing it to bits.] Reviewed-by: Dave Airlie Signed-off-by: Michel Dänzer Signed-off-by: Dave Airlie --- glamor/glamor_prepare.c | 16 +++- glamor/glamor_priv

[PATCH] glamor: add glamor_finish API

2016-03-10 Thread Dave Airlie
From: Dave Airlie Some drivers are calling glFinish, they really should be doing this. This also is needed for some reverse prime scenarios. Signed-off-by: Dave Airlie --- glamor/glamor.c | 9 + glamor/glamor.h | 1 + 2 files changed, 10 insertions(+) diff --git a/glamor/glamor.c b/g

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

2016-03-10 Thread Benoit Gschwind
Hello, Here is my little contribution to the discussion, following a discussion on #wayland irc channel. The issue discussed here, as far I understood, is due to a client that miss interpret a high latency of the compositor as a repeating key. This happen when a client receive a key press event b

Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

2016-03-10 Thread Adam Jackson
On Thu, 2016-03-10 at 11:45 -0800, Eric Anholt wrote: > > I think some compilers/static checkers will whine unless this is a do { > ... } while (0) macro, becauuse of the "stray" semicolons we end up with > otherwise.  With that changed, > > Reviewed-by: Eric Anholt Did this (and Julien's #unde

Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

2016-03-10 Thread Julien Cristau
On Thu, Mar 10, 2016 at 13:25:03 -0500, Adam Jackson wrote: > No functional change, just a little easier to read and harder to get > wrong. > > Signed-off-by: Adam Jackson > --- > glx/glxcmds.c | 38 +++--- > 1 file changed, 15 insertions(+), 23 deletions(-) > >

Re: [PATCH] [RFC] glamor: implement write-only prepares

2016-03-10 Thread Eric Anholt
Dave Airlie writes: > From: Dave Airlie > > For some putimages we know we won't ever care about the data we readback, > we are going to trash it with the putimage contents. So implement > GLAMOR_ACCESS_WO mode. > > This will avoid doing the readbacks. Use it for putimages that are copy > with a

Re: [PATCH xserver 4/4] glx: Implement GLX_EXT_fbconfig_packed_float

2016-03-10 Thread Eric Anholt
Adam Jackson writes: > The tokens for this are already defined by GLX_ARB_fbconfig_float, which > we already support, so just add the extension to the list and let the > driver provide those configs if it wants. The last 3 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signatur

Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

2016-03-10 Thread Eric Anholt
Adam Jackson writes: > No functional change, just a little easier to read and harder to get > wrong. > > Signed-off-by: Adam Jackson > --- > glx/glxcmds.c | 38 +++--- > 1 file changed, 15 insertions(+), 23 deletions(-) > > diff --git a/glx/glxcmds.c b/glx/glxcmd

[PATCH xserver 4/4] glx: Implement GLX_EXT_fbconfig_packed_float

2016-03-10 Thread Adam Jackson
The tokens for this are already defined by GLX_ARB_fbconfig_float, which we already support, so just add the extension to the list and let the driver provide those configs if it wants. Signed-off-by: Adam Jackson --- glx/extension_string.c | 1 + glx/extension_string.h | 1 + glx/glxdri2.c

[PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

2016-03-10 Thread Adam Jackson
No functional change, just a little easier to read and harder to get wrong. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 6eb3541..65d0739 100644 --- a

[PATCH xserver 2/4] glx: Add GLX_SCREEN to the GetDrawableAttributes response

2016-03-10 Thread Adam Jackson
libglvnd would like to use this to map from drawable to screen, so it can know which driver to dispatch to. Refer to the spec proposal here: https://lists.freedesktop.org/archives/mesa-dev/2016-March/109543.html Signed-off-by: Adam Jackson --- glx/glxcmds.c | 3 ++- 1 file changed, 2 insertions

[PATCH xserver 3/4] glx: Implement GLX_EXT_stereo_tree

2016-03-10 Thread Adam Jackson
This is correct as it is, but only because we know no DRI drivers implement stereo. v2: Use new ATTRIB macro Reviewed-by: James Jones Signed-off-by: Adam Jackson --- glx/extension_string.c | 1 + glx/extension_string.h | 1 + glx/glxcmds.c | 10 +- 3 files changed, 11 insert

Re: [PATCH xserver 00/12] glamor_picture.c total rewrite

2016-03-10 Thread Adam Jackson
On Mon, 2016-02-01 at 13:58 -0800, Eric Anholt wrote: > I started incrementally cleaning up glamor_picture.c after being > surprised by its behavior during the last series, and ended up with a > total rewrite.  There will be some small losses in acceleration paths > for GLES2, but since GLES2 hasn'

Re: [PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-03-10 Thread Michel Dänzer
On 10.03.2016 18:21, Martin Peres wrote: > On 05/03/16 06:20, Michel Dänzer wrote: >> >>> I will provide an xtrace for this as soon as I can, but I wanted to >>> provide you with a heads'up! >> >> FWIW, it'll be interesting to see the values of vblank->target_msc, >> crtc_msc and ust in present_exe

Re: [PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-03-10 Thread Martin Peres
On 05/03/16 06:20, Michel Dänzer wrote: [ Sorry for the late followup; I was down with the flu ] On 01.03.2016 20:26, Martin Peres wrote: On 25/02/16 17:28, Adam Jackson wrote: On Thu, 2016-02-25 at 09:49 +, Chris Wilson wrote: On Wed, Feb 24, 2016 at 04:52:59PM +0900, Michel Dänzer wrot

Re: Re-send: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-10 Thread Olivier Fourdan
Hi, - Original Message - > > [...] > Right, I am still not too familiar with the patch process for X.Org. > How do I mark the re-sent one, which as you said does not apply cleanly, > as superseded? You need to create an account in patchwork https://patchwork.freedesktop.org/ and link tha

Re: Re-send: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-10 Thread Michael Thayer
Hello Olivier, On 10.03.2016 09:11, Olivier Fourdan wrote: Hi Michael, [...] Re-sending as this did not seem to get noticed much the first time. I am not doing a formal review of your patch as it's outside of my area of competences, just a few comments, trying to help. Thank you, help welc

Re: Re-send: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-10 Thread Olivier Fourdan
Hi Michael, [...] > Re-sending as this did not seem to get noticed much the first time. I am not doing a formal review of your patch as it's outside of my area of competences, just a few comments, trying to help. I am not sure re-sending the patch as-is is the best course of action here, usual