Re: [PATCH xserver 6/9 v2] xfree86: Make xf86SetDDCproperties work more than once (v2)

2016-04-15 Thread Michel Dänzer
On 16.04.2016 01:22, Adam Jackson wrote: > We can call this more than once via xf86OutputSetEDID since hotplug is > actually a thing in RANDR 1.2, but xf86RegisterRootWindowProperty merely > adds the data to a list to be applied to the root at CreateWindow time, > so calls past the first (for a giv

Re: [PATCH xserver] xwayland: Fix compiler warning in GLAMOR Xv

2016-04-15 Thread Emil Velikov
Hi all, On 15 April 2016 at 21:23, Adam Jackson wrote: > On Fri, 2016-04-15 at 05:01 -0400, Olivier Fourdan wrote: >> Hi all, >> >> Gentle reminder, I sent this patch 2 weeks ago, could someone please >> review this fairly trivial fix for me? > Just a quick one (don't mean to high-jack the thread

Re: [PATCH xserver RFC v2] glamor: fix wrong offset on composite rectangles

2016-04-15 Thread Adam Jackson
On Fri, 2016-04-15 at 04:57 -0400, Olivier Fourdan wrote: > Hi all, > > Gentle reminder, could someone please review or give some feedback on > this patch? > > If this is not the right fix, just let me know. Yet the problem is > real and reproducible (see the reproducer I attached in the bug) re

Re: [PATCH xserver] xwayland: Fix compiler warning in GLAMOR Xv

2016-04-15 Thread Adam Jackson
On Fri, 2016-04-15 at 05:01 -0400, Olivier Fourdan wrote: > Hi all, > > Gentle reminder, I sent this patch 2 weeks ago, could someone please > review this fairly trivial fix for me? remote: I: patch #79206 updated using rev e8e5d839968e22cf42a6e1982a07b02c6f4a4562. remote: I: 1 patch(es) updated

Re: [PATCH xserver] xkb: fix SlowKeys release/reject beeps

2016-04-15 Thread Adam Jackson
On Tue, 2016-04-12 at 11:39 +0100, Daniel Stone wrote: > On 12 April 2016 at 06:48, Peter Hutterer > wrote: > > > > On Tue, Mar 08, 2016 at 03:42:42PM +1000, Peter Hutterer wrote: > > > > > > Wrong use of the mask here caused a beep whenever a key was > > > rejected but also > > > when it was re

Re: [PATCH xserver] xfree86/modes: Remove xf86_reload_cursors v2

2016-04-15 Thread Adam Jackson
On Thu, 2016-04-14 at 18:55 +0900, Michel Dänzer wrote: > From: Michel Dänzer > > No longer needed now that xf86CursorResetCursor is getting called for > each CRTC configuration change. > > v2: Keep xf86_reload_cursors as a deprecated empty inline function > until all drivers stop calling it

Re: [PATCH libICE] Enable visibility annotations

2016-04-15 Thread Adam Jackson
On Thu, 2016-04-14 at 09:50 +0300, Yury Gribov wrote: > Hi all, > > This patch adds visibility annotations to public functions in libICE and > also enables -fvisibility=hidden on platforms where it's available. > > This results in 10% size decrease (101K -> 92K) and 50% export symbols > reduction

Re: [PATCH xserver v2 7/9] xfree86: Remove a never-hit diagnostic message

2016-04-15 Thread Adam Jackson
On Mon, 2016-04-11 at 14:25 +0200, walter harms wrote: > edidSize() checks for if (DDC->ver.version != 1) (see 6/9) > so this is bogus either ? I suppose the check in edidSize isn't strictly necessary. DDC2_Read will always return a validly-sized block, so the math we do here will be correct. Its

[PATCH xserver 6/9 v2] xfree86: Make xf86SetDDCproperties work more than once (v2)

2016-04-15 Thread Adam Jackson
We can call this more than once via xf86OutputSetEDID since hotplug is actually a thing in RANDR 1.2, but xf86RegisterRootWindowProperty merely adds the data to a list to be applied to the root at CreateWindow time, so calls past the first (for a given screen) would have no effect until server rege

Re: [PATCH xserver] xwayland: Fix compiler warning in GLAMOR Xv

2016-04-15 Thread Olivier Fourdan
Hi all, Gentle reminder, I sent this patch 2 weeks ago, could someone please review this fairly trivial fix for me? Cheers, Olivier - Original Message - > XvWindowMask is defined as 0x0002 and cannot fit in the XvAdaptor > type which is defined as an unsigned char, thus causing a co

Re: [PATCH xserver RFC v2] glamor: fix wrong offset on composite rectangles

2016-04-15 Thread Olivier Fourdan
Hi all, Gentle reminder, could someone please review or give some feedback on this patch? If this is not the right fix, just let me know. Yet the problem is real and reproducible (see the reproducer I attached in the bug) Thanks Olivier - Original Message - > Hi all, > > Anyone to gi