Re: [PATCH xserver 4/4] damage: Make damageRegionProcessPending take a damage not a drawable

2016-04-29 Thread Michel Dänzer
On 30.04.2016 03:22, Adam Jackson wrote: > In the case where there's no damage monitor on the drawable, we look > that fact up twice: once before rendering to decide whether to compute > damage, and again after to decide whether to append it. This is wasted > effort, as the layer below us is effect

Re: [PATCH v5 00/13] PRIME Synchronization

2016-04-29 Thread Alex Goins
D'oh, I was still running mutter with vblank_mode=0 from when I had no native heads present. Now it's using the Present extension to wait for vblank, but not to flip. Still not seeing the issues described. Thanks, Alex On Sat, 30 Apr 2016, Alex Goins wrote: > So far I've been unable to reproduce

Re: [PATCH v5 00/13] PRIME Synchronization

2016-04-29 Thread Alex Goins
So far I've been unable to reproduce this, but I don't see the Present extension being used. What exactly is your setup to get mutter running against X using DRI3? I've ensured that DRI3 page flipping is enabled (it's required for PRIME synchronization too anyway), and glamor_egl->dri3_capable ==

Re: [PATCH v5 01/13] xf86: Add PRIME flipping functions to Screen

2016-04-29 Thread Alex Goins
I meant __GL_SYNC_DISPLAY_DEVICE=. Thanks Alex On Fri, 29 Apr 2016, Alex Goins wrote: > The reference implementation in modesetting doesn't use it, but our driver > uses > it so that we can be aware of the outputs available on the CRTC. > > This allows users to set __GL_SYNC_TO_VBLANK= so that

Re: [PATCH v5 00/13] PRIME Synchronization

2016-04-29 Thread Alex Goins
> Okay I've finally gotten around to playing with these today. Thanks!! > I'm using a i915 + nouveau system with nouveau running as the master. Both > using modesetting DDX. > > The basics seem to work okay, but I am seeing some issues I'm not 100% sure > are the fault of these patches. > > Sce

Re: [PATCH v5 01/13] xf86: Add PRIME flipping functions to Screen

2016-04-29 Thread Alex Goins
The reference implementation in modesetting doesn't use it, but our driver uses it so that we can be aware of the outputs available on the CRTC. This allows users to set __GL_SYNC_TO_VBLANK= so that OpenGL applications can sync to the slave's vblank in the same fashion that they do for native head

[PATCH xserver 0/4] Performance tuning for small ops

2016-04-29 Thread Adam Jackson
tl;dr: before after Operation - 1923358.8 2253822.2 (1.172) Copy 10x10 from window to window 1650543.1 1968869.9 (1.193) PutImage 10x10 square 1713902.4 2250849.1 (1.313) ShmPutIm

[PATCH xserver 1/4] dix: Push UpdateCurrentTimeIf down out of the main loop

2016-04-29 Thread Adam Jackson
This was added in: commit 312910b4e34215aaa50fc0c6092684d5878dc32f Author: Chase Douglas Date: Wed Apr 18 11:15:40 2012 -0700 Update currentTime in dispatch loop Unfortunately this is equivalent to calling GetTimeInMillis() once per request. In the absolute best case (as o

[PATCH xserver 4/4] damage: Make damageRegionProcessPending take a damage not a drawable

2016-04-29 Thread Adam Jackson
In the case where there's no damage monitor on the drawable, we look that fact up twice: once before rendering to decide whether to compute damage, and again after to decide whether to append it. This is wasted effort, as the layer below us is effectively not allowed to change whether there's a dam

[PATCH xserver 2/4] xace: Remove the audit hooks and tune dispatch

2016-04-29 Thread Adam Jackson
There are no in-tree consumers of the audit hooks, and they are in any case redundant with the dtrace dispatch hooks. Neither is there any in-tree user of the core request dispatch hook. The extension hook is only used for non-default security cases, but in the absence of LTO we always have to take

[PATCH xserver 3/4] dix: Convert ResourceClientBits to a variable

2016-04-29 Thread Adam Jackson
This turns out to be a remarkably hot function in XID lookup. Consider the expansion of CLIENT_ID. We start with: #define RESOURCE_CLIENT_BITS ResourceClientBits() #define RESOURCE_AND_CLIENT_COUNT 29 #define CLIENTOFFSET (RESOURCE_AND_CLIENT_COUNT - RESOURCE_CLIENT_BITS) So that's effectivel

Re: [PATCH 2/6] randr/provider: only allow slave gpu to be offload sources.

2016-04-29 Thread Alexander E. Patrakov
29.04.2016 09:01, Dave Airlie wrote: The other way around makes no sense. Not sure. My old (and now broken) Sony VAIO Z23A4R laptop had outputs attached to both Intel and Radeon GPUs. I don't know whether the Radeon card had this isGPU flag. -- Alexander E. Patrakov Signed-off-by: Dave

Re: misc prime/modesetting fixes

2016-04-29 Thread Alex Deucher
On Fri, Apr 29, 2016 at 12:01 AM, Dave Airlie wrote: > The first patch is picked from Alex Goins' series as a cleanup, > I then got distracted fixing other minor things I found just testing > prime with modesetting. > > Finally Alex's series showed up a bug we have currently leaking > the slave BO

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
On Fri, Apr 29, 2016 at 5:31 PM Julien Cristau wrote: > On Fri, Apr 29, 2016 at 15:25:40 +, Robert Ancell wrote: > > > On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote: > > > > Your footnotes seem to have gone missing. > > > > > > > Not sure what you mean by footnotes? > > > The [2] and [3

Re: [PATCH libICE] Enable visibility annotations

2016-04-29 Thread Yury Gribov
On 04/29/2016 04:28 PM, Emil Velikov wrote: On 28 April 2016 at 15:28, Yury Gribov wrote: On 04/28/2016 04:59 PM, Emil Velikov wrote: On 27 April 2016 at 08:48, Yury Gribov wrote: On 04/26/2016 02:14 PM, Emil Velikov wrote: On 26 April 2016 at 07:54, Yury Gribov wrote: On 04/20/2016

Re: [PATCH libICE] Enable visibility annotations

2016-04-29 Thread Yury Gribov
On 04/29/2016 04:31 PM, Emil Velikov wrote: Hi Jon, On 28 April 2016 at 17:38, Jon Turney wrote: On 28/04/2016 14:59, Emil Velikov wrote: Are you sure that think this is correct ? Afaict things should work, despite that xserver sets SYMBOL_VISIBILITY=no. Jon, any ideas why xserver disables

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Julien Cristau
On Fri, Apr 29, 2016 at 15:25:40 +, Robert Ancell wrote: > On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote: > > > On Fri, 2016-04-29 at 11:11 +0200, Robert Ancell wrote: > > > This is currently used in Ubuntu to allow X applications and sessions to > > run in > > > newer versions of Unity

Re: [PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

2016-04-29 Thread Adam Jackson
On Fri, 2016-04-29 at 17:18 +0200, Julien Cristau wrote: > > Any chance that can apply to 1/2 as well? > > > Yes.  Yes you can. Merci beaucoup: remote: E: failed to find patch for rev a5dd7b890f4f3a5245639591c73303c5a087b38a. remote: E: failed to find patch for rev c33250945b45adc447154239f0c

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote: > On Fri, 2016-04-29 at 11:11 +0200, Robert Ancell wrote: > > This is currently used in Ubuntu to allow X applications and sessions to > run in > > newer versions of Unity 8. For example, this allows applications like > GIMP to > > run on mobile

Re: [PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

2016-04-29 Thread Julien Cristau
On Fri, Apr 29, 2016 at 11:16:08 -0400, Adam Jackson wrote: > On Fri, 2016-04-29 at 17:01 +0200, Julien Cristau wrote: > > On Fri, Apr 29, 2016 at 10:53:22 -0400, Adam Jackson wrote: > > > > > gcc6 says: > > > > > > keyboard.c:46:21: warning: ‘linux_to_x’ defined but not used > > > > > > Only r

Re: [PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

2016-04-29 Thread Adam Jackson
On Fri, 2016-04-29 at 17:01 +0200, Julien Cristau wrote: > On Fri, Apr 29, 2016 at 10:53:22 -0400, Adam Jackson wrote: > > > gcc6 says: > > > > keyboard.c:46:21: warning: ‘linux_to_x’ defined but not used > > > > Only referenced by a bunch of long if-0'd code, so chuck it all out. > > > > Signe

Re: [PATCH] fix typo in supported sample sizes and maximum bit rate

2016-04-29 Thread Adam Jackson
On Thu, 2016-04-28 at 13:39 +0100, Eric Engestrom wrote: > On Wed, Apr 27, 2016 at 07:23:15PM +, Reinhard Zitzmann wrote: > > git://anongit.freedesktop.org/xorg/app/edid-decode master > > > > You should always CC: the mailing list, so everyone can see the answer. > > Reviewed-by: Eric Engest

Re: [PATCH xserver] Change include order to avoid conflict with system header

2016-04-29 Thread Adam Jackson
On Thu, 2016-04-28 at 14:47 +0200, Stefan Dirsch wrote: > From: Andreas Schwab > > R_SP is also defined in on m68k. > Also remove duplicate definitions. > > Signed-off-by: Andreas Schwab remote: I: patch #84260 updated using rev 23dfa017298ceceac818f83779858e490c7757b6. remote: I: 1 patch(es

Re: [PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

2016-04-29 Thread Julien Cristau
On Fri, Apr 29, 2016 at 10:53:22 -0400, Adam Jackson wrote: > gcc6 says: > > keyboard.c:46:21: warning: ‘linux_to_x’ defined but not used > > Only referenced by a bunch of long if-0'd code, so chuck it all out. > > Signed-off-by: Adam Jackson > --- > hw/kdrive/linux/keyboard.c | 441 > --

[PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

2016-04-29 Thread Adam Jackson
gcc6 says: keyboard.c:46:21: warning: ‘linux_to_x’ defined but not used Only referenced by a bunch of long if-0'd code, so chuck it all out. Signed-off-by: Adam Jackson --- hw/kdrive/linux/keyboard.c | 441 - 1 file changed, 441 deletions(-) diff --

Re: [PATCH xserver] xfree86: add support for MatchIsTabletPad

2016-04-29 Thread Adam Jackson
On Wed, 2016-04-27 at 08:48 +1000, Peter Hutterer wrote: > The tablet pads have been separate kernel devices for a while now and > libwacom has labelled them with the udev ID_INPUT_TABLET_PAD for over a year > now. Add a new MatchIsTabletPad directive to apply configuration options > specifically t

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Adam Jackson
On Fri, 2016-04-29 at 11:11 +0200, Robert Ancell wrote: > This is currently used in Ubuntu to allow X applications and sessions to run > in > newer versions of Unity 8. For example, this allows applications like GIMP to > run on mobile devices like the Bq Aquaris M10 [2] (currently shipping). > >

Re: [PATCH] glamor: add glamor_finish API

2016-04-29 Thread Adam Jackson
On Fri, 2016-04-29 at 13:57 +1000, Dave Airlie wrote: > On 12 March 2016 at 09:59, Eric Anholt wrote: > > Dave Airlie writes: > > > > > From: Dave Airlie > > > > > > Some drivers are calling glFinish, they really should be doing this. > > > > > > This also is needed for some reverse prime sce

Re: [PATCH libICE] Enable visibility annotations

2016-04-29 Thread Emil Velikov
On 28 April 2016 at 15:28, Yury Gribov wrote: > On 04/28/2016 04:59 PM, Emil Velikov wrote: >> >> On 27 April 2016 at 08:48, Yury Gribov wrote: >>> >>> On 04/26/2016 02:14 PM, Emil Velikov wrote: On 26 April 2016 at 07:54, Yury Gribov wrote: > > > On 04/20/2016 10:03 A

Re: [PATCH libICE] Enable visibility annotations

2016-04-29 Thread Emil Velikov
Hi Jon, On 28 April 2016 at 17:38, Jon Turney wrote: > On 28/04/2016 14:59, Emil Velikov wrote: >> >> Are you sure that think this is correct ? Afaict things should work, >> despite that xserver sets SYMBOL_VISIBILITY=no. >> >> Jon, any ideas why xserver disables -fvisibility=hidden ? Should we >

Re: [PATCH xserver] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2016-04-29 Thread Stefan Dirsch
On Fri, Apr 29, 2016 at 09:40:05AM +0200, Julien Cristau wrote: > On Thu, Apr 28, 2016 at 15:21:15 +0200, Stefan Dirsch wrote: > > > From: Reinhard Max > > > > For IPv6 add a link local addresses to the end of the list passed to > > the XDMCP servers. > > Reason: for link local addresses the XDM

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
The following email with the patch is just over 100k in size and thus is stuck in the moderation queue.. On Fri, Apr 29, 2016 at 11:11 AM Robert Ancell wrote: > This is currently used in Ubuntu to allow X applications and sessions to > run in > newer versions of Unity 8. For example, this allows

[PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
This is currently used in Ubuntu to allow X applications and sessions to run in newer versions of Unity 8. For example, this allows applications like GIMP to run on mobile devices like the Bq Aquaris M10 [2] (currently shipping). The proposed patch allows software based rendering only. The XMir us

Re: [PATCH xserver] prime: clean up slave bo properly. (v2)

2016-04-29 Thread Dave Airlie
On 29 April 2016 at 17:56, Julien Cristau wrote: > On Fri, Apr 29, 2016 at 15:54:28 +1000, Dave Airlie wrote: > >> This is an ABI break, in that we now pass NULL to a function >> that hasn't accepted it before. >> >> Alex Goins had a different patch for this but it wasn't symmetrical, >> it freed

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

2016-04-29 Thread Stefan Dirsch
On Fri, Apr 29, 2016 at 10:24:17AM +0200, Mark Kettenis wrote: > > Date: Fri, 29 Apr 2016 09:34:08 +0200 > > From: Julien Cristau > > > > On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote: > > > > > > From: Stefan Dirsch > > > > Date: Thu, 28 Apr 2016 14:35:00 +0200 > > > > > > > > B

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

2016-04-29 Thread Mark Kettenis
> Date: Fri, 29 Apr 2016 09:34:08 +0200 > From: Julien Cristau > > On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote: > > > > From: Stefan Dirsch > > > Date: Thu, 28 Apr 2016 14:35:00 +0200 > > > > > > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See > > > https://b

Re: [PATCH xserver] prime: clean up slave bo properly. (v2)

2016-04-29 Thread Julien Cristau
On Fri, Apr 29, 2016 at 15:54:28 +1000, Dave Airlie wrote: > This is an ABI break, in that we now pass NULL to a function > that hasn't accepted it before. > > Alex Goins had a different patch for this but it wasn't symmetrical, > it freed something in a very different place than it allocated it,

Re: [PATCH xserver] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2016-04-29 Thread Julien Cristau
On Thu, Apr 28, 2016 at 15:21:15 +0200, Stefan Dirsch wrote: > From: Reinhard Max > > For IPv6 add a link local addresses to the end of the list passed to > the XDMCP servers. > Reason: for link local addresses the XDMCP server would need to either > know the interface thru a scope identifier or

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

2016-04-29 Thread Julien Cristau
On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote: > > From: Stefan Dirsch > > Date: Thu, 28 Apr 2016 14:35:00 +0200 > > > > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See > > https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details. > > I think selectivel