Re: [PATCH libICE] Enable visibility annotations

2016-05-14 Thread Emil Velikov
On 13 May 2016 at 07:33, Yury Gribov wrote: > On 05/10/2016 03:00 PM, Yury Gribov wrote: >> >> On 05/06/2016 07:25 PM, Alan Coopersmith wrote: >>> >>> On 05/ 6/16 04:18 AM, Yury Gribov wrote: Unfortunately I don't see any good approach. We could move

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-14 Thread Keith Packard
Eric Anholt writes: > Oh, yeah. Even better. And a v3 which catches the other place where GL_BLEND is getting set. Sent that under a separate cover along with a more complicated patch for the red/alpha swizzling stuff. -- -keith signature.asc Description: PGP signature

Re: [PATCH] glamor: swizzle RED to 0 for alpha textures.

2016-05-14 Thread Keith Packard
Keith Packard writes: > And, loading a page from gfycat is broken by this change. > > firefox https://gfycat.com/HoarseCheapAmericankestrel > > So, we can either have feedly with black text or gfycat with > cat videos, but not both at the same time. I'm not sure I can live in

[PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

2016-05-14 Thread Keith Packard
If the logic op gets left enabled, it overrides the blending operation, causing incorrect contents on the display. v2: Disable only on non-ES2, but disable even for PictOpSrc v3: Found another place this is needed in glamor_composite_set_shader_blend Signed-off-by: Keith Packard

[PATCH xserver 3/3] glamor: Preserve GL_RED bits in R channel when destination is GL_RED

2016-05-14 Thread Keith Packard
A1 and A8 pixmaps are usually stored in the Red channel to conform with more recent GL versions. When using these pixmaps as mask values, that works great. When using these pixmaps as source values, then the value we want depends on what the destination looks like. For RGBA or RGB destinations,

[PATCH xserver 2/3] glamor: glamor_make_current sooner in glamor_composite_with_shader

2016-05-14 Thread Keith Packard
glamor_make_current is supposed to be called before any GL APIs. Signed-off-by: Keith Packard --- glamor/glamor_render.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c index ea9abc7..1e03ca0 100644 ---