Re: [PATCH xserver 7/9] dix: Reallocate touchpoint buffer at input event time

2016-05-15 Thread Keith Packard
Peter Hutterer writes: > fwiw, that first sentence isn't correct anymore, you can drop it. > rev-by still stands. I've edited the comment, along with re-adding the UseSIGIO option to the parsing code and pushed out an updated thread with all of your kind Rb/Ab lines added. We have but the two gi

Re: [PATCH xserver 2/9] Remove SIGIO support for input [v3]

2016-05-15 Thread Keith Packard
Peter Hutterer writes: Thanks for taking a look at these. This one is less mechanical than I'd like, so some of the changes aren't obvious. It's definitely good to review them carefully. >> KdNotifyFd(int fd, int ready, void *data) >> { >> int i = (int) (intptr_t) data; >> -OsBlockSIG

Re: [PATCH xserver 6/9] mi: Grow event queue while reading events

2016-05-15 Thread Peter Hutterer
On Wed, May 11, 2016 at 01:54:55PM -0700, Keith Packard wrote: > Now that events are read at normal process time, we can use malloc to > grow the event queue instead of discarding events. > > Signed-off-by: Keith Packard Reviewed-by: Peter Hutterer Cheers, Peter > --- > mi/mieq.c | 103 >

Re: [PATCH xserver 7/9] dix: Reallocate touchpoint buffer at input event time

2016-05-15 Thread Peter Hutterer
On Wed, May 11, 2016 at 01:54:56PM -0700, Keith Packard wrote: > Now that input is threaded, malloc can be used at event time to resize > the touchpoint buffer as needed.x > > Signed-off-by: Keith Packard > Reviewed-by: Peter Hutterer > --- > dix/touch.c | 89 > +---

Re: [PATCH xserver 3/9] xfree86: Remove unnecessary errno save/restore in xf86ReadInput

2016-05-15 Thread Peter Hutterer
On Wed, May 11, 2016 at 01:54:52PM -0700, Keith Packard wrote: > When this code was called from SIGIO, saving and restoring errno could > possibly have made sense in some strange environment. Now that this > will not be called from a signal handler, there is no reason to do that. > > Signed-off-by

Re: [PATCH xserver 4/9] xkb: Hold input lock across injected key event processing

2016-05-15 Thread Peter Hutterer
On Wed, May 11, 2016 at 01:54:53PM -0700, Keith Packard wrote: > This makes the code more consistent with other versions of > out-of-queue event processing > > Signed-off-by: Keith Packard Reviewed-by: Peter Hutterer Cheers, Peter > --- > xkb/xkbActions.c | 3 +-- > 1 file changed, 1 inse

Re: [PATCH xserver 1/9] xfree86: Set xf86CrtcConfigRec cursor pointer to NULL in HideCursor

2016-05-15 Thread Peter Hutterer
On Wed, May 11, 2016 at 01:54:50PM -0700, Keith Packard wrote: > This makes the cursor pointer held by xf86Cursors.c get reset to NULL > whenever the cursor isn't displayed, and means that the reference > count held in xf86Cursor.c is sufficient to cover the reference in > xf86Cursors.c. > > As Hi

Re: [PATCH xserver] Input: Send XI2 FocusOut NotifyPointer events to the pointer window.

2016-05-15 Thread Peter Hutterer
On Tue, Dec 29, 2015 at 11:41:27PM -0800, Andrew Comminos wrote: > This changes XInput 2's propagation of NotifyPointer focus out events to > include the pointer window as well, similar to core events. This fixes > a potential permanent focus in GDK when the focus moves to PointerRoot. > > Fixes:

Re: [PATCH xserver 2/9] Remove SIGIO support for input [v3]

2016-05-15 Thread Peter Hutterer
On Wed, May 11, 2016 at 01:54:51PM -0700, Keith Packard wrote: > This removes all of the SIGIO handling support used for input > throughout the X server, preparing the way for using threads for input > handling instead. > > Places calling OsBlockSIGIO and OsReleaseSIGIO are marked with calls > to

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

2016-05-15 Thread Keith Packard
Emil Velikov writes: > This hunk should be in 3/3, shouldn't it ? Yup, thanks for the catch! Series re-pushed to my 'render-fixes' branch, no change in the final version. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

2016-05-15 Thread Emil Velikov
Hi Keith, On 14 May 2016 at 16:52, Keith Packard wrote: > diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c > index 65f7059..ea9abc7 100644 > --- a/glamor/glamor_render.c > +++ b/glamor/glamor_render.c > @@ -1075,10 +1075,14 @@ > glamor_composite_set_shader_blend(glamor_screen_privat

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

2016-05-15 Thread Keith Packard
Hans de Goede writes: > Note I've not actually tested if these patches fix the issues at > hand, I've only run my normal stuff and did not notice any > regressions. I'm surprised no-one else has noticed the problems with libreoffice; random bits of GUI text rendered as black rectangles was prett

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

2016-05-15 Thread Hans de Goede
Hi, On 14-05-16 17:52, Keith Packard wrote: If the logic op gets left enabled, it overrides the blending operation, causing incorrect contents on the display. v2: Disable only on non-ES2, but disable even for PictOpSrc v3: Found another place this is needed in glamor_composite_set_shader_b