Re: [PATCH xserver 2/9] Remove SIGIO support for input [v3]

On Mon, May 16, 2016 at 01:24:21AM -0500, Keith Packard wrote: > Peter Hutterer writes: > > Thanks for taking a look at these. This one is less mechanical than I'd > like, so some of the changes aren't obvious. It's definitely good to > review them carefully. > > >>

Re: [PATCH xserver 7/7] glx: Conditionalize building indirect GLX support

Hi Adam, As some people (me alone?) finds all the ifdefined a bit annoying here are some ideas of how to resolve it. Other than that, there's a couple of serious suggestions inline, listing them here to just in case: - One should AC_ERROR when using --disable-glx --enable-iglx ? - How do we

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

Michel Dänzer writes: > https://bugs.freedesktop.org/show_bug.cgi?id=63397#c24 Some day I'll think to look at bugzilla when I fix a bug :-) I've added a comment and copy of the patch to that bug. -- -keith signature.asc Description: PGP signature

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

On 15.05.2016 19:48, Keith Packard wrote: I'm surprised no-one else has noticed the problems with libreoffice; random bits of GUI text rendered as black rectangles was pretty annoying to me. https://bugs.freedesktop.org/show_bug.cgi?id=63397#c24 -- Earthling Michel Dänzer|

Re: [PATCH xserver 7/9] dix: Reallocate touchpoint buffer at input event time

Peter Hutterer writes: > fwiw, that first sentence isn't correct anymore, you can drop it. > rev-by still stands. I've edited the comment, along with re-adding the UseSIGIO option to the parsing code and pushed out an updated thread with all of your kind Rb/Ab lines

Re: [PATCH xserver 2/9] Remove SIGIO support for input [v3]

Peter Hutterer writes: Thanks for taking a look at these. This one is less mechanical than I'd like, so some of the changes aren't obvious. It's definitely good to review them carefully. >> KdNotifyFd(int fd, int ready, void *data) >> { >> int i = (int)