[PULL xserver] Hook up colormaps and RandR 1.2 gamma ramps, present crash fix

2016-07-27 Thread Michel Dänzer
Hi Keith / Adam, I took the liberty of throwing in a present crash fix reviewed by Hans on top of the changes hooking up colormaps and RandR 1.2 gamma ramps. Feel free not to pull the present fix for now. The following changes since commit 0b2f30834b1a9f4a03542e25c5f54ae800df57e2: os: Clean

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread Keith Packard
Matt Turner writes: > I feel confident the compiler is already doing that transformation. I just tried and couldn't get the compiler to do it as the 'pow' function isn't declared with the 'const' attribute. That appears to be a bug in glibc. This code does what you'd expect: #include extern

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread Matt Turner
On Tue, Jul 26, 2016 at 7:25 AM, walter harms wrote: > > > Am 26.07.2016 11:11, schrieb Michel Dänzer: >> From: Michel Dänzer >> >> RRCrtcGammaSetSize cannot be used yet in xf86InitialConfiguration, >> because randr_crtc isn't allocated yet at that point, but a following >> change will require RR

Re: [PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v6

2016-07-27 Thread Keith Packard
Michel Dänzer writes: > [ Unknown signature status ] > On 28.07.2016 00:02, Keith Packard wrote: >> Michel Dänzer writes: >> >>> v6: >>> * Handle reallocarray failure in xf86RandR12LoadPalette (Keith Packard) >> >> Yeah, that'll work. >> >> Reviewed-by: Keith Packard > > Thanks! Does that ap

Re: [PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v6

2016-07-27 Thread Michel Dänzer
On 28.07.2016 00:02, Keith Packard wrote: > Michel Dänzer writes: > >> v6: >> * Handle reallocarray failure in xf86RandR12LoadPalette (Keith Packard) > > Yeah, that'll work. > > Reviewed-by: Keith Packard Thanks! Does that apply to the whole series? -- Earthling Michel Dänzer

Re: [PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v6

2016-07-27 Thread Keith Packard
Michel Dänzer writes: > v6: > * Handle reallocarray failure in xf86RandR12LoadPalette (Keith Packard) Yeah, that'll work. Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

[PATCH] xdm: add definition for libbsd headers

2016-07-27 Thread Alive 4ever
Add HAVE_BSD_UNISTD_H and HAVE_BSD_STDLIB_H definition to include 'bsd/unistd.h' and 'bsd/stdlib.h' headers. This fixes gcc 6.1.1 and clang 3.8.0 implicit function declaration error (setproctitle and arc4random) on Linux system with 'libbsd' headers under 'bsd' include directory. Signed-off-by: A

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread Michel Dänzer
On 27.07.2016 18:09, walter harms wrote: > Am 27.07.2016 04:39, schrieb Michel Dänzer: >> On 26.07.2016 23:25, walter harms wrote: >>> Am 26.07.2016 11:11, schrieb Michel Dänzer: diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c index 9f93270..5b24ebb

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread walter harms
Am 27.07.2016 04:39, schrieb Michel Dänzer: > On 26.07.2016 23:25, walter harms wrote: >> Am 26.07.2016 11:11, schrieb Michel Dänzer: >>> >>> diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c >>> index 9f93270..5b24ebb 100644 >>> --- a/hw/xfree86/modes/xf86RandR12.c >>>

Re: [PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v5

2016-07-27 Thread Michel Dänzer
On 27.07.2016 00:55, Keith Packard wrote: > Michel Dänzer writes: > >> +if (randrp->palette_size != palette_size) { >> +randrp->palette = reallocarray(randrp->palette, palette_size, >> + sizeof(colors[0])); > > Need error checking here. Fixed in

[PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v6

2016-07-27 Thread Michel Dänzer
From: Michel Dänzer Instead of breaking the former when the driver supports the latter, hook them up so that the hardware LUTs reflect the combination of the current colourmap and gamma states. I.e. combine the colourmap, the global gamma value/ramp and the RandR 1.2 per-CRTC gamma ramps into one