Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

2016-08-14 Thread Hans de Goede
Hi, On 12-08-16 16:09, walter harms wrote: Am 12.08.2016 12:11, schrieb Hans de Goede: Hi, On 28-07-16 19:31, walter harms wrote: janitorial patch: remove some unneeded if() before free() This is not free() but Xfree() and "man Xfree" states: "A NULL pointer cannot be passed to this fun

Re: [PATCH xserver] dix: Avoid writing uninitialized bytes in deliverPropertyNotifyEvent

2016-08-14 Thread Hans de Goede
Hi, On 13-08-16 18:06, Keith Packard wrote: Make sure the whole event is initialized, instead of leaving the pad bytes unset. Signed-off-by: Keith Packard LGTM: Reviewed-by: Hans de Goede Regards, Hans --- dix/property.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

Re: [PATCH xf86-input-libinput] Ensure parent devices are actual parent devices

2016-08-14 Thread Hans de Goede
Hi, On 15-08-16 02:57, Peter Hutterer wrote: The list returned by xf86FirstLocalDevice() includes our own device. If the parent device is removed before the hotplug callback is invoked, the first match with the same shared-device ID is our own device (or potentially another subdevice on the same

Re: [PATCH xserver 2/2] os: Abandon loop after poll call when array of fds has changed

2016-08-14 Thread Keith Packard
Peter Hutterer writes: > Reviewed-by: Peter Hutterer Both pushed. 69b782a..67fc5d6 master -> master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-dev

Re: [PATCH xserver 2/2] os: Abandon loop after poll call when array of fds has changed

2016-08-14 Thread Keith Packard
Peter Hutterer writes: >> -#if !HAVE_OSPOLL && HAVE_EPOLL_CREATE1 >> +#if !HAVE_OSPOLL && HAVE_EPOLL_CREATE1 && 0 > > that looks like a leftover? aside from that it looks good. Yeah, sorry, that's how I tested the poll path :-) -- -keith signature.asc Description: PGP signature

Re: [PATCH xserver] Build glamor when Xorg or Xephyr are built.

2016-08-14 Thread Keith Packard
Michel Dänzer writes: > What about Xwayland? Sorry, I didn't even think of that! -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x

Re: [PATCH xf86-input-libinput] Ensure parent devices are actual parent devices

2016-08-14 Thread Keith Packard
Peter Hutterer writes: > The list returned by xf86FirstLocalDevice() includes our own device. If the > parent device is removed before the hotplug callback is invoked, the first > match with the same shared-device ID is our own device (or potentially another > subdevice on the same already-remove

Re: [PATCH xserver 2/2] os: Abandon loop after poll call when array of fds has changed

2016-08-14 Thread Peter Hutterer
On Sat, Aug 13, 2016 at 09:11:18AM -0700, Keith Packard wrote: > If a file descriptor is added or removed from an ospoll callback, then > the arrays containing file descriptor information will have all of > their indices changed, so the loop state is no longer consistent. Just > bail out and let th

Re: [PATCH xserver 1/2] os: Delay freeing of epoll_wait return pointers until epoll is idle.

2016-08-14 Thread Peter Hutterer
On Sat, Aug 13, 2016 at 09:11:17AM -0700, Keith Packard wrote: > Instead of freeing the struct ospollfd elements when the fd is > removed by the user, delay that until epoll is idle so that we are > sure no epoll_event structures could contain the stale pointer. This > handles cases where an fd is

Re: [PATCH xserver] Build glamor when Xorg or Xephyr are built.

2016-08-14 Thread Michel Dänzer
On 12/08/16 01:39 PM, Keith Packard wrote: > Requires gbm when building Xorg so that xf86-video-modesetting will > work. > > Signed-off-by: Keith Packard > --- > configure.ac | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac

Re: [PATCH libpciaccess] Support for 32-bit domains

2016-08-14 Thread Michel Dänzer
On 11/08/16 06:16 PM, Mark Kettenis wrote: >> Date: Wed, 10 Aug 2016 22:58:34 + >> From: Keith Busch >> >> If preserving libpciaccess ABI is of high importance, I think the only >> other option is to just ignore domains requiring 32-bits. That should >> be okay for us since X should not need

[PATCH xf86-input-libinput] Ensure parent devices are actual parent devices

2016-08-14 Thread Peter Hutterer
The list returned by xf86FirstLocalDevice() includes our own device. If the parent device is removed before the hotplug callback is invoked, the first match with the same shared-device ID is our own device (or potentially another subdevice on the same already-removed parent). Avoid this by making s

Re: [PATCH xf86-input-libinput] Bail when a sub-device is it's own parent

2016-08-14 Thread Peter Hutterer
On Sat, Aug 13, 2016 at 09:28:20AM -0700, Keith Packard wrote: > I don't understand when or how this can happen, but 'make check' in > libinput causes this many times: > > [ 68331.672] (EE) libinput: litest ROCCAT ROCCAT Kone XTD: Parent device is > self? [...] > This is *not* a fix, simply a