Re: xserver: Branch 'master' - 3 commits

2016-08-16 Thread Michel Dänzer
On 17/08/16 05:04 AM, Adam Jackson wrote: > > New commits: > commit 5c69cb604a144bdced7d066eaca574aa44e8cb36 > Author: Adam Jackson > Date: Mon Jun 20 12:57:12 2016 -0400 > > xinput: Let top-level dispatch generate the error > > ... instead of calling SendErrorToClient ourselves.

[PATCH synaptics] eventcomm: don't ever probe if a device is set

2016-08-16 Thread Peter Hutterer
If opening the fd fails we still need to fail the device. This is particularly the case when a device disappears before we can open it - the current code wouldn't exit but instead switch to auto-probe touchpad devices on the system. Signed-off-by: Peter Hutterer --- src/eventcomm.c | 12 ++--

Re: [PATCH xserver] Fix Xorg -configure not working anymore

2016-08-16 Thread Michel Dänzer
On 17/08/16 05:36 AM, Hans de Goede wrote: > On 08/16/2016 06:36 PM, Adam Jackson wrote: >> On Mon, 2016-08-08 at 14:53 +0200, Hans de Goede wrote: >> >>> However some users still want to use Xorg -configure to generate a >>> template config file, this commit implements a minimal fix to make >>> th

Re: [PATCH xserver] Fix Xorg -configure not working anymore

2016-08-16 Thread Hans de Goede
Hi, On 08/16/2016 06:36 PM, Adam Jackson wrote: On Mon, 2016-08-08 at 14:53 +0200, Hans de Goede wrote: Adding support for the xf86Configure code to xf86platformBus.c is non trivial and since we advise users to normally run without any Xorg.conf at all not worth the trouble. I'm guessing "no

Re: [PATCH xserver 1/3] xwayland: Fix relinking when dix changes

2016-08-16 Thread Adam Jackson
On Tue, 2016-08-16 at 18:45 +0100, Daniel Stone wrote: > > On 16 August 2016 at 17:56, Adam Jackson wrote: > > > > On Mon, 2016-06-20 at 12:57 -0400, Adam Jackson wrote: > > > > > > Without this a change in eg Xext/ wouldn't relink Xwayland, making you > > > wonder why your changes didn't have a

Re: [PATCH xserver 1/3] xwayland: Fix relinking when dix changes

2016-08-16 Thread Daniel Stone
On 16 August 2016 at 17:56, Adam Jackson wrote: > On Mon, 2016-06-20 at 12:57 -0400, Adam Jackson wrote: >> Without this a change in eg Xext/ wouldn't relink Xwayland, making you >> wonder why your changes didn't have any effect. >> >> Signed-off-by: Adam Jackson > > Anyone? Yeah. Reviewed-by:

Re: [PATCH xserver 1/3] xwayland: Fix relinking when dix changes

2016-08-16 Thread Adam Jackson
On Mon, 2016-06-20 at 12:57 -0400, Adam Jackson wrote: > Without this a change in eg Xext/ wouldn't relink Xwayland, making you > wonder why your changes didn't have any effect. > > Signed-off-by: Adam Jackson Anyone? - ajax ___ xorg-devel@lists.x.or

Re: [PATCH xserver 1/3] sync: Don't do return client->noClientException

2016-08-16 Thread Adam Jackson
On Tue, 2016-06-28 at 15:54 -0400, Adam Jackson wrote: > Hasn't been necessary since: > > commit 92ed75ac59e2d3af149cddb962efd05fc8487750 > Author: Jamey Sharp > Date:   Mon May 10 20:22:05 2010 -0700 > > Eliminate boilerplate around client->noClientException. > > Signed-off

Re: [PATCH xserver] Fix Xorg -configure not working anymore

2016-08-16 Thread Adam Jackson
On Mon, 2016-08-08 at 14:53 +0200, Hans de Goede wrote: > Adding support for the xf86Configure code to xf86platformBus.c > is non trivial and since we advise users to normally run without > any Xorg.conf at all not worth the trouble. I'm guessing "non-trivial" is used here in the "I don't like th

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread Pekka Paalanen
On Tue, 16 Aug 2016 17:49:24 +0300 Pekka Paalanen wrote: > On Tue, 16 Aug 2016 11:56:50 +0100 > Eric Engestrom wrote: > > > On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: > > > since Xfree is a define for free() > > > Xlibint.h:#define Xfree(ptr) free((ptr)) > > > > > > Xfre

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread Pekka Paalanen
On Tue, 16 Aug 2016 11:56:50 +0100 Eric Engestrom wrote: > On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: > > since Xfree is a define for free() > > Xlibint.h:#define Xfree(ptr) free((ptr)) > > > > Xfree will accept NULL and do nothing. > > > > the patch is also available on gi

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread walter harms
Am 16.08.2016 13:10, schrieb Eric Engestrom: > On Tue, Aug 16, 2016 at 11:56:50AM +0100, Eric Engestrom wrote: >> On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: >>> since Xfree is a define for free() >>> Xlibint.h:#define Xfree(ptr) free((ptr)) >>> >>> Xfree will accept NULL and

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread Eric Engestrom
On Tue, Aug 16, 2016 at 11:56:50AM +0100, Eric Engestrom wrote: > On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: > > since Xfree is a define for free() > > Xlibint.h:#define Xfree(ptr) free((ptr)) > > > > Xfree will accept NULL and do nothing. > > > > the patch is also available

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread Eric Engestrom
On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: > since Xfree is a define for free() > Xlibint.h:#define Xfree(ptr) free((ptr)) > > Xfree will accept NULL and do nothing. > > the patch is also available on github.com/xtforever/libX11.git > > --- > man/XFree.man | 5 +++-- > 1 fi

[PATCH xserver 2/3] modesetting: Remove some dead code

2016-08-16 Thread Hans de Goede
The "if (pixmap) ..." block this commit removes is inside an "if (pixmap == NULL) ..." block, so it will never execute. Signed-off-by: Hans de Goede --- hw/xfree86/drivers/modesetting/dri2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/

[PATCH xserver 1/3] modesetting: ms_dri2_create_buffer: check screen of existing front buffers

2016-08-16 Thread Hans de Goede
If a frontbuffer drawable already has a pixmap, make sure it was created on the right screen. Signed-off-by: Hans de Goede --- hw/xfree86/drivers/modesetting/dri2.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/

[PATCH xserver 3/3] modesetting: Implement DRI2InfoRec version 9 callbacks

2016-08-16 Thread Hans de Goede
Implement the CreateBuffer2 / DestroyBuffer2 / CopyRegion2 DRI2InfoRec version 9 callbacks, this is necessary for being an offload source provider with DRI2. Signed-off-by: Hans de Goede --- hw/xfree86/drivers/modesetting/dri2.c | 64 ++- 1 file changed, 55 insert

Re: [PATCH xf86-input-libinput] Add support for configurable tap button mapping

2016-08-16 Thread Hans de Goede
Hi, On 16-08-16 01:58, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- include/libinput-properties.h | 7 ++ man/libinput.man | 8 +++ src/xf86libinput.c| 144

Re: [PATCH xserver] config: Hold input lock across udev socket handling

2016-08-16 Thread Peter Hutterer
On Mon, Aug 15, 2016 at 10:25:56PM -0700, Keith Packard wrote: > This avoids having the server running inside libudev from two threads > at once, which it appears to not like. > > Signed-off-by: Keith Packard Thanks, much appreciated de5291c..bf2ca50 master -> master Cheers, Peter > --