Re: [PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

2016-08-23 Thread Michel Dänzer
Adding Marek and Nicolai, maybe they have some feedback from a GL (driver) perspective. On 23/08/16 10:41 AM, Dave Airlie wrote: > From: Michel Dänzer > > [airlied: rebased onto master - > I left WO alone as it's more like the GL interface > review suggested changing it to bits.] After realiz

[PATCH xserver] xi2: fix FocusIn grabs

2016-08-23 Thread Peter Hutterer
From: Michael Thayer Fix a couple of copy-and-paste errors preventing FocusIn grabs from working. Perhaps the extension version should be bumped though to distinguish between working and non-working extension versions. Signed-off-by: Michael Thayer Reviewed-by: Peter Hutterer --- Michael, sorr

Re: [PATCH xserver] xfree86: print the module name together with the load failure message

2016-08-23 Thread Peter Hutterer
On Tue, Aug 23, 2016 at 10:29:37AM +0200, Hans de Goede wrote: > Hi, > > On 23-08-16 06:47, Peter Hutterer wrote: > > We're happily printing the error to the log but not which module caused > > it... > > That's in the Xorg.log but that's at least one click away. > > > > Signed-off-by: Peter Hutt

[PATCH 2/2] glamor: use write only for putimage in some cases (v2)

2016-08-23 Thread Dave Airlie
From: Dave Airlie Ilia pointed out that xlock -mode wator is slow, this speeds it up by avoiding the ReadPixels on every frame. The current criteria for putimage is a) ALU copy operation b) planemask all set c) region is contained inside pCompositeClip v2: check for rgnIN (Peter Harris) Signe

[PATCH v4 xserver 1/4] modesetting: make ms_do_pageflip generic for share with DRI2

2016-08-23 Thread Qiang Yu
Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/present.c | 39 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c index 0093fb

[PATCH v2 xserver 1/2] glamor: Add glamor_shareable_fd_from_pixmap()

2016-08-23 Thread Hans de Goede
Add glamor_shareable_fd_from_pixmap function to get dma-buf fds suitable for sharing across GPUs (not using GPU specific tiling). This is necessary for the modesetting driver to correctly implement the DRI2 SharePixmapBacking callback. Signed-off-by: Hans de Goede --- glamor/glamor.c | 20 +

[PATCH v2 xserver 2/2] modesetting: Fix msSharePixmapBacking returning a non-linear bo

2016-08-23 Thread Hans de Goede
glamor_fd_from_pixmap() may return a tiled bo, which is not suitable for sharing with another GPU as tiling usually is GPU specific. Switch to glamor_shareable_fd_from_pixmap(), which always returns a linear bo. This fixes mis-rendering when running the mode setting driver on the master gpu in a d

Re: [PATCH xserver] xfree86: print the module name together with the load failure message

2016-08-23 Thread Hans de Goede
Hi, On 23-08-16 06:47, Peter Hutterer wrote: We're happily printing the error to the log but not which module caused it... That's in the Xorg.log but that's at least one click away. Signed-off-by: Peter Hutterer LGTM: Reviewed-by: Hans de Goede Regards, Hans --- hw/xfree86/loader/loa

Re: [PATCH xserver] glamor: Declare "pos" in the composite glyph GLSL 1.20 vertex shader

2016-08-23 Thread Michel Dänzer
On 18/08/16 09:54 AM, Keith Packard wrote: > Michel Dänzer writes: > >> From: Michel Dänzer >> >> Fixes shader compile failure: >> >> Failed to compile VS: 0:13(43): error: `pos' undeclared >> 0:13(14): error: operands to arithmetic operators must be numeric >> 0:13(13): error: operands to arit

Re: [PATCH xserver v3] glamor: Handle bitplane in glamor_copy_fbo_cpu

2016-08-23 Thread Michel Dänzer
On 20/08/16 01:53 PM, Eric Anholt wrote: > Michel Dänzer writes: > >> On 18/08/16 11:09 PM, Alex Deucher wrote: >>> On Thu, Aug 18, 2016 at 5:42 AM, Michel Dänzer wrote: From: Michel Dänzer This can significantly speed up at least some CopyPlane cases, e.g. indirectly for st