[PATCH xserver] xwayland: fix order of calloc() args

2016-11-22 Thread Pekka Paalanen
From: Pekka Paalanen The definition by the manual is: calloc(size_t nmemb, size_t size) Swap the arguments of calloc() calls to be the right way around. Presumably this makes no functional difference, but better follow the spec. Signed-off-by: Pekka Paalanen --- hw/xwayland/xwayland-

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Alan Coopersmith
On 11/22/16 04:58 PM, Eric Anholt wrote: Adam Jackson writes: Signed-off-by: Adam Jackson --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 6fd853b..93c81a6 100644 --- a/configure.ac +++ b/configure.ac @@ -2138,10 +2138

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Eric Anholt
Adam Jackson writes: > Signed-off-by: Adam Jackson > --- > configure.ac | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6fd853b..93c81a6 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2138,10 +2138,7 @@ AM_CONDITIONAL([XOR

Re: [PATCH xserver 1/2] randr: rrCheckPixmapBounding: Do not substract crtc non 0 x, y from screen size

2016-11-22 Thread Dave Airlie
On 23 November 2016 at 00:28, Hans de Goede wrote: > The purpose of rrCheckPixmapBounding is to make sure that the > screen_pixmap is large enough for the slave-output which crtc is > being configured. > > This should include crtc->x and crtc->y, otherwise the crtc might > still end up scanning ou

[PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Adam Jackson
Signed-off-by: Adam Jackson --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 6fd853b..93c81a6 100644 --- a/configure.ac +++ b/configure.ac @@ -2138,10 +2138,7 @@ AM_CONDITIONAL([XORG_DRIVER_MODESETTING], [test "x$XORG_DRIV

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Daniel Stone
On 22 November 2016 at 15:51, Adam Jackson wrote: > Signed-off-by: Adam Jackson Acked-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 2/2] randr: rrCheckPixmapBounding: do not shrink the screen_pixmap

2016-11-22 Thread Hans de Goede
Hi, On 22-11-16 15:28, Hans de Goede wrote: The purpose of rrCheckPixmapBounding is to make sure that the screen_pixmap is *large* enough for the slave-output which crtc is being configured. However until now rrCheckPixmapBounding would also shrink the screen_pixmap in certain scenarios leading

[PATCH xserver 1/2] randr: rrCheckPixmapBounding: Do not substract crtc non 0 x, y from screen size

2016-11-22 Thread Hans de Goede
The purpose of rrCheckPixmapBounding is to make sure that the screen_pixmap is large enough for the slave-output which crtc is being configured. This should include crtc->x and crtc->y, otherwise the crtc might still end up scanning out an area outside of the screen-pixmap. For example: Take a la

[PATCH xserver 2/2] randr: rrCheckPixmapBounding: do not shrink the screen_pixmap

2016-11-22 Thread Hans de Goede
The purpose of rrCheckPixmapBounding is to make sure that the screen_pixmap is *large* enough for the slave-output which crtc is being configured. However until now rrCheckPixmapBounding would also shrink the screen_pixmap in certain scenarios leading to various problems. For example: Take a lapt

[PATCH xserver] xwayland: Don't send KeyRelease events on wl_keyboard::leave

2016-11-22 Thread Rui Matos
Commits 816015648ffe660ddaa0f7d4d192e555b723c372 and fee0827a9a695600765f3d04376fc9babe497401 made it so that wl_keyboard::enter doesn't result in X clients getting KeyPress events while still updating our internal xkb state to be in sync with the host compositor. wl_keyboard::leave needs to be ha

Re: [PATCH wayland] doc: start documenting Xwayland

2016-11-22 Thread Pekka Paalanen
On Tue, 22 Nov 2016 09:20:48 + Daniel Stone wrote: > Hi, > Hi Daniel, nice comments, I'll revise the patch later. Some replies below. > On 21 November 2016 at 15:06, Pekka Paalanen > wrote: > > On Mon, 21 Nov 2016 14:31:43 +0200 > > Pekka Paalanen wrote: > >> + > >> + X11 and

Re: [PATCH wayland] doc: start documenting Xwayland

2016-11-22 Thread Daniel Stone
Hi, On 21 November 2016 at 15:06, Pekka Paalanen wrote: > On Mon, 21 Nov 2016 14:31:43 +0200 > Pekka Paalanen wrote: >> + >> + X11 and Wayland are different enough that there is no "simple" way to >> + translate between them. Most of X11 is uninteresting to a Wayland >> + comp

[PATCH xserver v3] xwayland: Fix use after free of cursors

2016-11-22 Thread Olivier Fourdan
Sometimes, Xwayland will try to use a cursor that has just been freed, leading to a crash when trying to access that cursor data either in miPointerUpdateSprite() or AnimCurTimerNotify(). CheckMotion() updates the pointer's cursor based on which xwindow XYToWindow() returns, and Xwayland implement