On Tue, Jan 24, 2017 at 02:35:34AM +, Emil Velikov wrote:
> On 24 January 2017 at 00:40, Peter Hutterer wrote:
> > From: Adam Jackson
> >
> > Per discussion at XDC2015, we want this so we can easily distinguish
> > which module a patch is for. There's no way to set this in the
> > server-side
On 24 January 2017 at 01:14, Peter Hutterer wrote:
> On Mon, Jan 23, 2017 at 12:51:31PM +, Emil Velikov wrote:
>> On 23 January 2017 at 04:03, Peter Hutterer wrote:
>> > On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote:
>> >> On 20 January 2017 at 02:49, Peter Hutterer
>> >> wro
On 23 January 2017 at 06:30, Yu, Qiang wrote:
>
> Hi,
>
> If no further comments, can this patch be merged?
>
It's up-to our maintainers to pull the series. They might be a bit
busy with other atm.
-Emil
___
xorg-devel@lists.x.org: X.Org development
Arc
On 24 January 2017 at 00:40, Peter Hutterer wrote:
> From: Adam Jackson
>
> Per discussion at XDC2015, we want this so we can easily distinguish
> which module a patch is for. There's no way to set this in the
> server-side config, so setting a default at autogen time is about the
> best we can d
From: Emil Velikov
Requested by a number of distribution maintainers. Used starting with
the 17.0 series.
v2: Keep things conditional based on the version.
v3: Also update srv_path, to create the correct path
Signed-off-by: Emil Velikov
---
release.sh | 20
1 file changed
On Mon, Jan 23, 2017 at 12:51:31PM +, Emil Velikov wrote:
> On 23 January 2017 at 04:03, Peter Hutterer wrote:
> > On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote:
> >> On 20 January 2017 at 02:49, Peter Hutterer
> >> wrote:
> >> > On Thu, Jan 19, 2017 at 07:30:10PM +, Emil
Hi,
I've been debugging an issue in gtk2-perl causing it to SIGBUS on
sparc64, and traced it back to what seems to be dodgy code inside
libx11. One of the tests calls gdk_window_set_opacity, which calls
XChangeProperty with a pointer to a guint32, cast to char*, with the
length set to 32 bits as ex
On Mon, Jan 23, 2017 at 11:52:13AM -0500, Adam Jackson wrote:
> Not that any caller has likely made this mistake, but you want an if
> (number) before this, otherwise you turn a protocol error into a
> segfault.
If a caller supplies NULL, a segfault would always occur because the
pointer is never
On Fri, Jan 20, 2017 at 08:44:19AM -0800, Jason Ekstrand wrote:
> On Fri, Jan 20, 2017 at 2:15 AM, Nicolai Hähnle wrote:
>
> > Hi Rob,
> >
> > On 19.01.2017 23:32, Rob Clark wrote:
> >
> >> Just a friendly reminder that now would be a good time to update the
> >> wiki page for GSoC/EVoC ideas:
>
From: Emil Velikov
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov
Reviewed-by: Peter Hutterer
Signed-off-by: Peter Hutterer
---
autogen.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
dif
From: Adam Jackson
Per discussion at XDC2015, we want this so we can easily distinguish
which module a patch is for. There's no way to set this in the
server-side config, so setting a default at autogen time is about the
best we can do.
Reviewed-by: Eric Anholt
Signed-off-by: Adam Jackson
Sign
Heads up: I'll be pushing the following three patches into all xorg
repositories that need it in the next few days. Speak up now or be forever
silent, etc. etc.
Cheers,
Peter
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/a
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index fc34bd5..fd9c59a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -10,5 +10,5 @@ autoreconf -v
On Mon, Jan 23, 2017 at 14:32:14 -0500, Adam Jackson wrote:
> I'd like to move the module loader up to dix. In preparation for that, here's
> a bunch of cleanup patches. The first three aren't mine, I just think they're
> neat.
>
A few nits in separate mails, but for the series:
Reviewed-by: Juli
On Mon, Jan 23, 2017 at 14:32:33 -0500, Adam Jackson wrote:
> Hmm, this code looks wrong to me. I know! Instead of fix it, I'll put a
> comment here that nobody will look at for decades on end.
>
> Yaaay xfree86.
>
> Signed-off-by: Adam Jackson
> ---
> hw/xfree86/loader/loadmod.c | 3 +--
>
On Mon, Jan 23, 2017 at 14:32:20 -0500, Adam Jackson wrote:
> This API is dumb. uname(3) exists, feel free to use it, but ideally
> write to the interface not to the OS. There are a couple of drivers
> using this API, they could all reasonably just not.
>
It's uname(2) AFAICT :)
Cheers,
Julien
On 01/23/2017 01:27 PM, Eric Anholt wrote:
> Adam Jackson writes:
>
>> From: Emil Velikov
>>
>> Similar to its little brothre - LoadSubModule. Currently all call sites
>> provide NULL anyway ;-)
>
> "brother". Other than that,
>
> Reviewed-by: Eric Anholt
Reviewed-by: Aaron Plattner
We do
On Mon, Jan 23, 2017 at 14:32:18 -0500, Adam Jackson wrote:
> From: Emil Velikov
>
> Now that used can set the path only via LoaderSetPath(), we can simplify
> things.
>
used -> users, maybe?
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org developme
Adam Jackson writes:
> From: Emil Velikov
>
> Now that used can set the path only via LoaderSetPath(), we can simplify
"users"?
Other than that, 4-14 are:
Reviewed-by: Eric Anholt
There is so much "wow, remember when that was a thing?" in this series.
Time to go get some lunch before I see
On Mon, Jan 23, 2017 at 14:32:15 -0500, Adam Jackson wrote:
> From: Emil Velikov
>
> Afaics the argument hasn't been part of the API since the documentation
> has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc
> documents to DocBook/XML"
>
The commit message seems confused. AF
On Mon, Jan 16, 2017 at 16:26:08 -0800, Alan Coopersmith wrote:
> As best I can tell, it was historically under section 1 mainly because
> the old X Consortium Imake configs only supporting installing program
> man pages there, and didn't have an option for using other sections.
>
> Signed-off-by
Adam Jackson writes:
> From: Emil Velikov
>
> Similar to its little brothre - LoadSubModule. Currently all call sites
> provide NULL anyway ;-)
"brother". Other than that,
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
xorg
Adam Jackson writes:
> From: Emil Velikov
>
> Afaics the argument hasn't been part of the API since the documentation
> has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc
> documents to DocBook/XML"
In the subject, "remove references *to* LoadSubModule's path"?
Potential follo
I'd like to move the module loader up to dix. In preparation for that, here's
a bunch of cleanup patches. The first three aren't mine, I just think they're
neat.
b/hw/xfree86/common/xf86.h |2
b/hw/xfree86/common/xf86Config.c| 78 -
b/hw/xfree86/common/xf86Config.h|
From: Emil Velikov
Similar to its little brothre - LoadSubModule. Currently all call sites
provide NULL anyway ;-)
Cc: Aaron Plattner
Signed-off-by: Emil Velikov
---
hw/xfree86/common/xf86Helper.c | 2 +-
hw/xfree86/common/xf86Init.c| 2 +-
hw/xfree86/doc/ddxDesign.xml| 8 +---
h
Signed-off-by: Adam Jackson
---
hw/xfree86/loader/loadmod.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
index cb86925..ca77c7a 100644
--- a/hw/xfree86/loader/loadmod.c
+++ b/hw/xfree86/loader/loadmod.c
@
Just a waste of memory. Path was never referenced at all, and name was
only used when unloading the module; we can just as well get the
module's internal idea of its name from VersionInfo.
Signed-off-by: Adam Jackson
---
hw/xfree86/loader/loaderProcs.h | 2 --
hw/xfree86/loader/loadmod.c |
There's no reason a driver should ever care about this.
Signed-off-by: Adam Jackson
---
hw/xfree86/common/xf86Config.c| 2 +-
hw/xfree86/common/xf86Configure.c | 1 +
hw/xfree86/common/xf86Module.h| 2 --
hw/xfree86/loader/loaderProcs.h | 3 +++
4 files changed, 5 insertions(+), 3 dele
Signed-off-by: Adam Jackson
---
hw/xfree86/common/xf86Configure.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86Configure.c
b/hw/xfree86/common/xf86Configure.c
index 8c8e49e..0d7a127 100644
--- a/hw/xfree86/common/xf86Configure.c
+++ b/hw/xfree86/com
Hmm, this code looks wrong to me. I know! Instead of fix it, I'll put a
comment here that nobody will look at for decades on end.
Yaaay xfree86.
Signed-off-by: Adam Jackson
---
hw/xfree86/loader/loadmod.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/xfree86/loade
Callers only ever use this for a single directory anyway.
While we're at it, also move xf86DriverListFromCompile near its only
user in the X -configure code (and inline it out of existence), and
remove LoaderFreeDirList as it's unused (since X -configure is just
going to exit anyway, none of that
Nobody was ever calling this with a non-null argument for subdir list or
pattern list. Having done this, InitSubdirs is only ever called with a
NULL argument, so it's really just a complicated way of duplicating the
default list; we can remove that and just walk the list directly.
The minor error
The idea here is that the driver might have once been old enough to not
have the driverFunc slot in DriverRec, with the module ABI not having
changed when it was added. That was ages ago, and drivers always declare
themselves with DriverRec not DriverRec1, so uninitialized slots will
simply be zero
indent(1) gets confused by function-like macros with no trailing
semicolon, which is fair enough really.
Signed-off-by: Adam Jackson
---
hw/xfree86/common/xf86Configure.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/hw/xfree86/common/xf86Conf
From: Emil Velikov
Now that used can set the path only via LoaderSetPath(), we can simplify
things.
Signed-off-by: Emil Velikov
---
hw/xfree86/loader/loadmod.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/
The enum has been unused since at least the removal of elfloader.
Signed-off-by: Adam Jackson
---
hw/xfree86/common/xf86Module.h | 15 +--
hw/xfree86/loader/loadmod.c| 18 --
2 files changed, 1 insertion(+), 32 deletions(-)
diff --git a/hw/xfree86/common/xf86Modu
This API is dumb. uname(3) exists, feel free to use it, but ideally
write to the interface not to the OS. There are a couple of drivers
using this API, they could all reasonably just not.
This also removes the OS name from the loader subdirectory path search.
Having /usr/lib/xorg shared across O
Signed-off-by: Adam Jackson
---
hw/xfree86/loader/loader.c | 43 +-
hw/xfree86/loader/loadmod.c | 141
2 files changed, 81 insertions(+), 103 deletions(-)
diff --git a/hw/xfree86/loader/loader.c b/hw/xfree86/loader/loader.c
index c8d7540
Nobody who is using this functionality is ever not specifying a major
version, which makes sense. If you don't care about a minor version,
that's equivalent to saying you require minor >= 0, so just say so;
likewise patch level.
Likewise nobody using this functionality is ever not specifying an AB
Signed-off-by: Adam Jackson
---
hw/xfree86/loader/loadmod.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
index 95a37fc..d326d9d 100644
--- a/hw/xfree86/loader/loadmod.c
+++ b/hw/xfree86/loader/loadmod.c
@@ -177,7 +177,6 @@ static con
This looks like more, but only if you don't compare it to the number
pulled in by misc.h.
Signed-off-by: Adam Jackson
---
hw/xfree86/common/xf86Module.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86Module.h b/hw/xfree86/common/xf86Module.h
index
From: Emil Velikov
Afaics the argument hasn't been part of the API since the documentation
has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc
documents to DocBook/XML"
Signed-off-by: Emil Velikov
---
hw/xfree86/doc/ddxDesign.xml | 6 +-
1 file changed, 1 insertion(+), 5 de
From: Emil Velikov
Signed-off-by: Emil Velikov
---
hw/xfree86/loader/loaderProcs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/xfree86/loader/loaderProcs.h b/hw/xfree86/loader/loaderProcs.h
index 8d7872f..ee8a557 100644
--- a/hw/xfree86/loader/loaderProcs.h
+++ b/hw/xfree86/loader/l
Classic GNU ld resolves symbol dependencies only forward, while GOLD
seems to work regardless of the specified library order.
I assume that the original author of the changes (just like me), has
been using GNU ld with GOLD enabled (default on ArchLinux), and did
not check on older distros like Ubu
On Sun, 2017-01-22 at 15:18 +0100, Tobias Stoeckmann wrote:
> @@ -286,6 +286,7 @@ XineramaQueryScreens(
> if (!_XReply (dpy, (xReply *) &rep, 0, xFalse)) {
> UnlockDisplay (dpy);
> SyncHandle ();
> + *number = 0;
Not that any caller has likely made this mistake, but you want
Signed-off-by: Adam Jackson
---
hw/xfree86/parser/scan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c
index 81a454b..3356224 100644
--- a/hw/xfree86/parser/scan.c
+++ b/hw/xfree86/parser/scan.c
@@ -1046,6 +1046,8 @@ xf86nameCompare(cons
If the pixmap type is neither GLAMOR_TEXTURE_ONLY nor GLAMOR_TEXTURE_DRM
we might have the fbo field set but the gl_fbo still set to the default
GLAMOR_FBO_UNATTACHED, which later may fail an assert in
glamor_upload_picture_to_texture().
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99346
---
Educated guess since I cannot reproduce it. If you're seing any of the
install/changelog issues mentioned in my email, just drop the relevant
lines from Makefile.am
release.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/release.sh b/release.sh
index e0209bc..74b9b
On 23 January 2017 at 04:03, Peter Hutterer wrote:
> On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote:
>> On 20 January 2017 at 02:49, Peter Hutterer wrote:
>> > On Thu, Jan 19, 2017 at 07:30:10PM +, Emil Velikov wrote:
>> >> From: Emil Velikov
>> >>
>> >> Months ago, before my w
49 matches
Mail list logo