Re: [PATCH xserver] present: disable page flip only when a slave crtc is active

2017-02-01 Thread Michel Dänzer
On 01/02/17 10:21 AM, Michel Dänzer wrote: > On 01/02/17 04:05 AM, David Airlie wrote: >>> From: "Michel Dänzer" >>> On 26/01/17 07:13 PM, Qiang Yu wrote: @@ -145,7 +157,7 @@ present_check_flip(RRCrtcPtrcrtc, return FALSE; /* Fail to flip if we have sla

[PATCH xserver 2/2] present: Allow flipping with PRIME slave outputs

2017-02-01 Thread Michel Dänzer
From: Michel Dänzer Works fine now. Signed-off-by: Michel Dänzer --- present/present.c | 16 1 file changed, 16 deletions(-) diff --git a/present/present.c b/present/present.c index c9c68dcba..aa9c041df 100644 --- a/present/present.c +++ b/present/present.c @@ -118,18 +118,6

[PATCH xserver 1/2] prime: Sync shared pixmap from root window instead of screen pixmap

2017-02-01 Thread Michel Dänzer
From: Michel Dänzer The screen pixmap doesn't receive updates while there's a Present flip window. Signed-off-by: Michel Dänzer --- dix/pixmap.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/dix/pixmap.c b/dix/pixmap.c index 49267a19b..ef0083083 100644 -

[PATCH xserver 0/2] present: Allow flipping with PRIME slave outputs

2017-02-01 Thread Michel Dänzer
From: Michel Dänzer Turned out to be easier than I thought, and doesn't require any ABI changes. Michel Dänzer (2): prime: Sync shared pixmap from root window instead of screen pixmap present: Allow flipping with PRIME slave outputs dix/pixmap.c | 16 present/present.

Re: [PATCH util-modular] release.sh: run autogen.sh instead of manual autoreconf + configure

2017-02-01 Thread Emil Velikov
On 1 February 2017 at 00:58, Peter Hutterer wrote: > xkeyboard-config needs extra env variables to be set during autoreconf and > that is handled in the autogen.sh script. If we invoke autoreconf directly, we > fail on this repo. > Unrelated question: Why isn't xkeyboard-config under xorg/data or

Re: [PATCH util/macros] Rework stderr messages for the _CMD macros

2017-02-01 Thread Emil Velikov
On 31 January 2017 at 21:05, Gaetan Nadon wrote: > On 01/31/2017 05:26 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Redirect stderr from git, sh and cp to /dev/null to cut down the 'spam' >> and reword the error messages to be less misleading. >> >> Why ? Currently CHANGELOG_CMD can fai

[PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread arthur . huillet
From: Arthur Huillet _XReply isn't reentrant, and it can lead to deadlocks when the default error handler is called: _XDefaultError calls exit(1). It is called indirectly by _XReply when a X protocol error comes in that isn't filtered/handled by an extension or the application. This means that

Re: [PATCH util-modular] release.sh: run autogen.sh instead of manual autoreconf + configure

2017-02-01 Thread Alan Coopersmith
On 02/ 1/17 01:39 AM, Emil Velikov wrote: On 1 February 2017 at 00:58, Peter Hutterer wrote: xkeyboard-config needs extra env variables to be set during autoreconf and that is handled in the autogen.sh script. If we invoke autoreconf directly, we fail on this repo. Unrelated question: Why isn

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Jamey Sharp
I don't love this either, but it's Xlib; there's little there to love. ;-) I don't see anything fundamentally wrong with this approach. I'm a little confused by the notes in the commit message about whether this is legal. I don't know why it should be considered legal to use a Display from a _fini

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Arthur Huillet
Hi Jamey, On Wed, 1 Feb 2017 09:12:47 -0800 Jamey Sharp wrote: > I don't love this either, but it's Xlib; there's little there to love. ;-) > I don't see anything fundamentally wrong with this approach. Thanks. > I'm a little confused by the notes in the commit message about whether this > is

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Manasi Navare
On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode be

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Eric Anholt
Jani Nikula writes: > On Tue, 31 Jan 2017, Eric Anholt wrote: >> Martin Peres writes: >> >>> Despite all the careful planing of the kernel, a link may become >>> insufficient to handle the currently-set mode. At this point, the >>> kernel should mark this particular configuration as being broke

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Manasi Navare
On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > Jani Nikula writes: > > > On Tue, 31 Jan 2017, Eric Anholt wrote: > >> Martin Peres writes: > >> > >>> Despite all the careful planing of the kernel, a link may become > >>> insufficient to handle the currently-set mode. At this poi

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Jamey Sharp
On Feb 1, 2017 9:23 AM, "Arthur Huillet" wrote: On Wed, 1 Feb 2017 09:12:47 -0800 Jamey Sharp wrote: > I'm a little confused by the notes in the commit message about whether this > is legal. I don't know why it should be considered legal to use a Display > from a _fini or atexit handler… althoug

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Arthur Huillet
On Wed, 1 Feb 2017 12:23:30 -0800 Jamey Sharp wrote: > On Feb 1, 2017 9:23 AM, "Arthur Huillet" wrote: > > On Wed, 1 Feb 2017 09:12:47 -0800 > Jamey Sharp wrote: > > I'm a little confused by the notes in the commit message about whether > this > > is legal. I don't know why it should be cons

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Jani Nikula
On Tue, 31 Jan 2017, Manasi Navare wrote: > On Thu, Jan 26, 2017 at 06:21:20PM +0100, Daniel Vetter wrote: >> On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: >> > Despite all the careful planing of the kernel, a link may become >> > insufficient to handle the currently-set mode. At t

Re: [PATCH util-modular] release.sh: run autogen.sh instead of manual autoreconf + configure

2017-02-01 Thread Sergey Udaltsov
Hi Emil Historically xkeyboard-config was created as the repository not tightly bound to xorg (could be used by xfree86 if someone wants). So it is managed by me separately with 4-month release cycle, not within xorg. Hope that explains Cheers On Wed, Feb 1, 2017 at 9:39 AM, Emil Velikov wrote

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Jani Nikula
On Tue, 31 Jan 2017, Eric Anholt wrote: > Martin Peres writes: > >> Despite all the careful planing of the kernel, a link may become >> insufficient to handle the currently-set mode. At this point, the >> kernel should mark this particular configuration as being broken >> and potentially prune th

[PATCH xserver] tests: fix library order comment

2017-02-01 Thread Mihail Konev
ld.gold ignores --as-needed (Observable by: make -C test tests V=1 CFLAGS='-v') Fixes: b1a69863 ("tests: shuffle around the linking order") Signed-off-by: Mihail Konev --- Ubuntu patches gcc builtin -specs= file (the gcc -dumpspec), but gold ignores the arg. test/Makefile.am | 4 ++-- 1 file ch

Re: [PATCH xserver] tests: fix library order comment

2017-02-01 Thread Mihail Konev
Actually those *_SYS_LIBS are missing from LIBADD's in other makefiles, and libtool does no reordering. As the original patch then needs to be reverted anyway, maybe merging the fix would be noisy. On Thu, Feb 02, 2017 at 10:04:03AM +0500, Mihail Konev wrote: > ld.gold ignores --as-needed > (Obse