Re: [PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

2017-02-07 Thread Olivier Fourdan
Hey Peter, > > LGTM - Yo get rid of two \n along the way, but I think there were not > > needed in the first place so: > > oops. no, they're neeed so I added them back (and also to the instance where > it was missing). thanks Are they really needed? I looked at ErrorF() in the source tree and th

[PATCH v2 xserver 6/9] xwayland: handle button events after motion events

2017-02-07 Thread Peter Hutterer
Make sure the button events are sent after the motion events into the new position. Signed-off-by: Peter Hutterer --- Changes to v1: - new in this series hw/xwayland/xwayland-input.c | 44 +--- hw/xwayland/xwayland.h | 3 +++ 2 files changed, 40 in

[PATCH v2 xserver 5/9] xwayland: Handle tablet_tool events

2017-02-07 Thread Peter Hutterer
From: Jason Gerecke Translates Wayland tablet events into corresponding X11 tablet events. As with the prior commit, these events are modeled after those created by the xf86-input-wacom driver to maximize compatibility with existing applications. Signed-off-by: Jason Gerecke Signed-off-by: Carl

[PATCH v2 xserver 1/9] xwayland: Depend on wayland-protocols to build tablet protocol headers

2017-02-07 Thread Peter Hutterer
From: Jason Gerecke Signed-off-by: Jason Gerecke Signed-off-by: Carlos Garnacho Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- Changes to v1: - require wayland-protocols 1.5 for the pad bits configure.ac | 2 +- hw/xwayland/Makefile.am | 9 - hw/x

[PATCH v2 xserver 9/9] xwayland: add tablet pad support

2017-02-07 Thread Peter Hutterer
Hooked up a bit differently to the other tools. Those tools can be static for all and be re-used. The wacom driver initializes the pad with the correct number of buttons though and we can't do this until we have the pad done event. If the tablet is removed and we plug a different one in, we should

[PATCH v2 xserver 2/9] xwayland: Bind to wp_tablet_manager if available and get its seats

2017-02-07 Thread Peter Hutterer
From: Jason Gerecke If we're notified about the existence of the wp_tablet_manager interface, we bind to it so that we can make use of any tablets that are (or later become) available. For each seat that exists or comes into existance at a later point, obtain the associated tablet_seat. Signed-o

[PATCH v2 xserver 8/9] xwayland: update cursor on tablet tools in proximity

2017-02-07 Thread Peter Hutterer
From: Carlos Garnacho Each xwl_tablet_tool gets a xwl_cursor, as on wayland each of those will get an independent cursor that can be set through zwp_tablet_tool.set_cursor. However, all tools (and the pointer) share conceptually the same VCP on Xwayland, so have cursor changes trigger a xwl_curs

[PATCH v2 xserver 7/9] xwayland: Refactor cursor management into xwl_cursor

2017-02-07 Thread Peter Hutterer
From: Carlos Garnacho This struct takes away the cursor info in xwl_seat, and has an update function so we can share the frame handling code across several xwl_cursors. Signed-off-by: Carlos Garnacho Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- No changes to v1 hw/xwayland/

[PATCH v2 xserver 4/9] xwayland: Handle wp_tablet events

2017-02-07 Thread Peter Hutterer
From: Jason Gerecke Creates and maintains the canonical trio of X devices (stylus, eraser, and cursor) to be shared by all connected tablets. A per-tablet trio could be created instead, but there are very few benefits to such a configuration since all tablets still ultimately share control of a s

[PATCH v2 xserver 3/9] xwayland: Listen for wp_tablet_seat events

2017-02-07 Thread Peter Hutterer
From: Jason Gerecke The wp_tablet_seat interface provides us with notifications as tablets, tools, and pads are connected to the system. Add listener functions and store references to the obtained devices. Signed-off-by: Jason Gerecke Signed-off-by: Carlos Garnacho Reviewed-by: Peter Hutterer

[PATCH v2 xserver 0/9] xwayland: implement tablet support

2017-02-07 Thread Peter Hutterer
Continuation from the set here: https://www.mail-archive.com/xorg-devel@lists.x.org/msg50904.html A few comments added, button handling changed but the only real new feature is pad support. Cheers, Peter ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH xserver 1/3] xfree86: Take the input lock for xf86RecolorCursor

2017-02-07 Thread Peter Hutterer
On Thu, Feb 02, 2017 at 10:51:44AM +, Chris Wilson wrote: > xf86RecolorCursor() may be called directly from XRecolorCursor as well > as from xf86ScreenSetCursor(). In the latter case, the input lock is > already held, but not for the former and so we need to add a wrapper > function that acquir

Re: [PATCH util/macros] Add new script xorg-prepare-git-repo.sh

2017-02-07 Thread Peter Hutterer
On Fri, Feb 03, 2017 at 12:53:07PM +, Emil Velikov wrote: > On 2 February 2017 at 22:04, Peter Hutterer wrote: > > On Tue, Jan 31, 2017 at 10:24:55AM +, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> New script invoked by the project's autogen.sh to facilitate basic git > >> config

Re: [PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

2017-02-07 Thread Peter Hutterer
On Tue, Feb 07, 2017 at 03:11:35AM -0500, Olivier Fourdan wrote: > > Signed-off-by: Peter Hutterer > > --- > > hw/xwayland/xwayland-input.c | 4 ++-- > > hw/xwayland/xwayland-output.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/hw/xwayland/xwayland-input.c

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

2017-02-07 Thread Keith Packard
Max Staudt writes: > OpenGL implementations are allowed to be imprecise in drawing line caps. > This patch expands on the original workaround in dc9fa908. Yeah, finding a way to work around GL differences seems like a good idea. In this case, however, I think you're fixing some drivers and break

[PATCH mga] xf86-video-mga: Add support for a new G200eH3 device

2017-02-07 Thread mathieu . larouche
From: Mathieu Larouche - Added support for the new deviceID for G200eH3 - Added PLL algorithm for the G200eH3 - Removed the bandwidth limitation for the G200eH3 Signed-off-by: Mathieu Larouche --- src/mga.h| 4 +++- src/mga_dacG.c | 56 +++

Re: [PATCH xserver v2] damage: Validate source pictures bound to windows before unwrapping

2017-02-07 Thread Alex Deucher
On Tue, Feb 7, 2017 at 3:38 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The lower layers also do this, but no damage may be reported there, > since we unwrap before calling down. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99220 > Signed-off-by: Michel Dänzer Makes sense t

[PATCH xserver] glamor: Paint first and last pixel of lines

2017-02-07 Thread Max Staudt
OpenGL implementations are allowed to be imprecise in drawing line caps. This patch expands on the original workaround in dc9fa908. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=99705 Signed-off-by: Max Staudt --- glamor/glamor_lines.c | 21 + glamor/glamor_segs.c | 43

[PATCH xserver v3 2/2] xwayland: Disable RR ConstrainCursorHarder()

2017-02-07 Thread Olivier Fourdan
RRScreenInit() will install its own ConstrainCursorHarder() handler that will apply pointer constraints depending on the RR config, including the current rotation. In the case of Xwayland, the output size is already swapped when rotated, so the default ConstrainCursorHarder() will set the wrong li

[PATCH xserver v3 1/2] xwayland: CRTC should support all rotations

2017-02-07 Thread Olivier Fourdan
If the Wayland compositor sets a rotation on the output, Xwayland translates the transformation as an xrandr rotation for the given output. However, if the rotation is not supported by the CRTC, this is not a valid setup and xrandr queries will fail. Pretend we support all rotations and reflectio

[PATCH edid-decode v2] data: Add Dell UP2715k 5k EDID with DisplayID

2017-02-07 Thread Mark Ferry
Test data for DisplayID extension parsing. --- data/dell-up2715k-dp | Bin 0 -> 384 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 data/dell-up2715k-dp diff --git a/data/dell-up2715k-dp b/data/dell-up2715k-dp new file mode 100644 index

[PATCH xserver v2] damage: Validate source pictures bound to windows before unwrapping

2017-02-07 Thread Michel Dänzer
From: Michel Dänzer The lower layers also do this, but no damage may be reported there, since we unwrap before calling down. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99220 Signed-off-by: Michel Dänzer --- v2: Update code comment This is an alternative to https://patchwork.freede

[PATCH xserver] damage: Validate source pictures bound to windows before unwrapping

2017-02-07 Thread Michel Dänzer
From: Michel Dänzer The lower layers also do this, but no damage may be reported there, since we unwrap before calling down. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99220 Signed-off-by: Michel Dänzer --- This is an alternative to https://patchwork.freedesktop.org/patch/136721/ .

Re: [PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

2017-02-07 Thread Olivier Fourdan
> Signed-off-by: Peter Hutterer > --- > hw/xwayland/xwayland-input.c | 4 ++-- > hw/xwayland/xwayland-output.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/xwayland/xwayland-input.c b/hw/xwayland/xwayland-input.c > index 580df09..8d8bcbd 100644 > --- a/hw/xwayl