Re: [PATCH 0/7] ScrnInfoRec cleanup

2017-02-14 Thread Keith Packard
Adam Jackson writes: > ScrnInfoRec is xfree86's subclass of ScreenRec. It's... showing its age. > Much of it is only relevant to the pre-PCI world where probing the > hardware was fraught with uncertainty and configuration overrides were > common. This is a first cut at cleaning it up a bit, most

[PATCH xserver] os,dix: relocate when without dtrace

2017-02-14 Thread Mihail Konev
When building with dtrace compiler, "ld -r" is applied to the entire os/ and dix/, making their symbols visible from everywhere on linker command line. This alters the build from a non-dtrace one: * 3f8c2f94483bf0b96e129c97ef4950170a3f05b4 was only necessary without dtrace. * 3ef16dfb9830bd6b41ae42

Re: [PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-14 Thread Emil Velikov
Thanks for having a look Alan. On 14 February 2017 at 16:31, Alan Coopersmith wrote: > This one seems useful/important: >> +build lib libXpresent > > Are you using the github version for this since it moved off fd.o? >> +build lib libxkbcommon > > I don't know what this is: >> +build

Re: [PATCH util/macros 1/2] Rework CHANGELOG_CMD to touch/echo >&2 only as needed

2017-02-14 Thread Peter Hutterer
On Tue, Feb 14, 2017 at 11:38:20AM +, Emil Velikov wrote: > From: Emil Velikov > > Currently CHANGELOG_CMD issues a > > touch ChangeLog; echo "Scary message" >&2 > > even if the file is already present. For example, when running `make > distcheck' the following is observed: > > " > /bin/

Re: [PATCH xserver 4/7] xfree86: Remove Option "BiosBase"

2017-02-14 Thread Adam Jackson
On Tue, 2017-02-14 at 13:39 -0800, Aaron Plattner wrote: > On 02/14/2017 12:30 PM, Adam Jackson wrote: > > > > diff --git a/hw/xfree86/parser/xf86tokens.h b/hw/xfree86/parser/xf86tokens.h > > index 15792c6..4aa17a7 100644 > > --- a/hw/xfree86/parser/xf86tokens.h > > +++ b/hw/xfree86/parser/xf86tok

Re: [PATCH xserver 4/7] xfree86: Remove Option "BiosBase"

2017-02-14 Thread Aaron Plattner
On 02/14/2017 12:30 PM, Adam Jackson wrote: Just no. The ddxDesign chunk removes the whole para about xf86FixPciResource, since it turns out that function doesn't exist at all anymore. i128 and mga do use this slot, but they oughtn't. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Con

Re: [PATCH 0/7] ScrnInfoRec cleanup

2017-02-14 Thread Aaron Plattner
On 02/14/2017 01:28 PM, Alex Deucher wrote: On Tue, Feb 14, 2017 at 3:30 PM, Adam Jackson wrote: ScrnInfoRec is xfree86's subclass of ScreenRec. It's... showing its age. Much of it is only relevant to the pre-PCI world where probing the hardware was fraught with uncertainty and configuration ov

Re: [PATCH 0/7] ScrnInfoRec cleanup

2017-02-14 Thread Alex Deucher
On Tue, Feb 14, 2017 at 3:30 PM, Adam Jackson wrote: > ScrnInfoRec is xfree86's subclass of ScreenRec. It's... showing its age. > Much of it is only relevant to the pre-PCI world where probing the > hardware was fraught with uncertainty and configuration overrides were > common. This is a first cu

Re: [PATCH v6 libX11] Compose sequences for rouble sign

2017-02-14 Thread Adam Jackson
On Tue, 2017-02-14 at 20:20 +, Jon Turney wrote: > On 14/02/2017 16:39, Adam Jackson wrote: > > On Fri, 2017-02-10 at 18:48 +0500, Mihail Konev wrote: > > > Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout. > > > Also add Cyrillic sequences for hryvnia sign. > > > > > > Submitted

[PATCH xserver 7/7] xfree86: Reorganize the reserved ScrnInfoRec slots

2017-02-14 Thread Adam Jackson
First, move them to the end of the struct, for marginally better cache locality for the struct members that actually have meaning; move the existing slots at the end of the struct up near some others with similar meanings. Second, only keep four slots each of integer, data pointer, and function poi

[PATCH xserver 5/7] xfree86: Remove memClk from ScrnInfoRec

2017-02-14 Thread Adam Jackson
Never set by the core, not used in any modern driver. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86str.h | 1 - hw/xfree86/doc/ddxDesign.xml | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h index b060575..295a1ae 100644 ---

[PATCH xserver 4/7] xfree86: Remove Option "BiosBase"

2017-02-14 Thread Adam Jackson
Just no. The ddxDesign chunk removes the whole para about xf86FixPciResource, since it turns out that function doesn't exist at all anymore. i128 and mga do use this slot, but they oughtn't. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Config.c| 1 - hw/xfree86/common/xf86Configu

[PATCH xserver 3/7] xfree86: Drop virtualFrom from ScrnInfoRec

2017-02-14 Thread Adam Jackson
Seriously not worth the effort of tracking this, especially now that competent drivers don't have a limit. The sis driver does inspect this member, but hilariously does so only so it can print the same information as the core does. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Mode.c |

[PATCH xserver 1/7] xfree86: Fix a comment about ScrnInfoRec

2017-02-14 Thread Adam Jackson
We don't actually need (or intend) to keep this struct the same across revisions. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86str.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h index 74c65ba..121632f

[PATCH 0/7] ScrnInfoRec cleanup

2017-02-14 Thread Adam Jackson
ScrnInfoRec is xfree86's subclass of ScreenRec. It's... showing its age. Much of it is only relevant to the pre-PCI world where probing the hardware was fraught with uncertainty and configuration overrides were common. This is a first cut at cleaning it up a bit, mostly dropping unused or under-use

[PATCH xserver 2/7] xfree86: Remove max[HV]Value from ScrnInfoRec

2017-02-14 Thread Adam Jackson
Only mach64 and rendition actually use this feature. Everyone else just checks it in their ValidMode hook, they can too. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Mode.c | 18 -- hw/xfree86/common/xf86str.h | 2 -- hw/xfree86/doc/ddxDesign.xml | 12 3

[PATCH xserver 6/7] xfree86: Remove unused chipID/Rev from ScrnInfoRec

2017-02-14 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86str.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h index 295a1ae..7f126b0 100644 --- a/hw/xfree86/common/xf86str.h +++ b/hw/xfree86/common/xf86str.h @@ -652,9 +652,6 @@ typedef

Re: [PATCH v6 libX11] Compose sequences for rouble sign

2017-02-14 Thread Jon Turney
On 14/02/2017 16:39, Adam Jackson wrote: On Fri, 2017-02-10 at 18:48 +0500, Mihail Konev wrote: Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout. Also add Cyrillic sequences for hryvnia sign. Submitted-by: Victor V. Kustov Reviewed-by: Victor V. Kustov Signed-off-by: Mihail Kone

Re: [PATCH xserver 1/2] prime: Sync shared pixmap from root window instead of screen pixmap

2017-02-14 Thread Adam Jackson
On Tue, 2017-02-14 at 18:36 +0900, Michel Dänzer wrote: > I discovered a problem with this. Looks like on server shutdown the > root window can be destroyed before the scanout pixmap is detached, see > valgrind output below. > > Is there any solution for this other than wrapping DestroyWindow and

Re: [PATCH:xserver] DetermineClientCmd: try using /proc/pid/cmdline on Solaris too

2017-02-14 Thread Alan Coopersmith
On 02/14/17 08:34 AM, Adam Jackson wrote: On Sun, 2017-02-12 at 09:35 -0800, Alan Coopersmith wrote: Solaris 11.3.5 introduced support for /proc/pid/cmdline, so try it first, and if we can't open it, then fallback to /proc/pid/psinfo as we did before. Signed-off-by: Alan Coopersmith remote:

Re: [PATCH v6 libX11] Compose sequences for rouble sign

2017-02-14 Thread Adam Jackson
On Fri, 2017-02-10 at 18:48 +0500, Mihail Konev wrote: > Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout. > Also add Cyrillic sequences for hryvnia sign. > > Submitted-by: Victor V. Kustov > Reviewed-by: Victor V. Kustov > Signed-off-by: Mihail Konev remote: I: patch #138287 upd

Re: [PATCH util-modular 7/9] build.sh: add the remaining xorg proto(s)

2017-02-14 Thread Alan Coopersmith
These are deprecated/obsolete: +build proto calibrateproto +build proto evieproto +build proto fontcacheproto +build proto lg3dproto > +build proto pmproto > +build proto printproto > +build proto trapproto > +build proto xf86rushproto This shouldn't exist - it's

Re: [PATCH:xserver] DetermineClientCmd: try using /proc/pid/cmdline on Solaris too

2017-02-14 Thread Adam Jackson
On Sun, 2017-02-12 at 09:35 -0800, Alan Coopersmith wrote: > Solaris 11.3.5 introduced support for /proc/pid/cmdline, so try it > first, and if we can't open it, then fallback to /proc/pid/psinfo > as we did before. > > Signed-off-by: Alan Coopersmith remote: I: patch #138481 updated using rev

Re: [PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-14 Thread Alan Coopersmith
This one seems useful/important: > +build lib libXpresent Are you using the github version for this since it moved off fd.o? > +build lib libxkbcommon I don't know what this is: > +build lib libXrandrUtils This was a student project that I don't know if it ever got finished or adopt

Re: [PATCH util-modular 6/9] build.sh: add the remaining xorg driver(s)

2017-02-14 Thread Alan Coopersmith
On 02/14/17 03:57 AM, Emil Velikov wrote: +build driver glamor > +build driver xf86-video-modesetting Does anything still use the standalone glamor or modesetting since they were merged into the xserver source tree? Most of these should just error out in configure telling you they have

Re: [PATCH util-modular 4/9] build.sh: add the remaining xorg app(s)

2017-02-14 Thread Alan Coopersmith
On 02/14/17 03:57 AM, Emil Velikov wrote: Ideally we'll get everything inside build.sh so that a simple script (like below) can easily flag differences. Obviously deprecated/obsolete projects won't be build/are commented out. They don't appear to be commented out yet, since these are deprecated

Re: [PATCH mga] xf86-video-mga: Add support for a new G200eH3 device

2017-02-14 Thread Adam Jackson
On Mon, 2017-02-13 at 12:12 +1000, Dave Airlie wrote: > On 8 February 2017 at 02:12,   wrote: > > From: Mathieu Larouche > > > > - Added support for the new deviceID for G200eH3 > > - Added PLL algorithm for the G200eH3 > > - Removed the bandwidth limitation for the G200eH3 > > > > Signed-off-by

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

2017-02-14 Thread Max Staudt
On 02/14/2017 12:10 AM, Adam Jackson wrote: > fb has been the only extant renderer for nearly nine years. Clearly > there exists code that expects it. I'm not convinced that pushing back > on that expectation is a good move, technically correct though it may > be. I'll second that. So shall we us

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

2017-02-14 Thread Max Staudt
On 02/13/2017 11:53 PM, Keith Packard wrote: > afaict, GL suggests 'not > last' as the only option. It sounds like some drivers are doing both > 'not last' and 'not first' though? In the case that I reproduced, the 'not first' only happens occasionally, but reproducibly. Max __

[PATCH util-modular 0/9] En route to testing $WORLD

2017-02-14 Thread Emil Velikov
Hi all, Here are some patches inspired by my resent release.sh/xorg-macros work. The first two are a bit of bugfix/polish wrt the existing NOAUTOGEN option, patch 3 adds NOMAKE option, such that one can do only a fetch of the current repositories/projects via ./build.sh --clone [-p] -a -m Th

[PATCH util-modular 9/9] build.sh: add the remaining xorg util(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- build.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/build.sh b/build.sh index 2a46f35..06507e3 100755 --- a/build.sh +++ b/build.sh @@ -1405,6 +1405,9 @@ build_all_modules() { build util imake build util gccmakedep bu

[PATCH util-modular 6/9] build.sh: add the remaining xorg driver(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- build.sh | 44 1 file changed, 44 insertions(+) diff --git a/build.sh b/build.sh index 0af2fc0..437b15f 100755 --- a/build.sh +++ b/build.sh @@ -1308,6 +1308,50 @@ build_all_modules() {

[PATCH util-modular 1/9] build.sh: honour when NOAUTOGEN (-a) is set

2017-02-14 Thread Emil Velikov
From: Emil Velikov Do what the help string says - do not run autogen/configure when set. If one is cloning a fresh repo, that is no reason to effectively ignore the user requirement. Signed-off-by: Emil Velikov --- build.sh | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH util-modular 3/9] build.sh: add NOMAKE configure option

2017-02-14 Thread Emil Velikov
From: Emil Velikov Used alongside with -a and --clone (optionally -p) one can fetch/sync the whole collection of projects w/o executing anything in those. One example usecase is to test any direct or indirect (for example xorg-macros) changes to release.sh do not produce unexpected results. Sig

[PATCH util-modular 7/9] build.sh: add the remaining xorg proto(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- build.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/build.sh b/build.sh index 437b15f..402b8d4 100755 --- a/build.sh +++ b/build.sh @@ -994,22 +994,30 @@ build_all_modules() { CYGWIN*) build proto windowswmproto;;

[PATCH util-modular 8/9] build.sh: add the remaining xorg font

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/build.sh b/build.sh index 402b8d4..2a46f35 100755 --- a/build.sh +++ b/build.sh @@ -1379,6 +1379,7 @@ build_all_modules() { build font bh-type1 build font bitstream-100dpi

[PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- build.sh | 17 + 1 file changed, 17 insertions(+) diff --git a/build.sh b/build.sh index 7cd08c2..0af2fc0 100755 --- a/build.sh +++ b/build.sh @@ -1072,6 +1072,23 @@ build_all_modules() { build lib libXxf86dga build l

[PATCH util-modular 4/9] build.sh: add the remaining xorg app(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov With this and follow-up patches we'll add all the outstanding repos from xorg/ Ideally we'll get everything inside build.sh so that a simple script (like below) can easily flag differences. Obviously deprecated/obsolete projects won't be build/are commented out. for i in app

[PATCH util-modular 2/9] build.sh: mention when autogen/configure is omitted

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- build.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/build.sh b/build.sh index 9ef6302..c83ff5e 100755 --- a/build.sh +++ b/build.sh @@ -680,6 +680,8 @@ process() { cd $old_pwd return 1 fi +else +

[PATCH util-modular] x-driver-screen-scrn-conv.sh: add shebang

2017-02-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- x-driver-screen-scrn-conv.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/x-driver-screen-scrn-conv.sh b/x-driver-screen-scrn-conv.sh index e41cf7a..f805424 100755 --- a/x-driver-screen-scrn-conv.sh +++ b/x-driver-screen-scrn-conv.sh @

[PATCH util-modular] release.sh: Also update srv_path for older Mesa releases.

2017-02-14 Thread Emil Velikov
From: Emil Velikov Otherwise we'll be missing the "$version" directory and the files will be uploaded the the wrong location. Fixes: f16477858bc "release.sh: remove $MESA_VERSION from the destination location" Signed-off-by: Emil Velikov --- release.sh | 1 + 1 file changed, 1 insertion(+) di

[PATCH util/macros 1/2] Rework CHANGELOG_CMD to touch/echo >&2 only as needed

2017-02-14 Thread Emil Velikov
From: Emil Velikov Currently CHANGELOG_CMD issues a touch ChangeLog; echo "Scary message" >&2 even if the file is already present. For example, when running `make distcheck' the following is observed: " /bin/sh: ../../.changelog.tmp: Permission denied git directory not found: installing poss

[PATCH util/macros 2/2] Rework INSTALL_CMD to touch/echo >&2 only as needed

2017-02-14 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. With this commit we no longer get the following erroneous messages during `make distcheck'. " failed to copy INSTALL from util-macros: installing possibly empty INSTALL. ... failed to copy INSTALL from util-macros: installing possibly empty INSTA

Re: [PATCH xserver 1/2] prime: Sync shared pixmap from root window instead of screen pixmap

2017-02-14 Thread Michel Dänzer
On 01/02/17 06:35 PM, Michel Dänzer wrote: > From: Michel Dänzer > > The screen pixmap doesn't receive updates while there's a Present flip > window. > > Signed-off-by: Michel Dänzer > --- > dix/pixmap.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git