Re: [PATCH] fixing -logfile when used with -displayfd

2017-08-27 Thread Alan Coopersmith
I admit not looking at this code in a year and a half and barely remembering what it does, but that seems like the wrong place to add the check - wouldn't it make more sense to change if (displayfd != -1) { to if ((displayfd != -1) && strstr(saved_log_fname, "%s")) { in LogInit, so

Re: [PATCH] fixing -logfile when used with -displayfd

2017-08-27 Thread Antoine Martin
Bump. This is a cosmetic bug, but it trips up many people when they cannot find the log file that they had requested. This should be applied to older branches too since this particular bug was also applied to 1.18.1 (a fairly big change too, especially compared to this one liner fix for it) Cheer