Re: [PATCH xserver] xwayland: Fix a segfault with pointer locking

2017-09-04 Thread Peter Hutterer
On Thu, Aug 31, 2017 at 10:23:00AM +0200, Olivier Fourdan wrote: > Xwayland would crash in some circumstances while trying to issue a > pointer locking when the cursor is hidden when there is no seat focus > window set. > > The crash signature looks like: > > #0 zwp_pointer_constraints_v1_lock_

Re: [RFC xserver] present: remove unused argument in present_screen_info::check_flip()

2017-09-04 Thread Michel Dänzer
On 05/09/17 02:52 AM, Emil Velikov wrote: > From: Emil Velikov > > Namely: sync_flip has been unused since the code was introduced back in > 2015. > > Cc: Kenneth Graunke > Cc: Dave Airlie > Signed-off-by: Emil Velikov > --- > Hi all, > I'm fairly certain that the original goal was to actuall

[RFC xserver] present: remove unused argument in present_screen_info::check_flip()

2017-09-04 Thread Emil Velikov
From: Emil Velikov Namely: sync_flip has been unused since the code was introduced back in 2015. Cc: Kenneth Graunke Cc: Dave Airlie Signed-off-by: Emil Velikov --- Hi all, I'm fairly certain that the original goal was to actually check the boolean. Yet I'm not that familiar with the code to

Re: [PATCH libICE 1/7] Added visibility annotations.

2017-09-04 Thread Emil Velikov
[Adding Julien] Hi all, On 12 May 2016 at 14:18, Emil Velikov wrote: > On 9 May 2016 at 17:52, Adam Jackson wrote: >> On Sun, 2016-05-08 at 09:19 +0100, Emil Velikov wrote: >>> From: Yury Gribov >>> >>> This allow us to be good citizen by hiding the private symbols and >>> reducing the overall

Re: [PATCH xserver] dri2: sort DRI2InfoPtr::version checking in ascending order

2017-09-04 Thread Emil Velikov
On 3 August 2017 at 19:58, Alex Deucher wrote: > On Thu, Aug 3, 2017 at 2:43 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Makes it easer to follow if 8 is between 7 and 9 ;-) > > Agreed :) > Reviewed-by: Alex Deucher > Thank you Alex. Any ideas, who I need to poke to get the patch merged

Re: [PATCH] glx: remove unused systemTimeExtension

2017-09-04 Thread Emil Velikov
On 23 August 2017 at 18:08, Eric Anholt wrote: > Emil Velikov writes: > >> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a >> dri1 artefact copy/pasted in the dri2/drisw codebase. > > Agreed that it seems to be only DRI1 drivers that used it. > > Reviewed-by: Eric Anho

Re: [PATCH xserver 1/2] xwayland: use the lowercase xnf.*alloc API

2017-09-04 Thread Emil Velikov
Hi Olivier, On 30 May 2016 at 08:50, Olivier Fourdan wrote: > Hi Emil, > > On 29 May 2016 at 12:16, Emil Velikov wrote: >> Can anyone ack/nack this and patch 2/2 ? > > While at it, could you please also add the XNFreallocarray() I added in the > meantime in xwayland-glamor-xv.c to your patch fo

Re: [PATCH libICE 3/3] Make sure string is never NULL

2017-09-04 Thread Emil Velikov
On 4 September 2017 at 14:53, Eric Engestrom wrote: > On Monday, 2017-09-04 12:00:58 +0100, Emil Velikov wrote: >> On 7 July 2017 at 11:23, Eric Engestrom wrote: >> > `error_message` is passed in to strncpy() without any check, which >> > doesn't handle NULL itself, so let's make it a valid empty

Re: [PATCH libICE 3/3] Make sure string is never NULL

2017-09-04 Thread Eric Engestrom
On Monday, 2017-09-04 12:00:58 +0100, Emil Velikov wrote: > On 7 July 2017 at 11:23, Eric Engestrom wrote: > > `error_message` is passed in to strncpy() without any check, which > > doesn't handle NULL itself, so let's make it a valid empty string in > > cases where it was NULL. > > > Strictly spe

Re: [PATCH libICE 3/3] Make sure string is never NULL

2017-09-04 Thread Emil Velikov
On 4 September 2017 at 12:37, walter harms wrote: > > > Am 04.09.2017 13:00, schrieb Emil Velikov: >> On 7 July 2017 at 11:23, Eric Engestrom wrote: >>> `error_message` is passed in to strncpy() without any check, which >>> doesn't handle NULL itself, so let's make it a valid empty string in >>>

Re: [PATCH libICE 3/3] Make sure string is never NULL

2017-09-04 Thread walter harms
Am 04.09.2017 13:00, schrieb Emil Velikov: > On 7 July 2017 at 11:23, Eric Engestrom wrote: >> `error_message` is passed in to strncpy() without any check, which >> doesn't handle NULL itself, so let's make it a valid empty string in >> cases where it was NULL. >> > Strictly speaking strdup() ca

Re: [PATCH libICE 3/3] Make sure string is never NULL

2017-09-04 Thread Emil Velikov
On 7 July 2017 at 11:23, Eric Engestrom wrote: > `error_message` is passed in to strncpy() without any check, which > doesn't handle NULL itself, so let's make it a valid empty string in > cases where it was NULL. > Strictly speaking strdup() can fail, thus we could still end with a NULL. In all f

Re: [PATCH libICE 0/3] Fix memory access

2017-09-04 Thread Eric Engestrom
Ping :) On Friday, 2017-07-07 11:23:45 +0100, Eric Engestrom wrote: > Fix a few free() of static strings and strncpy() of NULL. > > BTW, there hasn't been a release in quite a few years, but some of the > fixes might be interesting, especially ff5e59f322 "Use getentropy() if > arc4random_buf() is

Re: [PATCH xserver] squash! sync: Convert from "CARD64" to int64_t. (v2)

2017-09-04 Thread Pekka Paalanen
On Fri, 1 Sep 2017 11:55:15 -0700 Eric Anholt wrote: > --- > > Pekka - that link didn't help, because we still need a correct > "result" value. I don't believe that the compiler could break uint -> > int conversions with the high bit, but here's the patch I think we > would need for that. I s