Re: [PATCH] os: Make sure big requests have sufficient length.

2017-10-09 Thread Michal Srb
On pondělí 9. října 2017 17:14:44 CEST Eric Anholt > I tried the updated testcase and that didn't crash for me, either. My > v2 (which I've now sent out) testcase times out in 30 seconds without > the fix and passes with the fix. I'd love your review if you like that > as a solution. PolyLine i

Re: [PATCH] os: Make sure big requests have sufficient length.

2017-10-09 Thread Eric Anholt
Peter Hutterer writes: > On Mon, Sep 25, 2017 at 12:55:47PM -0700, Eric Anholt wrote: >> Michal Srb writes: >> >> > On neděle 24. září 2017 0:20:07 CEST Eric Anholt wrote: >> >> Michal Srb writes: >> >> > Here is a script that can be used to crash X server using a broken big >> >> > request fo

[PATCH xserver] test: Add a test for the overflow bug in bigreqs.

2017-10-09 Thread Eric Anholt
The failing struct comes from the python test written by Michal Srb . v2: Use a drawable (root window) and gc, so that PolyLines hopefully actually tries processing things. However, the request seems to process successfully so the poll() just stalls out. However, this does let us dis