On Mon, Nov 6, 2017 at 1:30 PM, Louis-Francis Ratté-Boulianne <
l...@collabora.com> wrote:
> Using modifier might allow the driver to use a more optimal format
> (e.g. tiled/compressed). Let's try to use those if possible.
>
> Signed-off-by: Louis-Francis Ratté-Boulianne
> ---
> glamor/glamor_eg
Change 7b634067 added HW cursor support for PRIME by removing the
pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite
cursor functions set/check the cursor both on master and slave.
However, before this change, drivers that did not make use of pixmap_dirty_list
to implement
First two changes are prep, third change is for functionality.
Change 7b634067 added HW cursor support for PRIME by removing the
pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite
cursor functions set/check the cursor both on master and slave.
Naturally, the slave driving
xf86CheckHWCursor() has spacing that is inconsistent with the rest of the file.
Correct this in preparation for subsequent changes.
Signed-off-by: Alex Goins
---
hw/xfree86/ramdac/xf86HWCurs.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/xfree86/ramdac/xf86HW
https://lists.x.org/archives/xorg-devel/2016-September/050973.html implies that
xf86CursorScreenPtr is part of the ABI. Mark xf86CursorPriv.h as such.
Signed-off-by: Alex Goins
---
hw/xfree86/ramdac/Makefile.am | 4 ++--
hw/xfree86/sdksyms.sh | 1 +
2 files changed, 3 insertions(+), 2 de
On Thu, 2017-11-02 at 16:34 +, Emil Velikov wrote:
> On 1 November 2017 at 20:31, Adam Jackson wrote:
> > Signed-off-by: Adam Jackson
> > ---
>
> Please add a line about the reason behind the split.
> It's not immediately obvious if there's some technical merit or simply
> things easier to f
On Mon, 2017-11-06 at 03:29 -0500, Olivier Fourdan wrote:
> Hi Adam,
>
> > It doesn't matter, none of this matters.
>
> It's an indication that Xwayland has started and is using glamor
> though.
>
> Maybe we could replace it with some message indicating Xwayland has
> started, could be useful fo
On Thu, 2017-11-02 at 16:30 +, Emil Velikov wrote:
> On 1 November 2017 at 20:31, Adam Jackson wrote:
> > This really just wants to be the list of disable booleans and
> > initialization functions, and nothing else. Stop including the protocol
> > headers from extinit.h, remove a stray mention
fbGetRotatedPixmap went away with 24bpp support, just treat it as NULL
and we'll do the right thing.
Signed-off-by: Adam Jackson
---
saa/saa.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/saa/saa.c b/saa/saa.c
index be9520e..d956853 100644
--- a/saa/saa.c
+++ b/saa/saa.c
@@ -370,6 +3
Hi,
On Tue, 2017-11-07 at 09:54 -0500, Adam Jackson wrote:
> On Mon, 2017-11-06 at 16:30 -0500, Louis-Francis Ratté-Boulianne
> wrote:
> This conflicts with the changes added in:
>
> commit f44935cdb7321af242ce9f242975f096807b97f7
> Author: Daniel Martin
> Date: Mon Oct 23 10:31:21 2017 +0200
---
xkb/xkbUtils.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On Tue, Nov 7, 2017 at 10:55 AM, Eric Engestrom wrote:
> I think this patch is good, because it explicitly shows the NoSymbol
> value that is tested later on. The implicit 0s are fine, but I think adding
> a one-sentenc
On Mon, Nov 6, 2017 at 10:54 PM, Adam Jackson wrote:
> On Sat, 2017-11-04 at 23:06 +0100, Giuseppe Bilotta wrote:
>> Signed-off-by: Giuseppe Bilotta
>> ---
>> randr/rrcrtc.c | 6 ++
>> randr/rroutput.c | 5 +
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/randr/rrcrtc.c b/rand
On Mon, 2017-11-06 at 16:30 -0500, Louis-Francis Ratté-Boulianne wrote:
> @@ -1718,13 +1867,28 @@ drmmode_output_get_modes(xf86OutputPtr output)
> drmmode_ptr drmmode = drmmode_output->drmmode;
> int i;
> DisplayModePtr Modes = NULL, Mode;
> -drmModePropertyPtr props;
> xf8
On 7 November 2017 at 09:38, Daniel Martin wrote:
> The kernel guarantees that the MST path property blob of a connector
> has a certain format and this property is immutable - can't be changed
> from user space. With that in mind, reduce the parsing code to a minimum
> matching the format criteri
On 7 November 2017 at 09:38, Daniel Martin wrote:
> ../hw/xfree86/os-support/linux/lnx_platform.c: In function ‘get_drm_info’:
> ../hw/xfree86/os-support/linux/lnx_platform.c:29:16: warning: variable
> ‘minor’ set but not used [-Wunused-but-set-variable]
> int major, minor, fd;
>
On 6 November 2017 at 21:07, Adam Jackson wrote:
> The trailing \n are just wrong here, __glXEnableExtension wants a string
> without them.
>
> Signed-off-by: Adam Jackson
Reviewed-by: Emil Velikov
Related: we want to drop the ifdef __DRI2_FLUSH_CONTROL, adding a
fallback define for the symbol.
On 06/11/17 10:30 PM, Louis-Francis Ratté-Boulianne wrote:
> Add 'check_flip2' hook for driver to let know the core
> about why flipping is not possible ('reason').
> If it is because of unsupported buffer format/modifier,
> a PresentCompleteNotify event is sent to the client with
> the PresentComp
On 7 November 2017 09:43:06 GMT, Giuseppe Bilotta
wrote:
> On Mon, Nov 6, 2017 at 4:41 PM, Eric Engestrom
> wrote:
> > On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote:
> >> This fixes some “Conditional jump depends on uninitialized
> value(s)”
> >> errors spotted by valgrind.
> >>
On Mon, Nov 6, 2017 at 4:41 PM, Eric Engestrom
wrote:
> On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote:
>> This fixes some “Conditional jump depends on uninitialized value(s)”
>> errors spotted by valgrind.
>>
>> Signed-off-by: Giuseppe Bilotta
>
> Reviewed-by: Eric Engestrom
>
> A
We failed to handle the mode_output member properly a few times. We can
retrieve it at any time, which we do at various places anyway. Remove
it.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 21 -
hw/xfree86/drivers/modesetting/drmmode_d
No need for modes and connector status probing here.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drm
So, we don't rely on the mode_output member.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modeset
So, we don't rely on the mode_output member.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 28 +++-
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/mod
Hi all,
I've written a few fixes and patches to rip out the mode_output member.
We don't need it, we just fail handling it.
- fixing a compiler warning:
xfree86: Fix set but not used warnings in lnx_platform
- small fix (log msg missed a new-line):
modesetting: Fix log msg if pixmap creati
So, we don't rely on the mode_output member.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drmmo
The kernel guarantees that the MST path property blob of a connector
has a certain format and this property is immutable - can't be changed
from user space. With that in mind, reduce the parsing code to a minimum
matching the format criteria.
(Preparation to fold the parsing into output name creat
../hw/xfree86/os-support/linux/lnx_platform.c: In function ‘get_drm_info’:
../hw/xfree86/os-support/linux/lnx_platform.c:29:16: warning: variable ‘minor’
set but not used [-Wunused-but-set-variable]
int major, minor, fd;
^
../hw/xfree86/os-support/linux/lnx_platform.c:29:9
Add a missing new-line character and make the message more verbose than
"Failed".
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/d
If drmModeGetConnector() fails in drmmode_output_detect(), we have to
reset the output_id to -1 too.
Yet another spot leading to a potential NULL dereference when handling
the mode_output member as output_id was != -1. Though, this case should
be very hard to hit.
Signed-off-by: Daniel Martin
--
So, we don't rely on the mode_output member.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 13 +++--
hw/xfree86/drivers/modesetting/drmmode_display.h | 1 +
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/xfree86/drivers/modesettin
Looks much better without gotos.
Signed-off-by: Daniel Martin
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 75 +++-
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drm
On 06/11/17 10:07 PM, Adam Jackson wrote:
> The trailing \n are just wrong here, __glXEnableExtension wants a string
> without them.
>
> Signed-off-by: Adam Jackson
> ---
> glx/glxdri2.c | 2 +-
> glx/glxdriswrast.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
32 matches
Mail list logo
