Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Keith Packard
Adam Jackson writes: >> Should check for a NULL cursor here. > > It does, hidden in the macro: > > render/animcur.c:#define IsAnimCur(c) ((c) && ((c)->bits == > &animCursorBits)) Cool. In which case, the patch is Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP sig

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Adam Jackson
On Tue, 2018-01-09 at 14:06 -0800, Keith Packard wrote: > Adam Jackson writes: > > > +static void > > +AnimCurCancelTimer(DeviceIntPtr pDev) > > +{ > > +CursorPtr cur = pDev->spriteInfo->anim.pCursor; > > + > > +if (IsAnimCur(cur)) > > +TimerCancel(GetAnimCur(cur)->timer); > > +}

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Keith Packard
Adam Jackson writes: > +static void > +AnimCurCancelTimer(DeviceIntPtr pDev) > +{ > +CursorPtr cur = pDev->spriteInfo->anim.pCursor; > + > +if (IsAnimCur(cur)) > +TimerCancel(GetAnimCur(cur)->timer); > +} > + Should check for a NULL cursor here. Otherwise, this lgtm. -- -keith

Re: [PATCH xserver 2/2] randr: Use RRCrtcGetScanoutSize() in ProcRRSetScreenSize()

2018-01-09 Thread Keith Packard
Alex Goins writes: > RRCrtcGetScanoutSize() adds a significant amount of complexity compared to > simply checking the rotation and swapping width and height, since it operates > by > applying the transformation matrix crtc->transform to the mode. There's also an implicit assumption that when a

[PATCH] xfree86: add default modes for 16:9 and 16:10

2018-01-09 Thread Martin Wilck
Improve the user experience for users with wide screens by adding standard 16:9 and 16:10 modes to extramodes, as suggested previously (https://lists.x.org/archives/xorg-devel/2016-February/048866.html). Tested successfully on my laptop. Feedback welcome. See also https://bugs.freedesktop.org/show

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Adam Jackson
On Tue, 2018-01-09 at 10:39 -0800, Aaron Plattner wrote: > I re-verified the crash and verified that this series fixes it, so you > can add > Tested-by: Aaron Plattner Merged, thanks! remote: I: patch #196638 updated using rev de60245e05c0d2528d4ff42557a044387e53315c. remote: I: patch #196639

Re: [PATCH xserver 2/2] randr: Use RRCrtcGetScanoutSize() in ProcRRSetScreenSize()

2018-01-09 Thread Alex Goins
On Tue, 9 Jan 2018, Michel Dänzer wrote: > On 2018-01-09 03:44 AM, Alex Goins wrote: > > Previously, ProcRRSetScreenSize() manually computed the dimensions of a > > CRTC's > > viewport in order to check that it does not extend beyond the bounds of the > > new > > screen size. It did this incorre

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Adam Jackson
On Tue, 2018-01-09 at 10:08 -0800, Aaron Plattner wrote: > On 01/09/2018 08:51 AM, Adam Jackson wrote: > > > @@ -165,8 +174,10 @@ AnimCurDisplayCursor(DeviceIntPtr pDev, ScreenPtr > > pScreen, CursorPtr pCursor) > > if (pCursor != pDev->spriteInfo->anim.pCursor) { > > AnimCu

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Aaron Plattner
On 01/09/2018 10:08 AM, Aaron Plattner wrote: > On 01/09/2018 08:51 AM, Adam Jackson wrote: >> We weren't cancelling the old timer when changing cursors, making things >> go all crashy. Logically we could always cancel the timer first, but >> then we'd have to call TimerSet to re-arm ourselves, and

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Aaron Plattner
On 01/09/2018 08:51 AM, Adam Jackson wrote: > We weren't cancelling the old timer when changing cursors, making things > go all crashy. Logically we could always cancel the timer first, but > then we'd have to call TimerSet to re-arm ourselves, and GetTimeInMillis > is potentially expensive. > > R

Re: [PATCH xserver] animcur: Move timer into pDev->spriteInfo->anim

2018-01-09 Thread Aaron Plattner
On 01/09/2018 08:49 AM, Adam Jackson wrote: > On Mon, 2018-01-08 at 15:02 -0800, Aaron Plattner wrote: >> Commit 094a63d56fbfb9e23210cc9ac538fb198af37cee moved the timer that handles >> animated cursors from the per-screen AnimCurScreenRec into the per-cursor >> AnimCurRec. However, the timer that

[PATCH xserver 2/2] animcur: Handle allocation failure for the animation timer

2018-01-09 Thread Adam Jackson
Signed-off-by: Adam Jackson --- render/animcur.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/render/animcur.c b/render/animcur.c index 797029443c..b5d222bc6e 100644 --- a/render/animcur.c +++ b/render/animcur.c @@ -299,7 +299,7 @@ AnimCursorCreate(CursorPtr *cur

[PATCH xserver 1/2] animcur: Fix transitions between animated cursors

2018-01-09 Thread Adam Jackson
We weren't cancelling the old timer when changing cursors, making things go all crashy. Logically we could always cancel the timer first, but then we'd have to call TimerSet to re-arm ourselves, and GetTimeInMillis is potentially expensive. Reported-by: https://devtalk.nvidia.com/default/topic/10

Re: [PATCH xserver] animcur: Move timer into pDev->spriteInfo->anim

2018-01-09 Thread Adam Jackson
On Mon, 2018-01-08 at 15:02 -0800, Aaron Plattner wrote: > Commit 094a63d56fbfb9e23210cc9ac538fb198af37cee moved the timer that handles > animated cursors from the per-screen AnimCurScreenRec into the per-cursor > AnimCurRec. However, the timer that runs takes the DeviceIntPtr as its > argument, >

Re: [PATCH xserver 2/2] randr: Use RRCrtcGetScanoutSize() in ProcRRSetScreenSize()

2018-01-09 Thread Michel Dänzer
On 2018-01-09 03:44 AM, Alex Goins wrote: > Previously, ProcRRSetScreenSize() manually computed the dimensions of a CRTC's > viewport in order to check that it does not extend beyond the bounds of the > new > screen size. It did this incorrectly, leading to bugs. > > A previous patch "randr: Fix