Re: Making Composite better for interactive apps

2018-02-02 Thread Keith Packard
"Jasper St. Pierre" writes: > How is this different from unredirection? mutter / gnome-shell currently > doesn't unredirect windowed windows, but there's no reason it couldn't -- > it just needs to be able to handle the case where it's unredirecting the > client window rather than the parent fram

Re: Making Composite better for interactive apps

2018-02-02 Thread Jasper St. Pierre
How is this different from unredirection? mutter / gnome-shell currently doesn't unredirect windowed windows, but there's no reason it couldn't -- it just needs to be able to handle the case where it's unredirecting the client window rather than the parent frame window. On Fri, Feb 2, 2018 at 5:43

Re: [PATCH v2 xserver 00/11] modesetting: MS_ALL_IN_ONE

2018-02-02 Thread Yu, Qiang
It's still maintained inside amdgpu-pro driver stack but only on top of 1.19 xserver code base. Since the v2, we switched to use xorg.conf option instead of MS_ALL_IN_ONE environment variable and some code logic improvement and bug fix. Part of the new patches are at: https://github.com/yuq/xserv

Making Composite better for interactive apps

2018-02-02 Thread "Keith Packard"
I visited Valve recently and sat down with Pierre-Loup to hash out what it would take to improve X compositing behavior with interactive applications. I've written those up on my blog here: https://keithp.com/blogs/CompositeAcceleration/ If you've got questions or comments, I'd love to s

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Keith Packard
Michel Dänzer writes: > Taking a step back, do we even need to keep around the original pixmap > and unflip to it at all? I had a chat on IRC about this with Keith a > while ago, see the attached log excerpt. I guess the question is whether the special access granted by the kernel to the window

Re: [RFC xserver v5 05/14] modesetting: Use atomic modesetting API for pageflip if available

2018-02-02 Thread Adam Jackson
On Mon, 2017-11-06 at 16:30 -0500, Louis-Francis Ratté-Boulianne wrote: > +#ifdef GLAMOR_HAS_DRM_ATOMIC > +if (ms->atomic_modeset) { > +drmModeAtomicReq *req = drmModeAtomicAlloc(); > + > +if (!req) > +return 1; > + > +ret |= plane_add_prop(req, drmmode_crtc

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Keith Packard
Michel Dänzer writes: > On 2018-02-02 10:42 AM, Roman Gilg wrote: >> It's because of what you made me aware of in the previous patch set: >> the window original pixmap needs to have the updated content from the >> flip Pixmap, otherwise for example screenshot applications won't work >> anymore. I

Re: [PATCH xserver 1/2] shm, xwayland: prefer atomic close-on-exec without O_TMPFILE

2018-02-02 Thread Adam Jackson
On Fri, 2017-07-07 at 16:31 +0200, Jan Beich wrote: > Signed-off-by: Jan Beich Added the equivalent bits to the meson build (hence the failure below) and merged: remote: E: failed to find patch for rev 1e23f03dd5fb6c981ef6d64c084f72fc6820ed71. remote: I: 0 patch(es) updated to state Accepted. T

Re: [PATCH xserver 2/3] modesetting: Check for -1 before converting to unsigned int.

2018-02-02 Thread Adam Jackson
On Mon, 2017-03-27 at 15:03 +0300, m...@suse.com wrote: > From: Michal Srb > > dri2.c:516:21: warning: comparison of unsigned expression < 0 is always false > [-Wtautological-compare] > if (front->name < 0) > > Prevents a failure from being ignored. > --- Merged these two: remote: I: patc

Re: [PATCH xserver] Xdmx: fix input driver initialization code paths

2018-02-02 Thread Adam Jackson
On Mon, 2017-11-06 at 15:26 +0200, Raimonds Cicans wrote: > Problem: Xdmx exit with error "(Fatal Error) dmx: Unknown input argument: " > if local input driver is specified (example: -input local,usb-kbd,usb-mou). > > Cause: code block for remote input drivers is placed in code path common > for a

Re: [PATCH xserver] Xephyr: Call forgotten XShmDetach if can't mmap SHM segment

2018-02-02 Thread Adam Jackson
On Fri, 2018-02-02 at 15:17 +0300, Alexander Volkov wrote: > --- > hw/kdrive/ephyr/hostx.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) remote: I: patch #202076 updated using rev 93c16b0524711cd3cd8e32f151c53b5d6522e967. remote: I: 1 patch(es) updated to state Accepted. To

Re: [PATCH v2 xserver 00/11] modesetting: MS_ALL_IN_ONE

2018-02-02 Thread Adam Jackson
On Sat, 2017-01-07 at 16:01 +0800, Qiang Yu wrote: > V2: add PATCH 11 to support GPUScreen capable of display > > This is for hybrid drm device use case that one drm device > is only capable of display and the other is only capable of > rendering. Is this series still relevant? If so, have you re

[PATCH xserver 1/4] glx: Import glxvnd server module (v2)

2018-02-02 Thread Adam Jackson
From: Kyle Brenneman This is based on an out-of-tree module written by Kyle: https://github.com/kbrenneman/libglvnd/tree/server-libglx I (ajax) did a bunch of cosmetic fixes, ported it off xfree86 API, added request length checks, and fixed a minor bug or two. v2: Use separate functions to set

[PATCH xserver 4/4] miinitext: Remove separate extension toggle list

2018-02-02 Thread Adam Jackson
This was only separate because GLX was loadable. The frontend is now linked statically, so we can use the static extension list directly. Signed-off-by: Adam Jackson --- mi/miinitext.c | 173 + 1 file changed, 51 insertions(+), 122 deletion

[PATCH xserver 2/4] glx: Use vnd layer for dispatch (v3)

2018-02-02 Thread Adam Jackson
The big change here is MakeCurrent and context tag tracking. We now delegate context tags entirely to the vnd layer, and simply store a pointer to the context state as the tag data. If a context is deleted while it's current, we allocate a fake ID for the context and move the context state there, s

[PATCH xserver 3/4] miinitext: Load GLX on the mi path

2018-02-02 Thread Adam Jackson
Add a stub for Xnest so it continues to link, but otherwise we support GLX on every server so there's no need to make every DDX add it. Signed-off-by: Adam Jackson --- hw/dmx/dmxinit.c | 3 --- hw/kdrive/ephyr/ephyrinit.c| 16 hw/vfb/InitOutput.c|

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Michel Dänzer
On 2018-02-02 12:08 PM, Michel Dänzer wrote: > On 2018-02-02 10:42 AM, Roman Gilg wrote: > >> I also tried to not copy, but set the window pixmap to the flip >> pixmap. The problem I encountered here, is that the window original >> pixmap can be controlled by the client. > > How? > > >> And whe

[PATCH xserver] Xephyr: Call forgotten XShmDetach if can't mmap SHM segment

2018-02-02 Thread Alexander Volkov
--- hw/kdrive/ephyr/hostx.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index 23e1cd3bf..8a69ec1e0 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@ -457,8 +457,9 @@ hostx_create_shm_segment(xc

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Michel Dänzer
On 2018-02-02 10:42 AM, Roman Gilg wrote: > It's because of what you made me aware of in the previous patch set: > the window original pixmap needs to have the updated content from the > flip Pixmap, otherwise for example screenshot applications won't work > anymore. I tested it with xwd. FWIW, my

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Roman Gilg
It's because of what you made me aware of in the previous patch set: the window original pixmap needs to have the updated content from the flip Pixmap, otherwise for example screenshot applications won't work anymore. I tested it with xwd. I also tried to not copy, but set the window pixmap to the