Re: [PATCH 14/19] present: Add window flip mode

Roman Gilg writes: > An unflip might happen at any time when the window is reconfigured and > the check_flip_window function returns false. Then we need again a > pixmap for the window to paint to. Yup, no different than any existing resize operation today. > This is indeed

Re: [PATCH 14/19] present: Add window flip mode

On Fri, Feb 2, 2018 at 5:11 PM, Michel Dänzer wrote: > Taking a step back, do we even need to keep around the original pixmap > and unflip to it at all? I had a chat on IRC about this with Keith a > while ago, see the attached log excerpt. > > Keith's main concern is that the

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

Giuseppe Bilotta writes: > Actually, it just occurred to me that a negative scaling factor could > be interpreted as a reflection in that direction (i.e. --scale -2x1 > could be aliased to --scale 2x1 --reflect x). Or is it not worth it? Not worth it in my eye --

Re: Making Composite better for interactive apps

Giuseppe Bilotta writes: > Ok, I'm convinced. Just as a curiosity though, are there any plans (or > anything special that needs planning) to support things such as > adaptive sync? Adaptive sync has a bunch of additional work required: 1) Model the display time to

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

On Tue, Feb 6, 2018 at 8:03 PM, Keith Packard wrote: > Giuseppe Bilotta writes: >> I'll add the positive check for both scale and gamma and respin the patch. > > Thanks. Actually, it just occurred to me that a negative scaling factor could be

Re: Making Composite better for interactive apps

On Tue, Feb 6, 2018 at 3:39 AM, Keith Packard wrote: > Giuseppe Bilotta writes: >> I'm coming at this from the assumption that a Compositing Manager >> would try to pump out frames as frequently as possible, in order to >> minimize latency, which

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

On Tue, 2018-02-06 at 10:48 +0100, Giuseppe Bilotta wrote: > On Tue, Feb 6, 2018 at 10:03 AM, walter harms wrote: > > It would be nice to have an explanation why this change. > > The change is to align the description of the protocol with what the > protocol actually sends (see

Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > In the vast majority of cases, it'll be the application's own window > anyway, so even accidents won't affect anything else. :) Agreed. Thanks for taking time to help me understand this. -- -keith signature.asc Description: PGP signature

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

walter harms writes: > It would be nice to have an explanation why this change. Oh, sorry, the documented encoding didn't match the protocol specification above or the structure defined in randrproto.h. Clearly a mistake I left in the document while creating that version. --

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

On Mon, 2018-02-05 at 11:25 +0100, Thomas Hellstrom wrote: > On 02/05/2018 11:20 AM, Mario Kleiner wrote: > > Commit 91c42093b248 ("glx: Duplicate relevant fbconfigs for > > compositing visuals") adds many new depth 32 fbconfigs as > > composite visuals. On a X-Screen running at depth 24, this > >

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

Giuseppe Bilotta writes: > Joking aside, this does mean that strtod could be a good option when > parsing the single value. The check would be more verbose though, so I > think I'll stick with sscanf. Sure, your sscanf pattern is pretty simple to understand. > I'll

Re: [PATCH xserver v2] xwayland: Don't process cursor warping without an xwl_seat

On Tue, 2018-02-06 at 12:41 -0500, Lyude Paul wrote: > Unfortunately, on my machine Xwayland immediately crashes when I try to > start it. gdb backtrace: > > #0 0x774f0e79 in wl_proxy_marshal () from > target:/lib64/libwayland-client.so.0 > #1 0x00413172 in

[PATCH xserver v2] xwayland: Don't process cursor warping without an xwl_seat

Unfortunately, on my machine Xwayland immediately crashes when I try to start it. gdb backtrace: #0 0x774f0e79 in wl_proxy_marshal () from target:/lib64/libwayland-client.so.0 #1 0x00413172 in zwp_confined_pointer_v1_destroy (zwp_confined_pointer_v1=0x7) at

Re: [PATCH 14/19] present: Add window flip mode

On Tue, 2018-02-06 at 12:21 +0100, Michel Dänzer wrote: > On 2018-02-05 09:08 PM, Adam Jackson wrote: > > On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > > > > > > > The inability to queue a presentation to the next MSC is more of a > > > > > step > > > > > back compared to the status

Re: [PATCH xserver] xwayland: Don't process cursor warping without an xwl_seat

Hi Lyude, On Mon, Feb 5, 2018 at 11:22 PM, Lyude Paul wrote: > Unfortunately, on my machine Xwayland immediately crashes when I try to > start it. gdb backtrace: > > #0 0x774f0e79 in wl_proxy_marshal () from > target:/lib64/libwayland-client.so.0 > #1

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-05 09:08 PM, Adam Jackson wrote: > On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > The inability to queue a presentation to the next MSC is more of a step back compared to the status quo. >>> >>> I'm about to go write up some ideas I'm working on that will make it

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-05 08:09 PM, Keith Packard wrote: > Michel Dänzer writes: > >> Ignoring the Security extension, the client has the same control over >> the contents of another application's window *using* the X protocol, >> doesn't it? > > Yeah, good point -- it could easily call

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

On Tue, Feb 6, 2018 at 10:03 AM, walter harms wrote: > It would be nice to have an explanation why this change. The change is to align the description of the protocol with what the protocol actually sends (see e.g. line 417 in the same file, or the header and the server source). I

Re: [PATCH libXi] _XIPassiveGrabDevice needs to set time value

On Thu, Feb 01, 2018 at 01:59:56AM -0600, Jeff Smith wrote: > When setting up a XIPassiveGrabDevice request, the time field is not > being set, leading to improper data being passed 'over the wire'. > > Accept a time value into _XIPassiveGrabDevice and use it to set the time > field in the

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

It would be nice to have an explanation why this change. re, wh Am 06.02.2018 02:03, schrieb Giuseppe Bilotta: > --- > randrproto.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/randrproto.txt b/randrproto.txt > index c06bc90..f57301d 100644 > ---

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

On Tue, Feb 6, 2018 at 3:43 AM, Keith Packard wrote: > No, strtod requires a non-empty sequence of digits. Woah. My whole life is a lie … (I guess it's my fault for never bothering to actually verify this.) > strtod is actually not a terrible function (surprising for libc, I