Depth 30 enablement for modesetting-ddx and fixups for glamor. Rev 2

2nd revision of the server/modesetting-ddx/glamor patches for depth 30, following Eric's and Michel's suggestions (thanks!).. These ones tested on nouveau, amd, intel with the modesetting ddx + glamor and also (for glamor again) against the latest ati-ddx and amdgpu-ddx, which now can use depth 30

[PATCH xserver 7/7] modesetting: Enable screen color depth 30 support.

glamor now supports depth 30, so allow use of it. Signed-off-by: Mario Kleiner Reviewed-by: Eric Anholt --- hw/xfree86/drivers/modesetting/driver.c | 1 + hw/xfree86/drivers/modesetting/drmmode_display.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/

[PATCH xserver 3/7] glamor: Enable composite acceleration for rgb10 formats. (v2)

Specifically for xrgb2101010 format. Tested on KDE Plasma-5 with XRender based composite acceleration backend. Much smoother and faster. (v2) Dropped argb2101010, because of depth 32 confusion with argb, as pointed out by Eric. Thanks! Signed-off-by: Mario Kleiner --- glamor/glamor_ren

[PATCH xserver 4/7] glamor: Bump version to 1.0.1 to signal depth 30 support.

Signed-off-by: Mario Kleiner --- glamor/glamor_eglmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_eglmodule.c b/glamor/glamor_eglmodule.c index dd4664b..326af3a 100644 --- a/glamor/glamor_eglmodule.c +++ b/glamor/glamor_eglmodule.c @@ -40,7 +40,7 @@ stat

[PATCH xserver 5/7] xfree86/modes: Adapt xf86Randr12CrtcComputeGamma() for depth 30.

At screen depths > 24 bit, the color palettes passed into xf86Randr12CrtcComputeGamma() can have a larger number of slots than the crtc's hardware lut. E.g., at depth 30, 1024 palette slots vs. 256 hw lut slots. This palette size > crtc gamma size case is not handled yet and leads to silent failure

[PATCH xserver 1/7] glamor: Make Xv extension initialize at depth 30.

Support x-screens of depth 30, so init doesn't fail. Signed-off-by: Mario Kleiner Reviewed-by: Eric Anholt --- hw/xfree86/glamor_egl/glamor_xf86_xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/glamor_egl/glamor_xf86_xv.c b/hw/xfree86/glamor_egl/glamor_xf

[PATCH xserver 6/7] modesetting: Adapt xf86HandleColorMaps() for > 24 color depth.

This retains old behavior for depths <= 24, but allows gamma table and colormap updates to work properly at depth 30. This needs the xf86Randr12CrtcComputeGamma() fix for depth 30 from a previous commit to work. Otherwise the server will work, but gamma table updates will silently fail, iow. the s

[PATCH xserver 2/7] glamor: Fix loose ends in color depth 30 support.

This makes it work properly with OpenGL based desktop compositing, as tested with EGL and GLX based compositing under OpenGL-2/3, and also artifact free with XRender based 2D compositing. Signed-off-by: Mario Kleiner Reviewed-by: Eric Anholt --- glamor/glamor.c | 6 -- glamor/glamor_co

Re: [RFC xserver v6 09/14] modesetting: Create scanout buffers using supported modifiers

On Thu, 2018-02-15 at 23:15 -0500, Louis-Francis Ratté-Boulianne wrote: > Use most optimal buffer format (e.g. tiled/compressed) available > for scanout. > > v2: Don't use multi-plane modifier to create scanout buffer > > v3: Add flag to retrieve modifiers set from enabled CRTCs only > > v4: Fix

Re: [RFC xserver v6 05/14] modesetting: Use atomic modesetting API for pageflip if available

On Thu, 2018-02-15 at 23:15 -0500, Louis-Francis Ratté-Boulianne wrote: > In order to flip between compressed and uncompressed buffers - > something drmModePageFlip explicitly bans us from doing - we need > to port use the atomic modesetting API. It's only 'fake' atomic > though given we still comm

Re: [PATCH xserver 04/10] meson: Make DGA extension optional

On Sun, 2018-02-18 at 10:58 +0100, Laurent Carlier wrote: > Signed-off-by: Laurent Carlier Merged 1-4: remote: I: patch #205373 updated using rev 82d9e99bf99660537a11d9475369c43814cad664. remote: I: patch #205374 updated using rev ce4e20f80ff64a5a8b9f344e2507128f379e0715. remote: I: patch #205

Re: [PATCH xserver 07/10] meson: Check if SYSV IPC is available

On Sun, 2018-02-18 at 10:58 +0100, Laurent Carlier wrote: > diff --git a/meson.build b/meson.build > index 107c055..983604a 100644 > --- a/meson.build > +++ b/meson.build > @@ -96,6 +96,21 @@ nettle_dep = dependency('nettle') > dbus_required = get_option('systemd_logind') == 'true' > dbus_dep =

Re: [PATCH xserver 05/10] meson: Make APM support optional

On Sun, 2018-02-18 at 10:58 +0100, Laurent Carlier wrote: > diff --git a/hw/xfree86/os-support/meson.build > b/hw/xfree86/os-support/meson.build > index dfb613e..683aca0 100644 > --- a/hw/xfree86/os-support/meson.build > +++ b/hw/xfree86/os-support/meson.build > @@ -35,6 +35,9 @@ if host_machine.

Re: [PATCH xserver] os: avoid uninitialized offsets in backtrace

On Thu, 2018-02-15 at 23:47 -0600, Jeff Smith wrote: > When xorg_backtrace calls unw_get_proc_name and an error occurs, offset > might not be set for the current frame. > > Initialize offset for each frame so that the offset from another frame > cannot be used inadvertently. remote: I: patch #205

Re: [PATCH xserver] hw/xwin: Update for glxvnd

On Fri, 2018-02-16 at 16:44 +, Jon Turney wrote: > - Link with libglxvnd in meson.build > - Call xorgGlxCreateVendor() like all other DDX remote: Updating patchwork state for https://patchwork.freedesktop.org/project/Xorg/list/ remote: I: patch #205278 updated using rev 6f9d29040cd9f4723a2e6

Re: [PATCH xcb] Fix hanging issue in _XReply

No opinion on the patch, but do you have a small reproducer app to expose the problem? I've debugged something similar in the past, without much success (or interest). Thanks, -- A. Huillet ___ xorg-devel@lists.x.org: X.Org development Archives: http:

[PATCH xserver 6/6] mi: Mention extension loading in verbose logs

From: Emil Velikov Listing the extensions is useful, despite being annoying for normal usecases. Print it only when extra (lvl 3) vebose is requested. Signed-off-by: Emil Velikov --- mi/miinitext.c | 4 1 file changed, 4 insertions(+) diff --git a/mi/miinitext.c b/mi/miinitext.c index e5

[PATCH xserver 1/6] glx: keep glvnd_vendor a private [static] variable

From: Emil Velikov Signed-off-by: Emil Velikov --- glx/glxext.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/glx/glxext.c b/glx/glxext.c index a51c13ff1..37416a4e4 100644 --- a/glx/glxext.c +++ b/glx/glxext.c @@ -497,11 +497,11 @@ xorgGlxServerPreInit(const Extens

[PATCH xserver 5/6] docs: correct LoadExtensionList() documentation

From: Emil Velikov Add the missing arguments to the function signature. Fixes: e46820fb897 ("miinitext: introduce LoadExtensionList() to replace over LoadExtension()") Signed-off-by: Emil Velikov --- hw/xfree86/doc/ddxDesign.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH xserver 2/6] glx: NULL check the correct argument in dispatch_GLXVendorPriv

From: Emil Velikov malloc can return NULL, unlike GetVendorDispatchFunc. The latter provides DispatchBadRequest. Signed-off-by: Emil Velikov --- glx/vndcmds.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/glx/vndcmds.c b/glx/vndcmds.c index 200176d4c..c3e1332bf 100

[PATCH xserver 4/6] glx: set the version we implement in GlxServerExports

From: Emil Velikov Set the major/minor version it's currently implemented, not the one provided by the GLXSERVER_VENDOR_ABI_{MAJOR,MINOR}_VERSION macros. Those are identical for now, but can change in the future. Signed-off-by: Emil Velikov --- Hmm we seems to be missing any checks that enforc

[PATCH xserver 3/6] glx: use C99 initializers for GlxServerExports

From: Emil Velikov Signed-off-by: Emil Velikov --- glx/vndext.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/glx/vndext.c b/glx/vndext.c index f593c499a..aeefd7519 100644 --- a/glx/vndext.c +++ b/glx/vndext.c @@ -277,26 +277,26 @