Re: [PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

On 03/ 7/18 01:42 PM, Emil Velikov wrote: > On 7 March 2018 at 20:10, Alan Coopersmith > wrote: >> That should be effectively equivalent, just less change in indentation for >> the lines in between. >> > You're correct - it's functionally identical although it seems

Re: [PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

On 7 March 2018 at 20:10, Alan Coopersmith wrote: > On 03/ 7/18 05:36 AM, Emil Velikov wrote: >> Hi Alan, >> >> On 6 March 2018 at 21:47, Alan Coopersmith >> wrote: >>> Reported by gcc 7.3: >>> >>> GetImage.c:110:25: warning: potential

Re: [PATCH] dri2: Sync i965_pci_ids.h from Mesa.

On Wed, 2018-03-07 at 07:46 -0800, Rodrigo Vivi wrote: > Copied from Mesa with no modifications. > > Gives us Geminilake and Kaby Lake platform names updates and > sync on Coffee Lake PCI IDs. > > Cc: Timo Aaltonen > Signed-off-by: Rodrigo Vivi

Re: [PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

On 03/ 7/18 05:36 AM, Emil Velikov wrote: > Hi Alan, > > On 6 March 2018 at 21:47, Alan Coopersmith > wrote: >> Reported by gcc 7.3: >> >> GetImage.c:110:25: warning: potential null pointer dereference >> [-Wnull-dereference] >> if (planes < 1 || image->height <

[PATCH xserver 2/3] xwayland: Add xwayland-config.h

From: Lyude Paul Just a small autogenerated header that will soon contain more then just one macro. Signed-off-by: Lyude Paul --- configure.ac | 7 +++ hw/xwayland/xwayland.c | 10 ++ hw/xwayland/xwayland.h

[PATCH xserver 3/3] xwayland: Add glamor egl_backend for EGLStreams

From: Lyude Paul This adds initial support for displaying Xwayland applications through the use of EGLStreams and nvidia's custom wayland protocol by adding another egl_backend driver. This also adds some additional egl_backend hooks that are required to make things work

[PATCH xserver 0/3] EGLStreams for Xwayland, v2

This is a not-quite-mechanical rebase against master, mostly to cope with the new DRI3 code. I'm not entirely sure I got those bits correct, additional eyes would be appreciated (all in 1/3). I do wonder, though, why this needs to be about streams at all. Why can't the surface be from

[PATCH xserver 1/3] xwayland: Decouple GBM from glamor

From: Lyude Paul This takes all of the gbm related code in wayland-glamor.c and moves it into it's own EGL backend for Xwayland, xwayland-glamor-gbm.c. Additionally, we add the egl_backend struct into xwl_screen in order to provide hooks for alternative EGL backends such as

[PATCH xserver 2/5] Remove always true GLAMOR_HAS_DRM_* guards

From: Emil Velikov With earlier commit the required version was bumped to 2.4.89, thus the guards always evaluate to true. Fixes: e4e3447603b ("Add RandR leases with modesetting driver support [v6]") Cc: Keith Packard Cc: Daniel Stone

[PATCH xserver 3/5] modesetting: remove always true defined(DRM_CAP_PRIME) guards

From: Emil Velikov The macro was available in libdrm for ages. Furthermore having a guard like this is a very bad idea. Building on an old server will result in a missing run-time functionality. Since it's UABI one can use a local fallback, old kernels will return

[PATCH xserver 5/5] modesetting: remove fallback DRM_CAP_* defines

From: Emil Velikov All the macros are available in the libdrm that we depend on. Signed-off-by: Emil Velikov --- hw/xfree86/drivers/modesetting/driver.c | 8 hw/xfree86/drivers/modesetting/drmmode_display.h | 7 ---

[PATCH xserver 4/5] modesetting: remove always true DRM_IOCTL_CRTC_QUEUE_SEQUENCE guard

From: Emil Velikov We already require libdrm 2.4.89 which provides the definition plus guarding kernel UABI like that is generally a bad idea. See previous commit for details why :-) Cc: Keith Packard Signed-off-by: Emil Velikov

[PATCH xserver 1/5] configure: remove libdrm version check

From: Emil Velikov We already require said version. Signed-off-by: Emil Velikov --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f82c0a66a..14fe34995 100644 ---

[PATCH xserver 1/5] configure: remove libdrm version check

From: Emil Velikov We already require said version. Signed-off-by: Emil Velikov --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f82c0a66a..14fe34995 100644 ---

[PATCH] dri2: Sync i965_pci_ids.h from Mesa.

Copied from Mesa with no modifications. Gives us Geminilake and Kaby Lake platform names updates and sync on Coffee Lake PCI IDs. Cc: Timo Aaltonen Signed-off-by: Rodrigo Vivi --- hw/xfree86/dri2/pci_ids/i965_pci_ids.h | 26

Re: [PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

Hi Alan, On 6 March 2018 at 21:47, Alan Coopersmith wrote: > Reported by gcc 7.3: > > GetImage.c:110:25: warning: potential null pointer dereference > [-Wnull-dereference] > if (planes < 1 || image->height < 1 || image->bytes_per_line < 1 || >

Re: [PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

On 2018-02-28 07:00 PM, Roman Gilg wrote: > On Wed, Feb 28, 2018 at 6:43 PM, Michel Dänzer wrote: >> I'm unable to reproduce the issue you described with Steam (without this >> patch series applied). I'd really like to know where the bogus target >> MSC values you're seeing