Re: [PATCH xserver 5/5] xwayland: small xdg_output cleanup

2018-05-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2018-05-24 at 16:11 +0200, Olivier Fourdan wrote: > Make xwl_output_get_xdg_output() private, it doesn't need to be > available elsewhere. > > Signed-off-by: Olivier Fourdan > --- > hw/xwayland/xwayland-output.c | 4 +++- > hw/xwayland/xwayland.h| 1 - >

Re: [PATCH v2 xserver 4/5] xwayland: Do not disable glamor if eglstream failed

2018-05-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2018-05-24 at 16:33 +0200, Olivier Fourdan wrote: > EGL stream requires glamor, but the opposite is not true. So if someone > passes "-eglstream" with a GPU which does not support EGL stream, we > could maybe still try GBM and be lucky. > > That allows Wayland com

Re: [PATCH xserver 3/5] xwayland: process Wayland events after adding screen

2018-05-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2018-05-24 at 16:11 +0200, Olivier Fourdan wrote: > When we're done adding a new screen, we need to process pending Wayland > events again so that we don't end up processing xdg_output events when > unexpected if glamor is disabled (either becauase "-shm" was passe

Re: [PATCH xserver 2/5] xwayland: "EGL_EXT_device_base" required for eglstream

2018-05-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2018-05-24 at 16:11 +0200, Olivier Fourdan wrote: > eglQueryDevicesEXT() would abort if the required extenon are not > available, meaning that enabling “-eglstream”on a non-EGL stream capable > hardware would lead to an abort(). > > Check that "EGL_EXT_device_base

Re: [PATCH xserver 1/5] xwayland: Allow "-eglstream" option

2018-05-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2018-05-24 at 16:10 +0200, Olivier Fourdan wrote: > The command line option "-eglstream" used to enable EGLi stream support > for NVidia GPU was made available only when Xwayland was built with EGL > stream support enabled. > > Wayland compositors who spawn Xwayla

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-25 Thread Lyude Paul
NAK, unfortunately this check isn't going to be enough, see: 2018-05-24 15:44:34 jadahl Lyude: you can also look at the globals sent out by the compositor 2018-05-24 15:44:52 Lyude jadahl: you mean the wl interfaces 2018-05-24 15:45:30 jadahl yes 2018-05-24 15:46:22 -- ma

[PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-25 Thread Olivier Fourdan
Check for "platform_gbm" in the avaiable EGL extensions, and enable automatically EGL stream if not present. The command line options “-eglstream” is kept for compatibility to force the use of the EGL streams backend. Suggested-by: Ray Strode Signed-off-by: Olivier Fourdan --- Note: * This was

[PATCH xcb] Fix hanging issue in _XReply

2018-05-25 Thread Tatu Frisk
I just noticed this had made it here. I pasted below a reproducer app. The thread blocks until a key is pressed. About the patch itself, it looks like the assumption of the patch is also made on xcb_io.c, line 347, where it is more cautiously called a "reasonable claim". #include #include