Re: [PATCH] present: fix freed pointer access

2018-08-25 Thread Roman Gilg
Looking at the code I think it would be better to not use an else, but put the present_vblank_notify call before the if (vblank->abort_flip) line. Even if the flip was aborted, the client should receive a complete event. At least that's what we do in case of screen flips. On Fri, Aug 24, 2018 at 1

Re: [PATCH] present: fix freed pointer access

2018-08-25 Thread Lionel Landwerlin
On 25/08/2018 17:50, Roman Gilg wrote: The Valgrind backtrace is very similar to the gdb backtraces in: https://bugs.freedesktop.org/show_bug.cgi?id=106620 The patch could be a fix for this bug as well, which would be awesome. Yeah, I believe that's the same bug. We should probably mark that

Re: [PATCH] present: fix freed pointer access

2018-08-25 Thread Roman Gilg
The Valgrind backtrace is very similar to the gdb backtraces in: https://bugs.freedesktop.org/show_bug.cgi?id=106620 The patch could be a fix for this bug as well, which would be awesome. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lis