Re: [PATCH xserver] miext/damage: take care of the coordinate mode in damagePolyPoint

2018-09-21 Thread Eric Anholt
Cedric Roux writes: > The mode (CoordModeOrigin or CoordModePrevious) was not taken into > account when computing the box. The result was a bad drawing of > points in some situations (on my hardware/software configuration, > calling XDrawString followed by XDrawPoints in the mode > CoordModePrevi

[PATCH xserver] xwayland: Use `double` for `xwl_tablet_tool`

2018-09-21 Thread Olivier Fourdan
So we do not lose subpixel precision in Xwayland. Suggested-by: Peter Hutterer Signed-off-by: Olivier Fourdan Tested-by: Jean-Loup Tastet Closes: https://gitlab.freedesktop.org/libinput/libinput/issues/138 --- MR: https://gitlab.freedesktop.org/xorg/xserver/merge_requests/21 hw/xwayland/xwayl

Re: [RFC PATCH xserver] xwayland: Avoid assert failure in flips_stop()

2018-09-21 Thread Roman Gilg
Great detailed analysis in the backtrace! :) What confused me at first was that the present_wnmd_flips_stop function is called at all in this state because it should only be called when at least one flip has been done and in this case xwl_window->present_window must have been set to the presenting