On Wed, Nov 20, 2019 at 1:53 AM Guillem Jover <guil...@hadrons.org> wrote: > > Hi! > > On Sun, 2019-11-03 at 18:08:00 +0100, Roman Gilg wrote: > > On Wed, Oct 23, 2019 at 5:33 PM Alan Coopersmith wrote: > > > On 10/23/19 12:48 AM, Michael Joost wrote: > > > > regarding your recent patch in xorg/libXfont2 (strlcat/strlcpy > > > > fallbacks) I ran into a problem on Linux while having libbsd installed. > > > > The configure correctly detects libbsd and those functions, however, > > > > the macro HAVE_LIBBSD is never defined in this process. The compile > > > > then fails with "implicit declaration" error, as the libbsd includes > > > > are not loaded from replace.h. When defining this macro manually, > > > > everything is fine. > > > > I think HAVE_LIBBSD should be defined by configure when it has found > > > > -lbsd. > > > > > > Hmm, I see what you mean, but I've not heard of problems from any other > > > Linux > > > users/distro builders, so perhaps something else is masking it for them? > > > > > > I'm cc'ing the list to see if those who work on Linux see the problem, or > > > want to provide a patch that they can test more easily than I can. > > > > I don't know what needs to be done here, but just wanted to say that I > > experienced strlcat, strlcpy problems when compiling libXfont master > > branch on Arch as well. > > > > I can not build it from commit 2178c7445a on. > > The attached patch should fix this. I'm not sure whether it would be > better to put the LIBBSD flags into the OS ones, but that might > require more code shuffling.
Indeed this patch fixes it. Can build with it applied on top of master. Tested-by: Roman Gilg <subd...@gmail.com> > Thanks, > Guillem _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
