Re: Patches to libXau

2024-02-01 Thread tlaronde
On Thu, Feb 01, 2024 at 09:31:13AM -0800, Alan Coopersmith wrote: > > Merge requests are preferred as they make it clear that a patch is ready > to go in. Patches attached to issues are too easy to overlook. FWIW, I have created a fork, committed 4 changes and request a merge and the CI has pass

Re: is _X_INLINE still needed

2024-02-01 Thread Alan Coopersmith
On 2/1/24 03:33, Enrico Weigelt, metux IT consult wrote: On 31.01.24 20:22, Alan Coopersmith wrote: Hi Alan, In public headers, I'd say it's still needed, as we've always supported Which ones are public ? For the Xorg server, the ones listed in https://gitlab.freedesktop.org/xorg/xserver/-

Re: Patches to libXau

2024-02-01 Thread Alan Coopersmith
On 2/1/24 09:14, tlaro...@kergis.com wrote: Hello, On Thu, Feb 01, 2024 at 09:07:38AM -0800, Alan Coopersmith wrote: On 2/1/24 08:10, tlaro...@kergis.com wrote: On Thu, Feb 01, 2024 at 04:54:57PM +0100, Olivier Fourdan wrote: On Thu, Feb 1, 2024 at 4:09?PM Enrico Weigelt, metux IT consult < i

Re: Patches to libXau

2024-02-01 Thread Alan Coopersmith
On 2/1/24 05:59, tlaro...@kergis.com wrote: 1) Test for __GNUC__ as well as __clang__ since gcc has no attributes for __attribute((malloc)) as well; Current versions of gcc do: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-malloc-function-attribute It is also docume

Re: Patches to libXau

2024-02-01 Thread tlaronde
Hello, On Thu, Feb 01, 2024 at 09:07:38AM -0800, Alan Coopersmith wrote: > On 2/1/24 08:10, tlaro...@kergis.com wrote: > > On Thu, Feb 01, 2024 at 04:54:57PM +0100, Olivier Fourdan wrote: > > > On Thu, Feb 1, 2024 at 4:09?PM Enrico Weigelt, metux IT consult < > > > i...@metux.net> wrote: > > > >

Re: Patches to libXau

2024-02-01 Thread Alan Coopersmith
On 2/1/24 08:10, tlaro...@kergis.com wrote: On Thu, Feb 01, 2024 at 04:54:57PM +0100, Olivier Fourdan wrote: On Thu, Feb 1, 2024 at 4:09?PM Enrico Weigelt, metux IT consult < i...@metux.net> wrote: have you checked whether it's already on gitlab.freedesktop.org ? In that case just make a PR th

Re: Patches to libXau

2024-02-01 Thread tlaronde
On Thu, Feb 01, 2024 at 04:54:57PM +0100, Olivier Fourdan wrote: > On Thu, Feb 1, 2024 at 4:09?PM Enrico Weigelt, metux IT consult < > i...@metux.net> wrote: > > > have you checked whether it's already on gitlab.freedesktop.org ? > > In that case just make a PR there ? > > > > Indeed, it's there:

Re: Patches to libXau

2024-02-01 Thread Olivier Fourdan
On Thu, Feb 1, 2024 at 4:09 PM Enrico Weigelt, metux IT consult < i...@metux.net> wrote: > have you checked whether it's already on gitlab.freedesktop.org ? > In that case just make a PR there ? > Indeed, it's there: https://gitlab.freedesktop.org/xorg/lib/libxau Cheers Olivier

Re: Patches to libXau

2024-02-01 Thread Enrico Weigelt, metux IT consult
On 01.02.24 14:59, tlaro...@kergis.com wrote: Hi, have you checked whether it's already on gitlab.freedesktop.org ? In that case just make a PR there ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Si

Re: is _X_INLINE still needed

2024-02-01 Thread Enrico Weigelt, metux IT consult
On 01.02.24 12:33, Enrico Weigelt, metux IT consult wrote: made a PR on this: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1264 --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte

xserver extensions/hooks: freeing client resources

2024-02-01 Thread Enrico Weigelt, metux IT consult
Hello folks, I'm currently writing an extension that's storing per-client data. Where's is the right place to free up all resources ? I guess the client state xace hook - but what's the difference between retained and gone ? thx --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht ab

Patches to libXau

2024-02-01 Thread tlaronde
Hello, libXau has status "Unmaintained" I'd like to apply two patches: 1) Test for __GNUC__ as well as __clang__ since gcc has no attributes for __attribute((malloc)) as well; 2) Add a feature test to explicit_memset(3) supplementary to explicit_bzero(3), since bzero(3) is deprecated (even remo

Re: is _X_INLINE still needed

2024-02-01 Thread Enrico Weigelt, metux IT consult
On 31.01.24 20:22, Alan Coopersmith wrote: Hi Alan, In public headers, I'd say it's still needed, as we've always supported Which ones are public ? Here's a quick grep of Xserver tree: nekrad@orion:~/src/xorg/xserver$ git grep _X_INLINE Xext/security.c:static _X_INLINE const char * dix/regio