[PATCH randrproto] Add "Border" and "BorderDimensions" properties

2011-07-29 Thread Aaron Plattner
Signed-off-by: Aaron Plattner --- Does this interface make sense? I tried to describe what it should do as accurately as possible. I'm working on a corresponding change to the server to make it read this property and apply it during modesets. This is option #3 as described in http://lists.

Re: RFC - Overscan compensation configuration in RandR

2011-07-20 Thread Aaron Plattner
On Sat, Jul 16, 2011 at 10:29:58AM -0700, Keith Packard wrote: > On Fri, 15 Jul 2011 16:51:59 -0700, Aaron Plattner > wrote: > > > Since there's no good existing mechanism for clients to do this, > > I came up with a few possibilities: > > We added margin prope

RFC - Overscan compensation configuration in RandR

2011-07-15 Thread Aaron Plattner
I'm trying to add support for overscan compensation to the Tegra X driver. This driver uses RandR 1.2, so I need to add an official mechanism for X clients to describe the desired configuration through the protocol. RandR currently assumes that a mode with a given HDisplay/VDisplay size will disp

Re: [PATCH] xts5: Try to improve readability.

2011-06-10 Thread Aaron Plattner
On Fri, Jun 03, 2011 at 06:37:54AM -0700, Cyril Brulebois wrote: > Suggested-by: Walter Harms > Signed-off-by: Cyril Brulebois > --- > xts5/src/lib/nextvclass.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/xts5/src/lib/nextvclass.c b/xts5/src/lib/nextvclass.c

Re: [PATCH xts] xts5: Switch from K&R to ANSI prototypes.

2011-06-10 Thread Aaron Plattner
On Fri, Jun 03, 2011 at 06:31:39AM -0700, Cyril Brulebois wrote: > Conversion performed through: > cproto -a -I include -I xts5/include/ xts5/src/lib/checkevent.c > > (after which trailing spaces were removed.) > > Suggested-by: Walter Harms > Signed-off-by: Cyril Brulebois > --- > xts5/src/

Re: [PATCH 2/4] Remove the cacheing of the last scratch PixmapRec

2011-06-08 Thread Aaron Plattner
On Sun, Jun 05, 2011 at 10:36:07PM -0700, Chris Wilson wrote: > In order for the driver to be notified of when the resource backing the > scratch pixmap becomes no longer accessible, it needs to be called on > every FreeScratchPixmapHeader(). As we instead maybe cached the > PixmapRec (to avoid the

Re: xts warning fixes round 1 (was: [ANNOUNCE] xts 0.99.0)

2011-05-26 Thread Aaron Plattner
On Wed, May 25, 2011 at 03:57:04AM -0700, Cyril Brulebois wrote: > Hi, > > Aaron Plattner (24/05/2011): > > Patches to fix warnings in the build or the tests themselves would > > be very much appreciated. […] > > w00t, an XTS release! > > Here's a first r

[PATCH v2] randr: check rotated virtual size limits correctly

2011-05-24 Thread Aaron Plattner
Serial number of failed request: 14 Current serial number in output stream: 14 Fix this by moving the check above the code that swaps the dimensions based on the rotation. Signed-off-by: Aaron Plattner Reviewed-by: Jeremy Huddleston Tested-by: Robert Hooker Tested-by: Kent Baxley

[PATCH XTS] tet: tet_getvar needs to take a const char* argument

2011-05-24 Thread Aaron Plattner
config.c: In function ‘initconfig’: config.c:394: error: passing argument 1 of ‘_initconfig’ from incompatible pointer type config.c:328: note: expected ‘char * (*)(const char *)’ but argument is of type ‘char * (*)(char *)’ Signed-off-by: Aaron Plattner --- I'm thinking of making a re

[PATCH XTS] xts5: BadDevice takes an int*, not an XID*

2011-05-24 Thread Aaron Plattner
startup.c: In function ‘init_xinput’: startup.c:505: error: passing argument 2 of ‘_xibaddevice’ from incompatible pointer type /usr/include/X11/extensions/XInput.h:162: note: expected ‘int *’ but argument is of type ‘XID *’ Signed-off-by: Aaron Plattner --- xts5/src/lib/startup.c |2

Re: Howto determine screen geometry?

2011-05-23 Thread Aaron Plattner
On Sun, May 22, 2011 at 09:20:31AM -0700, Stef Bon wrote: > On 05/22/2011 04:23 PM, Mikhail Gusarov wrote: > > Twas brillig at 16:19:49 22.05.2011 UTC+02 when s...@bononline.nl did gyre > > and gimble: > > > > SB> Isn't it possible to just get that information from the Xserver?? > > > > xrand

[PATCH] randr: check rotated virtual size limits correctly

2011-05-11 Thread Aaron Plattner
Serial number of failed request: 14 Current serial number in output stream: 14 Fix this by moving the check above the code that swaps the dimensions based on the rotation. Signed-off-by: Aaron Plattner --- This patch is against server-1.10-branch. randr/rrscreen.c | 12 ++-- 1

Re: [PATCH xf86-video-nv] remove duplicated includes

2011-04-25 Thread Aaron Plattner
On Mon, Apr 25, 2011 at 04:26:33AM -0700, Nicolas Kaiser wrote: > Remove duplicated includes of guarded headers. > > Signed-off-by: Nicolas Kaiser Merged: 2b17d1a..4b03459 master -> master ___ xorg-devel@lists.x.org: X.Org development Archives: htt

[PATCH XTS 2/2] xts5: Fix 'missing sentinel in function call' warnings by using literal NULL

2011-04-12 Thread Aaron Plattner
= NULL; function(..., endlist); While this is perfectly valid, GCC warns about it anyway. Switch these to using literal NULLs too. Signed-off-by: Aaron Plattner --- xts5/Xlib14/XGetICValues.m|2 +- xts5/Xlib14/XGetIMValues.m|2 +- xts5/Xlib14/XSetICFocus.m |2

[PATCH XTS 1/2] mc: Add the ability to pass literal NULL arguments to XCALL functions

2011-04-12 Thread Aaron Plattner
Check for "NULL" in the argument list at the top of the .m file. If found, skip creating a declaration or initializer for it but do include it in the argument list when emitting the code for XCALL. Signed-off-by: Aaron Plattner --- xts5/src/bin/mc/code.c |8 xts5/src/b

[PATCH XTS 0/2] Fix 'missing sentinel in function call' warnings

2011-04-12 Thread Aaron Plattner
fying mc. Aaron Plattner (2): mc: Add the ability to pass literal NULL arguments to XCALL functions xts5: Fix 'missing sentinel in function call' warnings by using literal NULL xts5/Xlib14/XGetICValues.m|2 +- xts5/Xlib14/XGetIMValues.m|2 +- xts5/Xlib1

Re: [PATCH] Do not treat EINTR as a fatal error.

2011-04-12 Thread Aaron Plattner
On Tue, Apr 12, 2011 at 12:32:30AM -0700, Žilvinas Valinskas wrote: > Reinstates lost changes by d23c46dd3e2cbf84012055bad43b1bb15809a244 commit. > Call ioctl(VT_WAITACTIVE) fails with EINTR if call is interrupted by a signal > and it must be retried instead of failing hard. > > https://bugs.launc

Re: Splitting protocol screens from the driver interface

2011-04-11 Thread Aaron Plattner
On Wed, Apr 06, 2011 at 08:51:52PM -0700, Dave Airlie wrote: > On Thu, Apr 7, 2011 at 10:59 AM, Aaron Plattner wrote: > > Hi Dave, > > > > I like the idea of separating the driver from the protocol screens, > > and am interested in helping out.  I think it might be ea

[PATCH v2] linux: Retry VT ioctls while errno == EINTR

2011-04-07 Thread Aaron Plattner
he VT hadn't finished cleaning up. As of commit 7ee965a300c9eddcc1acacf9414cfe3e589222a8, it causes a FatalError instead. Retrying the ioctl as long as it fails with errno == EINTR fixes the problem and allows server regenerations to trigger VT switches that actually succeed. Signed-off-by: Aaro

[PATCH] linux: Retry VT ioctls while errno == EINTR

2011-04-07 Thread Aaron Plattner
he VT hadn't finished cleaning up. As of commit 7ee965a300c9eddcc1acacf9414cfe3e589222a8, it causes a FatalError instead. Retrying the ioctl as long as it fails with errno == EINTR fixes the problem and allows server regenerations to trigger VT switches that actually succeed. Signed-off-by: Aaro

Splitting protocol screens from the driver interface

2011-04-06 Thread Aaron Plattner
Hi Dave, I like the idea of separating the driver from the protocol screens, and am interested in helping out. I think it might be easiest in the short term to let the overlay functionality I talked about break and then I can add it back later in whatever form makes the most sense with the new ar

[PATCH] Decouple the test suite from "make check"

2011-04-05 Thread Aaron Plattner
st suite against his host X server, which is bad because some of the tests can have adverse effects. Signed-off-by: Aaron Plattner --- Makefile.am |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index b8de497..87040d2 100644 ---

Re: [PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

2011-04-04 Thread Aaron Plattner
On Mon, Apr 04, 2011 at 02:26:42PM -0700, Dave Airlie wrote: > On Tue, Apr 5, 2011 at 6:42 AM, Aaron Plattner wrote: > > On Mon, Apr 04, 2011 at 01:24:10PM -0700, Dave Airlie wrote: > >> > Are you planning on leaving the ChangeWindowAttrbutes screen hook there, > >>

Re: [PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

2011-04-04 Thread Aaron Plattner
On Mon, Apr 04, 2011 at 01:24:10PM -0700, Dave Airlie wrote: > > Are you planning on leaving the ChangeWindowAttrbutes screen hook there, or > > is it slated for deletion?  I ask because we currently wrap CWA so we can > > watch for colormap changes on PseduoColor windows. > > > > Can you give me

Re: [PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

2011-04-04 Thread Aaron Plattner
On Wed, Mar 30, 2011 at 11:07:46PM -0700, Dave Airlie wrote: > From: Dave Airlie > > This moves ChangeWindowAttributes to mi, and calls a new hook > that fb/exa can use to fixup the pixmap properly. > > I've looked at XAA and it seems this should work there as well, > and I'm sure UXA is like EX

Re: [PATCH] [RFC] dix: don't use CopyWindow in driver level interface.

2011-03-31 Thread Aaron Plattner
On Thu, Mar 31, 2011 at 05:01:20PM -0700, Keith Packard wrote: > On Thu, 31 Mar 2011 15:49:36 -0700, Aaron Plattner > wrote: > > Would this be multiple backing pixmaps like how James envisioned, or > > something else? The problem here is that while pWin may be in the overla

Re: [PATCH] [RFC] dix: don't use CopyWindow in driver level interface.

2011-03-31 Thread Aaron Plattner
On Thu, Mar 31, 2011 at 02:14:03PM -0700, Dave Airlie wrote: > On Fri, Apr 1, 2011 at 5:05 AM, Aaron Plattner wrote: > > On Wed, Mar 30, 2011 at 10:21:42PM -0700, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> This splits CopyWindow before the exa/fb l

Re: [PATCH] [RFC] dix: don't use CopyWindow in driver level interface.

2011-03-31 Thread Aaron Plattner
On Wed, Mar 30, 2011 at 10:21:42PM -0700, Dave Airlie wrote: > From: Dave Airlie > > This splits CopyWindow before the exa/fb layers, and uses a > new interface called PixmapCopyRegion to do the actual copy. > > The main point of this is a step towards removing WindowPtr's > from the interface t

Re: [PATCH 1/2] render: Move miCompositeRects() into fb as fbCompositeRects().

2011-03-31 Thread Aaron Plattner
On Wed, Mar 30, 2011 at 09:37:21AM -0700, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > It is not used anywhere else. > > Signed-off-by: Soren Sandmann > --- [...] > +pixman_image_fill_rectangles ( > + op, image, (pixman_color_t *)color, nRect, > + (const pixman_rectan

Re: [PULL XTS] Misc fixes

2011-03-29 Thread Aaron Plattner
0 (2010-10-18 16:16:03 -0700) > > are available in the git repository at: > git://people.freedesktop.org/~whot/xts.git master > > Peter Hutterer (21): > Remove superfluous (void) casts. > Remove EXPECT_NOTHING pointer to int cast. > Purge wbzero

Re: [PATCH] mi: Remove unused overlay support

2011-03-29 Thread Aaron Plattner
On Tue, Mar 29, 2011 at 09:47:19AM -0700, Mikhail Gusarov wrote: > Twas brillig at 09:26:19 29.03.2011 UTC-07 when aplatt...@nvidia.com did gyre > and gimble: > > AP> NAK. This code is not NVIDIA-specific just because only the NVIDIA > AP> driver currently uses it. > > I did not claim it. I jus

Re: [PATCH] mi: Remove unused overlay support

2011-03-29 Thread Aaron Plattner
On Mon, Mar 28, 2011 at 11:36:04PM -0700, Mikhail Gusarov wrote: > The only reference to it in server and free drivers is in XAA overlay code > which > would segfault as no miInitOverlay is called ever. > > Quoting Jamey Sharp: > > """ > It wasn't obvious to me that the patch was correct, becaus

Re: Resend: [PATCH xev] Show RandR events.

2011-03-03 Thread Aaron Plattner
On Thu, Mar 03, 2011 at 02:08:49PM -0800, Michael Thayer wrote: > On Thu, 2011-03-03 at 13:54 -0800, Aaron Plattner wrote: > > The updated change looks good to me. > > > > Reviewed-by: Aaron Plattner > > Tested-by: Aaron Plattner > > > > Do you have a fr

Re: Resend: [PATCH xev] Show RandR events.

2011-03-03 Thread Aaron Plattner
On Thu, Mar 03, 2011 at 01:35:15PM -0800, Michael Thayer wrote: > On Thu, 2011-03-03 at 11:37 -0800, Aaron Plattner wrote: > > On Wed, Feb 16, 2011 at 04:00:25AM -0800, Michael Thayer wrote: > > > +if (rr_major >= 1 && rr_minor >= 2) > > >

Re: Resend: [PATCH xev] Show RandR events.

2011-03-03 Thread Aaron Plattner
On Wed, Feb 16, 2011 at 04:00:25AM -0800, Michael Thayer wrote: > Signed-off-by: Michael Thayer > --- > [Resending this as there were no responses the first time, but I don't > know whether it was due to lack of interest or whether it just went down > in the flood.] > > I think the subject line s

Re: [PATCH xf86-video-nv] Fix compiler warning.

2011-03-01 Thread Aaron Plattner
On Tue, Mar 01, 2011 at 05:09:10PM -0800, Cyril Brulebois wrote: > Get rid of this with CFLAGS="-Wall -Werror": > | CC g80_display.lo > | cc1: warnings being treated as errors > | g80_display.c: In function ‘G80CrtcSetPClk’: > | g80_display.c:216: error: unused variable ‘i’ > > Signed-off-by

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-23 Thread Aaron Plattner
' doesn't contain SetScreenCrtcs. From the wording of the protocol doc, I would expect set = RR_SetScreenPixmapSize | RR_SetScreenSizeInMillimeters | RR_SetScreenSize to change those three things. > > -output_ids = (RROutput *) (x_configs

Re: [PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-07 Thread Aaron Plattner
On Fri, Jan 07, 2011 at 09:49:44AM -0800, Daniel Stone wrote: > On Fri, Jan 07, 2011 at 09:41:19AM -0800, Alan Coopersmith wrote: > > On 01/ 7/11 03:10 AM, Daniel Stone wrote: > > > On Fri, Jan 07, 2011 at 12:51:17AM +0100, Mark Kettenis wrote: > > >>> diff --git a/include/colormapst.h b/include/co

Re: [PATCH:libX11 1/2] Bug 32098: Making XInternAtoms take const char ** breaks callers

2010-12-15 Thread Aaron Plattner
On Tue, Dec 14, 2010 at 03:48:50PM -0800, Simon Thum wrote: > On 12/14/2010 10:01 PM, Alan Coopersmith wrote: > > Unfortunately, this was a surprise to me, since I was expecting it to > > behave as const char * does when passed char * pointers, as apparently > > did everyone on xorg-devel when the

Re: RandR 1.4 additional X server patches

2010-12-06 Thread Aaron Plattner
On Mon, Dec 06, 2010 at 02:44:08PM -0800, Keith Packard wrote: > On Mon, 6 Dec 2010 14:36:43 -0800, Aaron Plattner > wrote: > > > The change to decouple the screen and screen pixmap sizes scares me. We're > > going to have to go through our driver with a fine-toothe

Re: RandR 1.4 additional X server patches

2010-12-06 Thread Aaron Plattner
; It's probably the most fiddly of the whole patch sequence for PCP, but > at least it's not huge. These changes, plus the ones you sent out earlier, plus I guess the two at git://people.freedesktop.org/~keithp/xserver master that I can't find emails for Reviewed-by: Aaron Plattne

Re: [PATCH] RandR version 1.4 additions

2010-12-06 Thread Aaron Plattner
On Mon, Dec 06, 2010 at 10:01:03AM -0800, Keith Packard wrote: > On Mon, 6 Dec 2010 09:20:29 -0800, Aaron Plattner > wrote: > > Can this include indexed formats? Should there be some provision for > > specifying a colormap along with the pixmap to assign the pixel-to-color >

Re: Sprite transforms in RandR

2010-12-06 Thread Aaron Plattner
On Mon, Dec 06, 2010 at 08:44:41AM -0800, Keith Packard wrote: > On Mon, 6 Dec 2010 15:20:01 +, Daniel Stone wrote: > > > Nope, we don't have any per-CRTC differences there, it's just that > > rotation is essentially another property of the mode that we need to know > > about in order to set

Re: Sprite transforms in RandR

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 06:17:12PM -0800, Keith Packard wrote: > On Sun, 5 Dec 2010 16:42:43 -0800, Aaron Plattner > wrote: > > > Unless it's very generic or just a string to present to the user, I don't > > think trying to encode this in the protocol is going t

Re: Sprite transforms in RandR

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 08:47:15PM -0800, Keith Packard wrote: > On Sun, 5 Dec 2010 16:38:52 -0800, Aaron Plattner > wrote: > > > The crtc shadow functions seem obsolete given the new scanout pixmap > > creation function, but they can be removed in a later ABI. > &g

Re: [PATCH] RandR version 1.4 additions

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 08:43:07PM -0800, Keith Packard wrote: > On Sun, 5 Dec 2010 16:38:52 -0800, Aaron Plattner > wrote: > > This adds the specification and protocol header definitions for the > RandR 1.4 protocol changes, including > > * Per crtc pixmaps and pixma

Re: Sprite transforms in RandR

2010-12-05 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 06:15:04PM -0800, Keith Packard wrote: > On Sun, 5 Dec 2010 16:38:52 -0800, Aaron Plattner > wrote: > > Thanks for reviewing over the weekend. > > > There are a few whitespace bugs, such as this: > > ┌─── > > RRQueryScanoutPixmaps

Re: Sprite transforms in RandR

2010-12-05 Thread Aaron Plattner
On Sat, Dec 04, 2010 at 08:34:40PM -0800, Keith Packard wrote: > Would it be useful to be able to return more information from the server > to the application? How would such information get encoded? Unless it's very generic or just a string to present to the user, I don't think trying to encode t

Re: Sprite transforms in RandR

2010-12-05 Thread Aaron Plattner
e input sprite position for that crtc? It would be nice to have that be spelled out a little more in randrproto.txt. > Library changes: > > git://people.freedesktop.org/~keithp/libXrandr master There are some unrelated whitespace changes, and a tab-space-tab pattern in the argument lis

Re: [PATCH libXext (rev3) 0/5] XSync Fence Objects, lib portion

2010-12-03 Thread Aaron Plattner
On Thu, Dec 02, 2010 at 09:26:26AM -0800, James Jones wrote: > Changes since last version: > -Rebased at d35e95fdf433a249d0293744d3e1ef6196422700 > -Added xextproto version check. > > Adds client library support for binary sync objects added > in the X Synchronization protocol version 3.1. libXex

Re: [PATCH xextproto (rev4) 0/5] XSync Fence Objects

2010-12-03 Thread Aaron Plattner
On Thu, Dec 02, 2010 at 09:15:30AM -0800, James Jones wrote: > Changes since the last version: > -Rebased at fd8a26edefc53b370c554a60c75ff32fc60b99c8 > -Added version bump so other packages can check for fence support > > Adds support for binary sync objects. Objects are set to > "triggered" usin

Re: [PATCH damageproto (rev3) 1/3] Document changes in damage proto version 1.2

2010-12-02 Thread Aaron Plattner
On Thu, Dec 02, 2010 at 05:02:49PM -0800, Keith Packard wrote: > On Thu, 2 Dec 2010 16:58:58 -0800, James Jones wrote: > > > OK, I've pushed the requested updates to proto and lib with your > > reviewed-by > > line to my github repositories. Once I get a review for the Xext changes, > > I'll

Re: Any last-minute nominations for server-1.9-branch

2010-12-02 Thread Aaron Plattner
On Thu, Dec 02, 2010 at 12:29:54PM -0800, Jeremy Huddleston wrote: > I pulled in a few more changes to server-1.9-branch based on what Julien > recently merged into the 1.7 branch. Tomorrow will be the last rc before > 1.9.3, so please nominate anything outstanding. Only regression fixes > will b

Re: rendercheck segfaults [FIXED]

2010-12-01 Thread Aaron Plattner
On Wed, Dec 01, 2010 at 02:27:16PM -0800, Chris Wilson wrote: > On Wed, 1 Dec 2010 13:57:15 -0800, Aaron Plattner > wrote: > > On Wed, Dec 01, 2010 at 01:47:47PM -0800, Chris Wilson wrote: > > > On Wed, 1 Dec 2010 13:06:47 -0800, Aaron Plattner > > > wrote

Re: rendercheck segfaults [Re: rendercheck: 10 commits]

2010-12-01 Thread Aaron Plattner
On Wed, Dec 01, 2010 at 01:47:47PM -0800, Chris Wilson wrote: > On Wed, 1 Dec 2010 13:06:47 -0800, Aaron Plattner > wrote: > > This series causes a segmentation fault in blend_test because the loop > > at the top of the "while (k < num_dst)" loop doesn't eve

Re: [PATCH] xfree86: Fix rotation of 2-color non-interleaved cursor images

2010-11-29 Thread Aaron Plattner
Does anyone else want to review this, or are Robert's (@nvidia.com) Reviewed-by and Cyril's Tested-by sufficient? On Tue, Nov 16, 2010 at 12:17:33PM -0800, Aaron Plattner wrote: > When RandR 1.2's transformation code is enabled, it rotates the cursor > image so that it

[PATCH] xfree86: Fix rotation of 2-color non-interleaved cursor images

2010-11-16 Thread Aaron Plattner
ore computing the desired byte pointer. Signed-off-by: Aaron Plattner Reviewed-by: Robert Morell --- Could somebody with hardware that sets SOURCE_MASK_INTERLEAVE (e.g. Intel) please give this patch a try and verify that it doesn't break rotated cursors? hw

Re: Delete a bunch of unused stuff in fb

2010-11-01 Thread Aaron Plattner
ixman. Most of it has survived only > SS> because breaking the server ABI was not allowed at the time. > > For the series: Reviewed-by: Mikhail Gusarov For the series: Reviewed-by: Aaron Plattner EXCEPT that #4 should be applied before #3 to delete fbCompositeGeneral before deleting

[PATCH] os: Fix BigReq ignoring when another request is pending

2010-10-25 Thread Aaron Plattner
ST NOTIU WARN FIP FAIL UNRES UNIN ABORT -Xproto122 389 367 219 0 0 0 1 0 0 0 +Xproto122 389 368 219 0 0 0 0 0 0 0 Signed-off-by: Aaron Plattner --- Sorry I screwed this up the first time. Do you think I sh

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 03:49:47PM -0700, Keith Packard wrote: > On Wed, 20 Oct 2010 15:03:59 -0700, Aaron Plattner > wrote: > > > Fine, but will you be willing to move this call to the drivers that need it > > when we have a real sync extension? > > I don't se

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 03:03:59PM -0700, Aaron Plattner wrote: > On Wed, Oct 20, 2010 at 02:57:27PM -0700, Keith Packard wrote: > > On Wed, 20 Oct 2010 14:29:33 -0700, Aaron Plattner > > wrote: > > > The driver can do that by enabling ReportAfter from a damage create >

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 02:57:27PM -0700, Keith Packard wrote: > On Wed, 20 Oct 2010 14:29:33 -0700, Aaron Plattner > wrote: > > > Then you're implementing what sounds like a nice vendor-specific > > feature. > > There isn't any other mechanism pr

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 01:54:35PM -0700, Keith Packard wrote: > On Wed, 20 Oct 2010 11:35:46 -0700, Aaron Plattner > wrote: > > > By sending X protocol to explicitly fence the GL rendering with the X > > rendering, which is the whole purpose of James's XDamageSubt

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Aaron Plattner
Thanks for this discussion. More precise semantics are always better. Comments below: On Wed, Oct 20, 2010 at 11:05:29AM -0700, Keith Packard wrote: > On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner > wrote: > > > This change does not solve the problem it claims to s

[PATCH] xts5: Bail out with UNTESTED for BAD_LENGTH requests that would have length 0

2010-10-17 Thread Aaron Plattner
request handling in the X server. This makes the server interpret the next request as the size part of the Bell request, and hilarity ensues. Instead, detect this case and bail out with an UNTESTED result. Signed-off-by: Aaron Plattner --- pBell-2 and a lot of tests like it test two things: that

[PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-17 Thread Aaron Plattner
This change does not solve the problem it claims to solve because it makes two assumptions about the driver that are not always true: 1. that it sends rendering requests to the GPU immediately, which can kill performance on some GPUs, and 2. that the GPU processes all requests from multiple cli

Re: [PATCH 2/3] xfree86: Remove unused xf86AssertBlockedSIGIO

2010-10-14 Thread Aaron Plattner
On Thu, Oct 14, 2010 at 12:19:49PM -0700, Adam Jackson wrote: > On Thu, 2010-10-14 at 12:12 -0700, Aaron Plattner wrote: > > On Thu, Oct 14, 2010 at 09:49:05AM -0700, Adam Jackson wrote: > > > Signed-off-by: Adam Jackson > > > --- > > > hw/xfree86/o

Re: [PATCH 2/3] xfree86: Remove unused xf86AssertBlockedSIGIO

2010-10-14 Thread Aaron Plattner
On Thu, Oct 14, 2010 at 09:49:05AM -0700, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > hw/xfree86/os-support/shared/sigio.c | 11 --- > hw/xfree86/os-support/shared/sigiostubs.c |5 - > hw/xfree86/os-support/xf86_OSproc.h |1 - > 3 files changed, 0 in

Re: ABI breakage

2010-10-14 Thread Aaron Plattner
On Thu, Oct 14, 2010 at 12:00:40PM -0700, Thomas Hellstrom wrote: > > On 10/14/2010 06:11 PM, Thomas Hellstrom wrote: > > Hi! > > > > Isn't the commit > > > > 5c6a2f93ebc16a78093782b442306de23ae94e78 > > xfree86: Kill pixmapPrivate with a vengeance (v2) > > > > a major ABI breakage (It alters the

Re: [PATCH 1/3] composite: Don't backfill non-bg-None windows

2010-10-04 Thread Aaron Plattner
On Mon, Oct 04, 2010 at 12:33:40PM -0700, Adam Jackson wrote: > If there's a defined background then backfilling is a waste of effort, > since exposure processing will paint that in for us. But note that we > have to backfill if any children are bg=None to preserve semantics with > non-composited

[PATCH] Bump video driver ABI version to 9.0

2010-09-28 Thread Aaron Plattner
Signed-off-by: Aaron Plattner --- You guys are really churning through the ABIs. error: 'struct _ScrnInfoRec' has no member named 'pixmapPrivate' hw/xfree86/common/xf86Module.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/common/xf86M

Re: [PATCH] Xserver need not be compatible with old versions of xserver.

2010-09-17 Thread Aaron Plattner
Reviewed-by: Aaron Plattner I think Gaetan purged the last of that code from the drivers recently. At least he did for nv: http://cgit.freedesktop.org/xorg/driver/xf86-video-nv/commit/?id=6d2431a37ffd7a976e9046424a6c1f3c47ded2df I think you can also delete the RANDR_12_INTERFACE ifdefs, since

[PATCH xts 4/3] [dist] Don't clean BUILT_SOURCES

2010-09-16 Thread Aaron Plattner
We distribute the generated .c files, so we shouldn't clean them when the user runs "make clean". They should be cleaned as part of the "distclean" target. Signed-off-by: Aaron Plattner --- Oops, needed one more, to fix building from the release tarball after doin

[PATCH xts 3/3] [dist] Distribute files missing from the tarball

2010-09-16 Thread Aaron Plattner
Signed-off-by: Aaron Plattner --- Makefile.am |1 + src/tet3/Makefile.am |2 +- src/tet3/apilib/Makefile.am |3 +++ src/tet3/dtet2lib/Makefile.am |5 - src/tet3/tcc/Makefile.am |9 - src/tet3/tcm/Makefile.am |3 ++- xts5

[PATCH xts 2/3] [dist] Don't configure directories that aren't distributed

2010-09-16 Thread Aaron Plattner
libXtmu/Makefile.in' Fix this by just deleting those lines. The corresponding Makefiles aren't used. Signed-off-by: Aaron Plattner --- configure.ac |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 5e62578..a324764 100644 --

[PATCH xts 1/3] [dist] Build mc for dist

2010-09-16 Thread Aaron Plattner
mc is used to compile the .m files into .c files at dist time. If dist is run from a clean build directory, mc is not built and the dist fails in xts5/Xproto when it tries to run it. Add a dependency on mc for dist-hook to make sure that mc is built before the tests. Signed-off-by: Aaron

[PATCH xts 0/3] Fix dist rules

2010-09-16 Thread Aaron Plattner
With these changes, I can produce a distribution tarball and then build and install the test suite from there. It still doesn't pass distcheck, because after building the tarball it runs "make check" and that runs the whole test suite, but it's a start. Aaron Plattner (3):

Re: [PATCH 2/6] mi: change GE extension name to something painless for registry parsing

2010-09-07 Thread Aaron Plattner
On Tue, Sep 07, 2010 at 05:50:23AM -0700, Tiago Vignatti wrote: > in the next commit this changes will makes more sense. > > Signed-off-by: Tiago Vignatti > --- > mi/miinitext.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mi/miinitext.c b/mi/miinitext.c > inde

[PATCH v2] os: Return BadLength instead of disconnecting BigReq clients (#4565)

2010-08-27 Thread Aaron Plattner
onzero, ignore the data read instead of trying to process it as a request. Signed-off-by: Aaron Plattner --- Good point, fixed. os/io.c| 27 --- os/osdep.h |1 + 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/os/io.c b/os/io.c index e2df2e3..

[PATCH 1/1] os: Return BadLength instead of disconnecting BigReq clients (#4565)

2010-08-27 Thread Aaron Plattner
onzero, ignore the data read instead of trying to process it as a request. Signed-off-by: Aaron Plattner --- os/io.c| 27 --- os/osdep.h |1 + 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/os/io.c b/os/io.c index e2df2e3..86cde88 100644 --- a/os

[PATCH 0/1] os: Return BadLength instead of disconnecting BigReq clients (#4565)

2010-08-27 Thread Aaron Plattner
This change fixes a lot of XTS Xproto tests that use the TOO_LONG test mode. This mode sends a request with a length that's too large and then expects a BadLength error. Instead, when the server supports big requests, it just gets disconnected and receives a SIGPIPE instead. The test suite flags

Re: Old O'Reilly X books

2010-08-26 Thread Aaron Plattner
On Thu, Aug 26, 2010 at 11:57:27AM -0700, Pat Kane wrote: > On Thu, Aug 26, 2010 at 10:11 AM, Aaron Plattner wrote: > > On Thu, Aug 26, 2010 at 05:43:53AM -0700, Pat Kane wrote: > >> BTW, while trying to grep my dead trees I noticed that the current X server > >> co

Re: Old O'Reilly X books

2010-08-26 Thread Aaron Plattner
On Thu, Aug 26, 2010 at 05:43:53AM -0700, Pat Kane wrote: > BTW, while trying to grep my dead trees I noticed that the current X server > contains some HAKMEM code, in ./mi/micmap.c I see this hack: > ... > count = (visuals >> 1) & 0333; > count = visuals - count - ((count >> 1)

[PATCH] [loader] Tag sdksyms.c entries with source file and line number

2010-08-23 Thread Aaron Plattner
--- This isn't 100% accurate... sometimes it's off by a line or two, but it's still helpful. I attached a generated sdksyms.c so you can see what it looks like. hw/xfree86/loader/sdksyms.sh |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/loader/sdksyms

Re: [PATCH] XOpenDisplay: save the correct display_name value

2010-08-18 Thread Aaron Plattner
On Tue, Aug 17, 2010 at 09:33:59AM -0700, Jeremy Huddleston wrote: > On Aug 16, 2010, at 09:34, Aaron Plattner wrote: > > Jeremy, you seem to the be the most familiar with launchd. Does this > > change seem okay to you? Since this change stops appending the screen > > nu

Re: [PATCH xextproto 1/4] Document changes in XSync version 3.1

2010-08-17 Thread Aaron Plattner
On Tue, Aug 17, 2010 at 02:49:41PM -0700, Adam Jackson wrote: > Apologies for the slow review here... > > On Thu, 2010-08-12 at 16:40 -0700, James Jones wrote: > > > > > -The extension adds Counter and > > -Alarm to the set of resources managed by the > > +The extension adds Counter, > > Alarm,

Re: [PATCH] XOpenDisplay: save the correct display_name value

2010-08-17 Thread Aaron Plattner
On Tue, Aug 17, 2010 at 11:27:25AM -0700, ja...@minilop.net wrote: > On Mon, Aug 16, 2010 at 9:34 AM, Aaron Plattner wrote: > > The X Test Suite's XDisplayString test checks the invariant > > XDisplayString(XOpenDisplay(str)) == str.  The XCB-based XOpenDisplay > > viol

[PATCH] XOpenDisplay: save the correct display_name value

2010-08-17 Thread Aaron Plattner
AIL 410|26 1 1 19:26:41|IC End Fix this by deleting all of the code to construct the canonical path and just stash a copy of the original display_name in dpy->display_name. Delete the now unused HAVE_LAUNCHD macro and code to set it. Signed-off-by: Aaron Plattner --- I don't really kno

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-13 Thread Aaron Plattner
On Fri, Aug 13, 2010 at 09:02:34AM -0700, Adam Jackson wrote: > On Fri, 2010-08-13 at 08:53 -0700, Aaron Plattner wrote: > > On Fri, Aug 13, 2010 at 08:09:24AM -0700, Adam Jackson wrote: > > > ShmPutImage is a bit better in that it elides the socket copies, but > > > th

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-13 Thread Aaron Plattner
On Fri, Aug 13, 2010 at 08:09:24AM -0700, Adam Jackson wrote: > On Fri, 2010-08-13 at 08:51 -0300, Fernando Carrijo wrote: > > And to be honest, it seems to me that the precautions taken by the > > smart scheduler to penalize hungry clients isn't enough in certain > > circumstances. Firefox abusive

Re: [PATCH v2 video-nv] The /compat code is no longer required.

2010-07-19 Thread Aaron Plattner
On Sat, Jul 17, 2010 at 10:52:50AM -0700, Gaetan Nadon wrote: > This was used at one point in time to backport the modes code from server > 1.3 to server 1.2. When the tarball was created, whatever modes code > was on the developer disk was included. > > The server 1.2 as shipped in the tarball on

Re: [PATCH] Remove unused facility to build modes code from uninstalled server.

2010-07-13 Thread Aaron Plattner
e able to build the driver on older servers, we can always fork off a new branch from before this change. Reviewed-by: Aaron Plattner > There is no need to allow this driver to build from an arbitrary > modes and parser tree outside the installed server. > > This will sove the issue wher

Re: [PATCH XTS 1/7] Note in README that some tests fail when run as a set.

2010-07-10 Thread Aaron Plattner
On Tue, Jun 29, 2010 at 04:10:19PM -0700, Peter Hutterer wrote: > This should be fixed in the tests themselves, but for now it's easier to > note this in the readme. > > Signed-off-by: Peter Hutterer > --- > README |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-07-07 Thread Aaron Plattner
On Wed, Jul 07, 2010 at 04:48:45PM -0700, Keith Packard wrote: > On Wed, 7 Jul 2010 16:11:34 -0700, Aaron Plattner > wrote: > > > Sadly, moving it to the end doesn't look like it'll be enough: > > > > dix.h:extern _X_EXPORT ClientPtr clients[MAXC

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-07-07 Thread Aaron Plattner
On Wed, Jul 07, 2010 at 04:03:18PM -0700, Jesse Barnes wrote: > On Wed, 7 Jul 2010 15:54:50 -0700 > Aaron Plattner wrote: > > > On Fri, Jul 02, 2010 at 09:33:54AM -0700, Jesse Barnes wrote: > > > On Fri, 2 Jul 2010 10:45:52 +1000 > > > Peter Hutterer wrote: &g

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-07-07 Thread Aaron Plattner
On Fri, Jul 02, 2010 at 09:33:54AM -0700, Jesse Barnes wrote: > On Fri, 2 Jul 2010 10:45:52 +1000 > Peter Hutterer wrote: > > > On Wed, Jun 30, 2010 at 10:55:52AM -0700, Jesse Barnes wrote: > > > > > This looks good to me. I assume the client is allocated with calloc so > > > > > that the count s

Re: [RFC PATCH] XAA: Remove pluggable GC validation.

2010-07-06 Thread Aaron Plattner
On Tue, Jul 06, 2010 at 09:56:51AM -0700, Jamey Sharp wrote: > This patch is part of a long series-in-progress, available here: > http://cgit.freedesktop.org/~jamey/xserver/log/?h=ops-rework > I'm trying to reduce GC structures to only protocol-visible data plus > privates, following a plan

Re: Review Request: X Synchronization Fences

2010-06-29 Thread Aaron Plattner
On Mon, Jun 28, 2010 at 05:05:33PM -0700, James Jones wrote: > For those of you who were at the X.org developers conference in 2009, Aaron > Plattner gave a presentation describing the usefulness of these objects. To > summarize, they can be used to synchronize X rendering with direct

Re: [PATCH] [dbe] Fix pixmap validation in miDbePositionWindow.

2010-05-28 Thread Aaron Plattner
ances of mis-validated GCs around. I take it > somebody actually encountered this one though? I'm sure, and yes. :) > Jamey > > On Fri, May 28, 2010 at 9:10 AM, Aaron Plattner wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > miDbePos

[PATCH] [dbe] Fix pixmap validation in miDbePositionWindow.

2010-05-28 Thread Aaron Plattner
for the front buffer first, then revalidating against the back buffer before performing the back buffer rendering. Signed-off-by: Aaron Plattner - --- dbe/midbe.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/dbe/midbe.c b/dbe/midbe.c index e47a253

<    1   2   3   4   5   6   7   >