Re: [PATCH v2] arch: Fix image and bitmap byte order for ppc64le

2014-06-16 Thread Benjamin Herrenschmidt
On Mon, 2014-02-24 at 11:36 +0100, Egbert Eich wrote: > From: Dinar Valeev > > So far PPC was big endian for sure. For ppc64le this is no longer > true. What happened to this ? It never made it upstream... Cheers, Ben. > Signed-off-by: Egbert Eich > --- > include/servermd.h | 9 +++-- >

Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Benjamin Herrenschmidt
Pad X220 by incorretly changing the condition for enabling them. This restores it. Signed-off-by: Benjamin Herrenschmidt CC: sta...@kernel.org [3.3] diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index a3bb49c..37b3792 100644 --- a/drivers/input/mouse/synaptics.c

Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Benjamin Herrenschmidt
Hi folks ! So Peter and I have been discussing a problem I observed on my brand new ThinkPad X220 and it's multitouch "clickpad". I've been digging a bit more today and bisected the regression to: commit 7968a5dd492ccc38345013e534ad4c8d6eb60ed1 Input: synaptics - add support for Relative mode Wi

Re: [PATCH] xserver: Fix double free's in config file parser

2011-07-15 Thread Benjamin Herrenschmidt
On Thu, 2011-07-14 at 23:39 -0700, Keith Packard wrote: > On Fri, 15 Jul 2011 10:43:04 +1000, Benjamin Herrenschmidt > wrote: > > > Something, like freeing it when we try to replace it (or some other > > "common" place like at the end of the loops) rather tha

Re: [PATCH] xserver: Fix double free's in config file parser

2011-07-14 Thread Benjamin Herrenschmidt
On Thu, 2011-07-14 at 09:26 -0700, Keith Packard wrote: > On Fri, 15 Jul 2011 01:36:05 +1000, Benjamin Herrenschmidt > wrote: > > On Thu, 2011-07-14 at 07:57 -0700, Dan Nicholson wrote: > > > I also see a couple instances of "free (val.str)" in parser/Files.c

Re: [PATCH] xserver: Fix double free's in config file parser

2011-07-14 Thread Benjamin Herrenschmidt
On Thu, 2011-07-14 at 07:57 -0700, Dan Nicholson wrote: > I also see a couple instances of "free (val.str)" in parser/Files.c > that don't set it to NULL afterward. Yay for custom parsers! With > those two instances fixed: Hrm, did I have a grep failure ? Oh... I see, I didn't catch the space betw

[PATCH] xserver: Fix double free's in config file parser

2011-07-14 Thread Benjamin Herrenschmidt
Feeding the parser a bad config file, I crashed the server a few times. It looks like whoever free's "val.str" (yeah, "val" is a global .. yuck) is also responsible for clearing the pointer or something else might try to free it again some time later. Signed-off-b