Not sure how I missed that, but I did.
Also rename emulate_getrandom_buf() into insecure_getrandom_buf() as
requested in the previous patch reviews.
Last, getbits() expects an unsigned char, so remove the warning.
Signed-off-by: Benjamin Tissoires
---
Obviously, I somehow even didn't co
getentropy() on a supported glibc and kernel. If the call fails,
fall back to the current (vulnerable) code.
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- use the getentropy() from glibc, not the plain syscall
- make it clear that arc4random_buf() should be preferred and that we
are only
getentropy() on a supported glibc and kernel. If the call fails,
fall back to the current (partly vulnerable) code.
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- use the getentropy() from glibc, not the plain syscall
- make it clear that arc4random_buf() should be preferred and that we
are
On Mon, Apr 3, 2017 at 9:17 PM, Mark Kettenis wrote:
> OpenBSD does not have a getrandom(3) function in libc. The OpenBSD
> postion is that the arc4random(3) family of functions is always the
> preferred way to get proper random numbers as all the other interfaces
> have nasty corner cases that p
On Mon, Apr 3, 2017 at 9:27 PM, Alan Coopersmith
wrote:
> On 04/ 3/17 12:17 PM, Mark Kettenis wrote:
>>>
>>> From: Benjamin Tissoires
>>> Date: Mon, 3 Apr 2017 17:52:32 +0200
>>>
>>> On Mon, Apr 3, 2017 at 4:02 PM, Alan Coopersmith
>>>
On Mon, Apr 3, 2017 at 4:02 PM, Alan Coopersmith
wrote:
> On 04/ 3/17 05:52 AM, Benjamin Tissoires wrote:
>>
>> This allows to fix CVE-2017-2625 on Linux platforms without pulling in
>> libbsd.
>> The syscall getrandom is available since kernel v3.17. The code first
>
On Mon, Apr 3, 2017 at 3:17 PM, walter harms wrote:
>
>
> Am 03.04.2017 14:52, schrieb Benjamin Tissoires:
>> This allows to fix CVE-2017-2625 on Linux platforms without pulling in
>> libbsd.
>> The syscall getrandom is available since kernel v3.17. The code first
>&
glibc getrandom() call given that it's only
available in glibc 2.25, and the #if dance is already messy here.
Signed-off-by: Benjamin Tissoires
---
configure.ac | 3 +++
src/iceauth.c | 79 ++-
2 files changed, 65 insertions(+
getrandom() call given that it's only
available in glibc 2.25, and the #if dance is already messy here.
Signed-off-by: Benjamin Tissoires
---
Key.c| 12
configure.ac | 3 +++
2 files changed, 15 insertions(+)
diff --git a/Key.c b/Key.c
index a09b316..61b07db 100644
On Fri, Dec 11, 2015 at 10:42 AM, Peter Hutterer
wrote:
> On Fri, Dec 11, 2015 at 09:58:34AM +0100, Benjamin Tissoires wrote:
>> Hi Peter,
>>
>> On Fri, Dec 11, 2015 at 12:58 AM, Peter Hutterer
>> wrote:
>> > InputClass sections use various MatchFoo direct
Hi Peter,
On Fri, Dec 11, 2015 at 12:58 AM, Peter Hutterer
wrote:
> InputClass sections use various MatchFoo directives to decide which device to
> apply to. This usually works fine for specific snippets but has drawbacks for
> snippets that apply more generally to a multitude of devices.
>
> Thi
The fix for CVE-2015-1804 prevent DWIDTH to be negative.
However, the spec states that "DWIDTH [...] is a vector indicating the
position of the next glyph’s origin relative to the origin of this glyph."
So negative values are correct.
Found by trying to compile XTS.
Signed-off-by
e the motion events.
>
> Signed-off-by: Peter Hutterer
> ---
FWIW: Tested-by: Benjamin Tissoires
Cheers,
Benjamin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Evemu is a freedesktop project and can benefit from release.sh
One special case has been added to match the tag format used internally
(vX.Y.Z)
Signed-off-by: Benjamin Tissoires
---
It would be nice if release.sh could also handle evemu.
Cheers,
Benjamin
release.sh | 13 -
1
t;> none of them are touchpads so this code is superfluous.
>
> Looks good, the entire series is:
>
> Reviewed-by: Hans de Goede
>
Besides the small nitpick in 3/4, this series is also:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
_
On Tue, Mar 11, 2014 at 1:27 AM, Peter Hutterer
wrote:
> This was supposed to emulate a SYN_REPORT event so that the upper layers
> process what's in the queue.
>
> Signed-off-by: Peter Hutterer
> ---
> src/eventcomm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/
On Tue, Mar 11, 2014 at 1:27 AM, Peter Hutterer
wrote:
> When checking the device don't open a new mtdev instance, use the existing
> libevdev struct.
>
> Signed-off-by: Peter Hutterer
> ---
> src/eventcomm.c | 99
> -
> 1 file changed, 48
rtup-tested it
> so far but not triggered the actual code.
Here you go:
Tested-by: Benjamin Tissoires
tested under udev and hal backends.
Cheers,
Benjamin
>
> config/hal.c | 16 +---
> config/udev.c | 15 +++
> 2 files changed, 24 insertions(+), 7 deletions(
On Fri, May 31, 2013 at 7:46 AM, Peter Hutterer
wrote:
> Having /dev/input/event10 sort after /dev/input/event9 almost makes me think
> the future is here.
>
> Signed-off-by: Peter Hutterer
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
list of changes since 1.0.10
-
Benjamin Tissoires (15):
Test for device grab
.gitignore: add tools/evemu-event
Clean mixed declarations and code
add evemu-test-runner into .gitignore
remove -D_GNU_SOURCE=1 from CFLAGS
dis
gt;vals == NULL) and later receives an event from an MT axis.
>
> X.Org Bug 64029 <http://bugs.freedesktop.org/show_bug.cgi?id=64029>
>
> Signed-off-by: Peter Hutterer
Reviewed-by: Benjamin Tissoires
Thanks for the "fix" Peter :)
Cheers,
Benjamin
From: Benjamin Tissoires
Apple Magic Trackpad can report 16 slots. In clickpad_guess_clickfingers()
the array allocated on the stack contains only 10 slots.
As (.num_mt_mask == .num_slots), the function writes out of the bounds
of close_point.
Dynamically allocating the buffer depending on the
On Wed, Jan 23, 2013 at 3:19 AM, Chung-yih Wang wrote:
> If an evdev client cannot consume evdev events in its queue fast enough, the
> evdev kernel driver will enqueue a SYN_DROPPED event and clear the queue
> once the client's queue is full. The result is that the X driver will be out
> of sync
-off-by: Benjamin Tissoires
---
Hi guys,
well, I'm not 100% sure of this, but at least, it my tests don't print these
errors...
Cheers,
Benjamin
src/XExtInt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/XExtInt.c b/src/XExtInt.c
index 57d071d..507573b 100644
--- a/src
l
context.
Please update to check inSignalContext and/or use LogMessageVerbSigSafe() or
ErrorFSigSafe().
The offending log format message is:
%s: Attempted to start touch without x/y (driver bug)
Signed-off-by: Benjamin Tissoires
---
dix/getevents.c | 8
1 file changed, 4 insert
ABS_MT_DISTANCE controls whether the finger is touching the sensor or not.
When the slot is opened, if the device reports ABS_MT_DISTANCE, we should
rely on it to set the right value of touch. If not, then the creation of
the slot means that the touch began.
Signed-off-by: Benjamin Tissoires
the touch property to true or false.
The benefit of it is that we can now easily add proximity support
and several touch begin/end within the same slot.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 47 +++
src/evdev.h | 8 +++-
2 files
For non-mtdev multitouch devices, it's possible to retrieve the initial
state of the different touches.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index ec
Mtdev is only usefull for protocol A devices (quite a few now).
For all the others, it adds some memory and process which is not required
as it just passes the events to the caller.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 26 +++---
1 file changed, 23 insertions
Getting an out of range ABS_MT_SLOT value means that either the kernel
driver is broken or the device is sending more slots that it advertised.
In both cases, it's a bug in the kernel and processing the incoming
events for this bad slot may introduce end-user problems.
Signed-off-by: Ben
Everywhere else in the code, pEvdev->cur_slot is never used directly,
but through the function last_mt_vals_slot which standardize it.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evde
The current implementation assume that multitouch devices following the
Multitouch Protocol A (those requiring mtdev) present 10 touches,
no matter mtdev decides.
num_slots should be relying on mtdev when it is available.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 14 --
1
This prevents the creation of a touch in case no multitouch event came
before the very first EV_SYN.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/evdev.c b/src/evdev.c
index 619bce6..27b0e76 100644
--- a/src/evdev.c
+++ b/src/evdev.c
each slot.
Patches 7-8 handle these particular devices (proximity).
Cheers,
Benjamin
Benjamin Tissoires (8):
initialize pEvdev->slot_state to SLOTSTATE_EMPTY
num_slots should take into account the .mtdev field
Use last_mt_vals_slot() instead of directly using pEvdev->cur_slot
Ignore
update evdev according to latest changes in input.h
Signed-off-by: Benjamin Tissoires
---
Hi Peter,
well, I doubt we should bump the ABI number for just 3 labels in xserver.
So I'm not sure about the #ifdef here. Don't hesitate to send any comments.
Cheers,
Benjamin
src/axis_la
ABS_MT_DISTANCE exists since kernel v2.6.38,
ABS_MT_TOOL_X|Y appeared in v3.6.
Signed-off-by: Benjamin Tissoires
---
Hi Peter,
as requested, this is an update of the latest input definitions made
in the kernel.
It's been a long time since I submitted patches to X.org, so don't h
On 02/22/2011 11:31 PM, Peter Hutterer wrote:
On Tue, Feb 22, 2011 at 08:17:32AM +0100, Benjamin Tissoires wrote:
Hi Peter,
Except two unnecessary parenthesis here, you can add my Reviewed-by
for the series ;)
On 02/18/2011 04:52 AM, Peter Hutterer wrote:
[...]
diff --git a/Xi
Hi Peter,
Except two unnecessary parenthesis here, you can add my Reviewed-by for
the series ;)
On 02/18/2011 04:52 AM, Peter Hutterer wrote:
This is not a straightforward search/replacement due to a long-standing
issue.
dev->u.master is the same field as dev->u.lastSlave. Thus, if dev is a
Hi Peter,
On 02/18/2011 04:52 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
---
xkb/xkb.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 43d847a..169c604 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -5831,6 +5831,7 @@ ProcXkbGetK
I Peter,
I did not made an exhaustive review, but at least, you can add my
'tested-by'.
Thanks a lot for the work.
Cheers,
Benjamin
On 02/04/2011 12:45 AM, Peter Hutterer wrote:
New properties:
"Evdev Third Button Emulation" → switch on/off
"Evdev Third Button Emulation Timeout" → timeout u
Hi Peter,
well, I still have troubles (again, based on the backport to 2.6.0). ;)
On 02/02/2011 07:35 AM, Peter Hutterer wrote:
New properties:
"Evdev Third Button Emulation" → switch on/off
"Evdev Third Button Emulation Timeout" → timeout until event is delivered
"Evdev Third Button Emulation
m not able to know if
it's related to the backport or not).
Maybe I'm totally wrong (because the valuator stuff changed some logic),
in case I apologize for using your time. ;)
Cheers,
Benjamin
On 02/01/2011 10:08 AM, Benjamin Tissoires wrote:
On 01/31/2011 10:52 PM, Peter Hut
On 01/31/2011 10:52 PM, Peter Hutterer wrote:
On Mon, Jan 31, 2011 at 11:48:08AM +0100, Benjamin Tissoires wrote:
Thanks, that seems to be a good feature for touchscreen devices!
I've got one problem: on which tree does this patch applies? (I've
tried against the branch master of
Hi Peter,
Thanks, that seems to be a good feature for touchscreen devices!
I've got one problem: on which tree does this patch applies? (I've tried
against the branch master of xf86-input-evdev):
error: patch failed: src/evdev.c:453
error: src/evdev.c: patch does not apply
error: patch failed:
Re: [PATCH 0/2] input: mt: Add EVIOC mechanism for MT slots
>> Date: Thu, 27 May 2010 16:12:20 -0700
>> From: Dmitry Torokhov
>> To: Ping Cheng
>> CC: Henrik Rydberg , Andrew Morton
>> , linux-in...@vger.kernel.org,
>> linux-ker...@vger.kernel.or
Reviewed-by: Benjamin Tissoires
On 12/10/2010 04:16 PM, Peter Korsgaard wrote:
Since 59056e656c64 (Remove the reopen timer logic) from last year,
EvdevCacheCompare() is only used for caching ioctl values and not for
comparing, so remove the unused compare logic and rename the function
to
Hi Peter,
On 12/10/2010 01:28 PM, Peter Korsgaard wrote:
Since 59056e656c64 (Remove the reopen timer logic) from last year,
EvdevCacheCompare() is only used for caching ioctl values and not for
comparing, so remove the unused compare logic and rename the function
to EvdevCache().
Signed-off-by:
Le 08/11/2010 04:51, Peter Hutterer a écrit :
fwiw, I'm not sure "arbitrate" is the right word here, filtering seems
easier to understand in this context. I guess "arbitrate" would apply more
if we emit the events across multiple devices like in the bamboo case.
that's mostly bikeshedding though,
Hi,
Le 29/10/2010 07:37, Peter Hutterer a écrit :
On Sun, Oct 24, 2010 at 01:45:03PM +0200, Paolo D'Apice wrote:
The evdev driver does not allow to set a custom axes rotation
as the mousedrv driver does with the option "AngleOffset".
This option is necessary for some trackballs, for example the
Hi,
If I understand correctly, you are trying to work with the patches I
submitted, nearly a year ago.
First, I would just say that the work concerning this branch of evdev is
not maintained as it has a lot of problems (limit of the maximum count
of contact, etc).
Multitouch will be availa
Le 28/10/2010 05:11, Peter Hutterer a écrit :
On Tue, Oct 26, 2010 at 10:11:17AM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
---
src/evdev.c | 22 +-
1 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 018843f.
, thanks,
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Le 26/10/2010 02:11, Peter Hutterer a écrit :
Signed-off-by: Peter Hutterer
---
src/evdev.c | 22 +-
1 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 018843f..940f24d 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -63,7 +63,
Quite easy to review this one... ;)
Reviewed-by: Benjamin Tissoires
Le 26/10/2010 02:11, Peter Hutterer a écrit :
Signed-off-by: Peter Hutterer
---
src/evdev.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 32253a2
Reviewed-by: Benjamin Tissoires
Le 20/10/2010 02:47, Peter Hutterer a écrit :
Instead of two lists that need to be kept in sync, just store the bits in an
array and run through them.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 51 +--
1
Reviewed-by: Benjamin Tissoires
Le 20/10/2010 02:46, Peter Hutterer a écrit :
Mainly to avoid confusing between pEvdev->prox and pEvdev->proximity and to
better express what these fields are actually holding.
Signed-off-by: Peter Hutterer
---
src/evdev.c
->abs;
+return 0;
+}
+
+for (i = 0; pEvdev->prox&& i< pEvdev->num_queue; i++)
Hi Peter,
though it helps understanding the patch, the test on ->prox is not
necessary ("return 0" above).
Except that small thing,
Revie
Thoses definitions have been included in the kernel and in the X server.
However, the evdev driver has not been updated accordingly.
Without these definitions, the multitouch axes are not correctly labelled.
Signed-off-by: Benjamin Tissoires
---
This patch is in my queue since a few month
Le 12/10/2010 03:20, Peter Hutterer a écrit :
On Mon, Oct 11, 2010 at 01:09:50PM +0200, Benjamin Tissoires wrote:
Hi Peter,
Le 11/10/2010 01:23, Peter Hutterer a écrit :
We only use them as values, no need for the addresses.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 16
Le 12/10/2010 03:38, Peter Hutterer a écrit :
On Mon, Oct 11, 2010 at 12:58:06PM +0200, Benjamin Tissoires wrote:
Hi Peter,
see my comments:
Le 11/10/2010 01:33, Peter Hutterer a écrit :
When one of the tools comes into proximity, queue up a proximity event and
send it accordingly.
Signed
Hi Peter,
Le 11/10/2010 01:23, Peter Hutterer a écrit :
We only use them as values, no need for the addresses.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 16
src/evdev.h |4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/evdev.c b/src/e
Hi Peter,
see my comments:
Le 11/10/2010 01:33, Peter Hutterer a écrit :
When one of the tools comes into proximity, queue up a proximity event and
send it accordingly.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 62 ++-
src/evde
Le 21/09/2010 06:42, Daniel Stone a écrit :
Hi,
On Mon, Sep 20, 2010 at 04:54:37PM +0200, Benjamin Tissoires wrote:
Le 20/09/2010 06:45, Daniel Stone a écrit :
During a touchpoint's short lifetime, all motion events will be sent to
one client and one client only. Only TouchBegin r
Hi Daniel,
though I'm not a toolkit guy, I wanted to add some comments mainly from
the discussions we had at XDS (and from what I understood).
I've also added Denis in copy as he was present at XDS and may need to
add sth.
Le 20/09/2010 06:45, Daniel Stone a écrit :
Hi all,
This is my second
Le 23/06/2010 16:04, Chase Douglas a écrit :
From: Benjamin Tissoires
The MT Slots protocol sends only the ABS_MT_* values that have changed
from a previous set of events. We use the ABS_MT_SLOT value as an index
into an array of MT valuators.
(see kernel_src/Documentation/input/multi-touch
Le 18/06/2010 08:53, Peter Hutterer a écrit :
On Fri, Jun 18, 2010 at 08:46:17AM +0200, Benjamin Tissoires wrote:
Le 18/06/2010 06:56, Peter Hutterer a ?crit :
On Fri, Jun 18, 2010 at 12:18:00AM -0400, Rafi Rubin wrote:
On Thu, Jun 17, 2010 at 11:51:34AM -0400, Chase Douglas wrote:
On Thu
Le 17/06/2010 10:58, Henrik Rydberg a écrit :
Peter Hutterer wrote:
On Thu, Jun 10, 2010 at 05:47:57PM +0200, Benjamin Tissoires wrote:
Even if there is an interesting thread concerning the use of multitouch on
xorg-devel,
I still send the up-to-date patches to enable multitouch as valuators
Le 18/06/2010 06:56, Peter Hutterer a écrit :
On Fri, Jun 18, 2010 at 12:18:00AM -0400, Rafi Rubin wrote:
On Thu, Jun 17, 2010 at 11:51:34AM -0400, Chase Douglas wrote:
On Thu, 2010-06-17 at 12:16 +1000, Peter Hutterer wrote:
On Thu, Jun 10, 2010 at 05:47:57PM +0200, Benjamin Tissoires wrote
the first available place, i.e. it does
not override older mt values. This is valid as this protocol forces the
device to send all the values at each frame.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 42 +++---
src/evdev.h |1 +
2 files changed, 40
ABS_MT_POSITION_Y at their first position.
Note that I currently assume that all definitions between
ABS_MT_TOUCH_MAJOR and below ABS_MT_PRESSURE are MT-related.
This can be changed by re-defining EVDEV_FIRST_MT_AXIS and
EVDEV_LAST_MT_AXIS.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 188
The driver has to know the correct labels of the ABS_MT_* events.
However, to keep compatibility with older xserver that don't define
the corresponding labels, this patch does not inject them in the list.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 29 +++
Hi,
Even if there is an interesting thread concerning the use of multitouch on
xorg-devel,
I still send the up-to-date patches to enable multitouch as valuators.
Changes since last time:
* Remove the detection of the maximum number of touches based on the tracking ID
* changes in comments
Chee
Le 02/06/2010 15:13, Henrik Rydberg a écrit :
B> @@ -545,7 +548,15 @@ EvdevProcessAbsoluteMotionEvent(InputInfoPtr pInfo,
struct input_event *ev)
if (EvdevWheelEmuFilterMotion(pInfo, ev))
return;
-pEvdev->vals[pEvdev->axis_map[ev->code]] = value;
+if (ev->code< ABS_M
Le 02/06/2010 15:09, Henrik Rydberg a écrit :
+static int
+EvdevMTAddExtraValuators(EvdevPtr pEvdev, int total_num_axes)
+{
+int num_axes = 0;
+int mt_num_valuators = 0;
+
+if (!(pEvdev->flags& EVDEV_MULTITOUCH))
+return total_num_axes;
+
+mt_num_valuators = EvdevMTCoun
ABS_MT_POSITION_Y at their first position.
Note that I currently assume that all definitions between
ABS_MT_TOUCH_MAJOR and below ABS_MT_PRESSURE are MT-related.
This can be changed by re-defining EVDEV_FIRST_MT_AXIS and
EVDEV_LAST_MT_AXIS.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 196
the first available place, i.e. it does
not override older mt values. This is valid as this protocol forces the
device to send all the values at each frame.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 36 +---
src/evdev.h |1 +
2 files changed, 34 insert
Hi,
here the third version of the mt patches.
Changes since last time:
- typos and indents fixed
- introduced 3 defines: EVDEV_FIRST_MT_AXIS, EVDEV_LAST_MT_AXIS and
EVDEV_XI_MULTITOUCHDEVICE.
- changes in git commit messages to be more explicit (I hope)
- swapped "free(atoms)" and "EvdevMTInitVa
The driver has to know the correct labels of the ABS_MT_* events.
However, to keep compatibility with older xserver that don't define
the corresponding labels, this patch does not inject them in the list.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 29 +++
s well so one doesn't thave to read through the diff to satisfy
their curiosity ;)
other than that, just a two typos/language fixups
On Sun, May 30, 2010 at 03:08:59PM +0200, Benjamin Tissoires wrote:
In case the driver receives a mt event, it stores it at the first
available place, i.e. it
Thanks Peter (I also cross send to the right mailing list address as I
made a mistake the first time I send these patches)
Le 01/06/2010 03:35, Peter Hutterer a écrit :
On Sun, May 30, 2010 at 03:08:58PM +0200, Benjamin Tissoires wrote:
The step one in implementing multitouch in evdev is to
In case the driver receives a mt event, it stores it at the first
available place, i.e. it does not overrides older mt values.
At the end, in the EV_SYNC event, it only sends the values it has
filled.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 36
ABS_MT_POSISTION_Y at their first position.
Note that I currently assume that all definitions above ABS_MT_TOUCH_MAJOR
and below ABS_MAX are MT-related.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 177 ++-
src/evdev.h |6 ++-
2 files
The driver has to know the correct labels of the ABS_MT_* events.
However, to keep compatibility with older xserver that don't define
the corresponding labels, this patch does not inject them in the list.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 29 +++
Here is finally the new set of patches to enable a preliminary support of
multitouch into Xorg.
Changes since last time:
- squashed patches "Detection of multitouch device" and "Add the new valuators
for multitouch"
- renamed the field mt_num_valuators to mt_current_touchpoint
- namespace for i
In case the driver receives a mt event, it stores it at the first
available place, i.e. it does not overrides older mt values.
At the end, in the EV_SYNC event, it only sends the values it has
filled.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 36
ABS_MT_POSISTION_Y at their first position.
Note that I currently assume that all definitions above ABS_MT_TOUCH_MAJOR
and below ABS_MAX are MT-related.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 177 ++-
src/evdev.h |6 ++-
2 files
The driver has to know the correct labels of the ABS_MT_* events.
However, to keep compatibility with older xserver that don't define
the corresponding labels, this patch does not inject them in the list.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 29 +++
Here is finally the new set of patches to enable a preliminary support of
multitouch into Xorg.
Changes since last time:
- squashed patches "Detection of multitouch device" and "Add the new valuators
for multitouch"
- renamed the field mt_num_valuators to mt_current_touchpoint
- namespace for i
High resolution devices was generating integer overflow.
For instance the wacom Cintiq 21UX has an axis value up to
87000. Thus the term (dSx * (Cx - Rxlow)) is greater than
MAX_INT32.
Using 64bits integer avoids such problem.
Signed-off-by: Philippe Ribet
Signed-off-by: Benjamin Tissoires
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -556,12 +556,10 @@ EvdevProcessAbsoluteMotionEvent(InputInfoPtr pInfo,
struct input_event *ev)
if (ev->code< ABS_MT_TOUCH_MAJOR)
pEvdev->vals[pEvdev->axis_map[ev->code]] = value;
-else if (pEvdev->current_num_multitouch< EVDEV_MAX_TO
Le 09/04/2010 07:44, Peter Hutterer a écrit :
On Sun, Mar 28, 2010 at 01:58:12PM +0200, Benjamin Tissoires wrote:
In case the driver receive a mt event, it stores it at the first
available place, i.e. it does not overrides older mt values.
At the end, in the EV_SYNC event, it only send the
Sorry for the delay, I was quite busy this time...
I'm worried about EvdevAddAbsClass getting a bit too messy with this. If I'm
not mistaken, you can quite trivially move this if (flags& MULTITOUCH)
condition into a EvdevMTCountValuators() and the loop to init all axes into a
EvdevMTInitValuato
Le 12/04/2010 09:17, Philippe Ribet a écrit :
Dan Nicholson wrote:
On Fri, Apr 9, 2010 at 7:51 AM, Benjamin Tissoires
wrote:
High resolution devices was generating integer overflow.
For instance the wacom Cintiq 21UX has an axis value up to
87000. Thus the term (dSx * (Cx - Rxlow)) is
High resolution devices was generating integer overflow.
For instance the wacom Cintiq 21UX has an axis value up to
87000. Thus the term (dSx * (Cx - Rxlow)) is greater than
MAX_INT32.
Using 64bits integer avoids such problem.
Signed-off-by: Philippe Ribet
Signed-off-by: Benjamin Tissoires
device
- the device reports all multitouch fields at each frame
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 73 --
src/evdev.h | 11 +
2 files changed, 76 insertions(+), 8 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
In case the driver receive a mt event, it stores it at the first
available place, i.e. it does not overrides older mt values.
At the end, in the EV_SYNC event, it only send the values it has
filled.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 31 ---
src
: Benjamin Tissoires
---
src/evdev.c | 51 ++-
src/evdev.h |5 +
2 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index b84af7f..7e59601 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1156,7 +1156,7
This patch does nothing except detecting multitouch devices and putting
this detection in the log.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 22 +-
src/evdev.h |1 +
2 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
The driver has to know the correct labels of the ABS_MT_* events.
However, to keep compatibility with older xserver that don't define
the corresponding labels, this patch does not inject them in the list.
Signed-off-by: Benjamin Tissoires
---
src/evdev.c | 29 +++
Hello everybody,
I started the development of multitouch in the evdev driver. As the goal of the
evdev driver is to provide raw information from the kernel, I did not included
any gestures nor filtering.
Currently, I have the following limitations:
- the number of simultaneous reported touchpoi
1 - 100 of 114 matches
Mail list logo