Re: [PATCH] Substitution of VIA_VM800 label with VIA_P4M800PRO label

2016-01-07 Thread Benno Schulenberg
It is customary to have the subject line of a patch in the imperative, so here: "substitute the label VIA_VM800 with VIA_P4M800PRO". On Thu, Jan 7, 2016, at 01:14, Kevin Brace wrote: > Replaces VIA_VM800 label with VIA_P4M800PRO label Redundant. It repeats the subject line. Unneeded, annoying.

[PATCH xkbcomp] When a file contains several maps, look for a default map

2016-01-06 Thread Benno Schulenberg
(look for XkbLC_Default). https://bugs.freedesktop.org/show_bug.cgi?id=69950 Signed-off-by: Ran Benita Tested-by: Benno Schulenberg Acked-by: Sergey Udaltsov --- misc.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/misc.c b/misc.c index 4990a7

Re: [PATCH xkbcomp] symbols: increase the warning level for shortening a key type

2015-11-06 Thread Benno Schulenberg
On Fri, Nov 6, 2015, at 08:25, Peter Hutterer wrote: > On Thu, Nov 05, 2015 at 04:21:14PM +0100, Benno Schulenberg wrote: > > A patch that actually fixes the bug that causes this warning to printed > > was proposed and reviewed a year ago: > > > > http://list

Re: [PATCH xkbcomp] symbols: increase the warning level for shortening a key type

2015-11-05 Thread Benno Schulenberg
On Tue, Nov 3, 2015, at 00:06, Peter Hutterer wrote: > Any use of the german keyboard layout or anything else using > level3(ralt_switch) produces the warning > Type "ONE_LEVEL" has 1 levels, but has 2 symbols > Ignoring extra symbols > This warning is meaningless, the default definition

Re: [patch] xkbcomp: fixing an age-old warning

2014-09-11 Thread Benno Schulenberg
see it. I would like to propose that solution for this warning: Warning: Symbol map for key redefined Using last definition for conflicting fields Thanks for the detailed review. Benno -- http://www.fastmail.fm - Or how I learned to stop worrying and

[patch] xkbcomp: fixing an age-old warning

2014-09-09 Thread Benno Schulenberg
eac107e9421a23326ba Mon Sep 17 00:00:00 2001 From: Benno Schulenberg Date: Sat, 21 Sep 2013 10:32:54 +0200 Subject: [PATCH] When overriding a key, also adjust its number of levels. This gets rid of the age-old warning of the right Alt key being ONE_LEVEL but having two symbols assigned. R

Re: Additions for Compose

2014-06-06 Thread Benno Schulenberg
On Fri, Jun 6, 2014, at 18:16, Alan Coopersmith wrote: > On 06/ 6/14 03:45 AM, Geoff Streeter wrote: > > I see that the UTF-8 characters did not make the round trip into the digest. > > They made it fine in the direct e-mail Well, for me the body of the direct email is base64 encoded, which (whe

Re: [PATCH libX11 2/2] nls: remove duplicate Hebrew compose sequences

2014-01-29 Thread Benno Schulenberg
On Wed, Jan 29, 2014, at 18:35, James Cloos wrote: > I don't know that it has been long enough, yet, to drop the older names > from the compose tables. None of the deprecated symbols are in xkeyboard-config any more, and haven't been there since its beginning in 2004 -- so, quite long enough, I t

Re: XF86AudioMicMute / RALT / xkbcomp problems

2013-10-02 Thread Benno Schulenberg
On Wed, Oct 2, 2013, at 11:43, Knut Petersen wrote: > > Warning: Type "ONE_LEVEL" has 1 levels, but has 2 symbols > > Ignoring extra symbols This warning (though harmless) is fixed by this patch: https://bugs.freedesktop.org/attachment.cgi?id=86805 attached to th

Re: [PATCH] fix xkbcomp failure

2013-10-02 Thread Benno Schulenberg
> > syntax error: line 19 of level3 > > The XKEYBOARD keymap compiler (xkbcomp) reports: > > > Error:Error interpreting include file "level3" Ouch. Sorry. > Exactly the same thing in symbols/level5. We just missed release 2.10, > unfortunately. It seems a 2.10.1 releas

Re: [libX11/nls] requesting patch review: composing breve via lowercase u

2013-09-17 Thread Benno Schulenberg
On Sun, Aug 11, 2013, at 10:18, Benno Schulenberg wrote: > The Compose tables currently allow to put a breve on a letter via > the capital U (for example:produces ă). This > is fine for putting a breve on an uppercase letter, where one has > to press anyway, but it is awkwar

Re: [patches: libX11/nls] allowing breve to be composed via lowercase u

2013-09-01 Thread Benno Schulenberg
On Sun, Aug 11, 2013, at 10:18, Benno Schulenberg wrote: > So, the first patch [...] adds the " ..." sequences > for the relevant letters. > > The second patch adds the sequences with the plain key for > , similar to the ones that already exist for ; the > la

[patches: libX11] allowing breve to be composed via lowercase u

2013-08-11 Thread Benno Schulenberg
en comment. These patches were submitted in bug #59319: https://bugs.freedesktop.org/show_bug.cgi?id=59319 Please consider them for inclusion. [Please CC, not subscribed.] From 70f398690b457ee0900741508ab71f9f3efd5744 Mon Sep 17 00:00:00 2001 From: Benno Schulenberg Date: Fri, 11 Jan 201