Re: [PULL] Server build fixes

2011-02-26 Thread Cyril Brulebois
→ fails, master + your patch → works. Accordingly: Tested-by: Cyril Brulebois Also, the generated sdksyms.c lands in the build directory, meaning one can happily do stuff like: mkdir build1 build2 (cd build1 && ../configure --disable-stuff) (cd build2 && ../configure --enable-s

Re: [PULL] Server build fixes

2011-02-26 Thread Cyril Brulebois
Dan Nicholson (26/02/2011): > And when I run make, sdksyms.sh is run first and then sdksyms.c is > built. Can you check if that's the case on your error? Or, if you > manually run sdksyms.sh again, does the error go away? You may be > right, though. sdksyms.c doesn't explicitly depend on sdksyms.d

Re: [PULL] Server build fixes

2011-02-26 Thread Cyril Brulebois
Hi, Keith Packard (25/02/2011): > On Fri, 25 Feb 2011 06:43:58 -0800, Dan Nicholson wrote: > > > Dan Nicholson (2): > > xfree86: Allow sdksyms.dep to be included portably > > dmx: Construct paths in doxygen.conf to fix VPATH builds > > Merged. >780a77a..6b951de master -> maste

[PATCH xf86-video-vmware] Remove unused variable.

2011-02-26 Thread Cyril Brulebois
Fix the build with CFLAGS="-Wall -Werror": | CC vmware_drv_la-vmwaremodule.lo | cc1: warnings being treated as errors | vmwaremodule.c: In function ‘vmware_chain_module’: | vmwaremodule.c:178: error: unused variable ‘ret’ Signed-off-by: Cyril Brulebois --- src/vmwaremodule.c |

Re: [PULL] Server build fixes

2011-02-25 Thread Cyril Brulebois
Keith Packard (25/02/2011): > So, I'm a bit confused here -- I do 'make distcheck' to build > releases, and it works for me. I'd like to know how I can test this > patch to make sure it does what you expect. Do you end up building with devel docs, so with doxygen support when you're running make

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-24 Thread Cyril Brulebois
Hi Dan, Dan Nicholson (20/02/2011): > The paths in doxygen.conf assumed that srcdir=builddir and broke > otherwise. Use autoconf to fill in the paths to the srcdir so that > the files can be found when users have a separate build directory > (as with distcheck). > > Signed-off-by: Dan Nicholson

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011-02-24 Thread Cyril Brulebois
Keith Packard (24/02/2011): > On Thu, 24 Feb 2011 12:17:57 +0100, Michel Dänzer wrote: > > > On the other hand, the system memory copy doesn't need the pitch > > to be aligned beyond the PixmapBytePad of the width. > > Merged. Hi Jeremy, please consider 31704510f448706524b7b7085cc4ff0ada7bfe7

Re: [PATCH] test: add some tests for basic list manipulation.

2011-02-24 Thread Cyril Brulebois
Minor nit… Peter Hutterer (22/02/2011): > This has less purpose as a test but more as documentation on how to actually > use the differnent list calls. ^^ -n KiBi. signature.asc Description: Digital signature ___ xorg

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Cyril Brulebois
Hi, Keith Packard (24/02/2011): > As release manager, this seems like the right solution. However, > it's a larger change than adding the new fix-ups, which doesn't > exactly make me less nervous. not that I'm advocating last-minute pushes, I gave it a try anyway. > If you want to try out the R

[PULL] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

2011-02-24 Thread Cyril Brulebois
Hi Keith, Cyril Brulebois (20/02/2011): > BIG FAT WARNING: Not actually tested yet. Waiting for other builds to > finish before uploading a new revision with that fix. no longer true, the build went fine until the unit tests. Keith, please pull from: git://git.debian.org/users/kibi/pk

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011-02-24 Thread Cyril Brulebois
86crtc_resize hook, fixes > https://bugs.freedesktop.org/show_bug.cgi?id=33929 . > > On the other hand, the system memory copy doesn't need the pitch to be aligned > beyond the PixmapBytePad of the width. > > Signed-off-by: Michel Dänzer Yay! Acked-by: Cyril Brulebois And i

Re: [PATCH mouse 1/6] man: remove mention of core pointer.

2011-02-20 Thread Cyril Brulebois
Peter Hutterer (21/02/2011): > This doesn't apply to X servers 1.7 and later. > > Signed-off-by: Peter Hutterer For the series: Reviewed-by: Cyril Brulebois KiBi. signature.asc Description: Digital signature ___ xorg-devel@list

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-20 Thread Cyril Brulebois
Nicholson Tested-by: Cyril Brulebois both in-tree and out-of-tree. Thanks. KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mai

[PATCH 1/3] hw/dmx/doc: Fix missing slash in css target.

2011-02-20 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois --- hw/dmx/doc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx/doc/Makefile.am b/hw/dmx/doc/Makefile.am index 4bbc8bf..17defb5 100644 --- a/hw/dmx/doc/Makefile.am +++ b/hw/dmx/doc/Makefile.am @@ -260,6 +260,6

[PATCH 2/3] hw/dmx/doc: Specify {src,build}dir in DOXYGEN_SRC.

2011-02-20 Thread Cyril Brulebois
The doxygen configuration file is in the source tree (as seen in the html/annotated.html target), whereas doxygen.{head,foot,css} are symlinks in the build directory, as seen in the last targets of the Makefile. Signed-off-by: Cyril Brulebois --- hw/dmx/doc/Makefile.am |2 +- 1 files

[PATCH 3/3] hw/dmx/doc: Move from $(builddir) to $(abs_builddir).

2011-02-20 Thread Cyril Brulebois
$(builddir)/doxygen.* targets are never considered out-of-date, so symlinks never get created and out-of-tree builds fail. Using $(abs_builddir) instead fixes it. Signed-off-by: Cyril Brulebois --- hw/dmx/doc/Makefile.am |8 1 files changed, 4 insertions(+), 4 deletions(-) diff

Fixing out-of-tree failures in hw/dmx/doc

2011-02-20 Thread Cyril Brulebois
Hi, I saw Dan's reply, but I'm posting anyway the tiny patch series that fixes the out-of-tree build for me (with devel docs enabled, with doxygen; not tried distcheck). [PATCH 1/3] hw/dmx/doc: Fix missing slash in css target. Trivial enough. [PATCH 2/3] hw/dmx/doc: Specify {src,build}dir in D

[PATCH] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

2011-02-20 Thread Cyril Brulebois
xit status Fix typo introduced in: 3a9bb93dd178084f4ff1abcea331ca5a62f88ce6 Signed-off-by: Cyril Brulebois --- hw/xfree86/common/xf86sbusBus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) BIG FAT WARNING: Not actually tested yet. Waiting for other builds to finish before uploa

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-19 Thread Cyril Brulebois
Gaetan Nadon (19/02/2011): > The scenario in question is running distcheck in a VPATH build when > doc generation is disabled which conflicts with the requirement of > mandating generated docs in the tarball. > > This scenario does not affect distro/OS builds as far as I can tell. Out-of-tree bu

Input drivers (was [ANNOUNCE] xorg-server 1.9.99.902 (1.10 RC2))

2011-02-19 Thread Cyril Brulebois
Hi, Keith Packard (18/02/2011): > Other than that, I think we're pretty much ready for the 1.10 > release. Let me know if you've got pending fixes that you want to > see merged in 1.10. Peter, could we please get a (pre)release for -synaptics? Latest release doesn't build with input ABI 12. (I c

[PATCH libFS] Silence gcc warning.

2011-02-18 Thread Cyril Brulebois
kely to be sufficient for this buffer's size… Signed-off-by: Cyril Brulebois --- test/FSGetErrorText.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/FSGetErrorText.c b/test/FSGetErrorText.c index 31523c6..f9a88d2 100644 --- a/test/FSGetErrorText.c +++ b/test/F

Re: Current tinderbox regression (xserver, randr)

2011-02-18 Thread Cyril Brulebois
Chris Ball (17/02/2011): > http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build > > rrcrtc.c: In function 'RRConvertCrtcConfig': > rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first use in this > function) > rrcrtc.c:1512: error: (Each undeclared identifier is reporte

Re: xorg-server/*bsd: moving from hal support to devd support?

2011-02-15 Thread Cyril Brulebois
Hi Warner, Warner Losh (14/02/2011): > I'm mentioned this several times now: Get me a spec for what Linux > udev provides, and what services are needed, and I'll make a > compatible implementation on FreeBSD. as far as X is concerned, see Dan's reply to my first mail: http://lists.debian.org/d

Re: xorg-server/*bsd: moving from hal support to devd support?

2011-02-13 Thread Cyril Brulebois
Hi Dan, Dan Nicholson (13/02/2011): > As someone who's worked on the udev backend for input devices, what > needs to be provided is pretty simple. thanks! > 1. X needs to know about devices that are already plugged in when > the server starts I haven't looked yet, but probably not the hardest

xorg-server/*bsd: moving from hal support to devd support?

2011-02-13 Thread Cyril Brulebois
Hi FreeBSD/X11 folks, as an occasional GNU/kFreeBSD porter, I've been wondering what's going to happen with hal going away/being unmaintained. I've been pointed to a blog post about Xfce on *BSD [1], where it is mentioned that devd might be used as a udev equivalent. 1. http://gezeiten.org/post/

[PATCH libxkbcommon] Get rid of unneeded include.

2011-01-29 Thread Cyril Brulebois
There's no need for this xlib include: | YACC xkbparse.c | CC xkbparse.lo | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory Signed-off-by: Cyril Brulebois --- src/xkbcomp/xkbparse.y |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/xk

Re: [PATCH libxkbcommon] Check for x11 as well through pkg-config.

2011-01-29 Thread Cyril Brulebois
Gaetan Nadon (29/01/2011): > I recall some readings putting emphasis on the fact that the library > did not depend on libX11. > […] > Maybe this include is not necessary or there is an alternate > solution to not depend on X11. Ooh, thanks. This include indeed seems extraneous, removing it seems

[PATCH libxkbcommon] Check for x11 as well through pkg-config.

2011-01-28 Thread Cyril Brulebois
Otherwise, ./configure returns successfully while xkbparse.lo can fail to build due to a missing include: | YACC xkbparse.c | CC xkbparse.lo | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory Signed-off-by: Cyril Brulebois --- configure.ac |2 +- 1 files changed, 1

Re: [PATCH libxkbcommon] Add prototype for CheckDefaultMap().

2011-01-28 Thread Cyril Brulebois
Cyril Brulebois (28/01/2011): > Those warnings disappear accordingly: > | CC parseutils.lo > | parseutils.c:742: warning: no previous prototype for ‘CheckDefaultMap’ > | CC xkbscan.lo > | xkbscan.l: In function ‘XKBParseString’: > | xkbscan.l:220: warning: impli

[PATCH] Add prototype for CheckDefaultMap().

2011-01-28 Thread Cyril Brulebois
: warning: nested extern declaration of ‘CheckDefaultMap’ Signed-off-by: Cyril Brulebois --- src/xkbcomp/parseutils.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/xkbcomp/parseutils.h b/src/xkbcomp/parseutils.h index 9cf5097..c0a78df 100644 --- a/src/xkbcomp

Re: [PATCH (v5) 0/15] Multitouch take five

2011-01-23 Thread Cyril Brulebois
Daniel Stone (19/01/2011): > Another round of multitouch patches ... this lot addresses all the > review comments from the previous patchset, and seems to work quite > reliably and consistently for me. It's a fairly large change, but the > code is now a fair bit easier to understand and verify.

Re: [PATCH (v5) xinput 1/1] Add experimental multitouch support from XI 2.1

2011-01-23 Thread Cyril Brulebois
Hi Daniel, Daniel Stone (19/01/2011): > + > +if (event->evtype == XI_TouchBegin && event->event != event->child) > +touch_events_received = 0; > +else if (event->evtype == XI_TouchMotion && event->event != event->child > && > + ++touch_events_received == 5) > +

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Cyril Brulebois
Daniel Stone (19/01/2011): > +#ifdef MULTITOUCH > +free(pEvdev->mtMask); > +pEvdev->mtMask = NULL; > +for (i = 0; i < EVDEV_MAXQUEUE; i++) > +free(pEvdev->queue[i].touchMask); > +pEvdev->queue[i].touchMask = NULL; > +#endif Missing {} here. [Thank you, gcc! evdev.c: I

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Cyril Brulebois
Cyril Brulebois (24/01/2011): > Need to check the xi minor version in the server as well: > | evdev.c: In function ‘EvdevPostQueuedEvents’: > | evdev.c:862: warning: implicit declaration of function ‘xf86PostTouchEvent’ > | evdev.c:862: warning: nested extern declaration of ‘xf86Po

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Cyril Brulebois
Daniel Stone (19/01/2011): > From: Chase Douglas > > This multitouch addition only supports slotted MT evdev protocol > devices. Support must be enabled at configure time using > --enable-multitouch. > > Signed-off-by: Chase Douglas I think you're missing a few bits here: | --- a/configure.ac

Re: [PATCH (v5) xserver 7/8] Input: Add initial multitouch support from Xi 2.1

2011-01-23 Thread Cyril Brulebois
Hi Daniel, Daniel Stone (19/01/2011): > --- a/dix/getevents.c > +++ b/dix/getevents.c […] > +int > +GetTouchEvents(EventList *events, DeviceIntPtr pDev, TouchPointInfoPtr ti, > + uint16_t type, uint32_t flags, const ValuatorMask *mask_in) > +{ […] > +transformAbsolute(pDev,

Re: [PATCH (v5) inputproto 1/1] Add touch classes and events, bump to 2.1

2011-01-23 Thread Cyril Brulebois
Daniel Stone (19/01/2011): > @@ -1526,6 +1776,20 @@ EVENTHEADER { type: BYTE > KeyRepeat means that this event is for repeating purposes, and > the physical state of the key has not changed. This is only > valid for KeyPress events. > +Touc

[PATCH xf86-video-vmware] Fix include order.

2011-01-21 Thread Cyril Brulebois
eclaration of function ‘drmOpen’ | vmwaremodule.c:112: error: implicit declaration of function ‘drmClose’ Signed-off-by: Cyril Brulebois --- src/vmwaremodule.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vmwaremodule.c b/src/vmwaremodule.c index a7ba854..2754

[PATCH xf86-input-acecad v2] Fix type for default options.

2011-01-19 Thread Cyril Brulebois
InputDriverRec's default_options is char **, without const. Fix build failure with CFLAGS="-Wall -Werror": | CC acecad.lo | cc1: warnings being treated as errors | acecad.c:132: error: initialization from incompatible pointer type Signed-off-by: Cyril Brulebois --- src/

[PATCH xf86-video-mach64] Remove libc wrappers for malloc, realloc and free.

2011-01-19 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois --- src/aticonfig.c |2 +- src/aticonsole.c | 10 src/atidga.c |2 +- src/atidri.c | 54 +- src/atii2c.c |8 +++--- src/atimach64exa.c |2 +- src

[PATCH xf86-input-acecad] Fix type for default options.

2011-01-19 Thread Cyril Brulebois
patible pointer type Signed-off-by: Cyril Brulebois --- src/acecad.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I know it's not really maintained, but oh well, two-minute fix… diff --git a/src/acecad.c b/src/acecad.c index 6259f21..c5e1611 100644 --- a/src/acecad.c +++ b/src/

Re: [PATCH 7/9] glx: warning fixes

2011-01-14 Thread Cyril Brulebois
dst,src,n)memmove(dst,src,n) > #define __GLX_GET_DOUBLE(dst,src)__GLX_MEM_COPY(&dst,src,8) > #else > #define __GLX_GET_DOUBLE(dst,src)(dst) = *((GLdouble*)(src)) Reviewed-by: Cyril Brulebois KiBi. signature.asc Description: Digital signature ___

Re: [PATCH] xfree86: Fix Xasprinf/Xasprintf typo.

2010-12-30 Thread Cyril Brulebois
Alan Coopersmith (30/12/2010): > No, don't use Xasprintf, use: > http://lists.x.org/archives/xorg-devel/2010-December/017477.html Meh, I'm always wrong when it comes to picking one of two options. > And if you like it, give it a Reviewed-by, so that it doesn't sit > abandoned in the mailing list

Re: [PATCH] Fix asprintf typo in commit d2c42b10

2010-12-30 Thread Cyril Brulebois
s[i].name != NULL; i++) { > if (opts) { > char *s; > - if (Xasprinf(&s, "omit%s", extensionModules[i].name) != -1) { > + if (asprintf(&s, "omit%s", extensionModules[i].name) != -1) { > pointer o; > o

[PATCH] xfree86: Fix Xasprinf/Xasprintf typo.

2010-12-30 Thread Cyril Brulebois
It was introduced during the *printf conversion (d2c42b10). Signed-off-by: Cyril Brulebois --- hw/xfree86/dixmods/extmod/modinit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/dixmods/extmod/modinit.c b/hw/xfree86/dixmods/extmod/modinit.c index 168795d

Re: [PATCH xserver 09/17] Input: Pass sprite instead of device to XYToWindow, make non-static

2010-12-30 Thread Cyril Brulebois
Daniel Stone (28/12/2010): > diff --git a/include/input.h b/include/input.h > index a20f8a0..c1db544 100644 > --- a/include/input.h > +++ b/include/input.h > @@ -533,6 +533,7 @@ void FixUpEventFromWindow(SpritePtr pSprite, >WindowPtr pWin, >W

Re: [PATCH xserver 06/17] Input: Export SpriteRec for use in public API

2010-12-30 Thread Cyril Brulebois
Daniel Stone (28/12/2010): > diff --git a/include/inputstr.h b/include/inputstr.h > index 44de9c4..159d7f6 100644 > --- a/include/inputstr.h > +++ b/include/inputstr.h > @@ -203,6 +203,47 @@ typedef struct _GrabRec { > unsigned char xi2mask[EMASKSIZE][XI2MASKSIZE]; > } GrabRec; > > +

Re: [PATCH 4/4] GLX: DRI2: Fix mismatched-types warning

2010-12-30 Thread Cyril Brulebois
; #ifdef __DRI_USE_INVALIDATE > -&dri2UseInvalidate, > +&dri2UseInvalidate.base, > #endif > NULL > }; Reviewed-by: Cyril Brulebois KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org develo

Re: [PATCH 2/4] XC-Misc: Fix compilation warning

2010-12-30 Thread Cyril Brulebois
+198,8 @@ SProcXCMiscDispatch (ClientPtr client) > } > } > > +extern void XCMiscExtensionInit(INITARGS); > + > void > XCMiscExtensionInit(INITARGS) > { Anyway, this version works well enough for me. Reviewed-by: Cyril Brulebois KiBi. signature.asc Description: Digit

Re: [PATCH modular 11/13] build.sh: regroup script main line together

2010-12-30 Thread Cyril Brulebois
Gaetan Nadon (29/12/2010): > +# perform sanity checks on cmdline args which require arguments > +# arguments: > +# $1 - the option being examined > +# $2 - the argument to the option > +# returns: > +# if it returns, everything is good > +# otherwise it exit's > +required_arg() { > +#

Re: What's an X.Org module? What license can it have? (was: [PATCH util/modular] build.sh: add xrestop)

2010-12-30 Thread Cyril Brulebois
Alan Coopersmith (29/12/2010): > - current exceptions: > openchrome driver (not hosted on fd.o - is it still alive? > developer list seems dead - just one ping since April, no > release in over a year) xcb modules (hosted separately on > fd.o) I have been mailed last wee

Re: xorg-server-1.9.4 release schedule

2010-12-26 Thread Cyril Brulebois
Jeremy Huddleston (14/12/2010): > I've updated the X.org calendar for the xorg-server-1.9.4 release > schedule. […] 1.10.0 is scheduled for release in mid February, so > we'll likely have just one more release (1.9.5) in mid march. Quick question about packaging: What do you think would be more u

Re: [PATCH:libICE] Fix stdio.h include for asprintf.

2010-12-19 Thread Cyril Brulebois
rors. > +AC_USE_SYSTEM_EXTENSIONS > + > # Require xorg-macros minimum of 1.10 for DocBook XML documentation > m4_ifndef([XORG_MACROS_VERSION], >[m4_fatal([must install xorg-macros 1.10 or later before running > auto Reviewed-by: Cy

[PATCH:libICE] Fix stdio.h include for asprintf.

2010-12-19 Thread Cyril Brulebois
: implicit declaration of function ‘asprintf’ | process.c:672: error: nested extern declaration of ‘asprintf’ | make[2]: *** [process.lo] Error 1 Signed-off-by: Cyril Brulebois --- src/process.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/process.c b/src/proce

[PATCH xf86-video-nv] Replace xf86CrtcSetMode() calls with xf86CrtcSet().

2010-12-12 Thread Cyril Brulebois
licit declaration of function ‘xf86CrtcSetMode’ Signed-off-by: Cyril Brulebois --- Not that I really care about -nv anyway, it happened to red-light my tinderbox. Also, this means one is going to need a version of the server with the appropriate symbol… Not sure it warrants bumping the needed versi

Re: [PATCH libxkbcommon 6/6] config: remove PKG_PROG_PKG_CONFIG test

2010-12-07 Thread Cyril Brulebois
Hi Gaetan, Gaetan Nadon (07/12/2010): > The output is sufficient to locate the problem. sure. > It is not possible, or very difficult, to not have pkg-config > installed as the whole desktop and countless other software depends > on it. I call it trivial, but maybe that's because I maintain mi

Re: [PATCH xrandr] xrandr: dump configuration in parsable format

2010-12-07 Thread Cyril Brulebois
Hi Stefan. Stefan Tomanek (08/11/2010): > - printf ("%s %s", output_info->name, > connection[output_info->connection]); > + printf ( dump ? "output %s\n" : "%s %s", output_info->name, > connection[output_info->connection]); Looks like a missing "%s" in the first string? Mraw,

[PULL] Warning fixes, *LookupID* riddance, logic fix.

2010-12-07 Thread Cyril Brulebois
The following changes since commit 780754050bc9cb1489f92a2a890ab5665e3e6358: Fix GLX_LIBS vs. DMX_LIBS order. (2010-12-07 09:24:16 -0800) are available in the git repository at: git://git.debian.org/users/kibi/pkg-xorg/xorg-server.git master Cyril Brulebois (9): Fix missing include

Re: [PULL modular] Assorted updates.

2010-12-07 Thread Cyril Brulebois
Chris Wilson (07/12/2010): > I use it and the xorg.modules on my boxes to rebuild the stack. > > But I think Cyril just volunteered to maintain it. ;-) > -Chris Works for me as long as I get some reviewers to help me (and that's needed, see the reviews needed for my 3 little patches). ;) Mraw,

[PULL modular] Assorted updates.

2010-12-07 Thread Cyril Brulebois
ry at: git://git.debian.org/users/kibi/pkg-xorg/modular.git master Cyril Brulebois (3): jhbuild: Pass --enable-nouveau-experimental-api to libdrm. jhbuild: Support skipping packages on a per-architecture basis. jhbuild: Add makedepend, needed for mesa. arch.skip|

Re: [PULL updated] XQuartz: disabling OSX screensaver, RandR regression, and some warning cleanups

2010-12-07 Thread Cyril Brulebois
Hi, Keith Packard (06/12/2010): > On Fri, 03 Dec 2010 17:34:22 -0800, Jeremy Huddleston > wrote: > > > Jeremy Huddleston (4): > >XQuartz: Disable the Mac OS X screensaver when in full screen > > mode > >XQuartz: Remove one more backing store leftover > >XQuartz: Clean

Re: RandR 1.4 X server patch series

2010-12-05 Thread Cyril Brulebois
Hi, Keith Packard (05/12/2010): > Here's the full patch series to add RandR 1.4 functionality to the X > server. This is the order in which I propose to merge the patches to > the X server, to make it possible to bisect the X server in the > future, I've added all of the functionality before addi

Re: [PATCH 1/2] Whitespace cleanups in randrproto.txt

2010-12-05 Thread Cyril Brulebois
Keith Packard (05/12/2010): > This just eliminates some ugly space/tab combos Reviewed-by: Cyril Brulebois Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

Re: [PATCH 2/6] randr: Add sprite position transforms

2010-12-05 Thread Cyril Brulebois
Keith Packard (05/12/2010): > This implements sprite position transformations. Sprite image > transforms are passed all the way to the DDX layer, but the images are > not yet manipulated before being passed to the drivers. From that patch, your series doesn't build here: | CC rrsprite.lo |

Re: [PATCH mutouch 10/10 v2] Support input ABI 12

2010-12-05 Thread Cyril Brulebois
Peter Hutterer (06/12/2010): > Signed-off-by: Peter Hutterer Reviewed-by: Cyril Brulebois Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel I

Re: [PATCH elographics 7/7 v2] Support input ABI 12

2010-12-05 Thread Cyril Brulebois
Peter Hutterer (06/12/2010): > Signed-off-by: Peter Hutterer Reviewed-by: Cyril Brulebois Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel I

Re: [PATCH fpit 0/8] cleanup and ABI 12 support

2010-12-04 Thread Cyril Brulebois
Peter Hutterer (02/12/2010): > untested, I don't have a device. a few cleanups, the usual ones, and > then the standard changes for ABI 12 support. (untested as well) For the whole series: Reviewed-by: Cyril Brulebois Like other ones: 1-7/8: builds fine against 1.9 8/8 :

Re: [PATCH elographics 0/7] cleanup and abi 12 support

2010-12-04 Thread Cyril Brulebois
Peter Hutterer (03/12/2010): > as subject, untested, no device. (me too) Patch 1 to 6: applied incrementally, builds successfully against 1.9 → Reviewed-by: Cyril Brulebois Patch 7: fails against 1.9, needs an ABI check to bail out cleanly: | xf86Elo.c: In function ‘xf86EloCont

Re: [PATCH mutouch 00/10] cleanup and ABI 12 support

2010-12-04 Thread Cyril Brulebois
ls due to a missing ABI check. And since we can't do much more (build-)testing since building against master fails until the last patch is applied, I'm going to Reviewed-by: Cyril Brulebois the first 9 patches. Mraw, KiBi. signature.asc Descripti

Re: [PATCH elographics 7/7] Support input ABI 12

2010-12-03 Thread Cyril Brulebois
Peter Hutterer (03/12/2010): > -9500 /* max_res */); > +9500 /* max_res */, > +Absolute); Probably the same issue as for mutouch, you probably want to support *and require* ABI 12, like you did for other drivers

Re: [PATCH mutouch 10/10] Support input ABI 12

2010-12-03 Thread Cyril Brulebois
Hi Peter. Peter Hutterer (03/12/2010): > Signed-off-by: Peter Hutterer > --- > src/xf86MuTouch.c | 90 +++- > 1 files changed, 33 insertions(+), 57 deletions(-) > > diff --git a/src/xf86MuTouch.c b/src/xf86MuTouch.c > index 4312256..97d8843 100

Re: [PATCH 1/3] Fix missing include.

2010-12-03 Thread Cyril Brulebois
Cyril Brulebois (11/11/2010): > diff --git a/include/os.h b/include/os.h > index efa202c..fb10435 100644 > --- a/include/os.h > +++ b/include/os.h > @@ -51,6 +51,7 @@ SOFTWARE. > > #include "misc.h" > #include > +#include > > #define SCREEN_

Re: [PATCH 1/4] Fix dmx linking.

2010-12-03 Thread Cyril Brulebois
Cyril Brulebois (12/11/2010): > Turn glxproxy.a into glxproxy.la, and add an explicit dependency on dix. > > Signed-off-by: Cyril Brulebois Could I please get a review for one of those patches? [PATCH 1/4] Fix GLX_LIBS vs. DMX_LIBS order. [PATCH 1/4] Fix dmx linking. It'

[PATCH] Fix screen number checks.

2010-12-01 Thread Cyril Brulebois
screenInfo.numScreens is not a valid screen number, they go from 0 to numScreens - 1. Signed-off-by: Cyril Brulebois --- hw/dmx/glxProxy/glxcmds.c |6 +++--- hw/dmx/glxProxy/glxcmdsswap.c |2 +- hw/kdrive/ephyr/ephyrdriext.c |2 +- 3 files changed, 5 insertions(+), 5 deletions

[PATCH:libxmu] Fix missing const qualifier.

2010-11-27 Thread Cyril Brulebois
error: passing argument 2 of ‘XInternAtoms’ from incompatible pointer type | /home/kibi/xorg-build/include/X11/Xlib.h:1549: note: expected ‘const char **’ but argument is of type ‘char **’ Signed-off-by: Cyril Brulebois --- src/Atoms.c |2 +- src/EditresCom.c |2 +- 2 files change

[PATCH:libxt] Fix missing const qualifier.

2010-11-25 Thread Cyril Brulebois
f ‘XInternAtoms’ from incompatible pointer type | /home/kibi/xorg-build/include/X11/Xlib.h:1549: note: expected ‘const char **’ but argument is of type ‘char **’ Signed-off-by: Cyril Brulebois --- src/Selection.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Se

Re: [PATCH keyboard] Adjust to input ABI 12.

2010-11-17 Thread Cyril Brulebois
Chase Douglas (17/11/2010): > > +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) < 12 > > +static int > > +NewKbdPreInit(InputDriverPtr drv, InputInfoPtr pInfo, int flags) > > Has this been test built against < 12? I think you're missing a > semicolon here. Indeed, and it builds fine once the semicolon ad

Re: [PATCH] xfree86: Fix rotation of 2-color non-interleaved cursor images

2010-11-17 Thread Cyril Brulebois
Cyril Brulebois (17/11/2010): > Aaron Plattner (16/11/2010): > > Could somebody with hardware that sets SOURCE_MASK_INTERLEAVE > > (e.g. Intel) please give this patch a try and verify that it > > doesn't break rotated cursors? > > Sounds OK here. For those w

Re: [PATCH] xfree86: Fix rotation of 2-color non-interleaved cursor images

2010-11-16 Thread Cyril Brulebois
Aaron Plattner (16/11/2010): > Could somebody with hardware that sets SOURCE_MASK_INTERLEAVE (e.g. > Intel) please give this patch a try and verify that it doesn't break > rotated cursors? Sounds OK here. Mraw, KiBi. signature.asc Description: Digital signature

[PATCH modular 2/3 (v3)] jhbuild: Support skipping packages on a per-architecture basis.

2010-11-16 Thread Cyril Brulebois
Thanks to an execfile() in jhbuildrc, allow managing packages to be skipped on this or that architecture to be listed in an external file. Signed-off-by: Cyril Brulebois --- arch.skip | 24 jhbuildrc |8 +++- 2 files changed, 31 insertions(+), 1 deletions

Re: [PATCH modular 2/3 (v2)] jhbuildrc: Support skipping packages on a per-architecture basis.

2010-11-16 Thread Cyril Brulebois
Jon TURNEY (16/11/2010): > It's probably best to append to skip here, rather than set it, > otherwise confusion could occur if skip had already been set in > jhbuildrc? Agreed. Testing shows that skip exists even if it isn't previously declared in jhbuildrc, so calling .extend() on it seems to wo

Re: [PATCH] XKB: cache xkbcomp output for fast start-up v.1 for 1.7.2

2010-11-15 Thread Cyril Brulebois
Thierry Vignaud (16/11/2010): > The patch stores the cached files inside /usr/share/X11/xkb/compiled. That sounds wrong, FHS would rather point below /var/cache (data which can be trashed anytime, and which is going to be generated again when needed). Mraw, KiBi. signature.asc Description: Dig

Re: build.sh build order for mesa and makedepend

2010-11-15 Thread Cyril Brulebois
Cyril Brulebois (15/11/2010): > pending: http://lists.x.org/archives/xorg-devel/2010-November/015413.html Err, sorry, that was the jhbuild part. Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org developm

Re: build.sh build order for mesa and makedepend

2010-11-15 Thread Cyril Brulebois
Hi Pat, Pat Kane (15/11/2010): > Mesa needs makedepend, but util/makedepend is done much later in the > build script. pending: http://lists.x.org/archives/xorg-devel/2010-November/015413.html Mraw, KiBi. signature.asc Description: Digital signature

Re: [RFC XI 2.1 - inputproto] Add touch classes and events, bump to 2.1

2010-11-15 Thread Cyril Brulebois
Chase Douglas (15/11/2010): > > JFTR: to apply it to master, s/2.0/2.0.1/ in the removed line for > > configure.ac (see below), that's all: > >> -AC_INIT([InputProto], [2.0], > >> [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg]) > >> +AC_INIT([InputProto], [2.1], > >> [https://bugs.fre

Re: [PATCH] Build libxf86config with -fPIC.

2010-11-14 Thread Cyril Brulebois
Peter Hutterer (15/11/2010): > AFAIK, Debian doesn't package it at all. (I'm still quite new in its X packaging team, but that still) sounds about right. Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org devel

[PATCH modular 1/3 (v2)] jhbuild: Pass --enable-nouveau-experimental-api to libdrm.

2010-11-14 Thread Cyril Brulebois
This option is needed to build xf86-video-nouveau, but is disabled by default in libdrm. Let's make jhbuild able to build xf86-video-nouveau by default. Signed-off-by: Cyril Brulebois --- jhbuildrc |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/jhbuildrc b/jhbu

[PATCH modular 2/3 (v2)] jhbuildrc: Support skipping packages on a per-architecture basis.

2010-11-14 Thread Cyril Brulebois
Thanks to an execfile() in jhbuildrc, allow managing packages to be skipped on this or that architecture to be listed in an external file. Signed-off-by: Cyril Brulebois --- arch.skip | 28 jhbuildrc | 11 ++- 2 files changed, 38 insertions(+), 1

[PATCH modular] jhbuild: Mark xf86-video-sunbw2 as unmaintained.

2010-11-14 Thread Cyril Brulebois
See X.Org Bug 26343 <http://bugs.freedesktop.org/show_bug.cgi?id=26343> Signed-off-by: Cyril Brulebois --- xorg.modules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xorg.modules b/xorg.modules index 227371f..3eb3cbd 100644 --- a/xorg.modules +++ b/xorg.m

Re: [PATCH modular 2/3] jhbuildrc: Support skipping packages on a per-architecture basis.

2010-11-14 Thread Cyril Brulebois
Jon TURNEY (14/11/2010): > I think sunbw2 can just be moved to xorg-unmaintained-broken-drivers > in the xorg.modules file. It's been taken out of build.sh some time > ago (see [1]) > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=26343 Yeah, I saw that, but I didn't notice the unmaintained

Re: [PATCH modular 1/3] jhbuildrc: Pass --enable-nouveau-experimental-api to libdrm.

2010-11-14 Thread Cyril Brulebois
Jon TURNEY (14/11/2010): > Might I suggest the alternate syntax to be consistent with the style > of the reset of the file, and I believe we need to take steps to > appply any setting of autogenargs (e.g. setting --cache-file), e.g. > > module_autogenargs['libdrm'] = autogenargs + ' > --enable-n

Re: [PATCH modular 2/3] jhbuildrc: Support skipping packages on a per-architecture basis.

2010-11-14 Thread Cyril Brulebois
Dan Nicholson (14/11/2010): > Why not just have it set skip since you already have the comment to > use append() to add more packages? Then you don't have to worry > about arch_skip being deleted. Right, not sure why I didn't do that in the end. I guess I planned to check it was possible to refin

Re: [PATCH] Take width into account when choosing default mode

2010-11-14 Thread Cyril Brulebois
Hi, some comments about the form follow. Thierry Vignaud (14/11/2010): > int mm_height; > +int mm_width; > > mm_height = output->mm_height; > +mm_width = output->mm_width; > if (!mm_height) > mm_height = (768 * 25.4) / DEFAULT_

Re: Broken make check with 1.9.3 rc1

2010-11-14 Thread Cyril Brulebois
Cyril Brulebois (14/11/2010): > Now I'm getting an other issue in the second series of tests, I'm > tracking it (apparently was in 1.9.2 as well, not sure why I missed > it — will mail once I figured it out). False alarm, leftovers from my testing Chase's input stuff, so

Re: Broken make check with 1.9.3 rc1

2010-11-14 Thread Cyril Brulebois
Julien Cristau (14/11/2010): > IIRC 290af0418f8c94355e42ad81aa7779b90e173fc9 fixed that on master. Confirmed, fixes it on server-1.9-branch as well. Now I'm getting an other issue in the second series of tests, I'm tracking it (apparently was in 1.9.2 as well, not sure why I missed it — will mai

Broken make check with 1.9.3 rc1

2010-11-14 Thread Cyril Brulebois
Hi Jeremy, looks like 1.9.3 rc1 doesn't pass “make check”: | /dix/input/init-valuators: OK | /dix/input/event-core-conversion: [dix] EventToCore: Not implemented yet | [dix] EventToCore: Not implemented yet | [dix] EventToCore: Not implemented yet | ** | ERROR:../../test/input.c:192:dix_event_to_c

[PATCH modular 2/3] jhbuildrc: Support skipping packages on a per-architecture basis.

2010-11-13 Thread Cyril Brulebois
ild from complaining about unknown keys: | I: unknown keys defined in configuration file: foo Signed-off-by: Cyril Brulebois --- jhbuildrc |9 + xorg.modules.skip | 29 + 2 files changed, 38 insertions(+), 0 deletions(-) create mode 100644 xorg.modu

[PATCH modular 3/3] jhbuild: Add makedepend, needed for mesa.

2010-11-13 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois --- xorg.modules |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xorg.modules b/xorg.modules index 616fd6e..227371f 100644 --- a/xorg.modules +++ b/xorg.modules @@ -37,6 +37,13

[PATCH modular 1/3] jhbuildrc: Pass --enable-nouveau-experimental-api to libdrm.

2010-11-13 Thread Cyril Brulebois
This option is needed to build xf86-video-nouveau, but is disabled by default in libdrm. Let's make jhbuild able to build xf86-video-nouveau by default. Signed-off-by: Cyril Brulebois --- jhbuildrc |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/jhbuil

Re: [PATCH 2/2] XQuartz: Fix make distcheck

2010-11-13 Thread Cyril Brulebois
Jeremy Huddleston (13/11/2010): > - $(RM) -rf > $(DESTDIR)$(APPLE_APPLICATIONS_DIR)/$(APPLE_APPLICATION_NAME).app > + $(RM) -rf > $(DESTDIR)$(APPLE_APPLICATIONS_DIR)/$(APPLE_APPLICATION_NAME).app/Contents/{Resources,Info.plist,PkgInfo} You're relying on shell expansion of “foo/{bar

<    1   2   3   4   5   >