Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Daniel Drake
On Fri, Apr 20, 2012 at 1:21 AM, Benjamin Herrenschmidt wrote: > So Peter and I have been discussing a problem I observed on my brand new > ThinkPad X220 and it's multitouch "clickpad". I've been digging a bit > more today and bisected the regression to: > > commit 7968a5dd492ccc38345013e534ad4c8d

Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-21 Thread Daniel Drake
On Fri, Apr 20, 2012 at 6:16 PM, Benjamin Herrenschmidt wrote: >> It looks we lost a condition in synaptics_set_advanced_gesture_mode(). >> It used to be: >> >> >>       if (!(SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) || >>                       SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c))) >>            

[PATCH evtest] Add evstate tool for evdev state querying

2011-07-12 Thread Daniel Drake
evstate is a small utility that queries evdev state of a specific key, switch, button, LED or sound event. This is useful in programs such as powerd (http://wiki.laptop.org/go/Powerd) which need to query things like the state of the laptop lid switch from shell code. Signed-off-by: Daniel Drake

Re: [PATCH evtest] Add evstate tool for evdev state querying

2011-07-14 Thread Daniel Drake
On 13 July 2011 00:12, Peter Hutterer wrote: > I think I'd prefer it merged into evdev, simply because we have all the > lookup tables there already. Which allows a state query for "Key Comma" > instead of the numbers, making it a nicer interface IMO. > > Ideally we could also make it parse KEY_FO

[PATCH evtest 1/2] Remove custom event names

2011-07-14 Thread Daniel Drake
As suggested by Dmitry Torokhov, drop the textual name of the individual state bits. We already have the name of the constant - use that instead. Also mark the name lookup tables as static const data. --- evtest.c | 676 +++--- 1 files chang

[PATCH evtest 2/2] Add one-shot query functionality

2011-07-14 Thread Daniel Drake
left unchanged and is still activated by default. New usage modes are explained in the man page. Signed-off-by: Daniel Drake --- evtest.c | 267 evtest.txt | 31 ++- 2 files changed, 257 insertions(+), 41 deletions(-) diff --git

Re: [PATCH evtest 2/2] Add one-shot query functionality

2011-07-15 Thread Daniel Drake
On 15 July 2011 07:15, Peter Hutterer wrote: > On Thu, Jul 14, 2011 at 05:53:17PM +0100, Daniel Drake wrote: >> Add functionality to query evdev state of a specific key, switch, button, >> LED or sound event. This is useful in programs such as powerd >> (http://wiki.laptop

[PATCH evtest 1/2] Factor out capture setup code into its own function

2011-07-16 Thread Daniel Drake
This is in preparation for a followup patch which adds a one-shot query mode. Signed-off-by: Daniel Drake --- evtest.c | 68 +++-- 1 files changed, 35 insertions(+), 33 deletions(-) diff --git a/evtest.c b/evtest.c index 5cc8505

[PATCH evtest 2/2] Add one-shot query functionality

2011-07-16 Thread Daniel Drake
left unchanged and is still activated by default. New usage modes are explained in the man page. Signed-off-by: Daniel Drake --- evtest.c | 203 ++-- evtest.txt | 33 -- 2 files changed, 226 insertions(+), 10 deletions(-) diff

Re: [PATCH evtest 2/2] Add one-shot query functionality

2011-07-20 Thread Daniel Drake
On 17 July 2011 13:59, walter harms wrote: > did you consider NULL as terminater for the query_modes array ? Apples vs oranges, in my opinion. I prefer the approach taken in the patch. Is there a clear argument to go with the NULL terminator? > When you want to print an error you would be more v

[PATCH evtest v3] Add one-shot query functionality

2011-07-20 Thread Daniel Drake
left unchanged and is still activated by default. New usage modes are explained in the man page. Signed-off-by: Daniel Drake --- evtest.c | 248 +--- evtest.txt | 33 +++- 2 files changed, 266 insertions(+), 15 deletions(-) diff --git

Re: [PATCH evtest v3] Add one-shot query functionality

2011-07-23 Thread Daniel Drake
On 22 July 2011 00:55, Peter Hutterer wrote: > thanks! merged with one change: strcasecmp → strcmp. I'm not sure why we'd > need to accept both "EV_KEY" and "ev_key". I think it'd cause confusion for > little benefit but you can convince me otherwise before I push it on my > Monday :) Sounds fine

Re: [PATCH evtest v3] Add one-shot query functionality

2011-08-31 Thread Daniel Drake
On Mon, Aug 29, 2011 at 5:19 AM, Peter Hutterer wrote: > Patches pushed, thanks. >   8a10dfe..4479437  master -> master Thanks Peter. We're now ready to start using this in our software. Would it be possible to get a new release made? If you do the tarball release, I'm happy to do the Fedora pack

Re: ARMSOC X11 plugin issues

2016-04-04 Thread Daniel Drake
io/2013/02/01/new-xf86-video-sunxifb-ddx-driver.html > > As far as I know, Daniel Drake had some fixes for xf86-video-armsoc, > but I have no idea which of the armsoc forks is the most up to date > right now. Yes, I have another approach: https://github.com/endlessm/xf86-video-armsoc/commit/d

Re: [PATCH] dri2: work around broken DRI2CreateDrawable callers

2015-02-23 Thread Daniel Drake
37be778e2c13dc26fa6cd0f6ecd6f227c3 Mon Sep 17 00:00:00 2001 From: Daniel Drake Date: Fri, 7 Feb 2014 08:29:38 -0600 Subject: [PATCH] dri2: work around broken DRI2CreateDrawable callers The state of the DRI2CreateDrawable request is a little unclear. dri2proto.txt states that it was dropped in versio

[PATCH] Allow system call restarts upon signal interruption

2015-05-12 Thread Daniel Drake
The X server frequently deals with SIGIO and SIGALRM interruptions. If process execution is inside certain blocking system calls when these signals arrive, e.g. with the kernel blocked on a contended semaphore, the system calls will be interrupted. Some system calls are automatically restartable (

Re: [PATCH] Allow system call restarts upon signal interruption

2015-05-13 Thread Daniel Drake
On Tue, May 12, 2015 at 8:18 PM, Michel Dänzer wrote: > On 13.05.2015 07:39, Daniel Drake wrote: >> The X server frequently deals with SIGIO and SIGALRM interruptions. >> If process execution is inside certain blocking system calls >> when these signals arrive, e.g. with

[PATCH] Keep SIGALRM restart flag after Popen

2015-05-20 Thread Daniel Drake
. Signed-off-by: Daniel Drake --- os/utils.c | 49 ++--- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/os/utils.c b/os/utils.c index 7fd395b..47b0b80 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1228,14 +1228,15 @@ SmartScheduleTimer(int

xf86-video-armsoc, Mali and exynos4

2013-11-12 Thread Daniel Drake
Hi Tom, I'm wondering if you have a couple of minutes to update us on the status and direction of xf86-video-armsoc. I'm running it here on Exynos4 (Mali-400) with exynos_drm, but as you would expect, the currently available Mali GLES/EGL binaries don't work with it. Do you know if there are comp

Re: xf86-video-armsoc, Mali and exynos4

2013-11-12 Thread Daniel Drake
On Tue, Nov 12, 2013 at 3:49 PM, Luc Verhaegen wrote: > Fwiw, I am happily using a derivative of the standard fbdev driver on my > sunxi and exynos based devices. Namely fbturbo which is being done by > Siarhei Siamashka. For sunxi, it includes some knowledge about the > strangely implemented disp

Re: xf86-video-armsoc, Mali and exynos4

2013-11-14 Thread Daniel Drake
On Wed, Nov 13, 2013 at 7:10 PM, Siarhei Siamashka wrote: > I was considering to get xrandr working at least on sunxi hardware. > So that dual monitor support and screen resolution switching at > runtime works in X11 desktop in a standard way transparently for the > applications and for the user.

Re: xf86-video-armsoc, Mali and exynos4

2013-11-14 Thread Daniel Drake
On Thu, Nov 14, 2013 at 7:20 AM, Luc Verhaegen wrote: > On Thu, Nov 14, 2013 at 06:57:37AM -0600, Daniel Drake wrote: >> Yes, it works reasonably well. Not perfect, I did catch a hang, and >> 800x600 doesn't work quite right, but I think that is fixable. I'd >> defi

[PATCH] dri2: work around broken DRI2CreateDrawable callers

2014-02-07 Thread Daniel Drake
nsure that we have allocated the relevant internal DRI2 private data, and return. Signed-off-by: Daniel Drake --- hw/xfree86/dri2/dri2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 729a323..4eba896 100644 --- a/hw/xfree86/dri2/d

WebKit failing to find GLXFBConfig, confusion around fbconfigs + swrast

2018-08-27 Thread Daniel Drake
Hi, I'm looking at a strange issue which has taken me across WebKit, glvnd, mesa and X, and has left me somewhat confused regarding if I've found any real bugs here, or just expected behaviour (my graphics knowledge doesn't go far beyond the basics). The issue: Under xserver-1.18 + mesa-18.1, on

Re: WebKit failing to find GLXFBConfig, confusion around fbconfigs + swrast

2018-09-10 Thread Daniel Drake
On Fri, Sep 7, 2018 at 7:05 AM, Jasper St. Pierre wrote: > So this is a fun question and took me a day or two of random spelunking. > Let's start with the last question, since it gives us a good starting point: > why are the PCI IDs necessary? > > The answer is "DRI2 needs to figure out the driver

[PATCH] Xi: Don't check for TOUCH_END, it's never set

2012-09-07 Thread Daniel Drake
first time (since X then behaved as if the mouse button was held down all the time). Signed-off-by: Daniel Drake --- Xi/exevents.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/Xi/exevents.c b/Xi/exevents.c index 494d07e..6ed4991 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c @@ -949,8 +

Re: [PATCH] Xi: Don't check for TOUCH_END, it's never set

2012-09-10 Thread Daniel Drake
On Fri, Sep 7, 2012 at 8:42 PM, Chase Douglas wrote: > I could have sworn this had been removed by now. I remember deleting > it at one point during one of my debugging sessions and being > surprised it was still there at that point. > > I agree that this should be removed. The question is: will t

[PATCH 1/2] server/xi2: Fix N-Trig-MultiTouch file access

2012-10-01 Thread Daniel Drake
These tests were failing because the filenames were wrong. --- tests/server/xi2.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/server/xi2.cpp b/tests/server/xi2.cpp index 9fd7713..c1ec943 100644 --- a/tests/server/xi2.cpp +++ b/tests/server/xi2.cpp @@ -65,7 +

[PATCH 2/2] server/xi2: add touchscreen mouse pointer emulation test

2012-10-01 Thread Daniel Drake
Add a test case based on the bug fixed by http://lists.x.org/archives/xorg-devel/2012-September/033595.html --- tests/server/xi2.cpp | 131 +++ 1 file changed, 131 insertions(+) diff --git a/tests/server/xi2.cpp b/tests/server/xi2.cpp index c1ec943.

Re: [PATCH] Xi: Don't check for TOUCH_END, it's never set

2012-10-06 Thread Daniel Drake
On Thu, Sep 27, 2012 at 8:50 PM, Peter Hutterer wrote: > xserver branches are only for the respective maintainers (keith for master). > I've picked your patch up and will send a pull request out soon. Please do > try to get a test for this though. Thanks - this is now in master. Could it be appli

[PATCH libSM] Avoid infinite loop when SM rejects RegisterClient

2012-11-12 Thread Daniel Drake
. However, libSM currently has logic to retry with a NULL previous ID if the SM rejects a registration - and this behaviour will loop. Avoid this infinite loop by only retrying with a NULL previous ID when the previous attempt used a non-NULL ID. Signed-off-by: Daniel Drake --- src/sm_client.c

[PATCH] Xi: use correct touch event type for pointer emulation

2013-04-02 Thread Daniel Drake
In Sugar we are seeing a problem where after using the touchscreen to select certain UI elements (through a quick touch and release), pointer emulation gets confused, and further movements of the mouse happen as if the left mouse button is held down on the virtual core pointer (it is not). What se

Bad caching of the scratch pixmap

2013-04-13 Thread Daniel Drake
Hi, At http://dev.laptop.org/ticket/12542 we are seeing a problem where on OLPC XO-1.75 and XO-4, after rotating the screen with RandR, pixmaps often get drawn badly. e.g. launching the following via xinit shows the problem: #!/bin/bash xrandr -o left xrandr -o normal

Re: Bad caching of the scratch pixmap

2013-04-16 Thread Daniel Drake
Hi Chris, Thanks a lot for the quick response. On Sat, Apr 13, 2013 at 11:14 AM, Chris Wilson wrote: > Given the same fix works, it does sound like a very similar issue. The > difference is that the DDX is under control of the creating the scratch > pixmap in your case and should be well aware o

Re: Bad caching of the scratch pixmap

2013-04-16 Thread Daniel Drake
On Tue, Apr 16, 2013 at 11:22 AM, Michel Dänzer wrote: > On Die, 2013-04-16 at 10:54 -0600, Daniel Drake wrote: >> On Sat, Apr 13, 2013 at 11:14 AM, Chris Wilson >> wrote: >> > Given the same fix works, it does sound like a very similar issue. The >> > di

Re: Bad caching of the scratch pixmap

2013-04-17 Thread Daniel Drake
On Wed, Apr 17, 2013 at 1:34 AM, Michel Dänzer wrote: > Possibly. E.g. I see that mrvlPrepareAccess() returns TRUE but doesn't > set pPix->devPrivate.ptr. Easy enough to add:pPix->devPrivate.ptr = pPixSurf->pVirtAddr; However, PrepareAccess() doesn't get called on this pixmap. Lets see why:

Re: Bad caching of the scratch pixmap

2013-04-19 Thread Daniel Drake
On Tue, Apr 16, 2013 at 10:54 AM, Daniel Drake wrote: > I found that the same issue affected the geode driver in the past: > https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-geode/+bug/377929/comments/24 > and the fix chosen there (follow the link to the patch) is to make &

EXA composite ops don't report damage

2013-05-11 Thread Daniel Drake
Hi, I am investigating a bug in AbiWord where when the screen is rotated, newly inputted text does not appear in the document. This is affecting OLPC XO. The graphics driver (http://dev.laptop.org/git/projects/xf86-video-dove/) implements screen rotation via EXA, i.e. it supports composite operat

Re: EXA composite ops don't report damage

2013-05-13 Thread Daniel Drake
On Mon, May 13, 2013 at 3:15 AM, Michel Dänzer wrote: > The wrapping order is supposed to be the other way around, i.e. the > Damage layer is supposed to call down to EXA. I suspect you may need to > switch the order in which the driver initializes EXA vs. the Damage > layer, or something along th

Xv and alignment requirements

2013-05-30 Thread Daniel Drake
Hi, I am working with a vivante graphics controller in a Marvell ARM SoC (OLPC XO-4). We are having trouble playing back some I420 video resolutions with Xv. The X driver is open source, unfortunately it calls into a proprietary library to generate commands that are then sent to a GPL kernel modu

Re: Xv and alignment requirements

2013-05-31 Thread Daniel Drake
On Thu, May 30, 2013 at 4:31 PM, Daniel Stone wrote: > No bigs - pretty much all hardware has this requirement! The > QueryImageAttributes Xv hook lets you specify what the pitch has to be > for each plane, so just round up from the width and set it there. > Clients do (and have to) respect that.