Hi,
Looks good to me, although I thought this was handled at the callsites. I
guess some callsites have been added or changed that pass in the special
ID's.
Acked-by: Eamon Walsh e...@eamonwalsh.com
On Tue, Jun 12, 2012 at 9:49 AM, Richard Haines
richard_c_hai...@btinternet.com wrote
Reviewed-by: Eamon Walsh ewa...@tycho.nsa.gov
This should go as a bugfix on release branches; I'll take care of that after it
goes in. Thanks!
On 01/20/2011 11:01 PM, Adam Jackson wrote:
M_DRAWABLE_PIXMAP is the lookup mask to dixLookupDrawable, and _not_ the
type value in the drawable
On 08/23/2010 04:04 PM, Eamon Walsh wrote:
Selection objects were not being allocated with privates, and both
objects had a stray statement that zeroed out the devPrivates field.
Signed-off-by: Eamon Walsh ewa...@tycho.nsa.gov
Reported-by: Justin Mattock justinmatt...@gmail.com
---
dix
The SELinux extension does store a security label in the screen
devPrivates. Fixes crash caused by overwriting another private.
Signed-off-by: Eamon Walsh ewa...@tycho.nsa.gov
Reported-by: Justin Mattock justinmatt...@gmail.com
---
dix/privates.c |1 +
1 files changed, 1 insertions(+), 0
the window's
security context be different from the client itself, but for damage
resources it should be fine.
--
Eamon Walsh
National Security Agency
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info
Selection objects were not being allocated with privates, and both
objects had a stray statement that zeroed out the devPrivates field.
Signed-off-by: Eamon Walsh ewa...@tycho.nsa.gov
Reported-by: Justin Mattock justinmatt...@gmail.com
---
dix/property.c |1 -
dix/selection.c |3 +--
2
On 07/05/2010 09:21 AM, Vignatti Tiago (Nokia-MS/Helsinki) wrote:
On Sat, Jul 03, 2010 at 10:25:34PM +0200, ext Eamon Walsh wrote:
On 06/21/2010 09:52 AM, Tiago Vignatti wrote:
Last I remember, we want all possible build options set as on by default
just
to be sure the code
XACE enabled by default without any
hook backend? This is how the server is being compiled now by default.
As long as the in-tree security extensions are disabled by default I
think it should be OK to disable XACE by default as well.
--
Eamon Walsh
National Security Agency
-client-index,
Reviewed-by: Eamon Walsh ewa...@tycho.nsa.gov
--
Eamon Walsh
National Security Agency
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg
Reviewed-by: Eamon Walsh ewa...@tycho.nsa.gov
On 05/08/2010 07:39 PM, Jamey Sharp wrote:
In commit 42d6112ec21949a336ee8b34469f2695273ee2d6, Eamon changed
dixChangeGC to require DixUseAccess on any GCFont XID. I think
doPolyText needs to require the same level of access. Otherwise
Reviewed-by: Eamon Walsh ewa...@tycho.nsa.gov
On 05/09/2010 01:56 AM, Jamey Sharp wrote:
Otherwise we can't check that the XIDs this GC is being initialized with
are accessible to this client.
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Eamon Walsh ewa...@tycho.nsa.gov
---
dix/gc.c
(ABI_VIDEODRV_VERSION) 4)
#if LEO_OLDPRIV
#define LeoGetGCPrivate(g) (g)-devPrivates[LeoGCPrivateIndex].ptr
#else
#define LeoGetGCPrivate(g) dixLookupPrivate((g)-devPrivates,
LeoGCPrivateIndex)
#endif
So a new rev of devPrivates would involve adding another clause to these
ifdefs.
--
Eamon Walsh
of the privates list becomes part of the
server ABI.
--
Eamon Walsh
National Security Agency
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
and change the SELinux code as required.
--
Eamon Walsh
National Security Agency
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
because
that should not be necessary with this fix.
Please review...hopefully this finally fixes the issues.
--
Eamon Walsh
National Security Agency
From f1a3ef1976e9a690c8d6f8858e96cfee0bbb8914 Mon Sep 17 00:00:00 2001
From: Eamon Walsh ewa...@tycho.nsa.gov
Date: Mon, 8 Mar 2010 16:33:37
- XORG_SYS_LIBS=$XORG_SYS_LIBS $PCIACCESS_LIBS $GLX_SYS_LIBS
$SELINUX_LIBS
+ XORG_SYS_LIBS=$XORG_SYS_LIBS $PCIACCESS_LIBS $GLX_SYS_LIBS
XORG_CFLAGS=$XORG_CFLAGS $PCIACCESS_CFLAGS
case $host_os in
Reviewed-by: Eamon Walsh ewa...@tycho.nsa.gov
Both patches, please push
On 02/04/2010 06:57 AM, Daniel Stone wrote:
On Wed, Feb 03, 2010 at 05:04:17PM -0800, Keith Packard wrote:
On Wed, 03 Feb 2010 16:39:26 -0500, Eamon Walsh ewa...@tycho.nsa.gov wrote:
I chose option (3) and renamed the requests. The SELinux extension
doesn't have a traditional Xlib
On 01/24/2010 03:20 PM, Keith Packard wrote:
On 01/06/2010 02:00 PM, Eamon Walsh wrote:
xselinux: Allow SetWindowCreateContext to be used for pixmaps as well.
This is a fairly significant change in extension semantics, and as such
needs to be reflected throughout the stack
Ping?
On 01/06/2010 02:00 PM, Eamon Walsh wrote:
Hi Keith,
Please pull these updates into master.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver master
Eamon Walsh (5):
xselinux: Allow
Hi Keith,
Please pull these updates into master.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver master
Eamon Walsh (5):
xselinux: Allow SetWindowCreateContext to be used for pixmaps as well.
libselinux now
: for each function it appears in.)
--
Eamon Walsh
National Security Agency
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
functions
that do this are XAllocColor, XSendEvent, XQueryTree, XGetTextProperty.
--
Eamon Walsh
National Security Agency
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
the rebase -i thing again.
Thanks.
--
Eamon Walsh
National Security Agency
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
Hi Keith,
Please pull these updates into server-1.6-branch.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver server-1.6-branch
Eamon Walsh (9):
xace: Fake return values on denials in input polling requests
. I can't change the name outright but I can add
a new request opcode with the proper name.
Pull request will be sent once I hear about the IsPointerDevice() fix.
--
Eamon Walsh
National Security Agency
___
xorg-devel mailing list
xorg-devel
On 10/21/2009 09:36 PM, Peter Hutterer wrote:
On Wed, Oct 21, 2009 at 09:07:40PM -0400, Eamon Walsh wrote:
Hi Peter,
Please pull these updates into server-1.7-branch.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh
Hi Peter,
Please pull these updates into server-1.7-branch.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver server-1.7-branch
Eamon Walsh (9):
xace: Fake return values on denials in input polling requests
Hi Keith,
Please pull these updates into server-1.6-branch.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver server-1.6-branch
Eamon Walsh (5):
xace: Fake return values on denials in input polling requests
Hi Keith,
Please pull these updates into master.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver master
Eamon Walsh (7):
xselinux: refactor extension code into smaller files.
xselinux: Factor out some
Hi Keith,
Please pull these updates into master.
Thanks.
The following changes are available in the git repository at:
git://anongit.freedesktop.org/~ewalsh/xserver master
Eamon Walsh (9):
xselinux: refactor extension code into smaller files.
xselinux: Factor out some
On 10/13/2009 10:10 PM, Eamon Walsh wrote:
On 10/13/2009 09:45 PM, Daniel Stone wrote:
Hi,
On Tue, Oct 13, 2009 at 09:24:49PM -0400, Matt Turner wrote:
Please pull these changes into master. I've gotten confirmation from
multiple users that they fix the xserver on alpha
On 10/13/2009 09:45 PM, Daniel Stone wrote:
Hi,
On Tue, Oct 13, 2009 at 09:24:49PM -0400, Matt Turner wrote:
Please pull these changes into master. I've gotten confirmation from
multiple users that they fix the xserver on alpha.
Would these be useful for 1.6 as well? It looks
This is fine with me, however, I know that the proprietary nvidia driver
does resource lookups so it's possible they might call this. Maybe
check with them to verify.
On 09/03/2009 11:23 PM, Peter Hutterer wrote:
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
---
dix/deprecated.c
Peter Hutterer wrote:
On Fri, Jun 26, 2009 at 03:46:26PM -0400, Eamon Walsh wrote:
Why don't we just not support returning XGE events from those old
functions ?
This was the alternative towards the end of the previous email. To quote:
The only other solution I could come up
it there.
As I told Alan it's on my plate to go through and check for issues like
this, I already have a bug report that I think is the result of
DixUnknownAccess being used somewhere.
--
Eamon Walsh ewa...@tycho.nsa.gov
National Security Agency
35 matches
Mail list logo
