butors of projects that follow X.Org's
> purpose as enacted in its bylaws. Other projects can continue to be
> hosted on fd.o but won't receive X.Org membership for the mere reason
> of
> being hosted on fd.o.
With my member hat on, I think this is the best choice.
Acked
On Wednesday, 2018-03-21 11:24:50 -0400, Adam Jackson wrote:
> On Wed, 2018-03-14 at 15:37 +, Emil Velikov wrote:
> > On 13 March 2018 at 10:55, Eric Engestrom wrote:
> > > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from
> > > point
On Tuesday, 2018-03-13 12:09:40 +0100, Michel Dänzer wrote:
> On 2018-03-13 11:56 AM, Eric Engestrom wrote:
> > In function ‘doImageText’,
> > inlined from ‘ImageText’ at dix/dixfonts.c:1513:5:
> > dix/dixfonts.c:1492:9: warning: attempt to free a non-heap object
> &
In function ‘doImageText’,
inlined from ‘ImageText’ at dix/dixfonts.c:1513:5:
dix/dixfonts.c:1492:9: warning: attempt to free a non-heap object
‘local_closure’ [-Wfree-nonheap-object]
free(c);
^
Signed-off-by: Eric Engestrom
---
dix/dixfonts.c | 23
exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from
pointer target type [-Wdiscarded-qualifiers]
swap(pExaGC, pGC, funcs);
^
Signed-off-by: Eric Engestrom
---
exa/exa_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exa/exa_priv.h
On Tuesday, 2017-11-07 18:37:11 +0100, Giuseppe Bilotta wrote:
> ---
> xkb/xkbUtils.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> On Tue, Nov 7, 2017 at 10:55 AM, Eric Engestrom wrote:
>
> > I think this patch is good, because it explicitly shows the
On 7 November 2017 09:43:06 GMT, Giuseppe Bilotta
wrote:
> On Mon, Nov 6, 2017 at 4:41 PM, Eric Engestrom
> wrote:
> > On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote:
> >> This fixes some “Conditional jump depends on uninitialized
> value(s)”
> &g
e by calloc()ing the memory instead of malloc()ing (the alternative
> would be to memset just the padding, but I'm not sure it's more
> convenient.)
This sounds like the right fix, but I don't know enough to be sure.
The rest of the series is
Reviewed-by: Eric Engestr
On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote:
> This fixes some “Conditional jump depends on uninitialized value(s)”
> errors spotted by valgrind.
>
> Signed-off-by: Giuseppe Bilotta
Reviewed-by: Eric Engestrom
Although the rest of the array is 0-initialised,
n
Patches 1-3 are
Reviewed-by: Eric Engestrom
Patch 4 is
Acked-by: Eric Engestrom
> ---
> hw/xfree86/drivers/modesetting/drmmode_display.c | 38
>
> 1 file changed, 13 insertions(+), 25 deletions(-)
>
> diff --git a/hw/xfree86/drivers/modesetting/
reak;
> - }
> +for (i = iceConn->his_min_opcode; i <= iceConn->his_max_opcode; i++)
> + {
> + int n=i - iceConn->his_min_opcode;
spaces around `=`, and can you be more consistent with the indentation?
(mostly avoid mixing tabs and spaces).
With t
On Friday, 2017-09-08 19:59:17 +0200, walter harms wrote:
> free() can handle NULL so remove the check
Did you use a cocci script [1] to generate this?
If so, can you add it to the commit message?
Regardless, I double-checked it and it looks good to me:
Reviewed-by: Eric Engestrom
[1] perh
On Monday, 2017-09-04 12:00:58 +0100, Emil Velikov wrote:
> On 7 July 2017 at 11:23, Eric Engestrom wrote:
> > `error_message` is passed in to strncpy() without any check, which
> > doesn't handle NULL itself, so let's make it a valid empty string in
> > cases wh
Ping :)
On Friday, 2017-07-07 11:23:45 +0100, Eric Engestrom wrote:
> Fix a few free() of static strings and strncpy() of NULL.
>
> BTW, there hasn't been a release in quite a few years, but some of the
> fixes might be interesting, especially ff5e59f322 "Use getentropy
`error_message` is passed in to strncpy() without any check, which
doesn't handle NULL itself, so let's make it a valid empty string in
cases where it was NULL.
Signed-off-by: Eric Engestrom
---
src/process.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
di
Similar to the previous commit, assigning a static string would crash
upon freeing.
Signed-off-by: Eric Engestrom
---
src/process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/process.c b/src/process.c
index 1d7c07a..1ee1ceb 100644
--- a/src/process.c
+++ b/src
If the `errorClass` isn't handled by the switch, `errorStr`'s initial
value would be a pointer to some static memory with an empty string,
and freeing it would most likely crash.
Let's set it to NULL instead, as is done in other similar places.
Signed-off-by: Eric Engestrom
---
.1.0?
Cc: Alan Coopersmith
Eric Engestrom (3):
Make sure errorStr is a free-able string
Make sure error_message is a free-able string
Make sure string is never NULL
src/process.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
--
f you could send your next patches using `git send-email`, it would
make it easier (and thus quicker) for people to review them :)
I had a quick look, and it won't have any effect on non-haiku platforms,
so it should be fine to land, whatever state the haiku bit is.
Acked-by: Eric Engestrom
On Tuesday, 2017-05-09 19:39:47 -0400, Peter Harris wrote:
> If we're linking with libbsd anyway, we might as well use the functions
> it provides instead of compiling our replacements.
>
> Signed-off-by: Peter Harris
> ---
> include/meson.build | 6 +++---
> include/os.h| 6 ++
> 2
Reviewed-by: Eric Engestrom
On 1 May 2017 10:29:16 BST, Peter Hutterer wrote:
>While we're shipping both build systems, we'll likely have 'make dist'
>generated tarballs - those tarballs should be buildable with meson to
>have more exposure.
>
>Signed-off-by:
On Friday, 2017-04-28 11:30:08 +0100, Eric Engestrom wrote:
> On Friday, 2017-04-28 16:09:55 +1000, Peter Hutterer wrote:
> > While we're providing both build systems, we'll likely have 'make dist'
> > generated tarballs - those tarballs should be buildable w
On Friday, 2017-04-28 16:09:55 +1000, Peter Hutterer wrote:
> While we're providing both build systems, we'll likely have 'make dist'
> generated tarballs - those tarballs should be buildable with meson to
> have more exposure.
>
> Signed-off-by: Peter Hutterer
> ---
> triggered by:
> https://mai
Linux. The three commands to configure (building into the
> +build/ directory), build, and install are:
> +
> +meson build
> +ninja -C build
> +sudo ninja -C build install
s,build,build/, on all three lines, to make it clear this is the dir
name,
be `-p "$build_dir"` :P
And the output already contains `-p`, so this line should read:
build_dir=`mktemp -d -p "$build_dir" build.XX`
> if [ $? -ne 0 ]; then
> echo "Error: could not create a temporary directory for the release"
>
eleration in Xwayland (glamor being used by default).
>
> Add an environment variable XWAYLAND_NO_GLAMOR t odiable glamor support
"to disable"
The change itself looks good to me.
Reviewed-by: Eric Engestrom
As to whether it's a good idea to allow this, I'd say it
On Tuesday, 2017-02-28 19:18:43 +0100, Matthieu Herrb wrote:
> Signed-off-by: Matthieu Herrb
> ---
> configure.ac| 2 ++
> include/dix-config.h.in | 6 ++
> os/auth.c | 7 +++
> 3 files changed, 15 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> ind
On Friday, 2017-02-24 14:13:39 +, Eric Engestrom wrote:
> On Friday, 2017-02-24 13:10:17 +1000, Peter Hutterer wrote:
> > And why isn't this a thing in glibc yet
>
> Indeed :(
> So many bugs caused by someone assuming `if (strcmp(a, b))` means a==b...
>
> >
&
FFSET 8
>
> +#define streq(a, b) (strcmp(a, b) == 0)
> +#define strneq(a, b, n) (strncmp(a, b, n) == 0)
strneq() reads to me as "string not equal"...
streqn() might be a better name?
And a bit of a nitpick, but could you move its introduction to the patch
that starts using it
From: "Dr.-Ing. Dieter Jurzitza"
Fixes compile failure:
Failed to compile VS: 0:13(43): error: `pos' undeclared
0:13(14): error: operands to arithmetic operators must be numeric
0:13(13): error: operands to arithmetic operators must be numeric
Program source:
#version 130
attribute vec3 primi
On Wednesday, 2017-02-22 11:47:44 +0100, dieter.jurzi...@t-online.de wrote:
>
> From: Dr.-Ing. Dieter Jurzitza
>
> Fixes compile failure:
>
> Failed to compile VS: 0:13(43): error: `pos' undeclared
> 0:13(14): error: operands to arithmetic operators must be numeric
> 0:13(13): error: operands
On Wednesday, 2016-10-26 15:08:23 +1000, Peter Hutterer wrote:
> This device never sends events, no point in exposing these options
>
> Signed-off-by: Peter Hutterer
Does what it says on the tin :)
Reviewed-by: Eric Engestrom
> ---
> src/xf86libinput.c | 6 --
>
On Tuesday, 2016-10-25 19:24:49 +0200, Rui Matos wrote:
> Pointer enter event coordinates are surface relative and we need them
> to be screen relative for pScreen->SetCursorPosition().
>
> https://bugzilla.gnome.org/show_bug.cgi?id=758283
>
> Signed-off-by: Rui Matos
LGTM
ount_connectors > 0 check, fixing this.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Eric Engestrom
> ---
> hw/xfree86/xorg-wrapper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xfree86/xorg-wrapper.c b/hw/xfree86/xorg-wrapper.c
> ind
On Mon, Oct 03, 2016 at 05:59:33PM +0200, Hans de Goede wrote:
> Hello tigervnc devs,
>
> As part of updating Fedora to xserver 1.19 I've written
> a tiger vnc patch to make tigervnc work with xserver 1.19.
>
> Since xserver 1.19 switches from select to poll the changes
> are non trivial and requ
On Fri, Sep 23, 2016 at 03:12:18PM +0300, Hans de Goede wrote:
> Hi,
>
> On 01/13/2016 07:47 AM, Kyle Guinn wrote:
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93675
> >
> > Signed-off-by: Kyle Guinn
>
> Thanks for the patch, I've queued this up at:
>
> https://cgit.freedesktop.org/
On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote:
> Signed-off-by: Antoine Martin
Reviewed-by: Eric Engestrom
> ---
> src/dummy_driver.c | 19 ---
> 1 file changed, 19 deletions(-)
>
> diff --git a/src/dummy_driver.c b/src/dummy_driver.c
> i
crtc;
>
> +/* Hide any cursors which me be active from previous users */
s/me/may/ :)
This looks reasonable:
Reviewed-by: Eric Engestrom
> +drmModeSetCursor(drmmode->fd, drmmode_crtc->mode_crtc->crtc_id, 0, 0, 0);
> +
> /* Mark num'th crtc as in us
On Wed, Aug 31, 2016 at 10:16:34AM +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> build.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/build.sh b/build.sh
> index 369afc8..3006ebc 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -1155,11 +1155,13 @@ build_all_mo
On Tue, Aug 16, 2016 at 11:56:50AM +0100, Eric Engestrom wrote:
> On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote:
> > since Xfree is a define for free()
> > Xlibint.h:#define Xfree(ptr) free((ptr))
> >
> > Xfree will accept NULL and do nothing.
> >
ree
> function is a general-purpose Xlib routine that frees the specified data.
> -You must use it to free any objects that were allocated by Xlib,
> +You must use it to free any objects that were allocated by Xlib,
What's the change here?
The rest is:
Reviewed-by: Eric Engestr
Signed-off-by: Eric Engestrom
---
The first fix makes a long line longer; should I reflow it?
---
man/libinput.man | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/libinput.man b/man/libinput.man
index 43beda7..798aff5 100644
--- a/man/libinput.man
+++ b/man
d sofar because most gpus have both
> import and export capability.
>
> Signed-off-by: Hans de Goede
Both patches are:
Reviewed-by: Eric Engestrom
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
I
On Thu, May 19, 2016 at 05:35:57PM +0200, Stefan Dirsch wrote:
> ---
> conf/50-synaptics.conf | 46 --
> conf/70-synaptics.conf | 46 ++
Also, `git format-patch` supports -M, which avoids all this "delete whole
On Thu, May 19, 2016 at 05:35:57PM +0200, Stefan Dirsch wrote:
> Bump up synaptics driver to 70, so it get's perferred over libipnut,
> which was dropped down to 60. Reason is, that synaptics driver is more
> of an additional driver, which then should be installed if installed.
s/perferred/preferr
On Thu, May 05, 2016 at 01:07:26PM +0700, Antoine Martin wrote:
> Pointer events are clipped to the original screen dimensions with the
> dummy driver when using RandR to switch to a higher resolution at
> runtime. This fixes it.
Please use `git send-email` [1] to send patches, and add the quoted
On Wed, Apr 27, 2016 at 07:23:15PM +, Reinhard Zitzmann wrote:
> git://anongit.freedesktop.org/xorg/app/edid-decode master
>
You should always CC: the mailing list, so everyone can see the answer.
Reviewed-by: Eric Engestrom
Thanks for the patch :]
> On Tue, Apr 26, 2016 at 5:0
On Tue, Apr 26, 2016 at 09:00:42AM +0200, reinhard.zitzm...@gmail.com wrote:
> From: Reinhard Zitzmann
>
> Signed-off-by: Reinhard Zitzmann
> ---
> edid-decode.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/edid-decode.c b/edid-decode.c
> index 0b94ad5..62c7
On Tue, Apr 26, 2016 at 04:29:41PM +0200, walter harms wrote:
>
>
> free all memory on error
>
> Signed-off-by: walter harms
>
>
> ---
> src/xlibi18n/lcPublic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/xlibi18n/lcPublic.c b/src/xlibi18n/lcPublic.c
> ind
On Fri, Apr 08, 2016 at 11:47:33AM -0400, Adam Jackson wrote:
> On Sat, 2016-04-02 at 19:53 +0100, Eric Engestrom wrote:
>
> > index 5391b72..221c631 100755
> > --- a/hw/xfree86/sdksyms.sh
> > +++ b/hw/xfree86/sdksyms.sh
> > @@ -389,7 +389,7 @@ B
Signed-off-by: Eric Engestrom
---
Xi/exevents.c | 4 ++--
Xi/xiproperty.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Xi/exevents.c b/Xi/exevents.c
index 74e49ed..570352f 100644
--- a/Xi/exevents.c
+++ b/Xi/exevents.c
@@ -653,7 +653,7 @@ DeepCopyPointerClasses
Signed-off-by: Eric Engestrom
---
hw/xwayland/xwayland-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xwayland/xwayland-input.c b/hw/xwayland/xwayland-input.c
index f9e3255..67edea4 100644
--- a/hw/xwayland/xwayland-input.c
+++ b/hw/xwayland/xwayland-input.c
Signed-off-by: Eric Engestrom
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index dff06ef..715cbcc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -242,7 +242,7 @@ if test "x$ac_cv_func_getpeereid" = xno &
Signed-off-by: Eric Engestrom
---
Xext/vidmode.c | 2 +-
Xext/xres.c| 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Xext/vidmode.c b/Xext/vidmode.c
index 499a2a8..14d625b 100644
--- a/Xext/vidmode.c
+++ b/Xext/vidmode.c
@@ -277,7 +277,7 @@ ProcVidModeGetModeLine
Signed-off-by: Eric Engestrom
---
hw/dmx/config/dmxconfig.c | 2 +-
hw/dmx/dmxcb.c| 2 +-
hw/dmx/dmxextension.c | 4 ++--
hw/dmx/dmxscrinit.c | 2 +-
hw/dmx/dmxwindow.c| 2 +-
hw/dmx/doc/DMXSpec.txt| 2 +-
hw/dmx/input/dmxconsole.c | 2 +-
hw/dmx/man/Xdmx.man
Signed-off-by: Eric Engestrom
---
hw/xfree86/common/xf86Cursor.c | 2 +-
hw/xfree86/common/xf86Events.c | 2 +-
hw/xfree86/common/xf86Helper.c | 2 +-
hw/xfree86/common/xf86pciBus.c | 2 +-
hw/xfree86/dri/dri.c | 2 +-
hw/xfree86
Signed-off-by: Eric Engestrom
---
hw/xwin/InitOutput.c | 2 +-
hw/xwin/ddraw.h| 2 +-
hw/xwin/glx/indirect.c | 2 +-
hw/xwin/man/XWin.man | 2 +-
hw/xwin/win.h | 2 +-
hw/xwin/wincreatewnd.c | 2 +-
hw/xwin/winscrinit.c | 2 +-
7 files changed, 7 insertions(+), 7 deletions
Signed-off-by: Eric Engestrom
---
dix/BuiltInAtoms | 2 +-
dix/colormap.c | 2 +-
dix/events.c | 2 +-
dix/ptrveloc.c | 4 ++--
dix/touch.c | 2 +-
dix/window.c | 6 +++---
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/dix/BuiltInAtoms b/dix/BuiltInAtoms
index
Signed-off-by: Eric Engestrom
---
glamor/glamor_gradient.c| 8
glamor/glamor_largepixmap.c | 2 +-
glamor/glamor_render.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/glamor/glamor_gradient.c b/glamor/glamor_gradient.c
index c50542a..f7b67ce 100644
Signed-off-by: Eric Engestrom
---
miext/rootless/rootless.h | 2 +-
miext/rootless/rootlessWindow.c | 2 +-
miext/shadow/shadow.c | 2 +-
miext/shadow/shalloc.c | 2 +-
miext/sync/misyncstr.h | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a
Signed-off-by: Eric Engestrom
---
hw/xquartz/GL/capabilities.c | 6 +++---
hw/xquartz/GL/glcontextmodes.c | 2 +-
hw/xquartz/X11Controller.h | 2 +-
hw/xquartz/pbproxy/x-selection.m | 10 +-
hw/xquartz/xpr/appledri.h| 2 +-
5 files changed, 11 insertions(+), 11
Signed-off-by: Eric Engestrom
---
os/io.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/os/io.c b/os/io.c
index 19a449a..18f1497 100644
--- a/os/io.c
+++ b/os/io.c
@@ -338,7 +338,7 @@ ReadRequestFromClient(ClientPtr client)
/* save the data we&#x
Signed-off-by: Eric Engestrom
---
xkb/XKM_file_format.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xkb/XKM_file_format.txt b/xkb/XKM_file_format.txt
index 0ba28ee..2a90e40 100644
--- a/xkb/XKM_file_format.txt
+++ b/xkb/XKM_file_format.txt
@@ -77,8 +77,8
Signed-off-by: Eric Engestrom
---
glx/glxcmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/glx/glxcmds.c b/glx/glxcmds.c
index 0f0b714..1088fa8 100644
--- a/glx/glxcmds.c
+++ b/glx/glxcmds.c
@@ -224,7 +224,7 @@ __glXdirectContextCreate(__GLXscreen * screen
Signed-off-by: Eric Engestrom
---
exa/exa_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exa/exa_priv.h b/exa/exa_priv.h
index ca4db72..2ad6760 100644
--- a/exa/exa_priv.h
+++ b/exa/exa_priv.h
@@ -130,7 +130,7 @@ typedef struct {
PicturePtr picture
Signed-off-by: Eric Engestrom
---
mi/mibitblt.c | 2 +-
mi/miscrinit.c | 2 +-
mi/mizerline.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mi/mibitblt.c b/mi/mibitblt.c
index 28296a4..63e3abf 100644
--- a/mi/mibitblt.c
+++ b/mi/mibitblt.c
@@ -449,7 +449,7
Signed-off-by: Eric Engestrom
---
include/pixmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/pixmap.h b/include/pixmap.h
index c6a7736..926289d 100644
--- a/include/pixmap.h
+++ b/include/pixmap.h
@@ -126,7 +126,7 @@ extern _X_EXPORT Bool
Signed-off-by: Eric Engestrom
---
hw/kdrive/ephyr/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/kdrive/ephyr/README b/hw/kdrive/ephyr/README
index 6d6a222..f347dc2 100644
--- a/hw/kdrive/ephyr/README
+++ b/hw/kdrive/ephyr/README
@@ -54,7 +54,7 @@ Caveats
is
On 08/12/15 20:08, Adam Jackson wrote:
Signed-off-by: Adam Jackson
---
Xext/xres.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/Xext/xres.c b/Xext/xres.c
index 83cc691..5d3faa3 100644
--- a/Xext/xres.c
+++ b/Xext/xres.c
@@ -274,6 +27
69 matches
Mail list logo
