-9 the
process and witness X entering a neverending loop. Cnee's connection
issues RecordEnableContext, which makes the connection ignored.
Signed-off-by: Erkki Seppälä
Reviewed-by: Rami Ylimäki
---
os/connection.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/
when a new damage object is created.
As this patch makes DamageReportDamage a public interface, the
function has been moved into the part of the file that contains all
the other public functions. The function has not been otherwise
modified.
Signed-off-by: Erkki Seppälä
---
damageext
ers a full window update when a new damage object is
created.
Signed-off-by: Erkki Seppälä
---
damageext/damageext.c |2 +-
miext/damage/damage.c | 12
miext/damage/damage.h |5 +
3 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/damageext/damageext.c b
lobber the
previous return values), by supporting the getenv_r function, if it is
available. XauGetFileName is still easy to use in the basic situation,
but it works in fixed size buffer situations as well.
Erkki Seppälä (2):
XauGetFileName: added a thread-safe variant of XauFileName
XauGet*AuthB
fe according to
its documentation.
Signed-off-by: Erkki Seppälä
Reviewed-by: Rami Ylimäki
---
AuFileName.c| 163 ++-
configure.ac|5 ++
include/X11/Xauth.h | 38
man/Xau.man | 57 +-
4 fil
XauGetFileName is a thread-safe variant of XauFileName.
Signed-off-by: Erkki Seppälä
Reviewed-by: Rami Ylimäki
---
AuGetAddr.c | 12 +++-
AuGetBest.c | 12 +++-
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/AuGetAddr.c b/AuGetAddr.c
index 897d8b5..5d6c8fb
DetermineClientPid didn't close file descriptor if read on
/proc/pid/cmdline failed. Adjusted the code to disregard the close
return value and perform the return after that, if the read failed or
returned EOF.
Signed-off-by: Mark Kettenis
Signed-off-by: Erkki Seppälä
Reviewed-by: Rami Yl
DetermineClientPid didn't close file descriptor if read on
/proc/pid/cmdline failed. Added close to that path of code.
Signed-off-by: Erkki Seppälä
Reviewed-by: Rami Ylimäki
---
os/client.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/os/client.c b/os/cli
age object is created.
Signed-off-by: Erkki Seppälä
---
damageext/damageext.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/damageext/damageext.c b/damageext/damageext.c
index cfef069..7a0a779 100644
--- a/damageext/damageext.c
+++ b/damageext/damageext.c
@@ -22
ition.
Signed-off-by: Erkki Seppälä
Signed-off-by: Stefan Kost
---
Stefan, please ask a proper Reported-by tag for the bug from the
original reporter.
config/udev.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/config/udev.c b/config/udev.c
index a2f5710..c120747 1
miDCDeviceInitialize succeeds. The record itself
is zeroed on cleanup to ensure that the assumptions in the code still
hold.
Reviewed-by: Rami Ylimäki
Signed-off-by: Erkki Seppälä
---
mi/misprite.c | 41 +++--
1 files changed, 19 insertions(+), 22 deletions(-)
diff
The record allocated by miSpriteDeviceCursorInitialize was not being
released. This patch adds a call to free and resetting the private
record to miSpriteDeviceCursorCleanup.
Reviewed-by: Rami Ylimäki
Signed-off-by: Erkki Seppälä
---
mi/misprite.c |3 +++
1 files changed, 3 insertions
releasing sequences with one that is gotoed into.
Reviewed-by: Rami Ylimäki
Signed-off-by: Erkki Seppälä
---
hw/xfree86/modes/xf86Crtc.c | 21 -
1 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
index 9a5e50
: Erkki Seppälä
---
hw/xfree86/common/xf86Config.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
index 28786ba..906d4bd 100644
--- a/hw/xfree86/common/xf86Config.c
+++ b/hw/xfree86/common/xf86Config.c
t
might affect existing behavior, which may be relied upon.
Reviewed-by: Rami Ylimäki
Signed-off-by: Erkki Seppälä
---
record/record.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/record/record.c b/record/record.c
index 6a93d7a..bea3046 100644
--- a/record/record.
fragment would not have been reached.
This patch alters the function to return XcmsFailure if the call to
XGetWindowProperty fails.
Reviewed-by: Ander Conselvan de Oliveira
Reviewed-by: Rami Ylimäki
Signed-off-by: Erkki Seppälä
---
src/xcms/cmsProp.c | 17 ++---
1 files changed
to "free"
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
---
src/xcms/LRGB.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/xcms/LRGB.c b/src/xcms/LRGB.c
index 750c492..2dca82e 100644
--- a/src/xcms/LRGB.c
+++ b/sr
eturn
Erkki Seppälä (1):
xcms/cmsProp: don't deal with uninitialized values, fail instead
src/xcms/LRGB.c|1 -
src/xcms/cmsProp.c | 24 +---
2 files changed, 13 insertions(+), 12 deletions(-)
___
xorg-devel@lists.x.
Variable "missing_list" goes out of scope
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
ind
-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/cmsProp.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/xcms/cmsProp.c b/src/xcms/cmsProp.c
index 856ae84..9294cc7 100644
--- a/src/xcms/cmsProp.c
+++
pBoth. Each of
these has a specific meaning attached.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imLcLkup.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imLcLkup.c b/modules/im/ximcp/imLcLkup.c
index 80
Cannot reach dead expression "0U" inside statement "if (1U + (target_dir ?
strl..."
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcF
Cannot reach dead expression "0U" inside statement "if (1U + (target_dir ?
strl..."
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcF
Variable "prop_name" not freed or pointed-to in function "strlen"
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/XDefaultOMIF.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/xlibi18n/XDefaultO
From: Ander Conselvan de Oliveira
xcms/LRGB: Fix potential resource leak.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/LRGB.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/xcms/LRGB.c b/src
From: Ander Conselvan de Oliveira
xcms/LRGB: Add a label for freeing property_return.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/LRGB.c | 26 ++
1 files changed, 10 insertions(+), 16 deletions
Return value of "XGetWindowProperty(im->core.display, spec->lib_connect_wid,
prop, 0L, (length + bytes_after_ret + 3UL) / 4UL, 1, 0UL, &type_ret,
&format_ret, &nitems, &bytes_after_ret, &prop_ret)" is not checked
Signed-off-by: Erkki Seppälä
From: Ander Conselvan de Oliveira
Variable "wd_array" goes out of scope Value "wd_array" is overwritten in
"wd_array = (XPointer*)realloc((char*)info_list->watch_data,
(((dpy->watcher_count + 1) * 4U == 0U) ? 1U : ((dpy->watcher_count + 1) * 4U)))"
Re
Using uninitialized value "new"
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcGeneric.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n/lcGeneric.c
index 69ea97d..688a4cf 10
Using uninitialized value "error.resourceID" in call to function "_XError"
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/GetProp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
Variable "colormap_ret" goes out of scope
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index fa86979..3d09
From: Ander Conselvan de Oliveira
Using uninitialized value "conv->state" in call to function "close_converter"
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/lc/def/lcDefConv.c |2 +-
modules/lc
Possible overrun of 8192 byte fixed size buffer "buffer" by copying "ext->name"
without length checking
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/XlibInt.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --gi
Variable "colormap_ret" goes out of scope
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
ind
Variable "image" goes out of scope
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/ImUtil.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/ImUtil.c b/src/ImUtil.c
index cd418d8..3164d43 100644
--- a/src/ImUtil.c
+++ b/sr
Variable "colormap_ret" goes out of scope
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index ae053c9..5035df5 100644
--- a/module
From: Ander Conselvan de Oliveira
Double free of pointer "property_return" in call to "free"
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/LRGB.c |1 -
1 files changed, 0 insertions(+), 1 deletions(
Variable "colormap_ret" goes out of scope
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index 2e2c31f..fa86
Tracked variable "size" was passed to a negative sink.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/Xrm.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/Xrm.c b/src/Xrm.c
index 3e68c37..fbc8ad2 100644
--- a/src/Xrm.c
Variable "fs" not freed or pointed-to in function "get_prop_name"
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/XDefaultOMIF.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/XDefaultO
Variable "table" goes out of scope
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/Xrm.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/Xrm.c b/src/Xrm.c
index 21f0af3..3e68c37 100644
--- a/src/Xrm.c
+++ b/src/Xrm.c
Pointer "pBuf" returned from "fgets(buf, 256, stream)" is never used
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms/cmsC
Pointer "pBuf" returned from "fgets(buf, 256, stream)" is never used
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms/cmsC
loc
Fixed by zero'ing conv on allocation. Then close_converter works properly.
Erkki Seppälä (19):
Fixed a missing call to XFreeFont
Removed unused assignment
Removed unused assignment
Zero-initialized new
Fixed by using strncpy and explicitly terminating the bu
== 0 || nitems_ret == 0)
ends up returning XcmsFailure, the freed value of prop_ret from the
previous call to XGWP will be returned.
This patches changes the funcion to behavior to return XcmsFailure
if the call do XGetWindowProperty fails.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/GetProp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/GetProp.c b/src/GetProp.c
index a80c19c..5d6e0b8 100644
--- a/src/GetProp.c
+++ b/src/GetProp.c
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcFile.c b/src/xlibi18n
From: Ander Conselvan de Oliveira
property_return was free'd before and in the case the conditional is
true, the call to XcmsGetProperty failed which means that
property_return wasn't set so there is no need to free it again.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Co
Fixed the handling of the extremely unlikely situation of fstat failing
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/Xrm.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/Xrm.c b/src/Xrm.c
index 3e68c37..fbc8ad2 100644
--- a
From: Ander Conselvan de Oliveira
property_return was not free'd if the allocation of pRedTbl failed.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/LRGB.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
From: Ander Conselvan de Oliveira
The rest of the code uses goto's to free memory allocated later
and prevent memory leaks, but there were several paths were
property_return was free'd just before a goto.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Sig
The NEWTABLE macro missed freeing its allocated memory on subsequent memory
allocation errors. Added call to Xfree.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/Xrm.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/Xrm.c b/src
Zero-initialized new
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcGeneric.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n/lcGeneric.c
index 69ea97d..688a4cf 100644
--- a/src/xlibi18n
From: Ander Conselvan de Oliveira
Fixed by zero'ing conv on allocation. Then close_converter works properly.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/lc/def/lcDefConv.c |2 +-
modules/lc/gen/lcGenConv.c |2
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index fa86979..3d09b81 100644
--- a
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index 2e2c31f..fa86979 100644
--- a
From: Ander Conselvan de Oliveira
info_list->watch_data was being reallocated, but the return value of the
reallocation was stored only into a local variable. This might cause some funky
behavior and crashes.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
Signed-
s are XBufferOverflow,
XLookupNone, XLookupChars, XLookupKeySym, and XLookupBoth. Each of
these has a specific meaning attached.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imLcLkup.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --
Checked return value of XGetWindowProperty and return false if it fails.
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imTrX.c | 33 +
1 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/modules/im/ximcp/imTrX.c b/modules/im/ximcp/imTrX.c
index
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index b6d1e12..d62dfdb
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcFile.c b/src/xlibi18n
Fixed memory leak by adding Xfree
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index ae053c9..5035df5 100644
--- a/modules/im/ximcp/imRmAttr.c
+++ b
Instead of copying the value returned by get_prop_name and then releasing it,
directly use the return value of get_prop_name, which allocates memory for the
name.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/XDefaultOMIF.c |4 +---
1 files
Fixed by using strncpy and explicitly terminating the buffer
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/XlibInt.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/XlibInt.c b/src/XlibInt.c
index d55c26a..52ccff1 100644
--- a
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/ImUtil.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/ImUtil.c b/src/ImUtil.c
index cd418d8..3164d43 100644
--- a/src/ImUtil.c
+++ b/src/ImUtil.c
Fixed memory leak by adding Xfree and initializing missing_list with NULL
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im
Fixed a missing call to XFreeFont
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/XDefaultOMIF.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/XDefaultOMIF.c b/src/xlibi18n/XDefaultOMIF.c
index bc6b1b9..bb3986a
Removed unused assignment
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms/cmsColNm.c
index 4164370..c7ad4fd 100644
--- a/src/xcms/cmsColNm.c
Removed unused assignment
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms/cmsColNm.c
index c7ad4fd..8518adf 100644
--- a/src/xcms/cmsColNm.c
nt + 1) * 4U == 0U) ? 1U : ((dpy->watcher_count
+ 1) * 4U)))"
Using uninitialized value "conv->state" in call to function
"close_converter"
Erkki Seppälä (19):
Variable "fs" not freed or pointed-to in function "get_prop_name"
Pointer &qu
Release modifiermap before returning. Reordered code to call
XGetModifierMapping after the first return from the function.
Signed-off-by: Erkki Seppälä
diff --git a/modules/im/ximcp/imThaiFlt.c b/modules/im/ximcp/imThaiFlt.c
index e0b3988..e2b0458 100644
--- a/modules/im/ximcp/imThaiFlt.c
+++ b
Small fix by using Xcalloc instead of Xmalloc
Signed-off-by: Erkki Seppälä
diff --git a/src/KeyBind.c b/src/KeyBind.c
index 6d80a02..ac25ce2 100644
--- a/src/KeyBind.c
+++ b/src/KeyBind.c
@@ -996,7 +996,7 @@ XRebindKeysym (
tmp = dpy->key_bindings;
nb = sizeof(KeySym) * nm;
-
Here are revised versions of the fixes that got some review comments
on the list.
Erkki Seppälä (3):
Variable "map" goes out of scope
Using uninitialized value "p->modifiers"
Cannot reach dead statement "return NULL;"
modules/im/ximcp/imThaiFlt.
Check for the NULLness of prop->name and prop->value instead of
name and value, which was checked earlier anyway. Decided against
using strdup due to curious memory allocation functions and the
rest of the xkb not using it either.
Signed-off-by: Erkki Seppälä
diff --git a/src/xkb/XKBGAll
are available in the git repository at:
git://gitorious.org/erkkise/libx11-fixes.git fixes-reviewed-1
Erkki Seppälä (4):
Using freed pointer "e"
Dereferencing possibly NULL "str" in call to function "memcpy" (Deref
assumed on the basis of 'nonnull' parameter attribute.)
Var
Removed superfluous check for NULL. name == NULL is already checked
at the function entry.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xkb/XKBGAlloc.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/xkb/XKBGAlloc.c b/src/xkb
From: Ander Conselvan de Oliveira
The rest of the code uses goto's to free memory allocated later
and prevent memory leaks, but there were several paths were
property_return was free'd just before a goto.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
---
From: Ander Conselvan de Oliveira
Fixed by zero'ing conv on allocation. Then close_converter works properly.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
---
modules/lc/def/lcDefConv.c |2 +-
modules/lc/gen/lcGenConv.c |2 +-
2 files changed, 2 inser
From: Ander Conselvan de Oliveira
info_list->watch_data was being reallocated, but the return value of the
reallocation was stored only into a local variable. This might cause some funky
behavior and crashes.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
---
s are XBufferOverflow,
XLookupNone, XLookupChars, XLookupKeySym, and XLookupBoth. Each of
these has a specific meaning attached.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imLcLkup.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --
If _XkbGetReadBufferPtr returns NULL, goto BAILOUT
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xkb/XKBList.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/xkb/XKBList.c b/src/xkb/XKBList.c
index e1b4127..dec96b7 100644
--- a/src
Instead of copying the value returned by get_prop_name and then releasing it,
directly use the return value of get_prop_name, which allocates memory for the
name.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/XDefaultOMIF.c |4 +---
1 files
Fixed memory leak by adding Xfree and initializing missing_list with NULL
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index 2e2c31f..fa86979 100644
--- a
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcFile.c b/src/xlibi18n
Removed superfluous comparison.
Signed-off-by: Erkki Seppälä
---
src/xkb/XKBMisc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c
index fc5ae5f..4aa1f73 100644
--- a/src/xkb/XKBMisc.c
+++ b/src/xkb/XKBMisc.c
@@ -619,7 +619,7
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcFile.c b/src/xlibi18n
Fixed the handling of the extremely unlikely situation of fstat failing
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/Xrm.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/Xrm.c b/src/Xrm.c
index 3e68c37..b243d60 100644
--- a
== 0 || nitems_ret == 0)
ends up returning XcmsFailure, the freed value of prop_ret from the
previous call to XGWP will be returned.
This patches changes the funcion to behavior to return XcmsFailure
if the call do XGetWindowProperty fails.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander
Checked return value of XGetWindowProperty and return false if it fails.
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imTrX.c | 33 +
1 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/modules/im/ximcp/imTrX.c b/modules/im/ximcp/imTrX.c
index
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index fa86979..3d09b81 100644
--- a
From: Ander Conselvan de Oliveira
property_return was not free'd if the allocation of pRedTbl failed.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
---
src/xcms/LRGB.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/xcms/LRGB.c
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Conselvan de Oliveira
---
src/GetProp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/GetProp.c b/src/GetProp.c
index a80c19c..5d6e0b8 100644
--- a/src/GetProp.c
+++ b/src/GetProp.c
@@ -46,7 +46,7
The NEWTABLE macro missed freeing its allocated memory on subsequent memory
allocation errors. Added call to Xfree.
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/Xrm.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/Xrm.c b/src
From: Ander Conselvan de Oliveira
property_return was free'd before and in the case the conditional is
true, the call to XcmsGetProperty failed which means that
property_return wasn't set so there is no need to free it again.
Reviewed-by: Erkki Seppälä
Signed-off-by: Ander Co
Check entry for non-nullness before dereferencing it
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xkb/XKB.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xkb/XKB.c b/src/xkb/XKB.c
index 42dba99..f926cb9 100644
--- a/src/xkb/XKB.c
Fixed memory leak by adding Xfree
Signed-off-by: Erkki Seppälä
---
modules/im/ximcp/imRmAttr.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index ae053c9..5035df5 100644
--- a/modules/im/ximcp/imRmAttr.c
+++ b
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/ImUtil.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/ImUtil.c b/src/ImUtil.c
index cd418d8..3164d43 100644
--- a/src/ImUtil.c
+++ b/src/ImUtil.c
Fixed a missing call to XFreeFont
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/xlibi18n/XDefaultOMIF.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/XDefaultOMIF.c b/src/xlibi18n/XDefaultOMIF.c
index bc6b1b9..bb3986a
Fixed by using strncpy and explicitly terminating the buffer
Reviewed-by: Ander Conselvan de Oliveira
Signed-off-by: Erkki Seppälä
---
src/XlibInt.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/XlibInt.c b/src/XlibInt.c
index c385f4c..9f2745e 100644
--- a
1 - 100 of 138 matches
Mail list logo