Re: [PATCH 05/36] dix: introduce gpu screens. (v4)

2012-07-05 Thread Fernando Carrijo
Dave Airlie wrote: > +int > +AddGPUScreen(Bool (*pfnInit) (ScreenPtr /*pScreen */ , > + int /*argc */ , > + char ** /*argv */ > + ), > + int argc, char **argv) > +{ > +int i; > +ScreenP

Re: [PATCH 40/42] dix: Remove touch grabs if the grab disappears

2011-12-15 Thread Fernando Carrijo
Peter Hutterer wrote: > +void > +TouchListenerGone(XID resource) > +{ > +TouchPointInfoPtr ti; > +DeviceIntPtr dev; > +InternalEvent *events = InitEventList(GetMaximumEventsNum()); Forgot to deallocate the event list. > +int i, j, k, nev; > + > +if (!events) > +Fatal

Re: [PATCH 27/42] dix: add helper functions for adding/removing touch listeners

2011-12-15 Thread Fernando Carrijo
Peter Hutterer wrote: > +static void > +TouchAddActiveGrabListener(DeviceIntPtr dev, TouchPointInfoPtr ti, > + InternalEvent *ev, GrabPtr grab) > +{ > +if (!ti->emulate_pointer && > +(grab->grabtype == CORE || grab->grabtype == XI)) > +return; > + > +

Re: [PATCH 2/2] os: Work around integer overflow in TimerSet.

2011-03-06 Thread Fernando Carrijo
Cyril Brulebois wrote: > If TimerSet gets called with a big timeout, this call can overflow: > millis += now; > > Detect overflow and set millis to the maximal integer when that happens, > to avoid falling in the “already expired” case. Hi Cyril, I found this, buried in Section 6.2.5 (9) of

Re: RandR 1.4 restart

2011-03-01 Thread Fernando Carrijo
A couple of typos below... Keith Packard wrote: > +CRTCCONFIG { crtc: CRTC > + set: SETofCRTCFLAG > + x, y: INT16 > + mode: MODE > + rotation: ROTATION > + sprite-position-transform: TRANSFORM > + sprite-image-transform: TRANSFORM > +

Re: [PATCH synaptics] Increase post-motion-event timeout from 13 to 50 ms.

2011-02-28 Thread Fernando Carrijo
Daniel Kurtz wrote: > However, my understanding is that edge motion occurs when a drag or move > hits an edge, but the finger stays in contact with the pad. Thus, there > should always still be hardware events during an edge motion. Yeah, once the properties EdgeMotion{MinZ,MaxZ,UseAlways} are

Re: [PATCH vBrownPaperBag] dix: release all buttons and keys before reattaching a device (#34182)

2011-02-24 Thread Fernando Carrijo
; > X.Org Bug 34182 <http://bugs.freedesktop.org/show_bug.cgi?id=34182> > > Signed-off-by: Peter Hutterer > --- > > Changes to v1: > - Free the event list after usage. > - two loops require two counters. who would have thought. Reviewed-by: Fernando Carrijo _

Re: [PATCH] dix: release all buttons and keys before reattaching a device (#34182)

2011-02-24 Thread Fernando Carrijo
Peter Hutterer wrote: > /** > + * Generate release events for all keys/button currently down on this > + * device. > + */ > +static void > +ReleaseButtonsAndKeys(DeviceIntPtr dev) > +{ > +EventListPtreventlist = InitEventList(GetMaximumEventsNum()); Out of curiosity, where in the ca

[PATCH inputproto] Fix typos in XIproto.txt

2011-01-27 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- Nothing extraordinary here. Seriously! XIproto.txt | 30 ++ 1 files changed, 10 insertions(+), 20 deletions(-) diff --git a/XIproto.txt b/XIproto.txt index f9d19f0..83cf9dd 100644 --- a/XIproto.txt +++ b/XIproto.txt @@ -1650,7

Re: [PATCH 06/11] xfree86/dga: DGA2 events are missing the dx/dy information

2011-01-23 Thread Fernando Carrijo
Ville Syrjala wrote: > Copy dx/dy from the internal event to the DGA2 Motion/Button events. > Do the same for Key events for the sake of keeping the code consistent. > > Signed-off-by: Ville Syrjala > --- > hw/xfree86/common/xf86DGA.c |8 > 1 files changed, 4 insertions(+), 4 dele

Re: [PATCH] resource: Micro-tune resource hash computation

2011-01-11 Thread Fernando Carrijo
sn't have to know. > > Signed-off-by: Adam Jackson Reviewed-by: Fernando Carrijo ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] input: add valuator_mask_free() to free a valuator mask.

2011-01-05 Thread Fernando Carrijo
> Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > bit of an oversight in the first patchset... > > dix/inpututils.c |8 > include/input.h |1 + > test/input.c |3 ++- > 3 files changed, 11 insertions(+), 1 deletions(-) &

Re: [PATCH 9/9] DIX: Reset window properties when freeing them

2010-12-30 Thread Fernando Carrijo
;optional) > +pWin->optional->userProps = NULL; > } > > static int > -- > 1.7.2.3 Yeah, restoring the default state of the field is a good idea. Reviewed-by: Fernando Carrijo ___ xorg-devel@lists.x.org: X.Org development Archives: ht

Re: [PATCHES] Multitouch v4 - please review

2010-12-29 Thread Fernando Carrijo
Daniel Stone wrote: > Hi all, > I've published v4 of my multitouch patches, addressing (I think) all the > review comments from v3. libXi and xf86-input-evdev are untouched, but > xserver has seen a great deal of cleanups, xinput some minor tweaks, and > inputproto has had the usecases expanded

Re: [PATCH 1/2] xfree86: use a thread for the generation of input events

2010-12-14 Thread Fernando Carrijo
Adam Jackson wrote: [...] > +/** > + * Unregister a device in the threaded input facility > + * > + * @param fd File descriptor which identifies the input device > + * > + * @return 1 if success; 0 otherwise. > + */ > +int > +InputThreadUnregisterDev(int fd) > +{ > +InputThreadDevice *prev,

Re:What's the meaning of XSyncAlarmNotify ?

2010-12-04 Thread Fernando Carrijo
Hi Danny, danny wrote: > Could you explain about the XSyncAlarmNotify? What's function it provides? > Which situation could it be sent by X server? It seems to me XSyncAlarmNotify is an event type, not a request type. And as such, it is delivered from server to clients, not the other way around

Re: [PATCH v2 2/5] dix: Enable client ID tracking in server.

2010-09-14 Thread Fernando Carrijo
Hi Rami, I have a nitpick below. Rami Ylimäki wrote: > Let X server to keep track of client PIDs and process names. Also make > the client tracking interface available for external modules. Linking > order of Xnest libraries needs to be fixed, because libmain depends on > libdix and not vice ve

Re: [PATCH] xfree86: add xf86OptionListDuplicate()

2010-09-13 Thread Fernando Carrijo
raight and sane to me. Reviewed-by: Fernando Carrijo > Signed-off-by: Peter Hutterer > --- > hw/xfree86/common/xf86Opt.h|1 + > hw/xfree86/common/xf86Option.c | 19 +++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/hw/x

Re: [PATCH 2/3] ddx: Prepare xf86 to renounce input handling duties

2010-09-08 Thread Fernando Carrijo
Peter Hutterer wrote: > On Tue, Aug 31, 2010 at 04:00:13PM -0300, Fernando Carrijo wrote: > > From: Fernando Carrijo > > > > Signed-off-by: Fernando Carrijo > > Signed-off-by: Tiago Vignatti > > I think I'd prefer to see these three patches squashed to

Re: [PATCH 3/3] dix: ddx: Lift input handling duties from xf86 to dix

2010-09-08 Thread Fernando Carrijo
Peter Hutterer wrote: > On Tue, Aug 31, 2010 at 04:00:14PM -0300, Fernando Carrijo wrote: > > > > Signed-off-by: Fernando Carrijo > > Signed-off-by: Tiago Vignatti > > --- > > dix/inputhandler.c | 109 ++-- &g

Re: [PATCH 15/19] xfree86: don't export xf86InputDevs.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > On Tue, Sep 07, 2010 at 11:37:33PM -0300, Fernando Carrijo wrote: > > Peter Hutterer wrote: > > > > > Use xf86FirstLocalDevice() instead (but don't get me started on the naming > > > of that one...) > > > > Yeah, a p

Re: [PATCH 15/19] xfree86: don't export xf86InputDevs.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > Use xf86FirstLocalDevice() instead (but don't get me started on the naming > of that one...) Yeah, a poorly chosen name indeed. > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.h |2 +- &

Re: [PATCH 13/19] xfree86: remove XI_PRIVATE macro, unused.

2010-09-07 Thread Fernando Carrijo
public.devicePrivate))->private) > - I see both xf86-input-aiptek and xf86-input-joystick using it. I presume they don't count, do they? If they don't, then: Reviewed-by: Fernando Carrijo > /* Valuator verification macro */ > #define XI_VERIFY_VALUATORS(num_valua

Re: [PATCH 12/19] xfree86: update comment for xf86DeleteInput

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > We have a driver hook - it's UnInit. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/hw/xfree86/com

Re: [PATCH 10/19] xfree86: plug minor memory leak.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > When no identifier for the device was specified, the allocated IDevRec (and > its associated fields) need to be freed. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |3 ++- > 1 files

Re: [PATCH 07/19] xfree86: remove some ifdef 0 code.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > InputInfoRec hasn't had a free function pointer since the git import. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(

Re: [PATCH 06/19] xfree86: move a declaration down to the block it is used in.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput

Re: [PATCH 05/19] xfree86: minor comment fix. HAL → config backend

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c > i

Re: [PATCH 04/19] xfree86: skip a few NULL initialization, calloc does it for us.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput

Re: [PATCH 03/19] xfree86: remove conversion procs and close proc from InputInfoRec.

2010-09-07 Thread Fernando Carrijo
Peter Hutterer wrote: > None of them are called by the server. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |3 --- > hw/xfree86/common/xf86Xinput.h |8 > 2 files changed, 0 insertions(+), 11 d

Re: [PATCH 3/3] dix: ddx: Lift input handling duties from xf86 to dix

2010-09-02 Thread Fernando Carrijo
Alan Coopersmith wrote: > Fernando Carrijo wrote: > >> (You could either try > >> to work out which one applies based on the XFree86 cvs history or just take > >> the easy way out and copy both, since both are licenses we already have all > >> over the t

Re: [PATCH 3/3] dix: ddx: Lift input handling duties from xf86 to dix

2010-09-01 Thread Fernando Carrijo
Alan Coopersmith wrote: > Fernando Carrijo wrote: > > From: Fernando Carrijo > > > > Signed-off-by: Fernando Carrijo > > Signed-off-by: Tiago Vignatti > > --- > > dix/inputhandler.c | 109 ++-- >

[PATCH 3/3] dix: ddx: Lift input handling duties from xf86 to dix

2010-08-31 Thread Fernando Carrijo
From: Fernando Carrijo Signed-off-by: Fernando Carrijo Signed-off-by: Tiago Vignatti --- dix/inputhandler.c | 109 ++-- hw/xfree86/common/xf86Events.c | 122 +++- 2 files changed, 112 insertions(+), 119

[PATCH 2/3] ddx: Prepare xf86 to renounce input handling duties

2010-08-31 Thread Fernando Carrijo
From: Fernando Carrijo Signed-off-by: Fernando Carrijo Signed-off-by: Tiago Vignatti --- hw/xfree86/common/xf86Events.c | 16 +--- hw/xfree86/common/xf86str.h|4 +--- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/hw/xfree86/common/xf86Events.c b/hw

[PATCH 1/3] dix: Prepare dix to embrace input handling duties

2010-08-31 Thread Fernando Carrijo
From: Fernando Carrijo Signed-off-by: Fernando Carrijo Signed-off-by: Tiago Vignatti --- dix/Makefile.am|1 + dix/inputhandler.c | 58 include/Makefile.am|1 + include/inputhandler.h | 46

[PATCH 0/3] Lift part of input handling code from xf86 to dix

2010-08-31 Thread Fernando Carrijo
Ajax originally exposed the requirement embodied in this patches series. See: http://lists.x.org/archives/xorg-devel/2010-August/012204.html Do you guys see inproprieties in the changes I introduce here? Fernando Carrijo (3): dix: Prepare dix to embrace input handling duties ddx: Prepare

Re: [PATCH 7/8] Make the RECORD and DBE extensions builtin

2010-08-30 Thread Fernando Carrijo
Tomas Carnecky wrote: > On 8/29/10 7:01 PM, Fernando Carrijo wrote: > > Tomas Carnecky wrote: > > > >> diff --git a/mi/miinitext.c b/mi/miinitext.c > >> index 5ad7a39..e6f150f 100644 > >> --- a/mi/miinitext.c > >> +++ b/mi/miinitext

Re: [PATCH 7/8] Make the RECORD and DBE extensions builtin

2010-08-29 Thread Fernando Carrijo
Tomas Carnecky wrote: > diff --git a/mi/miinitext.c b/mi/miinitext.c > index 5ad7a39..e6f150f 100644 > --- a/mi/miinitext.c > +++ b/mi/miinitext.c > @@ -532,6 +532,12 @@ static ExtensionModule staticExtensions[] = { > #ifdef XSELINUX > { SELinuxExtensionInit, SELINUX_EXTENSION_NAME, &noSELi

Re: [PATCH libXi] fix build with gcc 2.95

2010-08-26 Thread Fernando Carrijo
Peter Hutterer wrote: > On Thu, Aug 26, 2010 at 08:37:57AM +0200, Matthieu Herrb wrote: > > On Wed, Aug 25, 2010 at 05:53:01PM -0400, Matt Turner wrote: > > > > > > Looks like a sufficiently trivial change, but what system still using > > > gcc 2.95 does anyone care about running modern X.Org on

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-13 Thread Fernando Carrijo
Adam Jackson wrote: > MTX was an experiment in X11R6 to do a multithreaded X server. It sure > does make software rendering faster if you do that, but given the modern > architecture that's a bit like putting twin turbos in your Honda Civic. > You get a fast Civic, but what you were really hopin

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Fernando Carrijo
Adam Jackson wrote: > I do eventually want to see each ScreenRec factored out to its own > thread. Right now in Xinerama rendering is serialized across all > screens, which is terrible. > > If you did that, you'd have one thread for dispatch and core object > model, one for input, and one per G

Re: [PATCH v2] input: constify valuators passed in by input drivers.

2010-08-11 Thread Fernando Carrijo
Tiago Vignatti wrote: > Hi, > > On Tue, Aug 10, 2010 at 07:28:30AM +0200, ext Peter Hutterer wrote: > > On Tue, Aug 10, 2010 at 03:05:48PM +1000, Daniel Stone wrote: > > > > > > malloc() in a signal handler ftl > > > > urgh, yes, thanks. > > ... > > > > I guess you could just have a static

Re: [PATCH 2/2] dix: Fix indentation in WaitForSomething

2010-08-04 Thread Fernando Carrijo
>From 2aa4c74e43556c227ac8c4966689e178c9cbbe40 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Wed, 4 Aug 2010 23:39:21 -0300 Subject: [PATCH 2/2] dix: Fix indentation in WaitForSomething Reviewed-by: Jamey Sharp Reviewed-by: Tiago Vignatti Signed-off-by: Fernando Carrijo ---

Re: [PATCH 1/2] dix: Better document Dispatch, WaitForInput and friends

2010-08-04 Thread Fernando Carrijo
>From fb429c58c113d6a2d38324644239e08b103d6c37 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Wed, 4 Aug 2010 23:34:24 -0300 Subject: [PATCH 1/2] dix: Better document Dispatch, WaitForSomething and friends Wrote this patch more as an exercise than anything else. And while I realize t

[PATCH v3] dix: Better document Dispatch, WaitForInput and friends

2010-08-04 Thread Fernando Carrijo
In the previous version of this patch series, Tiago recommended a minor stylistic modification in the comment created for SmartScheduleClient(). That's what I've done here. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

Re: Select() failing with EAGAIN?

2010-08-04 Thread Fernando Carrijo
Adam Jackson wrote: > On Tue, 2010-08-03 at 17:28 -0300, Fernando Carrijo wrote: > > The Open Group documentation for Select does not mention it failing with > > EAGAIN. > > > > http://opengroup.org/onlinepubs/007908775/xsh/select.html > > > > Even s

Re: [PATCH 1/2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-08-03 Thread Fernando Carrijo
Tiago Vignatti wrote: > > --- a/dix/dispatch.c > > +++ b/dix/dispatch.c > > @@ -240,6 +240,20 @@ long SmartLastPrint; > > voidDispatch(void); > > voidInitProcVectors(void); > > > > +/** > > + * Select the next client to be served. > > + * > > + * The chosen client wil

Re: My proto/ battle plan (Re: [PATCH] Refactoring of dixutils.c)

2010-08-03 Thread Fernando Carrijo
Tomas Carnecky wrote: > On 8/3/10 3:55 AM, Fernando Carrijo wrote: > > Cc-ing Tomas > > > > Tiago Vignatti wrote: > >> I'm looking forward now to see proto/ created, as discussed. > > > > It seems Tomas is already working on this area. See here:

Select() failing with EAGAIN?

2010-08-03 Thread Fernando Carrijo
a fix. >From 7f615aa4f441471979c1a5e090d09cbd019f57d0 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Tue, 3 Aug 2010 17:19:47 -0300 Subject: [PATCH] os: Select can not fail with EAGAIN. Don't check for it in WaitForSomething. Signed-off-by: Fernando Carrijo --- os/WaitFor.c |

Re: [PATCH] Refactoring of dixutils.c

2010-08-02 Thread Fernando Carrijo
Cc-ing Tomas Tiago Vignatti wrote: > Fernando Carrijo wrote: > > > > So, here is the result of my preliminary attempt to bring some order to > > dix. The > > refactoring of the messy dixutils.c into more cohesive files sounded like a > > good > > oportu

Re: [PATCH] xfree86 : Remove unused tokens from xf86parser.h

2010-08-01 Thread Fernando Carrijo
Jesse Adkins wrote: > -/* Keyboard tokens */ > -AUTOREPEAT, > -XLEDS, > -KPROTOCOL, > -XKBKEYMAP, > -XKBCOMPAT, > -XKBTYPES, > -XKBKEYCODES, > -XKBGEOMETRY, > -XKBSYMBOLS, > -XKBDISABLE, > -PANIX106, > -XKBRULES, > -XKBMODEL, > -XKBLAYOU

Re: [PATCH] xfree86: Remove unused constants supposedly for isc cc. Signed-off-by: Jesse Adkins

2010-08-01 Thread Fernando Carrijo
Jesse Adkins wrote: > -/* ISC's cc can't handle ~ of UL constants, so explicitly type cast them. */ > -#define XLED1 ((unsigned long) 0x0001) > -#define XLED2 ((unsigned long) 0x0002) > -#define XLED3 ((unsigned long) 0x0004) > -#define XLED4((unsigned long) 0x0008)

[PATCH 5/7] dix: Extract workqueue.c from within dixutils.c

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- dix/Makefile.am |3 +- dix/dixutils.c | 79 -- dix/workqueue.c | 166 +++ include/dix.h |2 + 4 files changed, 170 insertions(+), 80 deletions(-) create mode 100644 dix

[PATCH 4/7] dix: Extract sleepqueue.c from within dixutils.c

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- dix/Makefile.am |1 + dix/dixutils.c | 85 -- dix/sleepqueue.c | 173 ++ include/dix.h|2 + 4 files changed, 176 insertions(+), 85 deletions(-) create mode 100644

[PATCH 2/7] dix: Extract callback.c from within dixutils.c

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- dix/Makefile.am |1 + dix/callback.c | 322 +++ dix/dixutils.c | 233 3 files changed, 323 insertions(+), 233 deletions(-) create mode 100644 dix/callback.c

[PATCH 1/7] dix: Extract blockhandler.c from within dixutils.c

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- dix/Makefile.am|1 + dix/blockhandler.c | 233 dix/dixutils.c | 145 include/dix.h |1 + 4 files changed, 235 insertions(+), 145 deletions(-) create

[PATCH] Refactoring of dixutils.c

2010-07-30 Thread Fernando Carrijo
So, here is the result of my preliminary attempt to bring some order to dix. The refactoring of the messy dixutils.c into more cohesive files sounded like a good oportunity for me to experiment with the code, and that's what the following statistics are about: [PATCH 1/7] dix: Extract blockhand

[PATCH 6/7] dix: dixutils.c doesn't need those headers anymore. Remove them.

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- dix/dixutils.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/dix/dixutils.c b/dix/dixutils.c index 898dbe5..26a73a3 100644 --- a/dix/dixutils.c +++ b/dix/dixutils.c @@ -81,22 +81,13 @@ Author: Adobe Systems Incorporated

[PATCH 7/7] dix: Cleanup dix.h to match the refactoring suffered by dixutils.c

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- include/dix.h | 44 +--- 1 files changed, 21 insertions(+), 23 deletions(-) diff --git a/include/dix.h b/include/dix.h index 440b9eb..e435456 100644 --- a/include/dix.h +++ b/include/dix.h @@ -172,6 +172,13 @@ extern

[PATCH 3/7] dix: Extract lookup.c from within dixutils.c

2010-07-30 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- dix/Makefile.am |1 + dix/dixutils.c | 92 dix/lookup.c| 183 +++ include/dix.h |2 + 4 files changed, 186 insertions(+), 92 deletions(-) create mode 100644

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-30 Thread Fernando Carrijo
Tomas Carnecky wrote: > Fernando Carrijo wrote: > > > > I probably didn't understand quite well the reason for what you guys mean by > > server-side XCB. Google did't help too much either, although I wonder it > > might > > be not far from avoidin

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-30 Thread Fernando Carrijo
Daniel Stone wrote: > > Fernando Carrijo wrote: > > > > Peter Hutterer wrote: > > > > > > You'll probably have some fun untangling the various ProcRequestName from > > > the dix source files (static files, file-specific defines, etc.). And

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-29 Thread Fernando Carrijo
Peter Hutterer wrote: > Fernando Carrijo wrote: > > > > Would you guys mind if I chose /dix/core and /dix as the new homes for files > > related to the core protocol and the protocol support routines, > > respectively? > > Whenever possible, I prefer to avoid

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-29 Thread Fernando Carrijo
Vignatti Tiago wrote: > Jamey Sharp wrote: > > > > The proposed "lookup.c" is mostly about protocol implementation, though, > > and I'd be happy to see another patch after this series that reorganizes > > dix/ to highlight the protocol implementation bits. Perhaps a separate > > top-level proto/

Re: [PATCH v2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-07-29 Thread Fernando Carrijo
Fernando Carrijo wrote: > Changelog for v3: Sorry, I meant v2, for sure. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/2] dix: Fix indentation of code in WaitForSomething()

2010-07-29 Thread Fernando Carrijo
Reviewed-by: Jamey Sharp Signed-off-by: Fernando Carrijo --- os/WaitFor.c | 55 --- 1 files changed, 28 insertions(+), 27 deletions(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index 66f67e5..14f9719 100644 --- a/os/WaitFor.c +++ b/os

[PATCH v2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-07-29 Thread Fernando Carrijo
Changelog for v3: Amendments as suggested by Jamey and Tiago. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-07-29 Thread Fernando Carrijo
took straight from "Efficiently Scheduling X Clients", for which I hope not to be sued for plagiarism. Others are my own, and I'm still not in position to guarantee their correctness. Reviewed-by: Jamey Sharp Signed-off-by: Fernando Carrijo --- dix/dispatch.c | 74 +

Re: [PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-29 Thread Fernando Carrijo
Tiago Vignatti wrote: > On Wed, Jul 28, 2010 at 10:26:34PM +0200, ext Fernando Carrijo wrote: > > +/* clientReady: > > + * array of clients ready for input and/or output. Actually, the > > + * array is not composed of clients, but of the indexes they occupy > > +

Re: [PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-29 Thread Fernando Carrijo
Jamey Sharp wrote: > On Wed, Jul 28, 2010 at 05:26:34PM -0300, Fernando Carrijo wrote: > > --- > > Wrote this patch more as an exercise than anything else. And while I > > realize that there's a thin line between what people consider benign > > and pernicious comm

[PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-28 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- Wrote this patch more as an exercise than anything else. And while I realize that there's a thin line between what people consider benign and pernicious commenting styles, I tend to believe that in case of intricate code such as this, we better sin for ver

Re: [PATCH 5/5] dix: Extract blockhandler.c from within dixutils.c

2010-07-27 Thread Fernando Carrijo
Fernando Carrijo wrote: > The file dixutils.c has grown into an incohesive and bloated beast. The time > has > come to refactor some of its routines to their own files. This patch gives a > new > home for all of those which deal with work queues. > --- > dix/Makefil

[PATCH 5/5] dix: Extract blockhandler.c from within dixutils.c

2010-07-27 Thread Fernando Carrijo
The file dixutils.c has grown into an incohesive and bloated beast. The time has come to refactor some of its routines to their own files. This patch gives a new home for all of those which deal with work queues. --- dix/Makefile.am |3 +- dix/dixutils.c | 80 - dix/

[PATCH 4/5] dix: Extract sleepqueue.c from within dixutils.c

2010-07-27 Thread Fernando Carrijo
The file dixutils.c has grown into an incohesive and bloated beast. The time has come to refactor some of its routines to their own files. This patch gives a new home for all of those which deal with sleeping clients. --- dix/Makefile.am |1 + dix/dixutils.c | 84 -

[PATCH 3/5] dix: Extract lookup.c from within dixutils.c

2010-07-27 Thread Fernando Carrijo
The file dixutils.c has grown into an incohesive and bloated beast. The time has come to refactor some of its routines to their own files. This patch gives a new home for all of those which deal with resource lookup. --- dix/Makefile.am |1 + dix/dixutils.c | 92 ---

[PATCH 2/5] dix: Extract callback.c from within dixutils.c

2010-07-27 Thread Fernando Carrijo
The file dixutils.c has grown into an incohesive and bloated beast. The time has come to refactor some of its routines to their own files. This patch gives a new home for all of those which deal with callback management. --- dix/Makefile.am |1 + dix/callback.c | 333

[PATCH 1/5] dix: Extract blockhandler.c from within dixutils.c

2010-07-27 Thread Fernando Carrijo
The file dixutils.c has grown into an incohesive and bloated beast. The time has come to refactor some of its routines to their own files. This patch gives a new home for all of those which deal with block and wake up handlers. --- dix/Makefile.am|1 + dix/blockhandler.c | 243 +++

[RFC] Refactoring of dix/dixutils.c

2010-07-27 Thread Fernando Carrijo
My humble attempt to put some order in dix. For lack of inspiration (or knowledge, if you prefer) I didn't touch the original copyright notices, and simply copied them verbatim to the new files; exactly like I did to headers. Ugly, I presume. But just a first try. Do people see any value in things

Re: [PATCH input-synaptics] Added "friction physics" so coasting can stop on its own.

2010-07-12 Thread Fernando Carrijo
Peter Hutterer wrote: > [CC'ing Fernando to avoid duplicate efforts, he was interested in > implementing this] Thanks Peter. Yes, I was really interested in doing it, and even took a break to read the whole synaptics code. And albeit I couldn't make sense of some details of what I read, the exp

Re: request for help - evdev third-button emulation

2010-07-07 Thread Fernando Carrijo
Peter Hutterer wrote: > Just idling along, looking for something to do? There's a low-hanging fruit > that I've had on my todo list for ages but never found the time for: > third-mouse button emulation in evdev. > > What I eventually want is: if the emulation is enabled, a non-moving touch > emi

Re: [ANNOUNCE] xorg-server 1.8.99.904

2010-07-01 Thread Fernando Carrijo
On Thu, 1 Jul 2010 13:24:02 -0600, Jonathan Corbet wrote: > On Thu, 01 Jul 2010 16:15:58 -0300 > Fernando Carrijo wrote: > > > For sure the information contained in git logs don't measure how high-level > > the > > changes are being submitted, but it woul

Re: [ANNOUNCE] xorg-server 1.8.99.904

2010-07-01 Thread Fernando Carrijo
Tiago Vignatti wrote: > If I have more motivation I'll try to get some stats comparing different > versions of the server development and maybe other modules. Also, if you are > interested on different kind of statistics I can run more. Suggestions are > very welcome and appreciated (for instance

Re: [PATCH] Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Tiago Vignatti wrote: > Cool! For all patches: > > Acked-by: Tiago Vignatti Thank you. > BTW, I guess you set up some script to do this work and would be nice to share > it. More or less, Tiago. I dropped all occurrences of the macros by hand since there were some nested #define cases I d

Re: [PATCH 27-27] xf86-video-xgi: Purge macro NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/xgi.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/xgi.h b/src/xgi.h index fd2c6fa..715502f 100755 --- a/src/xgi.h +++ b/src/xgi.h @@ -265,7 +265,6 @@ extern BOOL g_bRunTimeDebug; #ifdef XGIMERGED #ifdef XGIXINERAMA

Re: [PATCH 26-27] xf86-video-vmware: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/vmwarectrl.c |2 -- src/vmwarexinerama.c |2 -- vmwarectrl/libvmwarectrl.c |2 -- 3 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/vmwarectrl.c b/src/vmwarectrl.c index d9ceaa4..d0aace5 100644 --- a/src

Re: [PATCH 25-27] xf86-video-sisusb: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/sisusb.h |1 - src/sisusb_utility.c |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/sisusb.h b/src/sisusb.h index b9992ac..fbbebc5 100644 --- a/src/sisusb.h +++ b/src/sisusb.h @@ -141,7 +141,6 @@ #define

Re: [PATCH 24-27] xf86-video-sis: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/sis.h |1 - src/sis_utility.c |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/sis.h b/src/sis.h index 400b83f..2144052 100644 --- a/src/sis.h +++ b/src/sis.h @@ -251,7 +251,6 @@ #endif /* Need that for SiSCtrl

Re: [PATCH 23-27] xf86-video-intel: Purge macro NEED_EVENTS

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- uxa/uxa-priv.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/uxa/uxa-priv.h b/uxa/uxa-priv.h index b107928..92536cc 100644 --- a/uxa/uxa-priv.h +++ b/uxa/uxa-priv.h @@ -39,7 +39,6 @@ #include "uxa.h" #include

Re: [PATCH 22-27] xf86-input-vmmouse: Purge macro NEED_EVENTS

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/vmmouse.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/vmmouse.c b/src/vmmouse.c index 1b08eff..f5ad234 100644 --- a/src/vmmouse.c +++ b/src/vmmouse.c @@ -48,7 +48,6 @@ #endif #include -#define NEED_EVENTS #include

Re: [PATCH 21-27] xf86-input-mouse: Purge macro NEED_EVENTS

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/hurd_mouse.c |1 - src/mouse.c |1 - src/pnp.c|1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/hurd_mouse.c b/src/hurd_mouse.c index 9f87e79..222c8ad 100644 --- a/src/hurd_mouse.c +++ b/src/hurd_mouse.c

Re: [PATCH 20-27] xf86-input-keyboard: Purge macro NEED_EVENTS

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/bsd_kbd.c |2 -- src/hurd_kbd.c |1 - src/kbd.c |1 - src/lnx_kbd.c |2 -- 4 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c index aa0d473..3653042 100644 --- a/src/bsd_kbd.c +++ b/src

Re: [PATCH 19-27] libXxf86vm: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/XF86VMode.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/XF86VMode.c b/src/XF86VMode.c index 83512ca..d924e2a 100644 --- a/src/XF86VMode.c +++ b/src/XF86VMode.c @@ -30,8 +30,6 @@ from Kaleb S. KEITHLEY. /* THIS IS NOT AN

Re: [PATCH 18-27] libXxf86dga: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/XF86DGA.c |3 --- src/XF86DGA2.c |2 -- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/XF86DGA.c b/src/XF86DGA.c index a6e66a4..4effcaf 100644 --- a/src/XF86DGA.c +++ b/src/XF86DGA.c @@ -58,9 +58,6 @@ Copyright (c) 1995,1996

Re: [PATCH 17-27] libXv: Purge macro NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/Xvlibint.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/Xvlibint.h b/src/Xvlibint.h index 501a211..fcc4a61 100644 --- a/src/Xvlibint.h +++ b/src/Xvlibint.h @@ -41,8 +41,6 @@ SOFTWARE. ** */ -#define NEED_REPLIES

Re: [PATCH 16-27] libXvMC: Purge macro NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/XvMC.c |2 -- src/XvMClibint.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/XvMC.c b/src/XvMC.c index 3d9b7b0..a850dc7 100644 --- a/src/XvMC.c +++ b/src/XvMC.c @@ -1,7 +1,5 @@ /* $XFree86: xc/lib/XvMC/XvMC.c,v 1.4

Re: [PATCH 15-27] libXtst: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/XRecord.c |2 -- src/XTest.c |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/XRecord.c b/src/XRecord.c index a0f7c52..40fbcc5 100644 --- a/src/XRecord.c +++ b/src/XRecord.c @@ -54,8 +54,6 @@ from The Open Group

Re: [PATCH 14-27] libXScrnSaver: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/XScrnSaver.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/XScrnSaver.c b/src/XScrnSaver.c index 0bbdc60..d496b94 100644 --- a/src/XScrnSaver.c +++ b/src/XScrnSaver.c @@ -28,8 +28,6 @@ in this Software without prior written

Re: [PATCH 13-27] libXRes: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/XRes.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/XRes.c b/src/XRes.c index ed6fe52..2d46af4 100644 --- a/src/XRes.c +++ b/src/XRes.c @@ -3,8 +3,6 @@ */ /* $XFree86: xc/lib/XRes/XRes.c,v 1.3 2002/03/10 22:06:53 mvojkovi

Re: [PATCH 12-27] libxrender: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/Xrenderint.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/Xrenderint.h b/src/Xrenderint.h index 49a294b..9119246 100644 --- a/src/Xrenderint.h +++ b/src/Xrenderint.h @@ -26,8 +26,6 @@ #define _XRENDERINT_H_ #include

Re: [PATCH 11-27] libXrandr: Purge macros NEED_EVENTS and NEED_REPLIES

2010-07-01 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo --- src/Xrandrint.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/Xrandrint.h b/src/Xrandrint.h index 75e38c9..7fb5831 100644 --- a/src/Xrandrint.h +++ b/src/Xrandrint.h @@ -25,8 +25,6 @@ #ifndef _XRANDRINT_H_ #define

  1   2   >