Re: [PATCH v2 4/5] DRI2: Expose API to set drawable swap limit.

oing our N-buffering without the current hack. Just in case it helps to have more RBs to get this patch in: Reviewed-by: Francisco Jerez > --- > hw/xfree86/dri2/dri2.c | 23 +++ > hw/xfree86/dri2/dri2.h |1 + > 2 files changed, 24 insertions(+), 0 deletion

Re: Fence Sync patches

James Jones writes: > On Sunday 05 December 2010 20:31:24 Owen Taylor wrote: >[...] >> Something like this was the first thing that came to mind (well, not the >> sequence number, since those are per-client, but say associating an XSync >> counter with the damage object.) I don't think it's very

Re: [PATCH v2 5/5] DRI2: Allow DDX to validate swap_limit changes

Pauli Nieminen writes: > On 11/11/10 18:46 +0100, ext Jesse Barnes wrote: >> On Mon, 1 Nov 2010 16:22:01 +0200 >> Pauli Nieminen wrote: >> >> > DDX can now implement validation for swap_limit changes to prevent >> > configurations that are not support in driver. >> > >> > Signed-off-by: Pauli

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

Keith Packard writes: > On Thu, 21 Oct 2010 01:38:58 +0200, Francisco Jerez > wrote: > >> Nouveau uses the hardware interchannel synchronization primitives on >> demand (it kicks in when two channels have references to the same BO): >> the nouveau DRM guarante

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

Keith Packard writes: > On Wed, 20 Oct 2010 15:03:59 -0700, Aaron Plattner > wrote: > >> Fine, but will you be willing to move this call to the drivers that need it >> when we have a real sync extension? > > I don't see the point -- it doesn't change anything visible to clients > or drivers, ot

Re: [PATCH] DRI2: Expose API to set drawable swap limit.

in allocation and selecting next back. > > Signed-off-by: Pauli Nieminen I can confirm that this works with some experimental patches for the nouveau driver that make it do pageflip with triple buffering, my 'Reviewed-by' is pretty useless here, so: Tested-by: Francisco Jerez >

Re: [PATCH video-siliconmotion] Added detection of SM501 on PPC LocalBus.

Marc Scherer writes: > This is the first patch in a series to make the Siliconmotion driver > work with the TQM5200 Board. > > If no PCI device is found the driver tries to MMIO to the relevant > location for a SM501 on PowerPC Localbus. If it finds the right device > ID after MMIO-mapping it ass

[PATCH] dri2: Update the fake front on SwapBuffers (bug 27305).

idate event, so we cannot rely on this behavior anymore. It was reported to make the following piglit/glean test cases regress: texgen, coloredTexPerf2, coloredLitPerf2. Signed-off-by: Francisco Jerez --- hw/xfree86/dri2/dri2.c | 32 ++-- 1 files changed, 18 insertions(+

Re: [xserver patch v5 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

Ian Romanick writes: > Kristian Høgsberg wrote: >> 2010/3/22 Ian Romanick : >>> Kristian Høgsberg wrote: >>>> 2010/2/8 Francisco Jerez : >>>>> The spec says (regarding glXCreateWindow): "If there is already a >>>>> GLXFBConfig ass

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

Keith Packard writes: > On Mon, 22 Mar 2010 12:51:36 +0100, Francisco Jerez > wrote: > >> v9 of this patch is almost what you're describing (link: [1]). The AIGLX >> code also makes use of this interface and in that case it didn't make a >> lot of sense to

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

Keith Packard writes: > On Tue, 16 Mar 2010 10:26:54 -0400, Kristian Høgsberg > wrote: > >> Yes, the series look good and I've updated my branch: > > I don't like this code. It adds an unnecessary layer between > DRI2TrackClient and the dri2ext code, with a 'priv' element, > 'invalidate' and 'd

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

Keith Packard writes: > I want to get this patch sequence merged, can someone point me at a > repository that I can pull it in from? Kristian, are you OK with v10? If so, could you gather the whole patch series in your personal tree? pgpITtxpMrg3J.pgp Description: PGP signature ___

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

Peter Hutterer writes: > On Mon, Mar 01, 2010 at 08:19:44PM +0100, Francisco Jerez wrote: >> Bumps the supported DRI2 protocol version. >> >> Signed-off-by: Francisco Jerez >> --- >> v10: Move resource allocation to dri2ext.c. >> >> configure.ac

Re: Problem using an Mesa based App with recent xorg/mesa/xf86-video-intel (loop?)

Florian Mickler writes: > [...] > p.s.: my software stack is git master of libdrm, mesa > and xf86-video-intel as well as xserver-master + krh's pull request, so > that it looks light that: > 90b6ab4c5f057737b5396f987fdea7dd5716b086 glx/dri2: Notify the driver when its > buffers become invalid.

[PATCHv10 5/5] glx/dri2: Notify the driver when its buffers become invalid.

Signed-off-by: Francisco Jerez --- glx/glxdri2.c | 53 + 1 files changed, 33 insertions(+), 20 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index edd29b0..f162f38 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -107,8 +107,10

[PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- v10: Move resource allocation to dri2ext.c. configure.ac|2 +- hw/xfree86/dri2/dri2.c | 122 +++ hw/xfree86/dri2/dri2.h |6 ++ hw/xfree86

[PATCHv9 5/5] glx/dri2: Notify the driver when its buffers become invalid.

Signed-off-by: Francisco Jerez --- glx/glxdri2.c | 53 + 1 files changed, 33 insertions(+), 20 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index edd29b0..2eec53b 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -107,8 +107,10

[PATCHv9 4/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- v9: Use a separate resource type to track client refs, let the caller specify an opaque closure and pass it to the invalidate handler instead of the resource ID, don't call the invalidate hooks on dra

[PATCHv9 3/5] dri2: No need to blit from front on DRI2GetBuffers if they're just being reused.

It can be quite an expensive operation, so we're better off not doing it unless it's totally required. Signed-off-by: Francisco Jerez --- hw/xfree86/dri2/dri2.c | 42 +++--- 1 files changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/xf

[PATCHv9 2/5] Import linked list helpers from the intel DDX.

Borrowed from i830.h, except for list_for_each_entry(). Signed-off-by: Francisco Jerez --- include/Makefile.am |1 + include/list.h | 101 +++ 2 files changed, 102 insertions(+), 0 deletions(-) create mode 100644 include/list.h diff

[PATCHv9 1/5] Add a ConfigNotify hook.

Executed from the ConfigureWindow request, right before sending ConfigureNotify to the clients. This commit breaks the ScreenRec ABI. Signed-off-by: Francisco Jerez --- dix/window.c |4 include/scrnintstr.h | 10 ++ 2 files changed, 14 insertions(+), 0 deletions

Re: [xserver patch v8 4/5] dri2: Support the DRI2InvalidateBuffers event.

Jesse Barnes writes: > On Tue, 23 Feb 2010 13:30:22 +0100 > Francisco Jerez wrote: > >> Bumps the supported DRI2 protocol version. >> >> Signed-off-by: Francisco Jerez >> --- >> v8: s/PreConfigureWindow/ConfigNotify/ >> >> configure.ac

[PATCH] Make the ordering restrictions of DRI2InvalidateBuffers explicit.

Signed-off-by: Francisco Jerez --- dri2proto.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dri2proto.txt b/dri2proto.txt index f74792e..64786ec 100644 --- a/dri2proto.txt +++ b/dri2proto.txt @@ -475,6 +475,12 @@ The name of this extension is "

[xserver patch v8 4/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- v8: s/PreConfigureWindow/ConfigNotify/ configure.ac|2 +- hw/xfree86/dri2/dri2.c | 110 +++ hw/xfree86/dri2/dri2.h |4 ++ hw/xfree86/dri2

[xserver patch v6 1/5] Add a ConfigNotify hook.

Executed from the ConfigureWindow request, right before sending ConfigureNotify to the clients. This commit breaks the ScreenRec ABI. Signed-off-by: Francisco Jerez --- v6: s/PreConfigureWindow/ConfigNotify/ dix/window.c |4 include/scrnintstr.h | 10 ++ 2 files

Re: [xserver patch v6 4/5] dri2: Support the DRI2InvalidateBuffers event.

Keith Packard writes: > On Mon, 22 Feb 2010 23:56:59 +0100, Francisco Jerez > wrote: > >> Discussed here [1], in short, the point of the PreConfigureWindow hook >> is that it's executed before any ConfigureNotify events get queued up, >> we want this to av

[xserver patch v7 4/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- v7: Use the standard hook "protocol" in DRI2PreConfigureWindow (this time for real...). configure.ac|2 +- hw/xfree86/dri2/dri2.c | 110 +

[xserver patch v6 4/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- v6: Use the standard hook "protocol" in DRI2PreConfigureWindow. configure.ac|2 +- hw/xfree86/dri2/dri2.c | 107 +++ hw/xfree86/d

Re: [PULL] DRI2 Invalidate series

Keith Packard writes: > It looks like the new PreConfigureWindow function is only used to detect > window size changes, which the existing ResizeWindow function should do > just fine. > Discussed here [1], in short, the point of the PreConfigureWindow hook is that it's executed before any Configu

[xserver patch v5 5/5] glx/dri2: Notify the driver when its buffers become invalid.

Signed-off-by: Francisco Jerez --- glx/glxdri2.c | 54 -- 1 files changed, 36 insertions(+), 18 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 0f998de..2cfc691 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -102,14 +102,14

[xserver patch v5 4/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. --- v5: Restructuring as proposed by Kristian: Don't duplicate the invalidation policy in the GLX code, keep it in dri2.c and hide the actual invalidation mechanism behind an opaque callback. configure.ac|2 +- hw/xfree86/dri2/dri2.c

[xserver patch v5 1/5] Add a PreConfigureWindow hook.

Executed from the ConfigureWindow request, right before sending ConfigureNotify to the clients. This commit breaks the ScreenRec ABI. Signed-off-by: Francisco Jerez --- v5: No need to bump the module ABI again. dix/window.c |4 include/scrnintstr.h | 10 ++ 2 files

[xserver patch v5 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

The spec says (regarding glXCreateWindow): "If there is already a GLXFBConfig associated with win (as a result of a previous glXCreateWindow call), then a BadAlloc error is generated.". It will also come useful to implement DRI2InvalidateBuffers for the indirect case. Signed-off-by:

Re: [xserver patch v4 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

Kristian Høgsberg writes: > On Mon, Feb 8, 2010 at 1:25 PM, Francisco Jerez wrote: >> The spec says (regarding glXCreateWindow): "If there is already a >> GLXFBConfig associated with win (as a result of a previous >> glXCreateWindow call), then a BadAlloc error is ge

Re: [Mesa3d-dev] [xserver patch v4 4/5] glx/dri2: Notify the driver when its buffers become invalid.

ay require the use of some #ifdefs in the > changes. > That's one of the reasons of the last rebase, see the comments in "[mesa patch v4 1/3] dri2: Event driven buffer validation.". > Keith > > On Mon, 2010-02-08 at 10:25 -0800, Francisco Jerez wrote: >> S

[mesa patch v4 3/3] st/dri2: Use event-driven buffer validation.

--- src/gallium/state_trackers/dri/dri_context.c |6 +-- src/gallium/state_trackers/dri/dri_drawable.c | 13 ++ src/gallium/state_trackers/dri/dri_screen.c | 12 ++ src/mesa/SConscript |1 - src/mesa/sources.mak |1 - sr

[mesa patch v4 2/3] dri/nouveau: Use event driven buffer validation.

--- src/mesa/drivers/dri/nouveau/nouveau_context.c | 33 +--- src/mesa/drivers/dri/nouveau/nouveau_screen.c | 12 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_context.c b/src/mesa/drivers/dri/nouveau/nouveau

[mesa patch v4 1/3] dri2: Event driven buffer validation.

When a buffer invalidation event is received from the X server, the "invalidate" hook of the DRI2 flush extension is executed: A generic implementation (dri2InvalidateDrawable) is provided that just bumps the "pStamp" sequence number in __DRIdrawableRec. For old servers not supporting buffer inval

[xserver patch v4 5/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- configure.ac|2 +- hw/xfree86/dri2/dri2.c | 109 +++ hw/xfree86/dri2/dri2.h |5 ++ hw/xfree86/dri2/dri2ext.c | 35 -- include

[xserver patch v4 4/5] glx/dri2: Notify the driver when its buffers become invalid.

Signed-off-by: Francisco Jerez --- glx/glxdri2.c | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 0f998de..dae7b42 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -67,6 +67,7 @@ struct __GLXDRIscreen

[xserver patch v4 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

The spec says (regarding glXCreateWindow): "If there is already a GLXFBConfig associated with win (as a result of a previous glXCreateWindow call), then a BadAlloc error is generated.". It will also come useful to implement DRI2InvalidateBuffers for the indirect case. Signed-off-by:

[xserver patch v4 2/5] dri2: No need to blit from front on DRI2GetBuffers if they're just being reused.

It can be quite an expensive operation, so we're better off not doing it unless it's totally required. Signed-off-by: Francisco Jerez --- hw/xfree86/dri2/dri2.c | 42 +++--- 1 files changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/xf

[xserver patch v4 1/5] Add a PreConfigureWindow hook.

Executed from the ConfigureWindow request, right before sending ConfigureNotify to the clients. This commit breaks the ScreenRec ABI. Signed-off-by: Francisco Jerez --- dix/window.c |4 hw/xfree86/common/xf86Module.h |6 +++--- include/scrnintstr.h

[dri2proto patch v4] Define an event to notify clients about the validity of their buffers.

Bumps the protocol and package versions. Signed-off-by: Francisco Jerez --- configure.ac |2 +- dri2proto.h | 19 +-- dri2proto.txt | 31 --- 3 files changed, 42 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [Mesa3d-dev] [RFC] Event-based buffer validation for DRI2.

Francisco Jerez writes: > Francisco Jerez writes: > >> The current buffer validation approach (AKA the DRI2 glViewport hack) >> is both incorrect (because a compliant OpenGL application may opt for >> the identity as viewport transform and work with window coor

[mesa patch v3 3/3] st/dri2: Use event-driven buffer validation.

--- src/gallium/state_trackers/dri/dri_context.c |6 +-- src/gallium/state_trackers/dri/dri_drawable.c | 13 ++ src/gallium/state_trackers/dri/dri_screen.c | 13 ++ src/mesa/SConscript |1 - src/mesa/sources.mak |1 - sr

[mesa patch v3 2/3] dri/nouveau: Use event driven buffer validation.

--- src/mesa/drivers/dri/nouveau/nouveau_context.c | 49 --- src/mesa/drivers/dri/nouveau/nouveau_context.h |7 +++ src/mesa/drivers/dri/nouveau/nouveau_driver.c |3 + src/mesa/drivers/dri/nouveau/nouveau_render_t.c |2 + src/mesa/drivers/dri/nouveau/nouveau_s

[mesa patch v3 1/3] dri2: Event driven buffer validation.

When a buffer invalidation event is received from the X server, the "invalidate" hook of the DRI2 flush extension is executed: A generic implementation (dri2InvalidateDrawable) is provided that just bumps the "pStamp" sequence number in __DRIdrawableRec. For old servers not supporting buffer inval

[xserver patch v3 5/5] dri2: Support the DRI2InvalidateBuffers event.

Bumps the supported DRI2 protocol version. Signed-off-by: Francisco Jerez --- configure.ac|2 +- hw/xfree86/dri2/dri2.c | 109 +++ hw/xfree86/dri2/dri2.h |5 ++ hw/xfree86/dri2/dri2ext.c | 35 -- include

[xserver patch v3 4/5] glx/dri2: Notify the driver when its buffers become invalid.

Signed-off-by: Francisco Jerez --- glx/glxdri2.c | 31 --- 1 files changed, 28 insertions(+), 3 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 69fd39b..5cb15d9 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -67,6 +67,7 @@ struct __GLXDRIscreen

[xserver patch v3 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

The spec says (regarding glXCreateWindow): "If there is already a GLXFBConfig associated with win (as a result of a previous glXCreateWindow call), then a BadAlloc error is generated.". It will also come useful to implement DRI2InvalidateBuffers for the indirect case. Signed-off-by:

[xserver patch v3 2/5] dri2: No need to blit from front on DRI2GetBuffers if they're just being reused.

It can be quite an expensive operation, so we're better off not doing it unless it's totally required. Signed-off-by: Francisco Jerez --- hw/xfree86/dri2/dri2.c | 42 +++--- 1 files changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/xf

[xserver patch v3 1/5] Add a PreConfigureWindow hook.

Executed from the ConfigureWindow request, right before sending ConfigureNotify to the clients. This commit breaks the ScreenRec ABI. Signed-off-by: Francisco Jerez --- dix/window.c |4 hw/xfree86/common/xf86Module.h |6 +++--- include/scrnintstr.h

[dri2proto patch v3] Define an event to notify clients about the validity of their buffers.

Bumps the protocol and package versions. Signed-off-by: Francisco Jerez --- configure.ac |2 +- dri2proto.h | 19 +-- dri2proto.txt | 31 --- 3 files changed, 42 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [Mesa3d-dev] [RFC] Event-based buffer validation for DRI2.

Francisco Jerez writes: > The current buffer validation approach (AKA the DRI2 glViewport hack) > is both incorrect (because a compliant OpenGL application may opt for > the identity as viewport transform and work with window coordinates > directly) and inefficient (some programs ha

Re: Status of the siliconmotion fd.o driver

Hi, Bernie Innocenti writes: > Hello Francisco, > > you appear to be a maintainer of the xf-86-video-siliconmotion > tree at git.freedesktop.org. > Alex (CC'ed) is the "official" maintainer, but neither of us has been doing anything siliconmotion-related for a while, I just have look at the bug

[PATCH] dix: Fix a double free in dixFreePrivates.

items[i].size was never zeroed out. Do it in dixResetPrivates. Signed-off-by: Francisco Jerez --- dix/privates.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dix/privates.c b/dix/privates.c index 3a2deb8..e3e7274 100644 --- a/dix/privates.c +++ b/dix/privates.c @@ -303,6

Re: [PATH] xf86-silicon-driver: fix segfault on LynxE chipset

Hi, Matthieu Herrb writes: > This patch fixes a segfault on LynxE chipsets and any other chipset > where IOBase is NULL: > > [...] Thanks, pushed, with a small correction. BTW, that chipset seems very old, and I don't think it has been tested at all since we switched to RandR1.2. I would be ve