Re: modular: Changes to 'master'

2009-10-08 Thread Jeremy Huddleston
Yes, but where is your rule for mkfontscale? ./tinderbox_test.sh jhbuild clean: libfontenc has a dependency on unknown "mkfontscale" module Usage: jhbuild [ -f config ] command [ options ... ] jhbuild autobuild: libfontenc has a dependency on unknown "mkfontscale" module Usage: jhbuild [

Re: [PATCH] Rootless: Abstract some of the Xplugin specific stuff which has crept into rootlessWindow.c

2009-10-09 Thread Jeremy Huddleston
On Oct 9, 2009, at 11:13, Jon TURNEY wrote: The rootless extension now directly calls some Xplugin functions, and relies on types defined in Xplugin.h, which isn't very abstracted :-) This patch is a start at abstracting some of the Xplugin specific stuff which has crept into rootlessWindo

Re: [PATCH] Rootless: Abstract some of the Xplugin specific stuff which has crept into rootlessWindow.c

2009-10-10 Thread Jeremy Huddleston
Yep, that looks fine. I'll test them later today if I have time... Monday if I can't today. --Jeremy On Oct 10, 2009, at 06:20, Jon TURNEY wrote: On 10/10/2009 03:44, Jeremy Huddleston wrote: On Oct 9, 2009, at 11:13, Jon TURNEY wrote: The rootless extension now directly

Re: Finishing the X11R7.5 katamari

2009-10-10 Thread Jeremy Huddleston
On Oct 9, 2009, at 22:01, Alan Coopersmith wrote: All the libraries on the list are released. I notice these omissions from releases, and just want to make sure they are intentional: libXevie ... RIP libxkbui ... ??? libXp... RIP libXtrap ... RIP Almost all the protocol modules are

Re: libXft: Changes to 'master'

2009-10-10 Thread Jeremy Huddleston
It looks like the dac73a51981632908ce86cff26af5b0bcfcdd770 isn't doing what it should be here on my system... the version numbers are not in the generated Xft.h ... interestingly, they are in config.h ... ??? /* include/X11/Xft/Xft.h. Generated from Xft.h.in by configure. */ ... /* * Curre

Re: libXft: Changes to 'master'

2009-10-10 Thread Jeremy Huddleston
It seems to be a bug in Apple's shipped auto*... when I autoreconf with my autotools built from MacPorts, it works... the shipped versions seem ok... On Oct 10, 2009, at 23:20, Jeremy Huddleston wrote: It looks like the dac73a51981632908ce86cff26af5b0bcfcdd770 isn't doing what it

[PATCH] xset: --without-{xf86misc,fontcache,xprint}

2009-10-13 Thread Jeremy Huddleston
diff --git a/configure.ac b/configure.ac index 194514c..1b774ef 100644 --- a/configure.ac +++ b/configure.ac @@ -56,25 +56,43 @@ PKG_CHECK_MODULES(SET_XKB, x11, AC_CHECK_HEADERS([X11/XKBlib.h],,,[#include ]) CPPFLAGS="$SAVE_CPPFLAGS"],[echo "not found"]) -PKG_CHECK_MODULES(SET_X

[PATCH] xdpyinfo: Add support for --without-xf86misc

2009-10-13 Thread Jeremy Huddleston
Since it's gone, I don't want it accidently finding a copy of xf86misc lying outside $prefix diff --git a/configure.ac b/configure.ac index 5d4e904..03c2fb4 100644 --- a/configure.ac +++ b/configure.ac @@ -78,13 +78,19 @@ else fi -PKG_CHECK_MODULES(DPY_XF86MISC, xxf86misc, - [SAVE_CPPF

Re: [PATCH] Rootless: src drawable window can now be NULL

2009-10-13 Thread Jeremy Huddleston
That looks like a sane enough sanity check... but why was pSrc- >pDrawable NULL in the first place? I'll check it out on XQuartz later today. On Oct 13, 2009, at 01:45, Colin Harrison wrote: Hi, This is one for Jeremy Huddleston and Jon Turney. Found when testing rootless modes

bitmaps stipple

2009-10-13 Thread Jeremy Huddleston
the stipple bitmaps from the 'app/bitmap' and 'data/bitmaps' modules collide on case-insensitive file systems: http://cgit.freedesktop.org/xorg/data/bitmaps/tree/stipple http://cgit.freedesktop.org/xorg/app/bitmap/tree/Stipple What's the best way to solve this issue? Why are there two stipple

Re: [PATCH] Rootless: Abstract some of the Xplugin specific stuff which has crept into rootlessWindow.c

2009-10-13 Thread Jeremy Huddleston
ew/test on your end. Signed-off-by: Jeremy Huddleston diff --git a/hw/xquartz/xpr/xprFrame.c b/hw/xquartz/xpr/xprFrame.c index a3e2076..53dde7a 100644 --- a/hw/xquartz/xpr/xprFrame.c +++ b/hw/xquartz/xpr/xprFrame.c @@ -83,6 +83,8 @@ static void xprDamageRects(RootlessFrameID wid, int nre

Re: [PATCH] Rootless: src drawable window can now be NULL

2009-10-13 Thread Jeremy Huddleston
On Oct 13, 2009, at 01:45, Colin Harrison wrote: Hi, This is one for Jeremy Huddleston and Jon Turney. Found when testing rootless modes in Xming using the new xeyes (uses Xrender to anti-alias). Patch to fix the crash and make it work... Looks like we need this in RootlessGlyphs as

cherry-pick to master

2009-10-13 Thread Jeremy Huddleston
anks, Jeremy commit 7e178ffbed7c8557faf8d471ad275aa2b0365e1d Author: Jeremy Huddleston Date: Tue Oct 13 12:54:56 2009 -0700 Rootless: src drawable window can now be NULL Fix a possible crash when pSrc->pDrawable is NULL. Signed-off-by: Colin Harrison Signed-off-by: Jer

Re: cherry-pick to master

2009-10-13 Thread Jeremy Huddleston
On Oct 13, 2009, at 13:16, Keith Packard wrote: Excerpts from Jeremy Huddleston's message of Tue Oct 13 12:59:19 -0700 2009: Hi Keith, Can you please pull these two commits into master: 6980f77892e0409b44bd8f33ba82e7273c6462a4 7e178ffbed7c8557faf8d471ad275aa2b0365e1d I'm still waiting on P

Re: git practices

2009-10-13 Thread Jeremy Huddleston
On Oct 13, 2009, at 14:48, Peter Hutterer wrote: On Tue, Oct 13, 2009 at 12:08:53PM -0700, Jeremy Huddleston wrote: I'm still holding off branching from master or creating my own xserver git because I want to read your promised "best practices", so I do it correctly. Have yo

Re: git practices

2009-10-13 Thread Jeremy Huddleston
clearing this up, Jeremy On Oct 13, 2009, at 16:45, Peter Hutterer wrote: On Tue, Oct 13, 2009 at 04:01:19PM -0700, Jeremy Huddleston wrote: On Oct 13, 2009, at 14:48, Peter Hutterer wrote: On Tue, Oct 13, 2009 at 12:08:53PM -0700, Jeremy Huddleston wrote: I'm still holding off branching

Re: git practices

2009-10-13 Thread Jeremy Huddleston
On Oct 13, 2009, at 19:11, Peter Hutterer wrote: Note that while I'm writing this email there's a discussion on IRC about this anyway, so I don't know what the final verdict will be on that. Well, I'll need to read through my IRC logs when I get into the office tomorrow then. yes, but n

Re: [PULL] fixes and clean ups for alpha

2009-10-13 Thread Jeremy Huddleston
On Oct 13, 2009, at 20:22, Keith Packard wrote: Excerpts from Matt Turner's message of Tue Oct 13 18:48:10 -0700 2009: Actually before I sent the pull request I did `git pull origin master` to verify that there were no conflicts, and when there weren't I did a `git reset --hard HEAD^`.

Re: xbitmaps 1.1.0

2009-10-14 Thread Jeremy Huddleston
On Oct 14, 2009, at 14:13, Alan Coopersmith wrote: Yaakov (Cygwin/X) wrote: On 13/10/2009 00:16, Alan Coopersmith wrote: A minor release of the standard collection of XBM-format bitmap images used by many X clients. Besides the normal janitorial changes, this adds in 2 bitmaps that were com

Re: [PATCH:app/xinit] Use platform-specific X server names in man pages for cygwin & darwin

2009-10-16 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston although this looks fishy to me: XCONFIGFILEMAN='${XCONFIGFILE} (__filemansuffix__)' ... -D__XCONFIGFILEMAN__='$(XCONFIGFILEMAN)' My brain isn't at 100% right now, so I can't recall if that's evaluated correctly. Sinc

Re: [PATCH:app/xinit] Use platform-specific X server names in man pages for cygwin & darwin

2009-10-18 Thread Jeremy Huddleston
On Oct 17, 2009, at 12:15, Alan Coopersmith wrote: Jon TURNEY wrote: I'm not sure why this sentence mentions the configuration file at all. Currently this reads: "It may be convenient to specify server options with startx to change on a per-session basis the default color depth, the s

Tinderbox regression: libX11 specs

2009-10-19 Thread Jeremy Huddleston
libX11's documentation is failing to build after this commit: http://tinderbox.x.org/builds/2009-10-19-0038/logs/libX11/ commit d3f801fd2f9198eaad6797414dba652f9c006c6d Author: Yaakov Selkowitz Date: Sun Oct 18 17:34:53 2009 -0500 Fix VPATH build of libX11 specs Signed-off-by: Yaako

[PATCH libX11] Add AC_ARG_VAR for GROFF and PS2PDF

2009-10-20 Thread Jeremy Huddleston
This allows you to set these environment variables to choose which binary to use rather than searching $PATH Signed-off-by: Jeremy Huddleston --- configure.ac |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index db83f26..20f2f24 100644

Re: [PATCH:xcb/util] Update autogen.sh to one that does builddir != srcdir

2009-10-20 Thread Jeremy Huddleston
Shouldn't we be nuking all the "--enable-maintainer-mode" in autogen.sh now... or do we still want to support the older toolchains? I thought I saw a commit fly by a few days ago nuking that from a module. On Oct 20, 2009, at 10:17, Jon TURNEY wrote: --- autogen.sh | 11 ++- 1 f

Re: [PATCH:util/modular] Update dependencies of xlsclients to xcb and xcb-util

2009-10-20 Thread Jeremy Huddleston
I think xcb-util should also be put in the xorg-libs meta module as well. With that change, Signed-off-by: Jeremy Huddleston On Oct 20, 2009, at 10:17, Jon TURNEY wrote: Also add xcb-util --- xorg.modules |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH libX11] Add AC_ARG_VAR for GROFF and PS2PDF

2009-10-20 Thread Jeremy Huddleston
On Oct 20, 2009, at 12:34, Dan Nicholson wrote: I'm pretty sure AC_PATH_PROG{,S} already check the environment variables. What AC_ARG_VAR does is put a blurb in the --help output and allow you to pass it on the command line. E.g., ./configure GROFF=/foo/groff. Is that what you want? Yes. s

Re: [PATCH libX11] Add AC_ARG_VAR for GROFF and PS2PDF

2009-10-20 Thread Jeremy Huddleston
On Oct 20, 2009, at 12:44, Dan Nicholson wrote: On Tue, Oct 20, 2009 at 12:38 PM, Yaakov (Cygwin/X) wrote: On 20/10/2009 14:34, Dan Nicholson wrote: I'm pretty sure AC_PATH_PROG{,S} already check the environment variables. What AC_ARG_VAR does is put a blurb in the --help output and allow yo

Tinderbox regression: xlsclients

2009-10-20 Thread Jeremy Huddleston
And if strnlen isn't available? ... http://tinderbox.x.org/builds/2009-10-20-0042/logs/xlsclients/#build On Oct 19, 2009, at 18:41, Jamey Sharp wrote: configure.ac |6 xlsclients.c | 524 ++ + 2 files changed, 430 insertions(+), 100

[PATCH:libXvMC] Include XvMClib.h

2009-10-20 Thread Jeremy Huddleston
This fixes compilation breakage after 9190399907610486001f3676945958dbab4b837a in videoproto Found by tinderbox Signed-off-by: Jeremy Huddleston --- src/XvMCWrapper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/XvMCWrapper.c b/src/XvMCWrapper.c index b9f97b2

Re: [PATCH:xcb/util] Update autogen.sh to one that does builddir != srcdir

2009-10-20 Thread Jeremy Huddleston
S) -rm -rf $(top_srcdir)/autom4te.cache -rm -f Makefile maintainer-clean-am: distclean-am maintainer-clean-generic On Tue, 2009-10-20 at 12:29 -0700, Jeremy Huddleston wrote: Shouldn't we be nuking all the "--enable-maintainer-mode" in autogen.sh now... or do we s

[PATCH] Add implementation of strnlen for systems without this function

2009-10-20 Thread Jeremy Huddleston
I'm not sure what magic to put in xlsclients.c to conditionally include strnlen.h ... anybody want to chime in about that bit? This atleast gets it building with "warning: implicit declaration of function ‘strnlen’" Signed-off-by: Jeremy Huddleston --- Makefile.am |

Re: [PATCH:app/xlsclients] Use inttypes.h for correct printf formats

2009-10-20 Thread Jeremy Huddleston
This is C99, right? If so, I don't think it's acceptable. On Oct 20, 2009, at 18:56, Yaakov (Cygwin/X) wrote: From: Yaakov Selkowitz xcb_atom_t and xcb_window_t are both typedef'd as uint32_t. Signed-off-by: Yaakov Selkowitz --- xlsclients.c |5 +++-- 1 files changed, 3 insertions(+), 2

INSTALL in git

2009-10-20 Thread Jeremy Huddleston
I noticed an INSTALL file in xlsclients and libXvMC today, and it was quite annoying to work around since 'autoreconf -fvi' replaces it and git wants to commit it. Should these files even be in git? Can I nuke them for the betterment of humanity and since they get created by autoreconf an

Re: [PATCH:app/xlsclients] Use inttypes.h for correct printf formats

2009-10-20 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston On Oct 20, 2009, at 22:18, Yaakov (Cygwin/X) wrote: From: Yaakov Selkowitz xcb_atom_t and xcb_window_t are both typedef'd as uint32_t. Since PRI*32 are a C99 feature that may not be available, fallbacks are provided based on the assumption of a 32-bi

Re: [PATCH] Kill compilation warnings.

2009-10-22 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Oct 22, 2009, at 11:15, Marcin Baczyński wrote: Kill compilation warnings. Signed-off-by: Marcin Baczyński --- hw/xfree86/common/xf86Xinput.c | 12 +--- hw/xfree86/common/xf86cmap.c |2 ++ 2 files changed, 11 insertions(+), 3 deletions

Acked-by, signed-off-by, vs reviewed-by

2009-10-22 Thread Jeremy Huddleston
So what actually is the difference between these. I'm guessing this usage, but it would be nice if this were written in stone somewhere on the wiki: Acked - I agree with the general idea of what you're doing Reviewed - I looked at your changes, and it looks right Signed-off - I reviewed and

Re: Acked-by, signed-off-by, vs reviewed-by

2009-10-22 Thread Jeremy Huddleston
On Oct 22, 2009, at 18:20, Peter Hutterer wrote: On Thu, Oct 22, 2009 at 05:57:54PM -0700, Jeremy Huddleston wrote: So what actually is the difference between these. I'm guessing this usage, but it would be nice if this were written in stone somewhere on the wiki: It is written in

[PATCH] dix: Properly detect if the other device is frozen

2009-10-27 Thread Jeremy Huddleston
othersFrozen was getting unset. We should detect if it should be set to true rather than setting it false for a device that isn't frozen Signed-off-by: Jeremy Huddleston --- dix/events.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dix/events.c

[PULL] Fix frozen device detection, run xmodmap after setting new keymap in XQuartz

2009-11-04 Thread Jeremy Huddleston
The following changes since commit 412c56ef3332d09efbd861e41c3e985f44729729: Maarten Maathuis (1): exa: remove some outdated comment are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver.git master Jeremy Huddleston (2): XQuartz: Run xmodmap

[PULL] Misc XQuartz/darwin fixes including yet another SHA1 implementation

2009-11-05 Thread Jeremy Huddleston
The following changes since commit f7b375bd141d0cf1e3add5443a5838dd8f554ef6: Alan Coopersmith (1): Enable XF86PM on all Solaris platforms, not just x86/x64 are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (6

[PULL] XQuartz: Buildfix, XBell() regression, and a pbproxy bugfix when multiple servers are running

2009-11-09 Thread Jeremy Huddleston
The following changes since commit c7d1319872e0ae0b7d945e9af8c4027ee5aa2055: Adam Jackson (1): randr: Fill in errorValue when verifying outputs/crtcs/modes are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (3

Re: [PATCH 0/5] xserver: configuration/packaging janitorial maintenance

2009-11-10 Thread Jeremy Huddleston
Thanks for doing this. Alan already raised the only concern that I had in mind, so if you just make sure you are careful when moving XORG_DEFAULT_OPTIONS, you should be good. Series Reviewed-By: Jeremy Huddleston On Nov 10, 2009, at 09:05, Gaetan Nadon wrote: > This set of patches

[PULL] XQuartz: Buildfix, XBell() regression, and a pbproxy bugfix when multiple servers are running

2009-11-11 Thread Jeremy Huddleston
The following changes since commit b5aa2e0a5fe233dc883084a5026013472e85bca4: Chase Douglas (1): Move FD_CLR above pInfo->read_input are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (3): XQuartz: Buildfix

Re: [PATCH] XCBify xlsatoms

2009-11-11 Thread Jeremy Huddleston
I'd rather see these xcb versions have a configure option (--enable-xcb for example)... I'm fine with it being on by default, but it's nice to have a fallback and easy regression testing. On Nov 10, 2009, at 13:55, Peter Harris wrote: > Like xlsclients, there are a whole lot of round trips in x

Re: [Xcb] [PATCH] XCBify xlsatoms

2009-11-12 Thread Jeremy Huddleston
On Nov 11, 2009, at 19:33, Peter Harris wrote: > On Wed, Nov 11, 2009 at 9:04 PM, Jeremy Huddleston wrote: >> I'd rather see these xcb versions have a configure option (--enable-xcb for >> example)... I'm fine with it being on by default, but it's nice to have a &

Re: [PATCH 0/5] xserver: configuration/packaging janitorial maintenance

2009-11-12 Thread Jeremy Huddleston
On Nov 12, 2009, at 08:20, Keith Packard wrote: > Excerpts from Gaetan Nadon's message of Thu Nov 12 05:27:14 -0800 2009: > >> There are two kinds of builds. > > There are probably as many kinds of builds as there are people > building -- people download the tarball because it's an easy way to

Re: [PATCH:util/modular] release.sh: use the remote consistently.

2009-11-19 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Nov 19, 2009, at 16:14, Peter Hutterer wrote: > Don't just use the specified remote for the git push, also check on the > remote for the tag names, etc. > > Signed-off-by: Peter Hutterer > --- > release.sh |8 > 1 files c

[PULL] XQuartz: Minor compatability fix for older versions of xinit

2009-11-23 Thread Jeremy Huddleston
The following changes since commit ec16357edaba23694b12fd234ffa12fd58a73dfa: Tiago Vignatti (1): configure: remove unused kdrive Xvesa config variable are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (1

Re: [PATCH] util-macros: Addition of a meta data file xorg-macros.pc.in used by XORG_INSTALL

2009-11-25 Thread Jeremy Huddleston
I like the idea... I'm just cautious about it being in share/pkgconfig ... I'm gonna have to edit some build system scripts here to include the new path in PKG_CONFIG_PATH, and I'm sure others will as well. We should make sure this is noted in the release notes. Reviewed-by: Je

Re: [PATCH 1/2] Update COMPILEDDEFAULTFONTPATH to match the new default font path

2009-11-25 Thread Jeremy Huddleston
But the big, bold letters say not to. What is this world coming to?!?! On Nov 25, 2009, at 11:31, Ingmar Vanhassel wrote: > Signed-off-by: Ingmar Vanhassel > Reviewed-by: Alan Coopersmith > --- > include/site.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/incl

Nested pkg-config macros in configure.ac

2009-11-27 Thread Jeremy Huddleston
ase remember to nominate your patches for 1.7 either by letting me know > over IRC/email or by shoving it into the server-1.7-nominations branch. > > As usual, the shortlog below: > > AaronsPlattner (1): > Bug #25136: Revert "Fix clipping when windows are used as sources&quo

Re: [PATCH 1/3] Revert "EXA: Accumulate arbitrary number of glyphs without flushing."

2009-11-30 Thread Jeremy Huddleston
On Nov 30, 2009, at 08:41, Keith Packard wrote: > On Mon, 30 Nov 2009 13:17:51 +0100, Michel Dänzer wrote: > >> Not sure what I was thinking, turns out alloca() of a size derived from >> client >> input is a bad idea. > > That was the sole remaining use of alloca outside of the quartz > back-

[PATH] XQuartz: Drop calls to alloca

2009-11-30 Thread Jeremy Huddleston
This makes us more consistent with the rest of the codebase, using xalloc/xfree Signed-off-by: Jeremy Huddleston --- hw/xquartz/mach-startup/stub.c | 12 hw/xquartz/xpr/x-hook.c| 12 ++-- hw/xquartz/xpr/xprCursor.c | 13 ++--- 3 files changed, 28

Re: [PATH] XQuartz: Drop calls to alloca

2009-11-30 Thread Jeremy Huddleston
On Nov 30, 2009, at 13:57, Keith Packard wrote: > On Mon, 30 Nov 2009 11:03:59 -0800, Jeremy Huddleston > wrote: > >> This makes us more consistent with the rest of the codebase, using >> xalloc/xfree > > xalloc/xfree instead of malloc/free? It's using xal

Re: Convert kdrive libraries to libtool convenience libraries.

2009-12-02 Thread Jeremy Huddleston
Hi Paulo, Last year, you made the following commit. http://cgit.freedesktop.org/xorg/xserver/commit/?id=f7585d020593345e7a61b1fe1a517c38da8f6d79 Also correct a link failure due to unresolved symbols. This is arguably a libtool/ranlib/ld bug, that "may" be corrected by linking all convenience l

[PATCH] Miscellaneous compilation warning fixes

2009-12-08 Thread Jeremy Huddleston
.c: In function 'RecordCreateSet': set.c:425: warning: old-style function definition stub.c: In function 'main': stub.c:236: warning: ISO C90 forbids mixed declarations and code Signed-off-by: Jeremy Huddleston --- dix/main.c |2 ++ hw/xquartz

Re: X.Org releases & automake security issue CVE-2009-4029

2009-12-08 Thread Jeremy Huddleston
First of all, can we come up with a hook in util-macros which will verify that the version of automake is correct and bail during configure if it's not? This would prevent future problems (assuming the packager has the latest util-macros... which they should). As far as what to do about re

Re: [PATCH] Miscellaneous compilation warning fixes

2009-12-09 Thread Jeremy Huddleston
>> +int dix_main(int argc, char *argv[], char *envp[]); >> + > > This should be declared in a header somewhere, not copied & pasted. In a perfect world, sure... but it only affects XQuartz, and I don't want to clutter up headers more than they need to be. smime.p7s Description: S/MIME crypt

Re: [PATCH] Add _X_NORETURN attribute

2009-12-10 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Dec 8, 2009, at 05:14, Tomas Carnecky wrote: > Since this attribute has been supported since GCC 2.5 only check the presence > of the GNU C compiler but not its version. > > Signed-off-by: Tomas Carnecky > --- > Xfuncproto.h.in |6 ++

[PULL] 2 minor build fixes

2009-12-11 Thread Jeremy Huddleston
The following changes since commit 12fb31815db9de9c01f2d4155a2b74531777c0bf: Peter Hutterer (1): xkb: don't assign garbage value to led_return. are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (2): Miscella

Xfake build failure (was Re: Convert kdrive libraries to libtool convenience libraries.)

2009-12-11 Thread Jeremy Huddleston
Resending due to lack of response. Xfake doesn't build in 1.7 or master due to "-Wl,-undefined=InitExtensions" in LDFLAGS ... Hi Paulo, Last year, you made the following commit. http://cgit.freedesktop.org/xorg/xserver/commit/?id=f7585d020593345e7a61b1fe1a517c38da8f6d79 Also correct a link

[PULL] Two build/clean fixes

2009-12-15 Thread Jeremy Huddleston
The following changes since commit 77221c9155a3c96cb63b210a048db1ea71a5e359: Adam Jackson (1): glx: swrast can do GLX 1.4 too are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (2): dtrace: Add Xserver-dtrace.h

Re: [PATCH:xset] Remove two unused variables.

2009-12-20 Thread Jeremy Huddleston
Reviewed-By: Jeremy Huddleston On Dec 20, 2009, at 14:36, Peter Hutterer wrote: > xset.c: In function ‘query’: > xset.c:1388: warning: unused variable ‘ind’ > xset.c:1387: warning: unused variable ‘state’ > > Signed-off-by: Peter Hutterer > --- > xset.c |3 ---

Re: X Org server 1.7.99.2 is faulty

2009-12-30 Thread Jeremy Huddleston
--with-fontdir=/opt/local/share/fonts --with-launchd-id-prefix=org.macports --without-dtrace make clean && make && sudo make install # This will do a binary search to hone in on the change that introduced the problem. *: Jeremy Huddleston (17): XQuartz: Run xmodmap aft

[PATCH font-util] Install pkg-config files in $(datadir)/pkgconfig

2009-12-30 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index ab75733..e96e6e4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -49,7 +49,7 @@ mapfiles_DATA = \ map-JISX0201.1976-0 \ map

Re: X Org server 1.7.99.2 is faulty

2009-12-31 Thread Jeremy Huddleston
On Dec 31, 2009, at 03:38, Michel Dänzer wrote: > On Wed, 2009-12-30 at 13:52 -0500, Jeremy Huddleston wrote: >> The version in MacPorts is just 1.7.99.2 without any MP/Apple specific >> patches (since these have been going into master with fairly low >> latency). My changes

Re: [PATCH 2/2] fb: Adjust transform or composite coordinates for pixman operations

2010-01-08 Thread Jeremy Huddleston
I'm trying to disect this commit to see why it's causing problems for Peter Dyballa (his emacs buffers are getting "cut off" ... see his original "xorg-server 1.7.99.2 is faulty" thread). I'm not too familiar with pixman and this area of the server, so hopefully someone else (Keith?) can respon

pkg-config files list protos when not required

2010-01-09 Thread Jeremy Huddleston
Why do the pkg-config files still report that the protos are dependencies of the Xlib libraries? Shouldn't that have been removed with the big proto/Xlib cleanup prior to the last Katamari? Was this just overlooked or intentional? I don't see any reason why a userland application building aga

Re: pkg-config files list protos when not required

2010-01-09 Thread Jeremy Huddleston
Julien Cristau wrote: > On Sat, Jan 9, 2010 at 13:42:25 -0800, Jeremy Huddleston wrote: > >> Why do the pkg-config files still report that the protos are >> dependencies of the Xlib libraries? Shouldn't that have been removed >> with the big proto/Xlib cleanup p

Re: pkg-config files list protos when not required

2010-01-10 Thread Jeremy Huddleston
On Jan 10, 2010, at 09:19, Dan Nicholson wrote: > Right, this was more of a cleanup for the server's benefit so that > pulling in the proto headers wouldn't drag in datatypes from the > client side. But both the client and server are always going to need > pull in the protocol headers such as . T

[PATCH - Please push] XQuartz: Setup the modifier map in the quartz thread

2010-01-11 Thread Jeremy Huddleston
This avoids possibly doing it twice which could result in incorrect keycodes for alt due to our loss of information about its side. Signed-off-by: Jeremy Huddleston --- hw/xquartz/quartzKeyboard.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/xquartz

[PULL] XQuartz: fix left alt keycode, don't die in x_hook_run when list is empty

2010-01-13 Thread Jeremy Huddleston
The following changes since commit 44f9c3d16c9c9b3362306a9ba26ee52e7baafeca: Keith Packard (1): Merge remote branch 'jbarnes/master' are available in the git repository at: git://anongit.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (3): XQuartz:

libX11 master uses xf86bigfontproto without checking for it

2010-06-16 Thread Jeremy Huddleston
src/Font.c has: #include but xf86bigfontproto is no longer checked for in configure.ac (removed with the !XCB puntage). smime.p7s Description: S/MIME cryptographic signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.o

groff results in empty pngs (pnm* tools not on system)

2010-06-16 Thread Jeremy Huddleston
In the process of building libX11, I noticed that a ton of empty images are being created. The command that results in the empty images is: ~/src/freedesktop/src/libX11/specs/XIM (master) $ /usr/bin/groff -e -t -ms -dxV="libX11 1.3.4" -I. ../../specs/macros.t -Thtml -P-Dimages -P- Ixim-image

Re: libX11 master uses xf86bigfontproto without checking for it

2010-06-16 Thread Jeremy Huddleston
weird... i must've mistyped when I greped for it... nevermind. On Jun 16, 2010, at 18:06, Josh Triplett wrote: > On Wed, Jun 16, 2010 at 02:36:20PM -0700, Jeremy Huddleston wrote: >> src/Font.c has: >> #include >> >> but xf86bigfontproto is no longer checked

Re: Current tinderbox regression (xserver, OS X)

2010-06-30 Thread Jeremy Huddleston
Yeah, this is likely on my end. I needed to backup the version installed on the system, and I don't build mesa in the tinderbox. Please ignore. On Jun 30, 2010, at 06:03, Chris Ball wrote: > http://tinderbox.x.org/builds/2010-06-30-0016/logs/xserver/#configure > > configure: error: Package re

Re: libXfont: Changes to 'master'

2010-07-10 Thread Jeremy Huddleston
This causes libXfont to fail building on darwin: http://tinderbox.x.org/builds/2010-07-10-0014/logs/libXfont On Jul 8, 2010, at 06:44, Jon TURNEY wrote: > src/stubs/stubs.h |1 + > src/util/miscutil.c |2 ++ > 2 files changed, 3 insertions(+) > > New commits: > commit 8f75706901da014159

Re: xwininfo: Changes to 'master'

2010-07-10 Thread Jeremy Huddleston
This introduces a build failure on darwin. You need to provide strnlen (look at xlsclients) On Jul 7, 2010, at 10:48, Alan Coopersmith wrote: > COPYING |2 > clientwin.c | 178 +++--- > clientwin.h |6 > configure.ac | 29 - > dsimple.c| 678 +--- > dsimp

[PULL] Fix an XQuartz regression freeing incorrectly in QuartzSetCursor

2010-07-13 Thread Jeremy Huddleston
: Remove some dead code. Jeremy Huddleston (1): XQuartz: Avoid a crash when mistakenly free()ing in QuartzSetCursor on some configs hw/xquartz/quartz.c|4 hw/xquartz/quartzCocoa.m | 11 --- hw/xquartz/quartzCommon.h | 15 --- hw/xquartz/xpr

xorg-server-1.8.99.904 tag

2010-07-13 Thread Jeremy Huddleston
I'm having some issues with my normal way of generating patches off of master. With a current state, I run: $ git format-patch xorg-server-1.8.99.904...origin/master 0001-Revert-dix-use-the-event-mask-of-the-grab-for-TryCli.patch 0002-xkb-remove-now-obsolete-comment.patch 0003-dix-fix-up-erroneo

Re: [PULL] Fix an XQuartz regression freeing incorrectly in QuartzSetCursor

2010-07-13 Thread Jeremy Huddleston
On Jul 13, 2010, at 10:18, Keith Packard wrote: On Tue, 13 Jul 2010 08:29:22 -0700, Jeremy Huddleston > wrote: Jeremy Huddleston (1): XQuartz: Avoid a crash when mistakenly free()ing in QuartzSetCursor on some configs I'd suggest just initializing 'data' to NULL

Re: [PATCH] xquartz: Delete compile-time-constant DRIGCRec.driOps field.

2010-07-13 Thread Jeremy Huddleston
Looks sane to me... Reviewed-by: Jeremy Huddleston On Jul 13, 2010, at 15:35, Jamey Sharp wrote: > The driOps field of this structure is never set to anything but > &driGCOps, and this structure is not visible outside this source file. > Just use the constant in the one place

Re: [PATCH 2/2] rootless: ROOTLESS_GLOBAL_COORDS is always set, so unifdef it.

2010-07-14 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Jul 14, 2010, at 11:44, Jamey Sharp wrote: Signed-off-by: Jamey Sharp Cc: Jeremy Huddleston Cc: Jon TURNEY --- miext/rootless/rootlessConfig.h |2 -- miext/rootless/README.txt | 15 ++- miext/rootless/rootless.h |5

Re: [PATCH 1/2] rootless: ROOTLESS_TRACK_DAMAGE is never set, so unifdef it.

2010-07-14 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Jul 14, 2010, at 11:44, Jamey Sharp wrote: Signed-off-by: Jamey Sharp Cc: Jeremy Huddleston Cc: Jon TURNEY --- miext/rootless/rootlessConfig.h |2 -- hw/xwin/winscrinit.c|2 -- miext/rootless/README.txt | 19

Re: [PATCH] rootless: Delete dead remnants of rootless acceleration.

2010-07-14 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Jul 14, 2010, at 13:49, Jamey Sharp wrote: Jeremy deleted rootlessAccelInit's implementation in 2008 in commit 587c010a1cd733fded4d49dc339df0634bda8be6. Delete its prototype and the remaining commented-out call to it. It still makes sense for the rootle

Re: [PATCH 1/3] rootless: ROOTLESS_PROTECT_ALPHA is always set, so unifdef it.

2010-07-15 Thread Jeremy Huddleston
Series Reviewed-by: Jeremy Huddleston Thanks for this cleanup effort Jamey, rootless is a big ball of ugly. I was hoping we would kill it off soon... but it looks like it will be with us for a while now, so this is very much appreciated. On Jul 15, 2010, at 09:28, Jamey Sharp wrote: >

Re: [PATCH 1/3] rootless: ROOTLESS_PROTECT_ALPHA is always set, so unifdef it.

2010-07-15 Thread Jeremy Huddleston
On Jul 15, 2010, at 13:30, Jon TURNEY wrote: > > > On 15/07/2010 17:28, Jamey Sharp wrote: >> The settings for each platform in rootlessConfig.h were misleading. On >> Apple builds, ROOTLESS_PROTECT_ALPHA was defined to TRUE; on Windows it >> was defined to NO. Both cases enabled alpha channel

[PATCH] rootless: Adjust the frame size of the native root window in RootlessResizeWindow

2010-07-17 Thread Jeremy Huddleston
FALSE) RootlessDisableRoot(screenInfo.screens[0]) RootlessDestroyFrame (pRoot, winRec); RootlessUpdateRooted(TRUE) RootlessEnableRoot(screenInfo.screens[0]) RootlessEnsureFrame(screenInfo.screens[0]->pRoot) creates a new WINREC... Signed-off-by: Jan Hauffa Reviewed-by: Jerem

Re: [PATCH] rootless: Adjust the frame size of the native root window in RootlessResizeWindow

2010-07-19 Thread Jeremy Huddleston
Ping for review. Jon, my guess is that you guys don't even enter this codepath. If that's the case, please just let me know. I'd like to get this fix into 1.9. Thanks, Jeremy On Jul 17, 2010, at 12:23, Jeremy Huddleston wrote: > If the native root window isn't r

Re: [PATCH libAppleWM] simplify Makefile as per-target compilation flags are not needed

2010-07-24 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston Sent from my iPhone... On Jul 23, 2010, at 18:31, Gaetan Nadon wrote: > We then do not need the AM_PROG_CC_C_O to detect compiler which > do not accept both -c and -o together. > The macro was missing, but it will no longer be needed. > > Thi

[PULL] Fix a regression in XQuartz due to recent GLX changes

2010-07-28 Thread Jeremy Huddleston
The following changes since commit 9c171d4aee695ab66e6db1ab92539557bd368cfa: Add documentation of the Xserver DTrace probes (2010-07-23 12:41:59 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (1): XQuartz: GLX

Should _XIOError really exit() ?

2010-07-29 Thread Jeremy Huddleston
Should _XIOError in libX11 really exit() even if the developer provides their own io error handler? That seems extreme and prevents recovery. It took me quite a while to actually discover that I was exiting at this point: (gdb) bt #0 0x7fff8673d3e3 in exit () #1 0x00010040c006 in _XI

[PULL] One more (hopefully last) XQuartz pull for 1.9

2010-07-29 Thread Jeremy Huddleston
: Don't mangle __GLXDrawable's pDraw (2010-07-28 18:11:38 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (1): XQuartz: xpbproxy: Don't take down the whole server on an IO error hw/xquartz/pbproxy/main

Re: [PATCH] rootless: fix uninitialized private key assert in non-rootless modes on cygwin

2010-08-03 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Aug 3, 2010, at 09:05, Jon TURNEY wrote: > IsFramedWindow() is called from miPaintWindow() if the server has > been built with ROOTLESS defined, irrespective of if RootlessInit() > has ever been called, or not. > > Add a check to IsFramedWindo

[PULL] A few more XQuartz cleanups

2010-08-12 Thread Jeremy Huddleston
nce commit 71af1f71c0492c365707c6b3810f94642ff39352: Bump to version 1.8.99.906 (1.9 RC6) (2010-08-12 23:01:59 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (4): XQuartz: Ignore kXquartzToggleFullscreen when rootless XQu

[PATCH] rootless: Remove ROOTLESS_WORKAROUND

2010-08-15 Thread Jeremy Huddleston
d fix it a real way rather than this hokey workaround which doesn't even work for COMPOSITE. Signed-off-by: Jeremy Huddleston --- configure.ac |2 +- miext/damage/damage.c |6 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configur

Re: [PATCH] XOpenDisplay: save the correct display_name value

2010-08-17 Thread Jeremy Huddleston
n number and pass it on to the remote tunneled DISPLAY. The configure.ac changes are actually still needed for the xtrans path. Aside from that, it looks good. Assuming you revert the configure.ac changes: Reviewed-by: Jeremy Huddleston --Jeremy _

Re: [PATCH] XOpenDisplay: save the correct display_name value

2010-08-18 Thread Jeremy Huddleston
On Aug 18, 2010, at 07:48, Aaron Plattner wrote: > Which xtrans path are you referring to? There are no users of HAVE_LAUNCHD > left, and the xtrans path was removed with commit 15e5eaf628 right after > libX11-1.3.4. Remember that xtrans is a bunch of source files and not a proper library: ~/s

Re: X server 1.9 stable release manager

2010-08-20 Thread Jeremy Huddleston
We're probably going to pick 1.9.x as our next long-term support branch for XQuartz (replacing 1.4.x), so I wouldn't mind managing the 1.9.x releases. The only problem is that I'm not terribly familiar with the xfree86 DDX. I've got a Linux box which I can use for simple sanity checks and prete

Re: You are not authorized to access bug #28801.

2010-08-20 Thread Jeremy Huddleston
On Aug 20, 2010, at 12:55, Pat Kane wrote: > When I try to access bug 28801 > > I get the message: > You are not authorized to access bug #28801. > I can see the bugs just fine. > > Why does bugzilla hate me? [insert your own joke here]

<    1   2   3   4   5   6   7   8   9   10   >