Re: [PATCH 1/3] Have FreePixmap call screen hooks, not the other way around.

2011-10-02 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com I think this series needs a Tested-by: though. I'll give it a go on Monday if nobody beats me to it. --Jeremy On Oct 1, 2011, at 11:08 PM, Jamey Sharp wrote: In the process, move reference counting into FreePixmap instead of doing

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Jeremy Huddleston
On Sep 26, 2011, at 1:18 PM, Keith Packard wrote: On Fri, 23 Sep 2011 13:14:57 -0700, Jeremy Huddleston jerem...@apple.com wrote: Thanks for more eyes! As always, I'm looking for rough consensus about this before I merge it in; please let me know what you're looking for before it can

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Jeremy Huddleston
On Oct 2, 2011, at 00:10, Matthieu Herrb wrote: Was the libpciaccess issue solved ? You're referring to the missing support from libpciaccess, yes? I'm still waiting on comments from my comments on those patches. http://lists.x.org/archives/xorg-devel/2011-September/025663.html

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-10-02 Thread Jeremy Huddleston
Peter, any thoughts on this? On Sep 20, 2011, at 10:01, Jeremy Huddleston wrote: I just realized I made (at least one) error in the inline functions I wrote below. s/ 0/ 1/ ... there're probably others, but that just emphasizes my point that there should be conversion routines rather than

Re: [PATCH 1/3] Have FreePixmap call screen hooks, not the other way around.

2011-10-02 Thread Jeremy Huddleston
On Oct 2, 2011, at 00:49, Jamey Sharp wrote: On Sat, Oct 01, 2011 at 11:20:25PM -0700, Jeremy Huddleston wrote: Reviewed-by: Jeremy Huddleston jerem...@apple.com I think this series needs a Tested-by: though. I'll give it a go on Monday if nobody beats me to it. I'll hold off

[PATCH libXft] Remove an extraneous FcPatternDestroy in XftFontOpenInfo

2011-10-02 Thread Jeremy Huddleston
https://bugs.freedesktop.org/show_bug.cgi?id=5745 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- src/xftfreetype.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/xftfreetype.c b/src/xftfreetype.c index 3f8dfef..1c5967a 100644 --- a/src/xftfreetype.c +++ b

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-10-02 Thread Jeremy Huddleston
On Oct 2, 2011, at 16:30, Peter Hutterer wrote: On Sun, Oct 02, 2011 at 10:52:03AM -0700, Jamey Sharp wrote: On 10/2/11, Daniel Stone dan...@fooishbar.org wrote: On 2 October 2011 09:19, Jeremy Huddleston jerem...@apple.com wrote: Peter, any thoughts on this? I think using * (1 16) * (1

Re: Maintaining backwards compatibility with swap macros

2011-10-02 Thread Jeremy Huddleston
On Oct 2, 2011, at 07:51, Matt Turner wrote: On Sun, Oct 2, 2011 at 2:15 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: ping. I didn't see anything as a followup to my comments below. I'm fine with either approach, but I'd like to get this in soon. On Sep 25, 2011, at 11:22 AM

Re: [PATCH] Remove another if (E != NULL) check around free(E)

2011-09-28 Thread Jeremy Huddleston
On Sep 26, 2011, at 7:58 PM, Matt Turner wrote: I wonder if there are any other patterns we haven't seen yet? Well clang static analyzer should help with that, but I just realized it was having issues. I'll try to fix it tomorrow for tomorrow evening's tinderbox run. --Jeremy

Re: [PATCH] fix doPolyText use-after-free issue

2011-09-28 Thread Jeremy Huddleston
I missed this point at first. The context is that in 'bail', c is accessed and expected to be the old value. Candidate for 1.11-branch Reviewed-by: Jeremy Huddleston jerem...@apple.com I think something is wrong with your mailer (or maybe mine). I was unable to git-am this patch. Can you

Re: [PATCH] Remove another if (E != NULL) check around free(E)

2011-09-28 Thread Jeremy Huddleston
, at 11:30 PM, Jeremy Huddleston wrote: On Sep 26, 2011, at 7:58 PM, Matt Turner wrote: I wonder if there are any other patterns we haven't seen yet? Well clang static analyzer should help with that, but I just realized it was having issues. I'll try to fix it tomorrow for tomorrow

Re: [PATCH] edid: Add quirk for Acer Aspire One 110

2011-09-28 Thread Jeremy Huddleston
Candidate for 1.11 Reviewed-by: Jeremy Huddleston jerem...@apple.com Is there anyone who can do a Tested-by? On Sep 26, 2011, at 7:00 AM, Ross Burton wrote: At least one revision of the AAO reports a 190x110mm maximum size but a 451x113mm mode. X.Org Bug 41141 https://bugs.freedesktop.org

Re: [PATCH:libxtrans 00/10] Warning cleanups

2011-09-28 Thread Jeremy Huddleston
Series Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 27, 2011, at 2:28 PM, Alan Coopersmith wrote: These greatly reduce the warning noise generated by the libxtrans code when building the X server, libX11, and other modules using libxtrans. Alan Coopersmith (10): Fix warnings

Re: [PATCH-V3] xserver: Optional backtrace handler

2011-09-28 Thread Jeremy Huddleston
After some thought, I think it's a good idea to not wait for the handler to exit. It may want to do some extra processing that it doesn't need the process hanging around for. You probably meant one of these to be backtrace_handler_stdin: +close(backtrace_handler_stdout); +

Re: [PATCH] misc.h: GCC's 'error' attribute was introduced in GCC 4.3

2011-09-28 Thread Jeremy Huddleston
/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel --- Jeremy Huddleston Rebuild Sudan - Board of Directors - http://www.rebuildsudan.org Berkeley Foundation for Opportunities in Information Technology - Advisory Board - http://www.bfoit.org

Re: [PATCH xf86-video-chips] PciTag is unused when using libpciaccess

2011-09-26 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 26, 2011, at 12:41, Mark Kettenis wrote: This should be the right thing to do regardless whether the pci bus cleanup gets committed. Signed-off-by: Mark Kettenis kette...@openbsd.org --- src/ct_driver.h |2 ++ 1 files changed, 2

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Jeremy Huddleston
On Sep 26, 2011, at 06:10, Mark Kettenis wrote: I don't really object to the canges to the in10 module (although the libpciaccess API uses uint32_t instead of unsigned int). But please keep the IOADDRESS typedef until the majority of the video drivers have been converted to use the

Re: [ANNOUNCE] xorg-server 1.11.1

2011-09-25 Thread Jeremy Huddleston
On Sep 24, 2011, at 01:43, Ville Syrjälä wrote: * #22566: [from 1.5.x] Random artifacts whith Composite extension enabled * This is a longstanding issue without much motion, needs status update This looks like something to do with implicit redirect. Should be re-tested w/ 1.11 as all of

Re: Bugzilla duplicate components

2011-09-25 Thread Jeremy Huddleston
On Sep 24, 2011, at 21:12, Alan Coopersmith wrote: On 09/24/11 07:50 PM, Jeremy Huddleston wrote: So there is quite a bit of unfortunate duplication in bugzilla. We have components in for libX11 in both the xlibs product and the xorg product. Xft has its own product as well

Re: [PATCH:xscope 06/14] Ensure ScopeHost global is initialized when built with USE_XTRANS

2011-09-25 Thread Jeremy Huddleston
conforming gethostbyname(3) (ie not glibc or its unfortunate relatives). -alan- On 09/24/11 12:43 PM, Jeremy Huddleston wrote: Can we use this opportunity to use getaddrinfo(3) rather than gethostbyname(3) as it is the preferred API and will make xscope IPv6 compatible. On Sep 24

Re: [PATCH libpciaccess 2/2] linux: Implement map_legacy

2011-09-25 Thread Jeremy Huddleston
I don't like that this has a side effect of changing errno since it returns errno, but I'm not sure if that promise is made by libpciaccess. My guess is that libpciaccess clients don't care about the errno side effect. Why is the sys-fs based fd opened with O_RDWR rather than flags? On May

Re: [PATCH libpciaccess 1/2] Add map_legacy interface

2011-09-25 Thread Jeremy Huddleston
On May 10, 2011, at 23:23, Mark Kettenis wrote: From: Adam Jackson a...@redhat.com Date: Tue, 10 May 2011 17:56:34 -0400 This allows platforms to hand back mmaps of the low 1M (ISA) address space on a per-domain basis. Any reason why you chose to have an explicit write_enable flag

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-25 Thread Jeremy Huddleston
On Sep 25, 2011, at 03:12, Matthieu Herrb wrote: On Sun, Sep 25, 2011 at 09:47:15AM +0200, Matthieu Herrb wrote: Hmm it fails to run because it seems that pci_device_map_legacy() never actually made it in libpciaccess(). I found patches in may for it but no actual commits to libpciaccess.

Re: [PATCH libXft] Remove broken fallback on non-pkg-config search for libXrender (was [PATCH]...)

2011-09-25 Thread Jeremy Huddleston
On Sep 25, 2011, at 05:54, Gaetan Nadon wrote: Perhaps the subject of another patch, ldd -r -u reports: Unused direct dependencies: /home/nadon/xorg/src/inst/lib/libXext.so.6 Ok, I'll roll that in as a separate commit. Thanks.

Re: Maintaining backwards compatibility with swap macros

2011-09-25 Thread Jeremy Huddleston
On Sep 25, 2011, at 10:50, Matt Turner wrote: Dave pointed out that there are a couple drivers (sis, sisusb, vmware) that use the swapl/swaps macros. My recent patch series dropped the n argument from the macros, causing these drivers to not build. Ideally, we'd like a deprecation warning

Re: [PATCH:xscope 06/14] Ensure ScopeHost global is initialized when built with USE_XTRANS

2011-09-25 Thread Jeremy Huddleston
to resurrect that bug. In any event, for your whole set: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 25, 2011, at 10:07, Alan Coopersmith wrote: On 09/25/11 12:07 AM, Jeremy Huddleston wrote: On Sep 24, 2011, at 21:22, Alan Coopersmith wrote: It's gethostname, no by, to get the name

[PATCH] Add additional compose sequences for pound sterling and yen (lower case)

2011-09-25 Thread Jeremy Huddleston
https://bugs.freedesktop.org/show_bug.cgi?id=1013 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- nls/en_US.UTF-8/Compose.pre |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre index fb64cb9..0e82dcb

[PATCH] Bump ABI_VIDEODRV_VERSION to 12

2011-09-24 Thread Jeremy Huddleston
The ABI changed in the previous series of changes, so bump the ABI version for the next release. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- I believe this is correct for the bus cleanup changes. hw/xfree86/common/xf86Module.h |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

2011-09-24 Thread Jeremy Huddleston
1) Include pciaccess.h for IOADDRESS 2) Use CARD32 instead of PCITAG Signed-off-by: Jeremy Huddleston jerem...@apple.com --- These were the necessary changes to build xf86-video-chips with the pending bus changes. If people are ok with this, I'll push these changes to xf86-video-chips

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 03:01, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Fri, 23 Sep 2011 20:21:54 -0700 On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: I'm also testing it on tifa32-linux tinderbox: http://tinderbox.x.org/builds/2011-09-23-0007 A few

Re: [PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 03:11, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 00:03:45 -0700 1) Include pciaccess.h for IOADDRESS How does this help you? Nothing in libpciaccess defines IOADDRESS, and adding that typedef to pciaccess.h seems wrong

Re: [PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 05:28, Mark Kettenis wrote: That doesn't help us. PCITAG is gone, and CARD32 is being used instead. XSERVER_LIBPCIACCESS is still defined. Perhaps *both* changes are necessary. Look again please. It's #ifndef XSERVER_LIBPCIACCESS, so PCITAG will only be needed if

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 09:31, Matthieu Herrb wrote: IOADDRESS is used massively throughout the drivers. I really don't see why it needs to be removed. Leaving the typedef in xf86Pci.h will save you/us a lot of work. At that point you might as well drop the changesto remove IOADDRESS usage in

Re: [PATCH:xscope 06/14] Ensure ScopeHost global is initialized when built with USE_XTRANS

2011-09-24 Thread Jeremy Huddleston
Can we use this opportunity to use getaddrinfo(3) rather than gethostbyname(3) as it is the preferred API and will make xscope IPv6 compatible. On Sep 24, 2011, at 08:48, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- common.c | 15 +++

Re: [PATCH:xscope 07/14] Make CS dynamically allocated

2011-09-24 Thread Jeremy Huddleston
Does this need a macro change somewhere? After this change, CS has MaxFD entries at start rather than StaticMaxFD. I haven't reviewed the context in full, but this seems wrong since it is a functional change and the comment indicates that it shouldn't be a functional change (modulo memory

Re: [PATCH:xscope 07/14] Make CS dynamically allocated

2011-09-24 Thread Jeremy Huddleston
Nevermind. I see the context now, and this looks fine. For the series: Reviewed-by: Jeremy Huddleston jerem...@apple.com Although I'd like to see a followup to use getaddrinfo(3) over gethostbyname(3). On Sep 24, 2011, at 12:52, Jeremy Huddleston wrote: Does this need a macro change

Re: [PATCH:xhost 1/2] Only need CFLAGS, not LIBS from xau package

2011-09-24 Thread Jeremy Huddleston
Both: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 24, 2011, at 10:31, Alan Coopersmith wrote: xhost needs the Family definitions from X11/Xauth.h to build, but doesn't call any libXau functions, so doesn't need to link against it. Fixes Solaris ld -z guidance warning: ld

[PULL] Build fix and an XQuartz race fix

2011-09-24 Thread Jeremy Huddleston
repository at: git://people.freedesktop.org/~jeremyhu/xserver for-keith Jeremy Huddleston (2): Address regressions from e8ff555b95ba and d206d52f657c to work with other compilers XQuartz: Use set_front_process rather than X11ApplicationSetFrontProcess since we're already in the AppKit

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 12:35, Jeremy Huddleston wrote: On Sep 24, 2011, at 09:31, Matthieu Herrb wrote: IOADDRESS is used massively throughout the drivers. I really don't see why it needs to be removed. Leaving the typedef in xf86Pci.h will save you/us a lot of work. At that point you

Bugzilla duplicate components

2011-09-24 Thread Jeremy Huddleston
So there is quite a bit of unfortunate duplication in bugzilla. We have components in for libX11 in both the xlibs product and the xorg product. Xft has its own product as well as a component in the xorg product. I'd like to get this all straightened out. I believe the goal was to have

[PATCH] Remove broken fallback on non-pkg-config search for libXrender

2011-09-24 Thread Jeremy Huddleston
https://bugs.freedesktop.org/show_bug.cgi?id=5425 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac | 31 +-- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git a/configure.ac b/configure.ac index 54d960f..3847e49 100644

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
On 09/23/2011 07:10 AM, Mark Kettenis wrote: From: Jeremy Huddlestonjerem...@apple.com Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
testing it on tifa32-linux tinderbox: http://tinderbox.x.org/builds/2011-09-23-0007 On Sep 22, 2011, at 22:29, Keith Packard wrote: On Thu, 22 Sep 2011 19:52:05 -0700, Jeremy Huddleston jerem...@apple.com wrote: git://people.freedesktop.org/~jeremyhu/xserver master This sequence needs

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: Hi Keith, I believe this failure is coming from b61950dc616402bbf3fb0774e9289d32c0f42c83 which removed these from xfree86/common/xf86str.h #include xf86Pci.h #include pciaccess.h I squashed your change below

[PATCH] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

2011-09-22 Thread Jeremy Huddleston
The error attribute appeared in gcc-4.3 The return type of __builtin_constant_p is int Found by Tinderbox. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- include/misc.h | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/include/misc.h b/include

Re: [PATCH] Fix misc.h changes from d206d52f657c to work with Sun compilers

2011-09-22 Thread Jeremy Huddleston
Ack, this is gonna conflict with the patch I just sent. I'll roll this into mine and send a new one in a sec. On Sep 22, 2011, at 18:59, Matt Turner wrote: On Thu, Sep 22, 2011 at 8:31 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Studio 12.0 and later have builtin support for

[PATCH v2] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

2011-09-22 Thread Jeremy Huddleston
1) The error attribute appeared in gcc-4.3 2) The return type of __builtin_constant_p is int 3) Sun Studio 12.0 and later builtin support for __builtin_constant_p Found by Tinderbox. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- include/misc.h | 14 +- 1 files changed, 9

Re: [PATCH] Unconditionally #include stdint.h

2011-09-22 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 22, 2011, at 17:55, Alan Coopersmith wrote: The more recent inclusions of this file haven't been checking for HAVE_STDINT_H, so might as well make the older ones consistent. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com

[PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-22 Thread Jeremy Huddleston
machines pci: Remove xf86MapDomainMemory int10: Port internal users off xf86MapVidMem incomplete: Remove xf86{Un,}MapVidMem Jeremy Huddleston (8): Address regressions from e8ff555b95ba and d206d52f657c to work with other compilers XQuartz: Use set_front_process rather

Re: [PATCH v2] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

2011-09-22 Thread Jeremy Huddleston
On Sep 22, 2011, at 19:49, Alan Coopersmith wrote: On 09/22/11 07:11 PM, Jeremy Huddleston wrote: -static inline void __builtin_constant_p(int x) +static inline int constant_p(int x) { +#if defined(__GNUC__) || (defined(__SUNPRO_C) (__SUNPRO_C= 0x590)) +return __builtin_constant_p(x

Re: [PATCH v2] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

2011-09-22 Thread Jeremy Huddleston
On Sep 22, 2011, at 20:23, Jamey Sharp wrote: Reviewed-by: Jamey Sharp ja...@minilop.net What I said for Alan's patch goes for this one too: Seems like there ought to be a better way than listing which compilers support it, though. I considered an autoconf test to check whether

Re: [PATCH RFC:modular] release.sh: Attempt to autodetect section and current/previous tags

2011-09-21 Thread Jeremy Huddleston
-by: Jeremy Huddleston jerem...@apple.com This sed-fu also doesn't work for xorg/xserver.git. Since we can easily provide that information on the command line, I'm ok with it not working for some edge cases which we can fixup in subsequent commits. I would like to add user verification

Re: [PATCH] xfree86: Bump extension ABI version to 6.0

2011-09-21 Thread Jeremy Huddleston
This looks like it's needed for 1.11.1. I plan on rolling this and the s/fb/wfb patch into the 1.11 branch and releasing 1.11.1 on Friday unless anyone knows of any other brownbag fixes that need merging. Speak up now. --Jeremy On Aug 29, 2011, at 20:44, Aaron Plattner wrote: The video

Re: [PATCH] xserver: Optional backtrace handler

2011-09-21 Thread Jeremy Huddleston
Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel --- Jeremy Huddleston Rebuild Sudan - Board of Directors - http://www.rebuildsudan.org Berkeley Foundation for Opportunities in Information Technology - Advisory Board - http://www.bfoit.org

Re: [RFC] Bugzilla Cleanup

2011-09-20 Thread Jeremy Huddleston
On Sep 19, 2011, at 9:11 PM, Matt Turner wrote: Sounds good to me. I did some clean ups a few months ago, but barely made a dent. What do you suggest we do about bugs where the reporter provides a bogus patch which fixes the problem for him, is unable to reproduce his own report, and

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-09-20 Thread Jeremy Huddleston
PM, Jeremy Huddleston wrote: I'm curious... why is the cls_wire-increment.frac getting cast to unsigned int? It's already typed as uint32_t. Looking at the context a bit more, I agree with Jamey that this should work (with or without explicit casts): cls_lib-increment = (double

server-1.11-branch

2011-09-20 Thread Jeremy Huddleston
I created server-1.11-branch a few days ago, and the plan is to get 1.11.1 RC1 out this Friday. Seeing as how there isn't any change yet on master, we have nothing to cherry-pick in at this point. As such, I don't expect that there will be much churn going into 1.11.1 and would like to keep

Re: Bus layer cleanups

2011-09-20 Thread Jeremy Huddleston
send another email with an updated branch. Matt Dropped patch 3 and rebased patches 4 and 5. Pushed to the same branch, git://people.freedesktop.org/~mattst88/xserver ioaddress Thanks, Matt --- Jeremy Huddleston Rebuild Sudan - Board of Directors - http://www.rebuildsudan.org

[RFC] Bugzilla Cleanup

2011-09-19 Thread Jeremy Huddleston
So, one of the things talked about at XDC was just how icky bugzilla has become. There are a ton of open bugs which haven't been touched in ages and either don't apply any more or don't have sufficient information to act upon. I would like to spend some effort cleaning these up, but before I

Re: Xserver driver merging pros cons

2011-09-19 Thread Jeremy Huddleston
On Sep 19, 2011, at 00:00, Peter Hutterer wrote: If the reason the model doesn't work is because people don't review, then some how getting people to step up and give reviews would fix the model. I think the one thing we don't cover right now are patches that cannot really be reviewed by

Re: [PATCH libXi] Use AM_CPPFLAGS to use in tree headers before installed headers

2011-09-19 Thread Jeremy Huddleston
On Sep 19, 2011, at 4:00 PM, Julien Cristau wrote: On Sun, Sep 18, 2011 at 01:01:58 -0700, Jeremy Huddleston wrote: This addresses a build failure found by the tinderbox. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- See: http://tinderbox.x.org/builds/2011-09-17-/logs

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-09-19 Thread Jeremy Huddleston
wrote: Reported-by: Jeremy Huddleston jerem...@apple.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- something like this good enough? src/XExtInt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/XExtInt.c b/src/XExtInt.c index d74a8d4..4009285

Re: libXi: Changes to 'master'

2011-09-18 Thread Jeremy Huddleston
2.1 internally Add the required constants to pretend to support XI 2.1. Having named constants for 2.1 seems a bit pointless, so let's just use the numbers directly. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Jeremy Huddleston jerem...@apple.com

[PATCH libXi] Use AM_CPPFLAGS to use in tree headers before installed headers

2011-09-18 Thread Jeremy Huddleston
This addresses a build failure found by the tinderbox. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- See: http://tinderbox.x.org/builds/2011-09-17-/logs/libXi src/Makefile.am |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Makefile.am b/src

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-16 Thread Jeremy Huddleston
On Sep 15, 2011, at 8:31 AM, Gaetan Nadon wrote: A bonus would be a list of drivers that do use pciaccess (maybe not in the commit text!). A complete list of drivers can be found in build.sh. Here's a complete list of modules which didn't contain the links *BEFORE* my change:

Re: Xserver driver merging pros cons

2011-09-16 Thread Jeremy Huddleston
Michel Dänzer 57 Soren Sandmann Pedersen 42 Brian 36 Ben Byer 35 Aaron Plattner 1.4 to 1.5: 106 individuals 360 Eamon Walsh 152 Adam Jackson 105 Ian Romanick 76 Jeremy Huddleston 75 Daniel Stone 74 Dodji Seketeli 74 Ben Byer 58 Peter Hutterer 52 Kristian Høgsberg 50 Michel Dänzer 1.5 to 1.6

Re: Xserver driver merging pros cons

2011-09-16 Thread Jeremy Huddleston
On Sep 16, 2011, at 12:45 PM, Stéphane Marchesin wrote: Well, the issue is not separate. Driver repos are straightforward to get changes in and therefore can move forward easily. How would that be different from an xorg-server tree with the exact same privileges? I don't see any difference

Re: Bus layer cleanups

2011-09-16 Thread Jeremy Huddleston
this reviewed so we can kill compiler.h. Thanks, Matt --- Jeremy Huddleston Rebuild Sudan - Board of Directors - http://www.rebuildsudan.org Berkeley Foundation for Opportunities in Information Technology - Advisory Board - http://www.bfoit.org

Re: [PATCH 03/16] vgahw: Move IO domain setup to IO dispatch vector setup

2011-09-16 Thread Jeremy Huddleston
On Sep 16, 2011, at 12:50 PM, Matt Turner wrote: --- a/hw/xfree86/vgahw/vgaHW.c +++ b/hw/xfree86/vgahw/vgaHW.c @@ -356,6 +356,8 @@ vgaHWSetStdFuncs(vgaHWPtr hwp) hwp-PIOOffset= 0; hwp-readEnable = stdReadEnable; hwp-writeEnable = stdWriteEnable;

Re: Xserver driver merging pros cons

2011-09-16 Thread Jeremy Huddleston
On Sep 16, 2011, at 13:10, Stéphane Marchesin wrote: 2011/9/16 Jeremy Huddleston jerem...@apple.com: On Sep 16, 2011, at 12:45 PM, Stéphane Marchesin wrote: Well, the issue is not separate. Driver repos are straightforward to get changes in and therefore can move forward easily. How

Re: [PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Jeremy Huddleston
On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote: +if HAVE_XMLTO_TEXT +noinst_DATA += $(docbook:.xml=.txt) +%.txt: %.xml $(chapters) + $(AM_V_GEN)$(XMLTO) $(XMLTO_HTML_FLAGS) txt $ +endif HAVE_XMLTO_TEXT ^^^ XMLTO_TEXT_FLAGS ?? ___

Re: [PATCH] int10: Delete #if 0'd implementation that's older than our git history.

2011-09-15 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 14, 2011, at 12:27 PM, Jamey Sharp wrote: Throughout the xserver git history, the generic portion of the int10 module has always used other methods for reading the video BIOS. For some time now it's been purely libpciaccess based

Re: [PATCH] fb: Rename wfbTriangles and wfbTrapezoids

2011-09-15 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 14, 2011, at 5:25 PM, Aaron Plattner wrote: These symbols were not renamed when they were added to libfb: # nm -D libwfb.so | grep ' fb' 00028d00 T fbTrapezoids 00028d60 T fbTriangles This causes corruption

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 2:58 AM, Julien Cristau wrote: On Wed, Sep 14, 2011 at 20:17:41 -0500, Jeremy Huddleston wrote: Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules need pixman or pciaccess, they should be depending on them directly

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Jeremy Huddleston
Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules need pixman or pciaccess, they should be depending on them directly rather than inheriting a dependency from xorg-server. The thing is, most video drivers *do* need pixman and pciaccess,

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 3:30 AM, Julien Cristau wrote: On Thu, Sep 15, 2011 at 03:20:02 -0500, Jeremy Huddleston wrote: Wouldn't it be nice if the servers that we cared about were in the xorg-server tree itself, so I could try building with these changes on a linux machine to see what broke

Re: [PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Jeremy Huddleston
Ok, then this gets my structural review, but would be nice if someone who really understands docbook looks at invocation. Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 15, 2011, at 8:41 AM, Gaetan Nadon wrote: On Thu, 2011-09-15 at 02:35 -0500, Jeremy Huddleston wrote: On Sep

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 11:34 AM, Alex Deucher wrote: For me personally, I don't seem much advantage in moving the drivers into the xserver. The number of ABI breaks is minimal (usually 1 per xserver) and those can usually be fixed within a day or so of the breakage. I don't rebuild the

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 11:02 AM, Michel Dänzer wrote: 3) Out of tree drivers will become second class citizens. I don't see that as a con. I see that as a benefit. If something is not in the tree, it IS a second class citizen, and users should not expect it to work any more. If the trident

Re: [PATCH fonts-util 2/2] If cross-compiling, we don't have to run mkfontdir

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 11:06 AM, Jon TURNEY wrote: On 14/09/2011 00:09, Jeremy Huddleston wrote: This is confusing to me. Why do you add the extra ; echo '** mkfontdir'? On Sep 12, 2011, at 9:18 AM, Jon TURNEY wrote: +AC_DEFUN([XORG_FONT_MKFONTDIR],[ + if test x$cross_compiling != xno

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-15 Thread Jeremy Huddleston
I review this in the sense that the comments match the src changes and look well formed. Hopefully another BSD developer can vouch for whether they actually do the right thing rather than just do the stated thing Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 15, 2011, at 12:20 PM

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 3:30 PM, Chase Douglas wrote: On 09/15/2011 01:00 PM, Jeremy Huddleston wrote: On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One

Re: [PATCH 3/3] xfree86: Link modules with -module

2011-09-15 Thread Jeremy Huddleston
? At least for me it builds a static libramdac.a not a shared object at all. -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System --- Jeremy Huddleston Rebuild Sudan - Board of Directors - http://www.rebuildsudan.org

Re: [PATCH] fb: Rename wfbTriangles and wfbTrapezoids

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 9:29 PM, Alan Coopersmith wrote: On 09/14/11 15:25, Aaron Plattner wrote: These symbols were not renamed when they were added to libfb: # nm -D libwfb.so | grep ' fb' 00028d00 T fbTrapezoids 00028d60 T fbTriangles This causes corruption and/or

Re: [RFC PATCH 0/9] Bus layer cleanups

2011-09-14 Thread Jeremy Huddleston
I'm interested in this patch series since I'm working to get Xorg building on darwin and need to get the IOADDRESS type of shared code. This is a pre-req for Tiago's --enable-pciaccess changes which I've rebased on recent master. This series still applies except for the following: [PATCH 5/9]

[PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-14 Thread Jeremy Huddleston
to to satisfy include dependencies but avoid linking needlessly. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac | 11 ++- xorg-server.pc.in |1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 415ead8

[PATCH 1/3] xfree86: fbdevhw: Remove unused include of pciaccess.h

2011-09-14 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xfree86/fbdevhw/fbdevhw.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/fbdevhw/fbdevhw.h b/hw/xfree86/fbdevhw/fbdevhw.h index bc46b9c..34870c2 100644 --- a/hw/xfree86/fbdevhw/fbdevhw.h +++ b/hw

[PATCH 3/3] xfree86: Link modules with -module

2011-09-14 Thread Jeremy Huddleston
This makes a difference on darwin (and apparently nowhere else) Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xfree86/dixmods/Makefile.am| 12 ++-- hw/xfree86/dixmods/extmod/Makefile.am |2 +- hw/xfree86/exa/Makefile.am|2 +- hw/xfree86/fbdevhw

[PATCH 0/2] Get the xfree86 to build on darwin

2011-09-13 Thread Jeremy Huddleston
In addition to Tiago's --disable-pci branch, this small series gets the xfree86 DDX to build on darwin. It removes a configure error with a warning and stub implementation for os-support. The second patch is a bit ugly (and hopefully there is a better way). It addresses an issue where ar is

[PATCH 1/2] xfree86: Add stubs for os-support to help adding new architecture support

2011-09-13 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Jamey Sharp ja...@minilop.net --- configure.ac|5 +++-- hw/xfree86/os-support/Makefile.am |2 +- hw/xfree86/os-support/stub/Makefile.am | 19 +++ hw/xfree86/os-support

[PATCH 2/2] xfree86: Work around issue where ar may be told to make an archive with no contents

2011-09-13 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xfree86/os-support/bus/Makefile.am |2 +- hw/xfree86/os-support/bus/nobus.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) create mode 100644 hw/xfree86/os-support/bus/nobus.c diff --git a/hw/xfree86/os-support/bus

Re: [PATCH libICE] specs: remove productnumber which is not used by default

2011-09-13 Thread Jeremy Huddleston
For all 4: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 11, 2011, at 4:23 PM, Gaetan Nadon wrote: This element is not rendered by default on the title. A template customization is required to display it. X Window System does not have a product number. Signed-off-by: Gaetan

Re: [PATCH fonts-util 2/2] If cross-compiling, we don't have to run mkfontdir

2011-09-13 Thread Jeremy Huddleston
___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel --- Jeremy Huddleston Rebuild Sudan - Board of Directors - http://www.rebuildsudan.org Berkeley Foundation

Re: [PATCH 1/2] Remove unused XORG_OS_PCI variable.

2011-09-13 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 13, 2011, at 4:33 PM, Jamey Sharp wrote: This is the last mention after ccfaf82367c9d057fd8314ce36b47f0a8eb696b6 quit using the variable. Signed-off-by: Jamey Sharp ja...@minilop.net --- configure.ac |3 --- 1 files changed, 0

Re: [PATCH] Remove PC98 support.

2011-09-13 Thread Jeremy Huddleston
Yeah, both people actually using PC98 should be satisfied with xorg-server-1.11 (if it actually still worked for them anyways). Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 13, 2011, at 5:55 PM, Jamey Sharp wrote: Gaetan Nadon wrote: Alan Coopersmith wrote: I think we

Re: [PATCH 2/2] configure.ac: XORG_OS is not used, so delete it.

2011-09-13 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 13, 2011, at 4:33 PM, Jamey Sharp wrote: Signed-off-by: Jamey Sharp ja...@minilop.net --- configure.ac |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index bc34c72..6c4fffd

Re: [PATCH] int10: Delete unused _PC variant methods.

2011-09-13 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 13, 2011, at 5:36 PM, Jamey Sharp wrote: I can't find any evidence that _PC has ever been defined. Patch created by fixing the documentation that referenced _PC, and running: for f in `git grep -Fwl _PC -- '*.[ch]'`; do

Re: [PATCH] x86emu: There is no NO_INLINE implementation of unaligned access here.

2011-09-13 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 13, 2011, at 4:32 PM, Jamey Sharp wrote: Patch produced with: unifdef -UNO_INLINE -B This change isn't relevant to the similar code in xfree86/common/compiler.h, because x86emu is expected to someday move out of xserver

Re: [PATCH mga] Nothing uses clientlx.c, so delete it.

2011-09-13 Thread Jeremy Huddleston
Huzah for 920 lines deleted. It compiles, ship it (seriously though, hopefully comeone can test this)! Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 13, 2011, at 4:12 PM, Jamey Sharp wrote: As far as I can tell, none of this code has been used since the beginning of git history

<    2   3   4   5   6   7   8   9   10   11   >