So, one of the things talked about at XDC was just how icky bugzilla has
become. There are a ton of open bugs which haven't been touched in ages and
either don't apply any more or don't have sufficient information to act upon.
I would like to spend some effort cleaning these up, but before I g
This addresses a build failure found by the tinderbox.
Signed-off-by: Jeremy Huddleston
---
See: http://tinderbox.x.org/builds/2011-09-17-/logs/libXi
src/Makefile.am |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index
er
> Date: Thu Jun 2 13:23:32 2011 +1000
>
>Support XI 2.1 internally
>
>Add the required constants to pretend to support XI 2.1.
>Having named constants for 2.1 seems a bit pointless, so let's just use the
>numbers directly.
>
>Signed-off-by: Pe
On Sep 16, 2011, at 13:10, Stéphane Marchesin wrote:
> 2011/9/16 Jeremy Huddleston :
>>
>> On Sep 16, 2011, at 12:45 PM, Stéphane Marchesin wrote:
>>
>>> Well, the issue is not separate. Driver repos are straightforward to
>>> get changes in and theref
On Sep 16, 2011, at 12:50 PM, Matt Turner wrote:
>
> --- a/hw/xfree86/vgahw/vgaHW.c
> +++ b/hw/xfree86/vgahw/vgaHW.c
> @@ -356,6 +356,8 @@ vgaHWSetStdFuncs(vgaHWPtr hwp)
> hwp->PIOOffset= 0;
> hwp->readEnable = stdReadEnable;
> hwp->writeEnable = stdWrit
available in the git repository at:
>>
>> ssh://people.freedesktop.org/~ajax/xserver.git ioaddress
>
> I merged patches 6 and 12 from the ioaddress branch since #12 just added a
> lost } from #6. Patch 2 had some tab/space mess which I also fixed.
>
> Let's get
On Sep 16, 2011, at 12:45 PM, Stéphane Marchesin wrote:
> Well, the issue is not separate. Driver repos are straightforward to
> get changes in and therefore can move forward easily.
How would that be different from an xorg-server tree with the exact same
privileges? I don't see any difference
out it off list.
1.2.0 to 1.4:
94 individuals
335 Daniel Stone
122 Keith Packard
83 Adam Jackson
74 Alan Coopersmith
71 Eric Anholt
69 Michel Dänzer
57 Soren Sandmann Pedersen
42 Brian
36 Ben Byer
35 Aaron Plattner
1.4 to 1.5:
106 individuals
360 Eamon Walsh
152 Adam Jackson
105 Ian Romani
On Sep 15, 2011, at 8:31 AM, Gaetan Nadon wrote:
> A bonus would be a list of drivers that do use pciaccess (maybe not in
> the commit text!). A complete list of drivers can be found in build.sh.
Here's a complete list of modules which didn't contain the links *BEFORE* my
change:
./drivers/chi
On Sep 15, 2011, at 9:29 PM, Alan Coopersmith wrote:
> On 09/14/11 15:25, Aaron Plattner wrote:
>> These symbols were not renamed when they were added to libfb:
>>
>> # nm -D libwfb.so | grep ' fb'
>> 00028d00 T fbTrapezoids
>> 00028d60 T fbTriangles
>>
>> This causes corrupt
xf86BitOrder.c
>
> Is this needed since libramdac isn't an installed module? At least for me
> it builds a static libramdac.a not a shared object at all.
>
> --
> -Alan Coopersmith-alan.coopersm...@oracle.com
>Oracle Solaris Platf
On Sep 15, 2011, at 3:30 PM, Chase Douglas wrote:
> On 09/15/2011 01:00 PM, Jeremy Huddleston wrote:
>>
>> On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote:
>>
>>> On Thursday 15 of September 2011, Jesse Barnes wrote:
>>>> At XDC this week
I review this in the sense that the comments match the src changes and look
well formed. Hopefully another BSD developer can vouch for whether they
actually "do the right thing" rather than just "do the stated thing"
Reviewed-by: Jeremy Huddleston
On Sep 15, 2011, a
On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote:
> On Thursday 15 of September 2011, Jesse Barnes wrote:
>> At XDC this week we discussed merging drivers back into the server
>> tree. One thing I found frustrating about the discussion was that we
>> didn't have a whiteboard nor a list of
On Sep 15, 2011, at 11:06 AM, Jon TURNEY wrote:
> On 14/09/2011 00:09, Jeremy Huddleston wrote:
>> This is confusing to me. Why do you add the extra " ; echo '** mkfontdir'"?
>
>> On Sep 12, 2011, at 9:18 AM, Jon TURNEY wrote:
>>> +AC_
On Sep 15, 2011, at 11:02 AM, Michel Dänzer wrote:
> 3) Out of tree drivers will become second class citizens.
I don't see that as a con. I see that as a benefit. If something is not in
the tree, it IS a second class citizen, and users should not expect it to work
any more. If the trident d
On Sep 15, 2011, at 11:34 AM, Alex Deucher wrote:
> For me personally, I don't seem much advantage in moving the drivers
> into the xserver. The number of ABI breaks is minimal (usually 1 per
> xserver) and those can usually be fixed within a day or so of the
> breakage. I don't rebuild the xse
Ok, then this gets my structural review, but would be nice if someone who
really understands docbook looks at invocation.
Reviewed-by: Jeremy Huddleston
On Sep 15, 2011, at 8:41 AM, Gaetan Nadon wrote:
> On Thu, 2011-09-15 at 02:35 -0500, Jeremy Huddleston wrote:
>
>> On Sep 14
On Sep 15, 2011, at 3:30 AM, Julien Cristau wrote:
> On Thu, Sep 15, 2011 at 03:20:02 -0500, Jeremy Huddleston wrote:
>
>> Wouldn't it be nice if the servers that we cared about were in the
>> xorg-server tree itself, so I could try building with these changes on a
Every module building against xorg-server does not *Require* pixman nor
libpciaccess. If such modules need pixman or pciaccess, they should be
depending on them directly rather than inheriting a dependency from
xorg-server.
>>> The thing is, most video drivers *do* need p
On Sep 15, 2011, at 2:58 AM, Julien Cristau wrote:
> On Wed, Sep 14, 2011 at 20:17:41 -0500, Jeremy Huddleston wrote:
>
>> Every module building against xorg-server does not *Require* pixman nor
>> libpciaccess. If such modules need pixman or pciaccess, they should be
&g
Reviewed-by: Jeremy Huddleston
On Sep 14, 2011, at 5:25 PM, Aaron Plattner wrote:
> These symbols were not renamed when they were added to libfb:
>
> # nm -D libwfb.so | grep ' fb'
> 00028d00 T fbTrapezoids
> 00028d60 T fbTriangles
>
> This caus
Reviewed-by: Jeremy Huddleston
On Sep 14, 2011, at 12:27 PM, Jamey Sharp wrote:
> Throughout the xserver git history, the generic portion of the int10
> module has always used other methods for reading the video BIOS. For
> some time now it's been purely libpciaccess based. This
Reviewed-by: Jeremy Huddleston
On Sep 14, 2011, at 12:05 PM, Arvind Umrao wrote:
> In solaris, /tmp/.X11-unix/ is already created with privilege
> drwxrwxrwt(01777), there is no reason to restrict /tmp/.X11-pipe with
> drwxrwxr-x (0775). So I have removed unwanted sun specific code.
On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote:
>
> +if HAVE_XMLTO_TEXT
> +noinst_DATA += $(docbook:.xml=.txt)
> +%.txt: %.xml $(chapters)
> + $(AM_V_GEN)$(XMLTO) $(XMLTO_HTML_FLAGS) txt $<
> +endif HAVE_XMLTO_TEXT
^^^ XMLTO_TEXT_FLAGS ??
___
xo
Loosely reviewed ... the magic looks reasonable to me, but I'm not terribly
familiar with the docbook internals to know if it's really the right magic.
Reviewed-by: Jeremy Huddleston
On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote:
> Adding support in libX11 for html chunking c
Reviewed-by: Jeremy Huddleston
On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote:
> Rather than referring to the external xorg.css stylesheet, embed the content
> of the file in the html output produced. This is accomplished by using
> version 1.10 of xorg-xhtml.xsl.
>
> This
This makes a difference on darwin (and apparently nowhere else)
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/dixmods/Makefile.am| 12 ++--
hw/xfree86/dixmods/extmod/Makefile.am |2 +-
hw/xfree86/exa/Makefile.am|2 +-
hw/xfree86/fbdevhw/Makefile.am
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/fbdevhw/fbdevhw.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/fbdevhw/fbdevhw.h b/hw/xfree86/fbdevhw/fbdevhw.h
index bc46b9c..34870c2 100644
--- a/hw/xfree86/fbdevhw/fbdevhw.h
+++ b/hw/xfree86/fbdevhw
to
to satisfy include dependencies but avoid linking needlessly.
Signed-off-by: Jeremy Huddleston
---
configure.ac | 11 ++-
xorg-server.pc.in |1 -
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index 415ead8..a97da47 100644
--- a
I'm interested in this patch series since I'm working to get Xorg building on
darwin and need to get the IOADDRESS type of shared code. This is a pre-req
for Tiago's --enable-pciaccess changes which I've rebased on recent master.
This series still applies except for the following:
[PATCH 5/9] v
Huzah for 920 lines deleted. It compiles, ship it (seriously though, hopefully
comeone can test this)!
Reviewed-by: Jeremy Huddleston
On Sep 13, 2011, at 4:12 PM, Jamey Sharp wrote:
> As far as I can tell, none of this code has been used since the
> beginning of git history.
>
>
Reviewed-by: Jeremy Huddleston
On Sep 13, 2011, at 4:32 PM, Jamey Sharp wrote:
> Patch produced with:
> unifdef -UNO_INLINE -B
>
> This change isn't relevant to the similar code in
> xfree86/common/compiler.h, because x86emu is expected to someday move
> out of
Reviewed-by: Jeremy Huddleston
On Sep 13, 2011, at 5:36 PM, Jamey Sharp wrote:
> I can't find any evidence that _PC has ever been defined.
>
> Patch created by fixing the documentation that referenced _PC, and
> running:
>
> for f in `git grep -F
Reviewed-by: Jeremy Huddleston
On Sep 13, 2011, at 4:33 PM, Jamey Sharp wrote:
> Signed-off-by: Jamey Sharp
> ---
> configure.ac |8
> 1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index bc34c72..6c4fffd 100644
Yeah, both people actually using PC98 should be satisfied with xorg-server-1.11
(if it actually still worked for them anyways).
Reviewed-by: Jeremy Huddleston
On Sep 13, 2011, at 5:55 PM, Jamey Sharp wrote:
> Gaetan Nadon wrote:
>
>Alan Coopersmith wrote:
>
>"
Reviewed-by: Jeremy Huddleston
On Sep 13, 2011, at 4:33 PM, Jamey Sharp wrote:
> This is the last mention after ccfaf82367c9d057fd8314ce36b47f0a8eb696b6
> quit using the variable.
>
> Signed-off-by: Jamey Sharp
> ---
> configure.ac |3 ---
> 1 files changed, 0 inser
SUBST([MKFONTDIR])
> +])
>
> # XORG_FONT_COMMON_UTILS()
> #
> @@ -187,7 +212,7 @@ AC_DEFUN([XORG_FONT_FCCACHE],[
>
> AC_DEFUN([XORG_FONT_COMMON_UTILS],[
> XORG_FONT_FCCACHE
> - XORG_FONT_REQUIRED_PROG(MKFONTDIR, mkfontdir)
> + XORG_F
For all 4:
Reviewed-by: Jeremy Huddleston
On Sep 11, 2011, at 4:23 PM, Gaetan Nadon wrote:
> This element is not rendered by default on the title. A template
> customization is required to display it.
> X Window System does not have a product number.
>
> Signed-off-b
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/os-support/bus/Makefile.am |2 +-
hw/xfree86/os-support/bus/nobus.c |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
create mode 100644 hw/xfree86/os-support/bus/nobus.c
diff --git a/hw/xfree86/os-support/bus/Makefile.am
b/hw
Signed-off-by: Jeremy Huddleston
Reviewed-by: Jamey Sharp
---
configure.ac|5 +++--
hw/xfree86/os-support/Makefile.am |2 +-
hw/xfree86/os-support/stub/Makefile.am | 19 +++
hw/xfree86/os-support/stub/stub_bell.c | 10
In addition to Tiago's --disable-pci branch, this small series gets the xfree86
DDX to build on darwin. It removes a configure error with a warning and stub
implementation for os-support.
The second patch is a bit ugly (and hopefully there is a better way). It
addresses an issue where ar is t
| 12
> 50 files changed, 241 insertions(+), 754 deletions(-)
> create mode 100644 COPYING
> create mode 100644 README
> create mode 100644 xaw3d.pc.in
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives:
Reviewed-by: Jeremy Huddleston
On Aug 23, 2011, at 14:51, Peter Hutterer wrote:
> This flag is part of the future (currently unreleased) XI 2.1 protocol.
> Introduced in 2c5187d0099e6c7588828ba9931d27f5c64bbaec
>
> Reported-by: Chris Ball
> Signed-off-by: Peter Hutterer
>
Reviewed-by: Jeremy Huddleston
On Aug 21, 2011, at 22:35, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> configure.ac |8 +++-
> src/list.c | 24
> src/test_xi2.c | 11 +++
> 3 files changed, 42 insertio
Reviewed-by; Jeremy Huddleston
On Aug 16, 2011, at 16:05, Alan Coopersmith wrote:
> It includes , , and , but
> does not include any headers or call any functions from libX11.
>
> Signed-off-by: Alan Coopersmith
> ---
> configure.ac |2 +-
> 1 files changed, 1 inser
The following changes since commit 4020cab88f5cf3164fc83cf912f94f288aa5a45d:
EXA/mixed: Update sys_pitch in MPH even when there's no system memory copy.
(2011-08-10 09:30:08 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Pelle Johansson
Reviewed-by: Jeremy Huddleston
On Aug 11, 2011, at 9:23 PM, Peter Hutterer wrote:
> Otherwise we run into the old problem again: recompiling xinput against
> newer inputproto headers will appear to change the version support,
> potentially causing errors or other misbehaviours.
>
Reviewed-by: Jeremy Huddleston
On Aug 11, 2011, at 9:25 PM, Peter Hutterer wrote:
> Otherwise we run into the old problem again: recompiling libXi against
> newer inputproto headers will appear to change the version support,
> potentially causing errors or other misbehaviours.
>
video
>> stream of the event.
>>
>> CALL FOR PAPERS: If you would like to present at the X.Org Developers
>> Conference, please add to the respective Wiki page:
>>
>> http://www.x.org/wiki/Events/XDC2011/Program
>>
>> Thanks,
>> Michael La
On Aug 10, 2011, at 8:56 AM, Michel Dänzer wrote:
> On Mit, 2011-08-10 at 08:26 -0700, Keith Packard wrote:
>> On Wed, 10 Aug 2011 11:36:16 +0200, Michel Dänzer wrote:
>>
>>> From: Michel Dänzer
>>>
>>> Otherwise sys_pitch will be stale when a system memory copy is allocated.
>>>
>>> Fixes
Looks about right...
Reviewed-by: Jeremy Huddleston
On Aug 1, 2011, at 12:34, Aaron Plattner wrote:
> RootWindow(dpy, 0) always uses screen 0, even if a different screen is
> specified in the $DISPLAY environment variable. Use
> DefaultRootWindow(dpy) instead to use the
The following changes since commit 08dfff92e8d0c2b1726634392c147f6634d1706d:
randr: Compare all the bytes in RRPostPendingProperties (2011-07-29 16:41:53
-0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (2
Reviewed-by: Jeremy Huddleston
Thanks.
On Jul 31, 2011, at 12:14, Julien Cristau wrote:
> Signed-off-by: Julien Cristau
> ---
> hw/xquartz/bundle/Makefile.am |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> Stumbled on these while trying to package a
Was there ever an updated version of this patch? This one seems to have bitrot.
On Jul 21, 2010, at 12:09, Keith Packard wrote:
> On Sun, 18 Jul 2010 20:49:58 -0700, Keith Packard wrote:
>
>> I think it would be nicer if the patch removed the bogus assignments
>> which are still there.
>
> Ar
Was there ever an updated version of this patch? This one seems to have bitrot.
On Jul 12, 2010, at 09:15, Keith Packard wrote:
> On Mon, 12 Jul 2010 10:07:12 -0400, Adam Jackson wrote:
>
>> + /* laame */
>> + if (screen->fb[0].depth == 24)
>> +if (priv->bytes_per_line < (screen->wid
This patch is attached to https://bugs.freedesktop.org/show_bug.cgi?id=31501 ,
but so far nobody has bothered to send it to xorg-devel ... I have not tested
it and am just forwarding it along for comment since it reportedly addresses
this crasher.
>From 59616dde4a04d407db76d55b06bcc82d646f42cd
On Jul 27, 2011, at 17:15, Peter Hutterer wrote:
> Note that these have not landed on master yet but they're in the pull queue.
> All four fix various startup crashers, triggered by xorg.conf input device
> configuration.
Yeah ... normally I'd want these to land in master first, but these look
We're discussing detaching from the tty that startx(1) was executed on, not the
tyy that the X11 server uses for its VT.
IE, you login to the shell on /dev/tty1, you run startx(1) there, and X11
starts on /dev/tty7. This is about disassociating with /dev/tty1.
On Jul 26, 2011, at 1:42 PM, Lenn
On Jul 26, 2011, at 1:34 PM, Ray Strode wrote:
> Hi,
>
> On Tue, Jul 26, 2011 at 4:02 PM, Jeremy Huddleston wrote:
>> IMO, there is a point to closing stdin aside from the setsid(2).
> My point is, it only solves the problem part way.
Well, the problem you are reporting is 2
On Jul 26, 2011, at 12:23 PM, Ray Strode wrote:
> Hi,
>
> On Tue, Jul 26, 2011 at 2:57 PM, Jeremy Huddleston wrote:
>> yick... ok, well I'd suggest making that its own patch rather than squashed
>> > into the stdin one... I dunno how I feel about it and will let
On Jul 26, 2011, at 11:28 AM, Ray Strode wrote:
> Hi,
>
> Apparently I wrote this patch like 5 years and promptly forgot about.
> Matej tracked me down and asked me to chime in. I don't really
> remember the patch, but it sort of makes sense to me so I'll try to
> answer any questions about it.
What's the point of setsid(2)? It certainly doesn't fall under the title of
the patch.
Also, you don't need:
+ close (STDIN_FILENO);
That is done for you by dup2(2). Also doing so could result in a problem if
this code were used in a multithreaded application. If another thread calle
Also, would you mind squashing this into your commit as well? After that and
cleaning up the ones in xwin (previous email),
Tested-by: Jeremy Huddleston
Reviewed-by: Jeremy Huddleston
diff --git a/hw/xquartz/darwin.c b/hw/xquartz/darwin.c
index a946448..f19d7bf 100644
--- a/hw/xquartz
This doesn't break XQuartz, but it reveals that we actually don't call LogClose
when we probably should be now.
That being said, it looks like you missed some...
~/src/freedesktop/src/xserver-1.11 (master) $ ack LogClose
hw/xfree86/common/xf86Helper.c
1203:LogClose(error);
hw/xwin/InitOutpu
repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
George Staplin (2):
XQuartz: Fix a memory leak with surfaces that a new test found.
XQuartz: Add diagnostic error checking to xp_destroy_surface.
Jeremy Huddleston (7):
XQuartz: DarwinEQFini doesn't return
Email the patch to xorg-devel for review, collect the reviewed-by's,
tested-by's, and send a final patch for integration. Use git format-patch to
create the patch.
--Jeremy
On Jul 15, 2011, at 1:57 PM, Bodo Graumann wrote:
> Hello,
>
> please excuse me, if I'm not following your patch workflo
For the series:
Reviewed-by: Jeremy Huddleston
On Jul 15, 2011, at 6:34 PM, Alan Coopersmith wrote:
> Changes from "xset: unknown option force" to
> "xset: missing argument to dpms force"
>
> Signed-off-by: Alan Coopersmith
> ---
> xset.c |5 +++--
Thanks.
Reviewed-by: Jeremy Huddleston
On Jul 13, 2011, at 4:08 AM, Daniel Stone wrote:
> The previous patch accidentally introduced a hard dependency on
> Composite. Sorry, OS X.
>
> Signed-off-by: Daniel Stone
> Reported-by: Jeremy Huddleston
> ---
> dix/window.c
Yeah ... autoconf has some ugly limitations, but then so does every build
system...
Reviewed-by: Jeremy Huddleston
On Jul 7, 2011, at 22:41, Alan Coopersmith wrote:
> This reverts commit 4af24b2f5b3f8f2c20271ae323b6fa528b9b2127.
>
> Letting autoconf do it failed to handle the
I'll pull this in next week for 1.10.4
--Jeremy
On Jul 3, 2011, at 20:17, Peter Hutterer wrote:
> Fix for 30068. I don't consider this a must, so if you'd rather skip this
> one, feel free to do so.
>
> The following changes since commit bc3c539e8a2b0b95a19e40258bcb18824d7700cd:
>
> configure
This breaks !composite
If you want to fix XQuartz so that it doesn't crash under composite, you're
more than welcome to, but short of that, would you mind fixing builds for the
!composite case:
http://tinderbox.x.org/builds/2011-07-03-/logs/xserver/#build
--Jeremy
On Jun 22, 2011, at 2:17
Reviewed-by: Jeremy Huddleston
On Jun 30, 2011, at 7:30 AM, Jon TURNEY wrote:
> The GLXversion member of the __GLXscreen struct
> is just cruft since commit ad5c0d9efa47476ed5cf75c82265c73919e468b4,
> when we started returning the minimum GLX version supported by all
> of the sc
This patch removes this XQuartz extension which needs to be initialized in the
new common path.
#ifdef INXQUARTZ
if(!noPseudoramiXExtension) PseudoramiXExtensionInit();
#endif
Is this on a branch of your personal git repo for testing?
On Jun 28, 2011, at 12:27, Daniel Stone wrote:
> Rather
Thanks. It's in the pull request I just sent.
The generator script is in mesa, so I'll try to figure this out in mesa as well.
--Jeremy
On Jun 28, 2011, at 6:24 AM, Jon TURNEY wrote:
> On 27/06/2011 18:38, Jeremy Huddleston wrote:
>> Those bits in the NoOp stub can be le
The following changes since commit 4dbed2625431a92e20bede7b8cef847b5d5d99ba:
xfree86: Only log the serial bytes if debug is on. (2011-06-27 12:21:45 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (2):
XQuartz
;, fstr);
}
On Jun 27, 2011, at 7:05 AM, Jon TURNEY wrote:
> On 14/06/2011 21:34, Jeremy Huddleston wrote:
>> _glapi_create_table_from_handle was recently added to mesa to ease creation
>> of
>> a _glapi_table. This commit brings this API over to xserver for use in
>>
On Jun 26, 2011, at 11:02 PM, Peter Hutterer wrote:
> On Sun, Jun 26, 2011 at 06:13:42PM -0700, Jeremy Huddleston wrote:
>> You should add that to XQuartz's CloseInput in darwinXinput.c rather than
>> adding a duplicate symbol in darwin.c
>>
>> Assuming
You should add that to XQuartz's CloseInput in darwinXinput.c rather than
adding a duplicate symbol in darwin.c
Assuming you do that,
Acked-by: Jeremy Huddleston
On Jun 26, 2011, at 17:39, Peter Hutterer wrote:
> mieqFini() already does the right thing, but it needs to be calle
The following changes since commit 8ac651552bb70ba36238f430adab2f7a7f24db6e:
Merge remote-tracking branch 'alanc/master' (2011-06-22 11:03:37 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (1):
XQuar
Thanks, I was having trouble figuring out the history for those.
c9336d1..9fab8b4 server-1.10-branch -> server-1.10-branch
--Jeremy
On Jun 19, 2011, at 23:05, Peter Hutterer wrote:
> Sorry, should've asked you to pull these ages ago.
> Fixes bugs 34182 and 36146.
>
> Cheers,
> Peter
>
>
The following changes since commit 08a7246f43c9f18079219a1c982bed558722f545:
dix: rename ProcessRawEvents to dix/events.c:DeliverRawEvent (2011-06-08
13:57:05 +1000)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (4
server and add those which
are still in the server but not in mesa (CullParameterdvEXT and
CullParameterfvEXT)
Signed-off-by: Jeremy Huddleston
Probably too big for the list, so see it here:
http://cgit.freedesktop.org/~jeremyhu/xserver/commit/?id=8bcb92245085e7c7ba81942381b4a75e90b8d355
Hi Chris,
Your xf86-intel patch bcef98af561939aa48d9236b2dfa2c5626adf4cb seems to have
causes xf86-video-intel to fail 'make check':
http://tinderbox.x.org/builds/2011-06-04-0001/logs/xf86-video-intel
It just starts hanging during make check. Your bcef98af patch was the only
change in xf86-vi
On Jun 6, 2011, at 11:48 PM, Peter Hutterer wrote:
>>
>> Or to really be picky:
>> buff = calloc(req->mask_len, 4);
>
> amended locally, thanks.
or to be even pickier:
buff = calloc(4, req->mask_len);
b/c:
void * calloc(size_t count, size_t size);
;)
___
-off-by: Philipp Reh
> Reviewed-by: Peter Hutterer
> Signed-off-by: Peter Hutterer
> Reviewed-by: Jeremy Huddleston
> ---
> Changes to v1:
> - slave devices can have confine_to as well. add the documentation
>
> I've thought about the valuator range confinement and IMO
Looks right...
Reviewed-by: Jeremy Huddleston
On Jun 6, 2011, at 9:01 PM, Peter Hutterer wrote:
> dc57f89959e549403f8488eb9f23425bd7118b22 accidentally reversed the
> conditions.
>
> in dix/events.c we try to detach floating devices. This leads to a
> NULL-dereference on
On Jun 5, 2011, at 9:22 PM, Peter Hutterer wrote:
> On Fri, Jun 03, 2011 at 11:40:02PM -0400, Jeremy Huddleston wrote:
>> 5-10, 12:
>> Reviewed-by: Jeremy Huddleston
>>
>> 11:
>>
>> This looks odd. You're only going to deliver to the first
Looks rightish.
Reviewed-by: Jeremy Huddleston
On Jun 2, 2011, at 9:36 PM, Alan Coopersmith wrote:
> Assign allow_null_passwd and allow_root_login variables' values before call to
> pam_authenticate()
>
> https://bugs.freedesktop.org/show_bug.cgi?id=13455
>
> Based on
Set:
Reviewed-by: Jeremy Huddleston
On Jun 3, 2011, at 1:10 AM, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
> greeter/Login.c |8
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/greeter/Login.c b/greeter/Login.c
> i
> Reviewed-by: Alan Coopersmith
> 5,6:
> Reviewed-by: Jeremy Huddleston
> 7,8,9:
> Disgusted-by: Jeremy Huddleston
> Reviewed-by: Jeremy Huddleston
> 10:
> Reviewed-by: Jeremy Huddleston
> 12:
> Reviewed-by: Jeremy Huddleston
>
> → Amended wi
5-10, 12:
Reviewed-by: Jeremy Huddleston
11:
This looks odd. You're only going to deliver to the first client:
+for (; inputclients; inputclients = inputclients->next)
{
+ClientPtr c; /* unused */
+Mask m; /* unused */
+InputCl
The following changes since commit 5115c2c7216fc10acb8a26deb904ad15ef18ce8a:
Xephyr: Mention Xserver's options are also accepted. (2011-06-03 18:09:51
+0200)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (3):
XQ
Reviewed-by: Jeremy Huddleston
I'll review 5+ later ...
Sent from my iPhone...
On Jun 2, 2011, at 22:45, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> Changes to v1:
> - use get_confine_to instead of in-place byte offset calculation
>
> Xi/xigrabd
for all 4 libXi patches
Reviewed-by: Jeremy Huddleston
Sent from my iPhone...
On Jun 2, 2011, at 23:56, Peter Hutterer wrote:
> Same as the XI 2.0 calls but they take a confine_to window.
> Both the old call and the new call send the confine_to down the wire now
> (None for XIG
i believe 4/4 also had unbalanced unlock as well
Sent from my iPhone...
On Jun 2, 2011, at 21:40, Peter Hutterer wrote:
> From: Philipp Reh
>
> The new function is like XIGrabDevice but it takes an
> additional confine_to parameter. This functionality is important
> for programs that need rel
Yep. Looks like it.
Reviewed-by: Jeremy Huddleston
On Jun 2, 2011, at 3:32 AM, Nicolas Kaiser wrote:
> * Alan Coopersmith :
>> Providing an argument to return in a function with void return type
>> is not allowed by the C standard, and makes the Sun compilers unhappy.
>>
xserver patches 1, 2, 4:
Reviewed-by: Jeremy Huddleston
I haven't looked at 5+ yet but should be able to this weekend.
--Jeremy
On Jun 2, 2011, at 12:13 AM, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> include/protocol-versions.h |2 +-
> 1 files chan
"&stuff[1] + stuff->mask_len * 4 + stuff->num_modifiers * 4" is rather
grotesque, IMO ... can that be cleaned up a bit? Even having an extra variable
properly named with a comment explaining that it's referencing the XI2 confine
window would be better than just dropping that bomb in place.
On
This hunk irks me.
> @@ -65,10 +65,15 @@ XIGrabDevice(Display* dpy, int deviceid, Window
> grab_window, Time time,
> buff = calloc(1, len * 4);
> memcpy(buff, mask->mask, mask->mask_len);
>
> +len++; /* for the confine_to */
> +
> SetReqLen(req, len, len);
> -Data(dpy, buff,
701 - 800 of 1444 matches
Mail list logo
