Re: Alignment error in libXi

2011-03-25 Thread Jeremy Huddleston
On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy? You can just get the latest libXi release with the fix.

xf86-video-xgi xf86-video-xgixp: Tinderbox build failures for big endian

2011-03-25 Thread Jeremy Huddleston
xf86-video-xgi and xf86-video-xgixp fail to build on BigEndian architectures due to: http://tinderbox.x.org/builds/2011-03-25-0003/logs/xf86-video-xgi/#build src/xgi_accel.c references undefined CurrentColorDepth http://tinderbox.x.org/builds/2011-03-25-0003/logs/xf86-video-xgixp/#build

Re: Alignment error in libXi

2011-03-25 Thread Jeremy Huddleston
Don't feel too bad. I missed it too and bugged Peter about it before I pushed the release ;) On Mar 24, 2011, at 11:31 PM, Matt Turner wrote: On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one

Re: xf86-video-xgi xf86-video-xgixp: Tinderbox build failures for big endian

2011-03-25 Thread Jeremy Huddleston
Thank's I've removed them from the skip list. --Jeremy On Mar 25, 2011, at 3:55 PM, Adam Jackson wrote: On 3/25/11 2:40 AM, Jeremy Huddleston wrote: xf86-video-xgi and xf86-video-xgixp fail to build on BigEndian architectures due to: http://tinderbox.x.org/builds/2011-03-25-0003/logs

Re: [PATCH xserver] GLX: Support TLS with better portability

2011-03-23 Thread Jeremy Huddleston
On Mar 22, 2011, at 9:13 PM, tom fogal wrote: Jeremy Huddleston jerem...@apple.com writes: AX_TLS detects when toolchains support __thread or __declspec(thread), but existing code assumed __thread. Good find. configure.ac|1 + [snip] +AC_DEFINE(__XSERVER_TLS

[PATCH] GLX: Support TLS with better portability

2011-03-23 Thread Jeremy Huddleston
From c55baebf4ebf1887262cc16899eb297b9f284f6e Mon Sep 17 00:00:00 2001 From: Jeremy Huddleston jerem...@apple.com Date: Tue, 22 Mar 2011 19:01:48 -0700 Subject: [PATCH] GLX: Support TLS with better portability AX_TLS detects when toolchains support __thread or __declspec(thread), but existing

[PULL XQuartz] clang fixes + [PATCH] GLX: Support TLS with better portability

2011-03-23 Thread Jeremy Huddleston
+0900) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (4): GLX: Support TLS with better portability XQuartz: Properly comment extra tokens (-Wextra-tokens) after endif XQuartz: Put ifdef guards around have_depth

[PATCH xserver] GLX: Support TLS with better portability

2011-03-22 Thread Jeremy Huddleston
AX_TLS detects when toolchains support __thread or __declspec(thread), but existing code assumed __thread. Found-by: Tinderbox http://tinderbox.x.org/builds/2011-03-22-0007 Regression-from: 82b1eaa6cad20f39dbf15573bdb3d62acbcd91f9 Signed-off-by: Jeremy Huddleston jerem...@apple.com

Re: TLS autodetection support in the X server

2011-03-22 Thread Jeremy Huddleston
This change introduced a regression when building with clang on darwin (and possibly other configurations as well): http://tinderbox.x.org/builds/2011-03-22-0007 http://cgit.freedesktop.org/xorg/xserver/commit/?id=93393411e39fbb0f72cf6c2f79ebde177aa86932 This is because the AX_TLS macro tests

Nominations for 1.10.1 RC1 on Friday

2011-03-21 Thread Jeremy Huddleston
1.10.1 RC1 (that's a lot of 1s) is planned for release this Friday. Currently, we don't have much on the server-1.10-branch, so please send me nomination requests. I'll be going over recent master commits to cherry-pick in what I feel is prudent, but if you feel strongly about a change

Re: libX11: Changes to 'master'

2011-03-17 Thread Jeremy Huddleston
There's been quite a bit of code churn in libX11, and I want to get Jamey's fixes out. If nobody yells at me not to in the next half hour or so, I'm going to tag/push an updated libX11 tag (1.4.2). Thanks for those changes Jamey. --Jeremy On Mar 15, 2011, at 16:57, Jamey Sharp wrote:

Re: [PULL] xserver-next, 2011-03-08

2011-03-09 Thread Jeremy Huddleston
/facepalm fix applied to both 1.9 and 1.10: 424..8ffaef2 server-1.9-branch - server-1.9-branch 3550396..0ab680f server-1.10-branch - server-1.10-branch On Mar 9, 2011, at 15:23, Adam Jackson wrote: On 3/9/11 5:20 PM, Keith Packard wrote: On Tue, 08 Mar 2011 13:52:45 -0500, Adam

Need some m4 wizardry to quote []s in configure.ac

2011-03-04 Thread Jeremy Huddleston
How do I quote []s in m4? I've tried escaping with \, 's, s, ... I'm out of tricks... I'm trying to update the poll() checks in libxcb and libXt to allow poll on darwin11, but the []s are getting stripped. darwin[789]* is becoming darwin789*, and the \([^ ]*\) in sed is becoming \(^ *\) ...

Re: Need some m4 wizardry to quote []s in configure.ac

2011-03-04 Thread Jeremy Huddleston
On Mar 4, 2011, at 11:42, Gaetan Nadon wrote: On Fri, 2011-03-04 at 10:50 -0800, Jeremy Huddleston wrote: How do I quote []s in m4? I've tried escaping with \, 's, s, ... I'm out of tricks... I'm trying to update the poll() checks in libxcb and libXt to allow poll on darwin11

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Jeremy Huddleston
On Feb 28, 2011, at 22:53, Keith Packard wrote: 2) I think the early rcs might not have been as well tested because they relied on xextproto and randrproto versions that were not released. Perhaps we should ensure that we release rc protos along with rc servers where appropriate. Do you

[PULL] Misc XQuartz changes for 1.11

2011-03-01 Thread Jeremy Huddleston
The following changes since commit f3d19c0cf3327cceb90f7378f5d8fc0c3e327400: Version bumped to 1.10 (2011-02-25 21:25:58 -0800) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (6): XQuartz: RandR: Capture the display when

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-02-28 Thread Jeremy Huddleston
On Feb 28, 2011, at 21:14, Keith Packard wrote: On Tue, 1 Mar 2011 13:34:54 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: A number of fixes I've had lingering in my next branch. I was about to send out a message offering to run the 1.11 release. I'm still having fun doing it.

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-02-28 Thread Jeremy Huddleston
On Feb 28, 2011, at 22:30, Keith Packard wrote: On Tue, 1 Mar 2011 15:55:13 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: There were a few times during the last cycle where patches didn't get merged but for no apparent reason. A simple email to the list stating something like I'm

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011-02-25 Thread Jeremy Huddleston
Merged: 0e253a9..7b3b7ef server-1.9-branch - server-1.9-branch On Feb 24, 2011, at 19:52, Cyril Brulebois wrote: Keith Packard kei...@keithp.com (24/02/2011): On Thu, 24 Feb 2011 12:17:57 +0100, Michel Dänzer mic...@daenzer.net wrote: On the other hand, the system memory copy doesn't

[PULL xserver] Minor XQuartz updates

2011-02-24 Thread Jeremy Huddleston
) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (2): XQuartz: Add LSApplicationCategoryType key to Info.plist XQuartz: Localization Updates hw/xquartz/bundle/Info.plist.cpp |2 + .../bundle/Resources

Re: Spinning in _XReply

2011-02-21 Thread Jeremy Huddleston
. The only way to break out of that while(1) loop is if req == current. I wonder why the test at the top: if(dpy-flags XlibDisplayIOError) return 0; did not work. Pat --- On Sat, Jan 29, 2011 at 11:54 AM, Jeremy Huddleston jerem...@apple.com wrote: I'm trying

Re: Spinning in _XReply

2011-02-21 Thread Jeremy Huddleston
On Feb 21, 2011, at 19:03, Pat Kane wrote: On Mon, Feb 21, 2011 at 7:51 PM, Jeremy Huddleston jerem...@apple.com wrote: So... what should we do about this? A good first step would be to try come up with a small-ish test case, or to at least figure out how to reproduce the problem

Re: xkeyboard-config 2.1

2011-02-11 Thread Jeremy Huddleston
/g' rules/base.xml.in rules/base.xml) } I'll try to find a new way around this. Thanks. --Jeremy On Feb 11, 2011, at 07:07, Gaetan Nadon wrote: On Fri, 2011-02-11 at 01:42 -0800, Jeremy Huddleston wrote: 2.0 built fine, but when I dropped 2.1 into my build system, things started

xorg-server 1.9.5 release schedule

2011-02-11 Thread Jeremy Huddleston
1.9.5 will likely be the last scheduled release of the 1.9 server branch. 1.9.5 is on a 8-week schedule (like 1.9.4). I've updated the calendar with the following release dates: 2011-03-04 - 1.9.5 RC1 2011-03-25 - 1.9.5 RC2 2011-04-01 - 1.9.5 Changes for 1.9.5 should continue to fit the

Re: [PATCH 1/3] exa/driver: set pExaPixmap-use_gpu_copy to the right value

2011-02-07 Thread Jeremy Huddleston
On Feb 7, 2011, at 09:24, Maarten Maathuis wrote: 2011/2/7 Michel Dänzer mic...@daenzer.net: On Mon, 2011-02-07 at 09:34 +0100, Maarten Maathuis wrote: On Wed, Feb 2, 2011 at 11:55 PM, Keith Packard kei...@keithp.com wrote: On Sun, 30 Jan 2011 14:06:14 +0100, Maarten Maathuis

Re: --disable-nls

2011-02-05 Thread Jeremy Huddleston
On Feb 5, 2011, at 06:03, Gaetan Nadon wrote: On Fri, 2011-02-04 at 13:56 -0800, Jeremy Huddleston wrote: It looks like libXpm ... does not honor --disable-nls. and it does not need to. Actually, it should, in order to disable undersired support or pull in undesired dependencies

--disable-nls

2011-02-04 Thread Jeremy Huddleston
Hey Gaetan, It looks like libXpm (and probably others, I just noticed now because of a toolchain change) does not honor --disable-nls. Do you know how wide spread this is throughout the modules? This seems like something we should move into util-macros. --Jeremy ./configure

Re: --disable-nls

2011-02-04 Thread Jeremy Huddleston
On Feb 4, 2011, at 13:02, Gaetan Nadon wrote: On Fri, 2011-02-04 at 10:25 -0800, Jeremy Huddleston wrote: It looks like libXpm ... does not honor --disable-nls. ... Never heard of it, did a bit a surfing. It is related to getttext and intltool which is used in libXpm only and inxload

[PATCH xrdb] Properly honor -nocpp

2011-02-02 Thread Jeremy Huddleston
Previously, if the user passed -nocpp and there was a cpp present, cpp would be used. This patch fixes that case. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- xrdb.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/xrdb.c b

Spinning in _XReply

2011-01-29 Thread Jeremy Huddleston
29, 2011, at 02:23, Peter Dyballa wrote: Am 29.01.2011 um 05:50 schrieb Jeremy Huddleston: Ok, well give me a spindump when your libXaw3d version is in this state. Here it is: emacs-24.0.50.1_26454.sample.txt -- Greetings Pete Inside every small problem is a large problem

[PULL xserver] XQuartz updates

2011-01-28 Thread Jeremy Huddleston
in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (5): XQuartz: Update copyright dates in bundle's plist XQuartz: Bump version string to 2.6.1 XQuartz: Call RRScreenSizeNotify after handling externally-generated

Re: [PATCH 1.9.2.902 1/1] dix: GetPointerEvents: added valuator range checking

2011-01-24 Thread Jeremy Huddleston
Pushed: 089a510..188148e server-1.9-branch - server-1.9-branch On Jan 24, 2011, at 16:34, Peter Hutterer wrote: On Mon, Jan 24, 2011 at 10:03:30PM +0200, Oliver McFadden wrote: Button events may be sent with no valuators (e.g. to simply indicate ButtonPress or ButtonRelease without any

1.9.4rc2 next Friday

2011-01-23 Thread Jeremy Huddleston
Due to other schedules I'm dealing with and the relatively small number of changes on the branch since rc1, I've pushed the 1.9.4 release schedule back a week. Please send me any change requests. Thanks, Jeremy ___ xorg-devel@lists.x.org: X.Org

Re: [PULL 1.9] two minor input fixes

2011-01-11 Thread Jeremy Huddleston
Done: 6451a3f..089a510 server-1.9-branch - server-1.9-branch On Jan 11, 2011, at 17:15, Peter Hutterer wrote: The second one is just a debug message typo anyway, the first one fixes up a minor issue with udev callbacks. The following changes since commit

Re: [PULL 1.9] xfree86(ish) updates

2011-01-07 Thread Jeremy Huddleston
a3c7b86..3d12e6d server-1.9-branch - server-1.9-branch On Jan 6, 2011, at 14:50, Adam Jackson wrote: Not entirely xf86 ddx, but all things that hardware server users can hit. --- The following changes since commit a3c7b86472aed80cf16edcfe2b77a92d4f3d196f: EXA: Pad size of system

Re: [PATCH] EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803).

2011-01-06 Thread Jeremy Huddleston
On Jan 6, 2011, at 10:46, Michel Dänzer wrote: On Don, 2011-01-06 at 08:38 -0800, Keith Packard wrote: Merged. f348028..6358a60 master - master Thanks Keith. This is a candidate for the 1.9 (and 1.8) branch. 93b75c7..a3c7b86 server-1.9-branch - server-1.9-branch

1.9.4rc1 - send me cherry-picks and merge requests

2011-01-05 Thread Jeremy Huddleston
Right now, the changes on the server-1.9-branch are pretty small (which is hopefully an indicator of a high level of stability). The schedule calls for the 1.9.4rc1 to be tagged on Friday, so please send me any change requests before then, so I can cherry-pick and merge as appropriate. After

Re: xserver: Branch 'master' - 11 commits

2010-12-30 Thread Jeremy Huddleston
On Dec 30, 2010, at 07:12, Julien Cristau wrote: On Mon, Dec 6, 2010 at 19:59:18 -0800, Keith Packard wrote: commit 27593eea7efcbed8de0c6e8233cbd1a1b8a50459 Author: James Jones jajo...@nvidia.com Date: Mon Dec 6 13:36:14 2010 -0800 Add and use SERVER_SYNC_*_VERSION Most

Re: xorg-server-1.9.4 release schedule

2010-12-27 Thread Jeremy Huddleston
On Dec 26, 2010, at 14:27, Cyril Brulebois wrote: Jeremy Huddleston jerem...@freedesktop.org (14/12/2010): I've updated the X.org calendar for the xorg-server-1.9.4 release schedule. […] 1.10.0 is scheduled for release in mid February, so we'll likely have just one more release (1.9.5

Re: [PATCH] EXA: Fix crash with fill using 1x1 tile of depth 8 (bug #24703).

2010-12-23 Thread Jeremy Huddleston
On Dec 23, 2010, at 03:26, Michel Dänzer wrote: On Mit, 2010-12-22 at 11:38 -0800, Keith Packard wrote: On Wed, 22 Dec 2010 11:45:36 +0100, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer daen...@vmware.com Fixes http://bugs.freedesktop.org/show_bug.cgi?id=24703 .

Re: Reviewed patches from the Ubuntu tree

2010-12-21 Thread Jeremy Huddleston
Done: a2c674b..d819ff1 On Dec 21, 2010, at 04:40, Thierry Vignaud wrote: On 21 December 2010 00:48, Thierry Vignaud thierry.vign...@gmail.com wrote: Ping? The sync fixes resolve some fairly visible and annoying behaviour with an uninterruptible fade in gnome-screensaver. Thanks for the

Re: [PULL 1.9] input fixes for 1.9.4

2010-12-15 Thread Jeremy Huddleston
Done: e1e37ef..a2c674b On Dec 14, 2010, at 19:18, Peter Hutterer wrote: Nothing big, just two bugfixes and the fixes to make the test runs faster. The following changes since commit e1e37ef7eb72fb4dfd8cefa1933e406231558d9d: XQuartz GL: Add $(GL_CFLAGS) to CFLAGS (2010-12-14 17:55:19

xorg-server-1.9.4 release schedule

2010-12-14 Thread Jeremy Huddleston
I've updated the X.org calendar for the xorg-server-1.9.4 release schedule. The 6 week schedule (3/2/1) has been working fairly well, so I'm keeping with the pattern (but 4/2/1 in this case due to the holiday): 2011.01.07 - 1.9.4rc1 2011.01.21 - 1.9.4rc2 (freeze for regressions only)

Re: [PATCH libxkbcommon 00/11] Review configuration - Part 3

2010-12-13 Thread Jeremy Huddleston
For the series: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 11, 2010, at 17:08, Gaetan Nadon wrote: I left a couple of items to do: 1- add a paragraph in the README file describing what this library does 2- add the _X_EXPORT _X_HIDDEN where appropriate Please check

Re: [PATCH newport] Replace X{c, r, }alloc and Xfree for stdlib functions

2010-12-13 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 13, 2010, at 09:55, Paulo Zanoni wrote: Signed-off-by: Paulo Zanoni pzan...@mandriva.com --- src/newport_cursor.c |2 +- src/newport_driver.c |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src

Re: [PATCH 3/3 xgi] Replace alloc for malloc

2010-12-13 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 13, 2010, at 10:02, Paulo Zanoni wrote: alloc is not declared Signed-off-by: Paulo Zanoni pzan...@mandriva.com --- src/xgi_driver.c | 14 +++--- src/xgi_opt.c|2 +- src/xgi_video.c |2 +- 3 files changed, 9

Re: [PATCH:x11proto] Enable gcc attribute(__format__) on gcc versions older than 4.0

2010-12-10 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 9, 2010, at 22:34, Alan Coopersmith wrote: Enabled on 2.3 and up, since that's where it's available according to http://www.ohse.de/uwe/articles/gcc-attributes.html#func-format Tested with gcc 3.4.3 on Solaris. Signed-off-by: Alan

Re: bitmaps: Changes to 'refs/tags/xbitmaps-1.1.1'

2010-12-09 Thread Jeremy Huddleston
On Dec 8, 2010, at 23:15, Alan Coopersmith wrote: Jeremy Huddleston wrote: This release still has the file collision with bitmap that I mentioned a while ago. Sorry, I didn't remember anything about that - but this collision must have existed since X11R6.0 or so - these aren't new files

[PULL] XQuartz: Cull buggy CoreAudio

2010-12-08 Thread Jeremy Huddleston
The following changes since commit 2c70b650b342378898064cf27e2f95c4b2e53d24: Fix Xwin build after af0f9f91 (2010-12-08 11:48:21 -0800) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (1): XQuartz: Just NSBeep() for XBell

Tinderbox Regression Xext/sync.c

2010-12-08 Thread Jeremy Huddleston
The recent fence sync changes have introduced a new warning that should be addressed. I'm guessing it's just a cast to a less-specific struct ptr, but I haven't looked at the code to be certain: sync.c: In function 'SyncCreate': sync.c:889: warning: assignment from incompatible pointer type

Re: bitmaps: Changes to 'refs/tags/xbitmaps-1.1.1'

2010-12-08 Thread Jeremy Huddleston
config: remove the pkgconfig pc.in file from EXTRA_DIST config: do not clean xbitmaps.pc config: update AC_PREREQ statement to 2.60 Jeremy Huddleston (1): This is not a GNU project, so declare it foreign. --- .gitignore | 77

Re: Any last-minute nominations for server-1.9-branch

2010-12-03 Thread Jeremy Huddleston
As it's not even on master right now, this will need to wait for 1.9.4 ... Sent from my iPhone... On Dec 3, 2010, at 0:39, Jesse Adkins jesserayadk...@gmail.com wrote: Threadjacking a bit, but is it possible that vdb's latest patch for 17953 could get slipped in? It adds some printing for

Re: Any last-minute nominations for server-1.9-branch

2010-12-03 Thread Jeremy Huddleston
Done. 806790b..2fa0029 server-1.9-branch - server-1.9-branch On Dec 2, 2010, at 21:24, Alan Coopersmith wrote: Jeremy Huddleston wrote: I pulled in a few more changes to server-1.9-branch based on what Julien recently merged into the 1.7 branch. Tomorrow will be the last rc before

[PULL] XQuartz: disabling OSX screensaver and some warning cleanups

2010-12-03 Thread Jeremy Huddleston
The following changes since commit 311cad33155c64ed996418808727fc417168592e: Fix Xdmx and Xephyr build when DTrace support is enabled (2010-12-02 16:56:30 -0800) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (3

[PULL updated] XQuartz: disabling OSX screensaver, RandR regression, and some warning cleanups

2010-12-03 Thread Jeremy Huddleston
) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (4): XQuartz: Disable the Mac OS X screensaver when in full screen mode XQuartz: Remove one more backing store leftover XQuartz: Cleanup some compiler warnings

Re: [PATCH for discussion] release.sh: autodetect current and previous tags

2010-12-03 Thread Jeremy Huddleston
On Sep 24, 2010, at 12:18, Gaetan Nadon wrote: On Fri, 2010-09-24 at 11:21 -0700, Alan Coopersmith wrote: +Usage: `basename $0` [options] section [tag_previous [tag_current]] +Usage: `basename $0` [options] section initial [tag_current] Can there be a safeguard to prevent accidental

Re: [PATCH 2/7] Add asprintf() implementation for platforms without it

2010-12-03 Thread Jeremy Huddleston
On Dec 3, 2010, at 21:09, Alan Coopersmith wrote: ... +extern _X_EXPORT int Xasprintf (char **ret, + const char * _X_RESTRICT_KYWD fmt, + ...) _X_ATTRIBUTE_PRINTF(2,3); +extern _X_EXPORT int Xvasprintf (char **ret, +

Re: [PATCH 3/7] Convert existing Xprintf style calls to asprintf style

2010-12-03 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 3, 2010, at 21:09, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- config/hal.c |4 ++- config/udev.c | 14 ++- dix/dixfonts.c

Re: Any last-minute nominations for server-1.9-branch

2010-12-02 Thread Jeremy Huddleston
Done. e720e08..7eaf84d On Dec 2, 2010, at 13:20, Aaron Plattner wrote: On Thu, Dec 02, 2010 at 12:29:54PM -0800, Jeremy Huddleston wrote: I pulled in a few more changes to server-1.9-branch based on what Julien recently merged into the 1.7 branch. Tomorrow will be the last rc before

Re: [PATCH 0/7] Xserver-spec: another batch of updates

2010-11-28 Thread Jeremy Huddleston
Series: Reviewed-by: Jeremy Huddleston jerem...@apple.com Does the documentation include reference for these from inputstr.h which I recall being added in the past year or two: #define BitIsOn(ptr, bit) (!!(((BYTE *) (ptr))[(bit)3] (1 ((bit) 7 #define SetBit(ptr, bit) (((BYTE *) (ptr

Re: [PATCH 1/2] Remove unused ReqLen CastxReq macros

2010-11-27 Thread Jeremy Huddleston
Both: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Nov 27, 2010, at 13:46, Alan Coopersmith wrote: According to Xserver-spec, they were part of the now-deleted DBE Idioms code. The last callers of them were removed in commits fe616f9230b6 3d642905477f. Signed-off-by: Alan

Re: [PATCH:libxt] Fix missing const qualifier.

2010-11-26 Thread Jeremy Huddleston
of the newly introduced warning, the change is correct. I'd rather see the change persist. Additionally, the change to libXt is correct regardless of whether or not it generates a warning with the broken libX11. Reviewed-By: Jeremy Huddleston jerem...@apple.com On Nov 25, 2010, at 14:30, Alan

Re: [PATCH 1/6] dix: replace a manual valuator check with valuator_get_mode().

2010-11-23 Thread Jeremy Huddleston
All 6: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Nov 22, 2010, at 19:35, Peter Hutterer wrote: This check was missing the OutOfProximity mask and resulted in the wrong bits being set in InternalEvents. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c

Re: [PULL] xfree86 updates for 1.9.3

2010-11-23 Thread Jeremy Huddleston
Merged, thanks. 201273a..2da9b72 On Nov 23, 2010, at 10:34, Adam Jackson wrote: The following changes since commit 201273a2b97754d1f9fd672660dcc9c05af29621: XQuartz: Don't use bashism in uninstall-hook (2010-11-15 10:57:43 -0800) are available in the git repository at:

CallCallbacks tinderbox regression (dirty object files not rebuilt)

2010-11-14 Thread Jeremy Huddleston
http://tinderbox.x.org/builds/2010-11-11-0004/logs/xserver/#build http://cgit.freedesktop.org/xorg/xserver/commit/?id=6274dca9d984ad3c553b4901edc3151e770e6c40 From the look of it, it seems like a dependency issue. include/callback.h was updated, but xace.o resource.o and selection.o were not

Re: Broken make check with 1.9.3 rc1

2010-11-14 Thread Jeremy Huddleston
Thanks Cyril and Julien. Peter, can you ack this for my cherry-pick. On Nov 14, 2010, at 02:35, Julien Cristau wrote: On Sun, Nov 14, 2010 at 11:23:04 +0100, Cyril Brulebois wrote: Hi Jeremy, looks like 1.9.3 rc1 doesn't pass “make check”: | /dix/input/init-valuators: OK |

[PATCH 2/2] XQuartz: Fix make distcheck

2010-11-13 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xquartz/bundle/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xquartz/bundle/Makefile.am b/hw/xquartz/bundle/Makefile.am index c4d77c0..8237e0d 100644 --- a/hw/xquartz/bundle/Makefile.am +++ b/hw

[PATCH 2/2 updated] XQuartz: Fix make distcheck

2010-11-13 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Cyril Brulebois k...@debian.org --- hw/xquartz/bundle/Makefile.am |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/xquartz/bundle/Makefile.am b/hw/xquartz/bundle/Makefile.am index c4d77c0..8a206cf

Re: [PATCH] Xorg.man: Replace XDarwin reference with Xquartz

2010-11-12 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Nov 12, 2010, at 20:53, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/doc/man/Xorg.man.pre |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/doc/man

XQuartz buildfailure with recent input changes

2010-11-11 Thread Jeremy Huddleston
Hey Peter, tinderbt ox picked up a build failure in XQuartz with the recent input changes. I'll hopefully have time to take a look at it this weekend, but you probably know what the fix is better than I do since didn't I look at all the recent merges to master. --Jeremy

[PATCH] XQuartz: Build-fixes for XQuartz for recent input API changes

2010-11-11 Thread Jeremy Huddleston
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xquartz/darwin.c |2 -- hw/xquartz/darwinEvents.c |7 --- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/xquartz/darwin.c b/hw/xquartz/darwin.c

[PATCH] DOC: Only build dtrace documentation with --enable-docs

2010-11-09 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |1 + doc/xml/dtrace/Makefile.am |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 35a6c52

fop requiring a GUI

2010-11-09 Thread Jeremy Huddleston
This came up a while ago that building documentation failed without a GUI due to some oddities in fop... this can be worked around by adding -Djava.awt.headless=true to FOP_OPTS, so maybe we should set that by default. ___ xorg-devel@lists.x.org:

Re: [PULL 1.9] input fixes for 1.9.3

2010-11-09 Thread Jeremy Huddleston
pushed, thanks. On Nov 9, 2010, at 20:25, Peter Hutterer wrote: Jeremy, Please pull the 1.9 input fixes from my repo. Fairly straightforward stuff, all bugfixes. The only special one is the dix: don't create core motion patch which was reverted on the 1.9 branch because of 30267. The patch

1.9.3rc1 Firday

2010-11-08 Thread Jeremy Huddleston
I'd like to round up changes for a 1.9.3rc1 this Friday. I know there are some good input fixes (one of which was delayed from 1.9.2 due to a regression that should now be fixed), and there are probably others. If you think you've got a fix that should land in 1.9.3, please nominate it this

docs still getting built in xorg-server despite --disable-specs --disable-devel-docs --disable-docs

2010-11-05 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com --- doc/xml/dtrace/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/xml/dtrace/Makefile.am b/doc/xml/dtrace/Makefile.am index 0e25e5d..a941563 100644 --- a/doc/xml/dtrace/Makefile.am +++ b/doc/xml

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-11-01 Thread Jeremy Huddleston
I still haven't seen any measurements showing any benefits from making this change. Are there any? I think Michael is asking a very good question here. The strict aliasing rules introduced in C99 have always been somewhat controversial. They get in the way for lots of low-level

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-11-01 Thread Jeremy Huddleston
On Nov 1, 2010, at 05:48, Gaetan Nadon wrote: On Mon, 2010-11-01 at 11:32 +0100, Mark Kettenis wrote: I may be somewhat overcautious, but I would keep -fno-strict-aliasing as a default. And I'd only enable -fstrict-aliasing for particular bits of code where it has a significant

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-11-01 Thread Jeremy Huddleston
On Nov 1, 2010, at 13:18, Gaetan Nadon wrote: On Mon, 2010-11-01 at 12:33 -0700, Jeremy Huddleston wrote: On Nov 1, 2010, at 05:48, Gaetan Nadon wrote: On Mon, 2010-11-01 at 11:32 +0100, Mark Kettenis wrote: I may be somewhat overcautious, but I would keep -fno-strict-aliasing

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-11-01 Thread Jeremy Huddleston
On Nov 1, 2010, at 14:46, Gaetan Nadon wrote: Sorry, I got confused. I forgot -O brings strict aliasing by default. We need one new variable for real warnings and one variable for -fno-strict-aliasing. Modules would typically use the new real warnings variable and some would pick the new

Re: pkg-config mysticism regarding Requires.private

2010-10-31 Thread Jeremy Huddleston
Why was the change to remove xmu from xaw7.pc not also done for xaw6.pc? On Oct 30, 2010, at 16:20, Jeremy Huddleston wrote: $ PKG_CONFIG_PATH=/opt/local/lib/pkgconfig /opt/local/bin/pkg-config xft --libs -L/opt/local/lib -lXft -lXrender -lfontconfig -lexpat -liconv -lfreetype -lz -lX11 -lxcb

Re: [PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

2010-10-31 Thread Jeremy Huddleston
On Oct 31, 2010, at 08:55, Gaetan Nadon wrote: On Sat, 2010-10-30 at 15:02 -0700, Jeremy Huddleston wrote: diff --git a/configure.ac b/configure.ac index e8f9473..01c5196 100644 --- a/configure.ac +++ b/configure.ac @@ -83,6 +83,12 @@ AC_PROG_SED # easier overrides at build time

File collission for bitmaps

2010-10-31 Thread Jeremy Huddleston
app/bitmap and data/bitmaps both contain a file named stipple that collide on case-insensitive file systems. We're just not shipping the one from the app. Is there a better way around this? Should we move the bitmaps from app/bitmap into data/bitmaps and maybe rename stipple to stipple2 ?

Re: [PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

2010-10-31 Thread Jeremy Huddleston
On Oct 31, 2010, at 13:07, Gaetan Nadon wrote: On Sun, 2010-10-31 at 11:29 -0700, Jeremy Huddleston wrote: Right, but the problem is that my util-macros contain a patchset from February that never got committed (and I never noticed they didn't get committed because I was still using your

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-10-31 Thread Jeremy Huddleston
it to the modules listed in the email below (as well as the xf86-* drivers that historically had the flag which I didn't check at the time of the first email... I know intel needs it) On Feb 2, 2010, at 14:44, Jeremy Huddleston wrote: Instead, we warn where this optimization might cause a problem

Re: [PATCH:xbiff] Convert checks for mailbox directory from ifdefs to autoconf tests

2010-10-31 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 31, 2010, at 13:45, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- MailboxP.h | 18 +++--- configure.ac | 36 2 files changed, 39 insertions

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-10-31 Thread Jeremy Huddleston
On Oct 31, 2010, at 18:39, Gaetan Nadon wrote: On Sun, 2010-10-31 at 15:54 -0700, Jeremy Huddleston wrote: Resurrecting this thread as I just realized it was never actually fixed. I propose we actually follow up on these changes. We should remove -fno-strict-aliasing from

Re: X under valgrind?

2010-10-30 Thread Jeremy Huddleston
Nix, have you made any progress on this issue? My guess is that we're running into a reference count issue. This has apparently been an issue for quite some time, but it had been benign. We commented out and eventually removed logging of the fixed reference count, but I don't think the

[PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

2010-10-30 Thread Jeremy Huddleston
This should address https://bugs.freedesktop.org/show_bug.cgi?id=31238 in the short term, although I'd much rather see a fix for: https://bugs.freedesktop.org/show_bug.cgi?id=22939 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac |6 ++ 1 files changed, 6

pkg-config mysticism regarding Requires.private

2010-10-30 Thread Jeremy Huddleston
$ PKG_CONFIG_PATH=/opt/local/lib/pkgconfig /opt/local/bin/pkg-config xft --libs -L/opt/local/lib -lXft -lXrender -lfontconfig -lexpat -liconv -lfreetype -lz -lX11 -lxcb -lXau -lXdmcp $ PKG_CONFIG_PATH=/opt/local/lib/pkgconfig /usr/local/bin/pkg-config xft --libs -L/opt/local/lib -lXft $

Re: [ANNOUNCE] libXcomposite 0.4.3

2010-10-28 Thread Jeremy Huddleston
It looks like libXcomposite doesn't have a --disable-docs, --disable-specs, nor --disable-docs-devel, but it does have --without-fop ... Is there a reason why the docs/specs/docs-devel option is missing even though fop is there? I was under the impression that the tool options were extra

Re: [ANNOUNCE] libXcomposite 0.4.3

2010-10-28 Thread Jeremy Huddleston
On Oct 28, 2010, at 10:23, Gaetan Nadon wrote: On Wed, 2010-10-27 at 23:27 -0700, Jeremy Huddleston wrote: It looks like libXcomposite doesn't have a --disable-docs, --disable-specs, nor --disable-docs-devel, but it does have --without-fop ... I don't see a --without-fop configuration

xorg-server-1.9.2 plans

2010-10-25 Thread Jeremy Huddleston
So xorg-server-1.9.1 went out fairly smoothly and will probably be the version tied to the Katamari release. My current plan is to release rc1 on 11/12, rc2 on 12/3, and rc3 or final on 12/10. I'd like to continue with the same type and quality of fixes for 1.9.2, so please email me

Re: [PATCH] KDrive: Fix error handlig in tslib driver

2010-10-25 Thread Jeremy Huddleston
This looks mostly fine, but you're no longer validating private-fd ... you need a: if(private-fd 0) return BadAlloc; On Oct 17, 2010, at 14:02, Paulius Zaleckas wrote: If ts_open() fails and return NULL, then next call to ts_fd() segfaults because of NULL dereference. There is no need

Re: [PATCH] fb: Remove fbcmap.c (bug 5436)

2010-10-25 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 15, 2010, at 15:08, Jesse Adkins wrote: This is obsolete since a240c039c47c0be22ea5e100692307b26d938747. Updated fb.h to mention that the functions come from fbcmap_mi.c now. Dropped fbcmap.c from the makefile. Signed-off-by: Jesse

Re: X under valgrind?

2010-10-21 Thread Jeremy Huddleston
On Oct 21, 2010, at 09:13, walter harms wrote: can you see what is freed ? perhaps you can grep the code to see if that is used somewhere else, then setting the variable there to NULL. If this is not happening with X 1.9.0. 901 the most easy way is to use git-biset. Based on similar

Re: X under valgrind?

2010-10-20 Thread Jeremy Huddleston
I have a bunch of reports of this on version 1.4.2-apple53 as well (which cherry picked changes to support the new libXfont), so it probably reduces down to something in those change which were cherry picked. That's not much help, but it looks like it probably landed in late 2008 or early

Re: [PATCH] xfree86: fix VbeModeInfoBlock memcpy off-by-one (#30159)

2010-10-13 Thread Jeremy Huddleston
This patch seems to have wandered into the void... what is its state? On Sep 30, 2010, at 14:47, Rémi Cardona wrote: Le 28/09/2010 17:16, Adam Jackson a écrit : It's correct but it's exactly as ridiculous as the original. How's this instead: ♥ ! Although... ---

[PATCH resent] test: Fix make distcheck when not building unit tests

2010-10-13 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com --- test/Makefile.am |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/test/Makefile.am b/test/Makefile.am index 7c44671..456221e 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -33,10 +33,9

Re: [PATCH] xfree86: fix VbeModeInfoBlock memcpy off-by-one (#30159)

2010-10-13 Thread Jeremy Huddleston
Ah there it is. It was hiding from me =). On Oct 13, 2010, at 16:40, Keith Packard wrote: On Wed, 13 Oct 2010 16:20:58 -0700, Jeremy Huddleston jerem...@apple.com wrote: This patch seems to have wandered into the void... what is its state? It's on master

<    5   6   7   8   9   10   11   12   13   >