Re: FOSDEM15: Graphics DevRoom: call for speakers.

2014-12-11 Thread Jesse Barnes
left their abstracts open, please get those filed in ASAP. Your talk will be only be ordered in when at least the basics are provided. Hey Luc, thanks for the reminder. I just submitted a talk myself; hopefully there's still room on the schedule! :) -- Jesse Barnes, Intel Open Source

Re: FOSDEM2013: DevRoom or not?

2012-09-29 Thread Jesse Barnes
could come up with something, maybe people would be interested in hearing about some of our recent SoC work? I'd have to see what I could get approval for, but I could probably find *something* that's not still secret. :) -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH] dri2: Pass AsyncSwap [swap_interval=0] requests to the drivers

2012-02-23 Thread Jesse Barnes
for the intervening 12 months since v1. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org Cc: Kristian Høgsberg k...@bitplanet.net Cc: Ville Syrjälä ville.syrj...@nokia.com Cc: Dave Airlie airl...@redhat.com Cc: Michel Dänzer mic...@daenzer.net Cc

Re: [PATCH 05/11] glx: Optionally call DRI2 createContextAttribs from __glXDRIscreenCreateContext

2012-01-04 Thread Jesse Barnes
branches that could be pulled out for clarity. Looking forward to the next release though! -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 09/11] glx: Use one function to add a context to all global tables

2012-01-04 Thread Jesse Barnes
On Tue, 03 Jan 2012 17:00:32 -0800 Ian Romanick i...@freedesktop.org wrote: On 01/03/2012 04:28 PM, Jesse Barnes wrote: On Fri, 23 Dec 2011 15:18:27 -0800 Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com Instead of having separate

Re: [PATCH 02/11] glx: Don't track GLClientmajorVersion or GLClientminorVersion

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:20 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Nothing uses these fields anywhere in the server. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- Looks fine. Reviewed-by: Jesse Barnes jbar

Re: [PATCH 03/11] glx: Extend __GLXscreen::createContext to take attributes

2012-01-03 Thread Jesse Barnes
. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 05/11] glx: Optionally call DRI2 createContextAttribs from __glXDRIscreenCreateContext

2012-01-03 Thread Jesse Barnes
up a little and save an #ifdef in the middle of a function (always a nice thing). Or just require updated DRI2 bits to build and avoid the ifdefs altogether, since they tend to cause trouble anyway. -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH 07/11] glx: Initialize all context fields together

2012-01-03 Thread Jesse Barnes
a reasonable cleanup. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH 08/11] glx: Initialize remaining context fields

2012-01-03 Thread Jesse Barnes
-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 09/11] glx: Use one function to add a context to all global tables

2012-01-03 Thread Jesse Barnes
__glXErrorCallBack(GLenum code); extern void __glXClearErrorOccured(void); extern GLboolean __glXErrorOccured(void); Seems ok, but should you update the corresponding DMX code too? -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel

[PATCH] crtc: match full preferred modes if possible when choosing an initial config

2011-10-13 Thread Jesse Barnes
It's fairly common to have multiple, identical monitors plugged in. In that case, it's preferable to run the monitor's preferred mode on each output, rather than just matching the width height and end up with different timings or refresh rates. Signed-off-by: Jesse Barnes jbar

Xserver driver merging pros cons

2011-09-15 Thread Jesse Barnes
At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the pros cons of such a change. So I'd like to capture that here (from memory) to let us continue the discussion about

Re: [git pull] DRI2 GLX swap event fixes

2011-06-30 Thread Jesse Barnes
On Wed, 29 Jun 2011 20:12:20 -0700 Keith Packard kei...@keithp.com wrote: On Wed, 29 Jun 2011 11:01:22 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Jesse Barnes (2): GLX/DRI2: pass drawable correctly for indirect swap events DRI2/GLX: use new swap event types

[ANNOUNCE] dri2proto 2.6

2011-06-29 Thread Jesse Barnes
Chad Versace (1): Add attachment token DRI2BufferHiz Jesse Barnes (2): Revert dri2proto: make DRI2 swap event match GLX spec dri2proto: add a new DRI2BufferSwapComplete struct that matches the spec git tag: dri2proto-2.6 http://xorg.freedesktop.org/archive/individual/proto

[git pull] DRI2 GLX swap event fixes

2011-06-29 Thread Jesse Barnes
packages with the new event structs are released, you can pull these changes in to use them and fix the swap count field when swap events are generated. Jesse Barnes (2): GLX/DRI2: pass drawable correctly for indirect swap events DRI2/GLX: use new swap event types configure.ac

Re: [git pull] DRI2 GLX swap event fixes

2011-06-29 Thread Jesse Barnes
On Wed, 29 Jun 2011 11:01:22 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: The following changes since commit 9d568450b1319e9057319ebb37e76003bcba447d: Create sdksyms.dep in the right place at configure time (2011-06-28 09:33:25 -0700) are available in the git repository

Re: [PATCH] dri2: Pass AsyncSwap [vblank_mode=0] requests to the drivers

2011-06-08 Thread Jesse Barnes
vsync'ed since the drivers cannot distinguish it from a regular CopyRegion request. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org Cc: Kristian Høgsberg k...@bitplanet.net --- Sigh... I broke the patch with a last minute name change. Please

Re: [PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

2011-05-19 Thread Jesse Barnes
On Tue, 10 May 2011 17:57:52 -0700 Eric Anholt e...@anholt.net wrote: On Tue, 10 May 2011 12:32:24 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 10 May 2011 11:59:56 -0700 Eric Anholt e...@anholt.net wrote: On Thu, 5 May 2011 12:39:57 -0700, Jesse Barnes jbar

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-10 Thread Jesse Barnes
On Tue, 10 May 2011 10:46:17 +0200 Michel Dänzer mic...@daenzer.net wrote: On Fre, 2011-05-06 at 14:01 -0700, Jesse Barnes wrote: On Fri, 6 May 2011 13:00:19 -0700 Jeremy Huddleston jerem...@apple.com wrote: Yeah, that looks about right. This in combination with the latest

Re: [PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

2011-05-10 Thread Jesse Barnes
On Tue, 10 May 2011 11:59:56 -0700 Eric Anholt e...@anholt.net wrote: On Thu, 5 May 2011 12:39:57 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Just add a new struct to remain compatible with existing code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git

Call for desktop/graphics/mobile tracks for Linux Plumbers' Conf 2011

2011-05-09 Thread Jesse Barnes
it soon. Early registration for LPC is open until June 1st, so regardless of whether you're submitting a topic, if you see discussions or proposed talks of interest to you, be sure to register soon to get the discounted rate. Thanks, Jesse Barnes LPC2011 Planning Chair

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jesse Barnes
On Fri, 06 May 2011 09:25:35 +0200 Michel Dänzer mic...@daenzer.net wrote: On Don, 2011-05-05 at 14:02 -0700, Jesse Barnes wrote: if (swap_complete) { if (pPriv-swap_count 0x) ErrorF(something appropriate); swap_complete(client, swap_data

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jesse Barnes
On Fri, 06 May 2011 09:25:35 +0200 Michel Dänzer mic...@daenzer.net wrote: On Don, 2011-05-05 at 14:02 -0700, Jesse Barnes wrote: if (swap_complete) { if (pPriv-swap_count 0x) ErrorF(something appropriate); swap_complete(client, swap_data

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jesse Barnes
change a little as I add a glx_drawable type and move the counters there (mainly this logic will be duplicated for the indirect case). Patch on its way soon now that I've scaled back the effort from rewriting the whole object model to just tracking a glx drawable... -- Jesse Barnes, Intel Open Source

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jesse Barnes
GLX drawable type? -- Jesse Barnes, Intel Open Source Technology Center From fae63609dd4fd20ccd84d2211787136bb9a1da05 Mon Sep 17 00:00:00 2001 From: Jesse Barnes jbar...@virtuousgeek.org Date: Fri, 6 May 2011 10:31:24 -0700 Subject: [PATCH] GLX/DRI2: handle swap event swap count wrapping Create

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jesse Barnes
. Thanks Jeremy. This turd is pretty polished at this point. Anyone else besides me care to test? There's a glx-swap-event test in piglit, and Mario may have some stuff... curious to see how well it stands up. Thanks, -- Jesse Barnes, Intel Open Source Technology Center

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Jesse Barnes
On Wed, 4 May 2011 21:29:23 -0700 Jeremy Huddleston jerem...@freedesktop.org wrote: Yeah... so considering the comments in mesa-dev earlier today, I was really surprised to see that glproto and dri2proto were tagged today. I think we need to brownbag retract and rethink this. Damnit; right

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Jesse Barnes
, but at least the symptoms and the working workaround suggested fullscreen drawables do share their back buffers when page flipping is on. Is this workaround needed on the Intel driver too? Or is this just a driver bo name tracking bug? Thanks, -- Jesse Barnes, Intel Open Source Technology

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Jesse Barnes
On Thu, 5 May 2011 10:07:24 -0700 Jeremy Huddleston jerem...@freedesktop.org wrote: Why is sbc a 32bit field in xGLXBufferSwapComplete2 and xDRI2BufferSwapComplete2 when it is a 64bit field in GLXBufferSwapComplete? The hunk at the bottom will result in casting a 64bit int to a 32bit int.

Compatible GLX swap event fixes

2011-05-05 Thread Jesse Barnes
. And new clients with new servers will see correct SBC values (yay). I won't push until I get at least a couple of reviewed-by and at least one tested-by from people. Thanks, -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org

[PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

2011-05-05 Thread Jesse Barnes
Just add a new struct to remain compatible with existing code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/configure.ac b/configure.ac index a3047e4..a6c301c 100644 --- a/configure.ac +++ b/configure.ac @@ -1,5 +1,5 @@ AC_PREREQ([2.60]) -AC_INIT([GLProto], [1.4.13

[PATCH] mesa/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
Use the new swap event type so we get valid SBC values. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/configure.ac b/configure.ac index 54d9c29..fb38a4e 100644 --- a/configure.ac +++ b/configure.ac @@ -21,8 +21,8 @@ dnl Versions for external dependencies LIBDRM_REQUIRED

Re: Compatible GLX swap event fixes

2011-05-05 Thread Jesse Barnes
On Thu, 5 May 2011 12:38:24 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: This set is compatible with existing code bases since it adds a new struct to the glx and dri2 proto files instead of renaming existing fields. New clients with old servers will see larger, but still broken, SBC

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
places that actually preserve the full 64 bits. I could add an explicit cast in the few places where we pass it to the swap completion though if you think that's better... -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
transmitting 32 bits... -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
events have a 32 bit sbc and OML uses 64 bit counts. I'll add the warning though; if it becomes a real issue we can potentially add another round trip to get the value using OML instead. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg

Re: [Mesa-dev] Compatible GLX swap event fixes

2011-05-05 Thread Jesse Barnes
On Thu, 05 May 2011 14:15:33 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/05/2011 12:38 PM, Jesse Barnes wrote: This set is compatible with existing code bases since it adds a new struct to the glx and dri2 proto files instead

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Wed, 04 May 2011 15:17:31 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 12:21 PM, Jesse Barnes wrote: We only spec a 32 bit swap count, so drop the high sbc field. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Wed, 4 May 2011 16:16:37 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 04 May 2011 15:17:31 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 12:21 PM, Jesse Barnes wrote: We only spec a 32 bit swap count, so

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Thu, 05 May 2011 09:32:46 +1000 Dave Airlie airl...@redhat.com wrote: On Wed, 2011-05-04 at 16:16 -0700, Jesse Barnes wrote: On Wed, 04 May 2011 15:17:31 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 12:21 PM

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Wed, 4 May 2011 17:49:37 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: How about you look at git and see what happened last time? We added some dri2 proto requests, and people wanted to build with old versions w/o the new requests. So they added some ifdefs but didn't check all

Re: [Mesa-dev] glproto changes

2011-05-04 Thread Jesse Barnes
. But in this case adding a separate struct is probably the right thing to do, and I'd be happy to do it if people are willing to put up with the churn (glproto 1.4.14, dri2proto 2.5 plus changes to Mesa and X to use the new struct). -- Jesse Barnes, Intel Open Source Technology Center

[PATCH 7/8] DRI2: support generic swap events

2011-05-03 Thread Jesse Barnes
it for the lifetime of the client. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- configure.ac |2 +- glx/glxdri2.c | 20 +++ hw/xfree86/dri2/dri2.c| 57 - hw/xfree86/dri2/dri2.h|6 hw/xfree86

Re: [RFC] swap complete event handling fixes

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 11:38:26 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 10:59 AM, Jesse Barnes wrote: Ended up moving over to generic events since the GLX type code is part of the GLX namespace and larger than 8 bits

Re: [RFC] swap complete event handling fixes

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 11:38:26 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 10:59 AM, Jesse Barnes wrote: Ended up moving over to generic events since the GLX type code is part of the GLX namespace and larger than 8 bits

Make swap event handling match the spec

2011-05-03 Thread Jesse Barnes
Ian reminded me that we changed the spec to fit within an XEvent, but we never updated the code to match. This set of patches (much simpler than the last) does just that. Wrapping support can be added to Mesa if we really want 64 bit values, but that means checking the drawable sbc and adding

[PATCH 3/4] GLX/DRI2: pass drawable correctly for indirect swap events

2011-05-03 Thread Jesse Barnes
Pass the right drawable pointer as data to the swap complete function. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- glx/glxdri2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index d979717..93c5e5b 100644 --- a/glx/glxdri2.c

[PATCH 6/6] DRI2/GLX: make swap event handling match spec

2011-05-03 Thread Jesse Barnes
We only handle a 32 bit swap count, so use the new structure definitions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- configure.ac |4 ++-- src/glx/dri2.c |2 +- src/glx/glxext.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 13:54:38 -0700 Keith Packard kei...@keithp.com wrote: On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: We only spec a 32 bit swap count, so drop the high sbc field. You're missing the explicit 16-bit padding field after 'event_type

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 3 May 2011 14:02:31 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 03 May 2011 13:54:38 -0700 Keith Packard kei...@keithp.com wrote: On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: We only spec a 32 bit swap count, so drop

Re: [PATCH] dri2proto: make DRI2 swap event match GLX spec

2011-05-03 Thread Jesse Barnes
Updated with explicit padding. -- Jesse Barnes, Intel Open Source Technology Center From 0ca3778de195a82087d0f07415a1cf8fc94f5b0a Mon Sep 17 00:00:00 2001 From: Jesse Barnes jbar...@virtuousgeek.org Date: Tue, 3 May 2011 12:14:58 -0700 Subject: [PATCH] dri2proto: make DRI2 swap event match GLX

Re: [RFC] swap event handling fixes

2011-05-02 Thread Jesse Barnes
On Sat, 30 Apr 2011 01:10:27 +0200 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: I obviously failed to count the swap event structure size after

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-04-29 Thread Jesse Barnes
On Fri, 29 Apr 2011 09:23:27 +0200 Michel Dänzer mic...@daenzer.net wrote: On Fre, 2011-04-29 at 08:52 +0200, Michel Dänzer wrote: On Don, 2011-04-28 at 13:27 -0700, Jesse Barnes wrote: @@ -1114,7 +1169,7 @@ DRI2ScreenInit(ScreenPtr pScreen, DRI2InfoPtr info) ds-ScheduleSwap = info

Re: [RFC] swap event handling fixes

2011-04-29 Thread Jesse Barnes
On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is that clients today won't receive the sbc_lo field

[PATCH] GLX/DRI2: fix swap complete handling

2011-04-28 Thread Jesse Barnes
The swap complete event wasn't being handled fully; because XEvents are only 32 bytes long, we were getting junk for the sbc_lo value. If the server supports it, unpack the new structure, otherwise just return 0 for the sbc value instead of garbage. --- configure.ac|4 ++--

[PATCH] Fix swap complete event size

2011-04-28 Thread Jesse Barnes
XEvents are limited to 32 bytes, so use some creative stuffing to fit all the bits we'd like to supply. --- configure.ac |2 +- dri2proto.h |9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 5b78d6b..9505f56 100644 ---

[RFC] swap event handling fixes

2011-04-28 Thread Jesse Barnes
I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is that clients today won't receive the sbc_lo field at all, and so will likely stuff junk into that field on the client side (or zero at

[PATCH] DRI2/GLX: fix swap event handling

2011-04-28 Thread Jesse Barnes
Use the new swap event structure packing and send it to the client if possible. This means tracking client version information when clients connect. If they don't support the new packing, they'll get the old bits and fill junk into their sbc values when they receive the event. If they do support

Re: [PATCH] Pack swap complete bits into an XEvent

2011-04-28 Thread Jesse Barnes
On Thu, 28 Apr 2011 14:33:58 -0700 Eric Anholt e...@anholt.net wrote: On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: The defintion of the swap complete event was wrong; XEvents are only 32 bytes long, and with padding the swap event was longer. So use

Re: [PATCH] glx: Use 0 rather than garbage for unknown INTEL_swap_event types

2011-04-14 Thread Jesse Barnes
catch. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: internal screen concept

2011-03-22 Thread Jesse Barnes
no matter what. Maybe you should just punt and support it under Wayland only. :) What does this look like from the app side? How does a given app end up running on the offload GPU? Is there a GLX or EGL extension that adds bits to the config for choosing? Or a separate X display? -- Jesse Barnes

Re: Swap limit

2010-12-10 Thread Jesse Barnes
option to allow blits to happen immediately when swap_interval = 0 both with and without tear avoidance. I think Pauli's followup covers this (tearing swap limit 0 vs tear free swap limit 0). -- Jesse Barnes, Intel Open Source Technology Center ___ xorg

Re: libpciaccess bogus bridge data - commit 2bda5b73

2010-12-06 Thread Jesse Barnes
still be a bridge above the device regardless, even if it's just a host bridge I think, so we should figure out why that's not getting set... -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PULL] DRI2 fixes and extensions

2010-12-06 Thread Jesse Barnes
obviously wrong. I think I looked at all of them and replied with reviewed-by lines; the only one I wanted extra eyes on was the one dealing with buffer lifetimes; that code has changed a bit and I think Kristian understands it best. -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH v2 5/5] DRI2: Allow DDX to validate swap_limit changes

2010-11-12 Thread Jesse Barnes
On Fri, 12 Nov 2010 10:03:22 +0200 Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: On 11/11/10 18:46 +0100, ext Jesse Barnes wrote: On Mon, 1 Nov 2010 16:22:01 +0200 Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: DDX can now implement validation for swap_limit changes

Re: [PATCH v2 4/5] DRI2: Expose API to set drawable swap limit.

2010-11-11 Thread Jesse Barnes
*swap_target, Yeah, looks ok to me. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH v2 5/5] DRI2: Allow DDX to validate swap_limit changes

2010-11-11 Thread Jesse Barnes
. Other than that, Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH 2/2] DRI2: Add error message when working around driver bug

2010-10-28 Thread Jesse Barnes
, and have corresponding MSCs. Old applications using SGI_video_sync or existing OML behavior would work like they do today (with an MSC value that may jump, which we could fix with the virtualize count), and new ones would be pipe aware. -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH 2/2] DRI2: Add error message when working around driver bug

2010-10-26 Thread Jesse Barnes
On Tue, 26 Oct 2010 11:39:11 +0300 Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: On 26/10/10 03:00 +0200, ext Mario Kleiner wrote: On Oct 25, 2010, at 6:52 PM, Jesse Barnes wrote: On Mon, 25 Oct 2010 17:13:58 +0300 Pauli Nieminen ext-pauli.niemi...@nokia.com wrote

Re: [PATCH 2/2] DRI2: Add error message when working around driver bug

2010-10-26 Thread Jesse Barnes
for all your work on this. These are good improvements. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] DRI2: Add ReuseBufferNotify hook

2010-10-25 Thread Jesse Barnes
On Mon, 25 Oct 2010 17:13:56 +0300 Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: +if (info-version = 6) { + ds-ReuseBufferNotify = info-ReuseBufferNotify; +} Looks ok to me aside from the extra parens. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes

Re: [PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-25 Thread Jesse Barnes
pPriv-last_swap_target) + pPriv-last_swap_target = current_msc; + + } /* * Swap target for this swap is last swap target + swap interval since Yeah, that's fine. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source

Re: [PATCH 2/2] DRI2: Add error message when working around driver bug

2010-10-25 Thread Jesse Barnes
positives (no question that the specs could use some additions here though). Making it a debug message that only shows up with -verbose would be fine though. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-25 Thread Jesse Barnes
by the drawable handling code too many times... I think Kristian touched it last, hopefully he can review. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: Application calling DRI2SwapBuffers twice without updating buffers

2010-09-13 Thread Jesse Barnes
in this case at the very least. Maybe if we try to swap again with the same dri2 invalidate stamp we could print an error. Kristian? Jesse -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http

[PATCH] composite: only update window contents when using automatic redirection

2010-09-07 Thread Jesse Barnes
...@tarricone.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/composite/compwindow.c b/composite/compwindow.c index 160b764..c17d998 100644 --- a/composite/compwindow.c +++ b/composite/compwindow.c @@ -713,7 +713,7 @@ compWindowUpdate (WindowPtr pWin) for (pChild = pWin-lastChild

Re: xf86-video-intel: configure.ac

2010-07-27 Thread Jesse Barnes
On Tue, 27 Jul 2010 15:41:35 +0200 Julien Cristau jcris...@debian.org wrote: On Mon, Jul 26, 2010 at 16:44:47 -0700, Jesse Barnes wrote: configure.ac |2 ++ 1 file changed, 2 insertions(+) New commits: commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3 Author: Jesse Barnes jbar

Re: xf86-video-intel: configure.ac

2010-07-27 Thread Jesse Barnes
haven't tried building against a 1.6 server for a long time, if we need changes to support that I can make them as well. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [Intel-gfx] xf86-video-intel: configure.ac

2010-07-27 Thread Jesse Barnes
On Tue, 27 Jul 2010 17:00:28 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote: On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote: Apparently MeeGo does automatic packaging based on configure.ac, so Arjan

Re: [Intel-gfx] xf86-video-intel: configure.ac

2010-07-27 Thread Jesse Barnes
On Tue, 27 Jul 2010 17:39:11 +0100 Daniel Stone dan...@fooishbar.org wrote: On Tue, Jul 27, 2010 at 09:34:01AM -0700, Jesse Barnes wrote: On Tue, 27 Jul 2010 17:00:28 +0100 Daniel Stone dan...@fooishbar.org wrote: On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote: On Tue

Re: [RFC] dri2: Expose API for drivers to set drawable swap limit.

2010-07-14 Thread Jesse Barnes
to work on it... To make things fast, you'll need some extra buffers allocated in the DRI2 drawable, and you'll need to switch between them at swapbuffers time, along with upping the swap_limit. -- Jesse Barnes, Intel Open Source Technology Center diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2

Re: glXSwapBuffers fix for moving between crtcs is not following the OML_sync_control specification

2010-07-09 Thread Jesse Barnes
where we need a Mesa extension to specify specific behavior... -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-09 Thread Jesse Barnes
On Fri, 09 Jul 2010 10:11:35 +0200 Michel Dänzer mic...@daenzer.net wrote: On Don, 2010-07-08 at 14:55 -0700, Jesse Barnes wrote: On Thu, 08 Jul 2010 14:19:23 -0700 Keith Packard kei...@keithp.com wrote: On Thu, 8 Jul 2010 14:06:01 -0700, Jesse Barnes jbar...@virtuousgeek.org

[PATCH 1/2] miModifyPixmapHeader: always update serialNumber

2010-07-09 Thread Jesse Barnes
We should update the serial number even if we just change a single field. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- mi/miscrinit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mi/miscrinit.c b/mi/miscrinit.c

[PATCH 2/2] DRI2: re-allocate DRI2 drawable if pixmap serial changes

2010-07-09 Thread Jesse Barnes
://bugs.freedesktop.org/show_bug.cgi?id=28365. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- hw/xfree86/dri2/dri2.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-07-08 Thread Jesse Barnes
: dix.h:extern _X_EXPORT ClientPtr clients[MAXCLIENTS]; That's just an array of pointers. D'oh, you're right. Never mind, then. Just pushed a fix into the 1.8 branch. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel

[PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-08 Thread Jesse Barnes
in the DRI2 screen struct, re-allocating DRI2 buffers as needed when the changes occur. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index f9ba8e7..a12542b 100644 --- a/hw/xfree86/dri2/dri2.c +++ b/hw/xfree86/dri2/dri2.c @@ -82,6 +82,7

Re: [PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-08 Thread Jesse Barnes
On Thu, 8 Jul 2010 11:39:01 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: If the root window changes size, we need to re-allocate any DRI2 buffers that share the same pixmap so that they'll pick up the new root pixmap (if the underlying driver ended up creating a new one). So make sure

Re: [PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-08 Thread Jesse Barnes
On Thu, 08 Jul 2010 12:26:22 -0700 Keith Packard kei...@keithp.com wrote: On Thu, 8 Jul 2010 11:39:01 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: If the root window changes size, we need to re-allocate any DRI2 buffers that share the same pixmap so that they'll pick up the new

Re: [PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-08 Thread Jesse Barnes
Ok, back to tracking serials then. Unfortunately, using the pixmap serial for windows doesn't actually fix this bug. See below, maybe something is wrong with my DRI2DrawableSerial function. Using the drawable serial unconditionally lets things work (just like the old patch). -- Jesse Barnes

Re: [PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-08 Thread Jesse Barnes
On Thu, 08 Jul 2010 14:19:23 -0700 Keith Packard kei...@keithp.com wrote: On Thu, 8 Jul 2010 14:06:01 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Ok, back to tracking serials then. Unfortunately, using the pixmap serial for windows doesn't actually fix this bug. See below

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-07-07 Thread Jesse Barnes
On Wed, 7 Jul 2010 15:54:50 -0700 Aaron Plattner aplatt...@nvidia.com wrote: On Fri, Jul 02, 2010 at 09:33:54AM -0700, Jesse Barnes wrote: On Fri, 2 Jul 2010 10:45:52 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Jun 30, 2010 at 10:55:52AM -0700, Jesse Barnes wrote

Re: [PATCH] DRI2: track drawable serial numbers

2010-07-03 Thread Jesse Barnes
On Fri, 02 Jul 2010 23:54:26 -0400 Keith Packard kei...@keithp.com wrote: On Fri, 2 Jul 2010 12:26:34 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: If a pixmap header is modified or the drawable serial changes, some aspects of the drawable are likely to have changed so we should

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-07-02 Thread Jesse Barnes
On Fri, 2 Jul 2010 10:45:52 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Jun 30, 2010 at 10:55:52AM -0700, Jesse Barnes wrote: This looks good to me. I assume the client is allocated with calloc so that the count starts out at zero? Reviewed-by: Keith Packard kei

[PATCH] DRI2: track drawable serial numbers

2010-07-02 Thread Jesse Barnes
://bugs.freedesktop.org/show_bug.cgi?id=28365. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index f9ba8e7..e1238a5 100644 --- a/hw/xfree86/dri2/dri2.c +++ b/hw/xfree86/dri2/dri2.c @@ -82,6 +82,7 @@ typedef struct _DRI2Drawable { CARD64

Re: IgnoreClient question

2010-07-02 Thread Jesse Barnes
can be shared explicitly, likewise for some of the other objects, so you should be able to get the sharing you want. -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

2010-06-30 Thread Jesse Barnes
branch as well? commit 28e33ae6f69f716ece5d68e63fc52557236c5f6e Author: Jesse Barnes jbar...@virtuousgeek.org Date: Wed Jun 30 07:59:04 2010 -0700 OS support: fix writeable client vs IgnoreClient behavior Thanks, -- Jesse Barnes, Intel Open Source Technology Center

IgnoreClient question

2010-06-28 Thread Jesse Barnes
it is the wrong thing to do... Thanks, -- Jesse Barnes, Intel Open Source Technology Center ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/2] DRI2: keep clients suspended across VT switch

2010-06-28 Thread Jesse Barnes
DRI2 overrides the GLX suspend/resume client code, potentially waking clients while the server is VT switched away. Fix this up by making sure we don't AttendClient after GLX has suspended our clients. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- glx/glxdri2.c |4

  1   2   >