On Mon, Jan 24, 2022 at 03:53:23PM -0800, Alan Coopersmith wrote:
> On 1/23/22 21:18, Peter Hutterer wrote:
> > xf86-input-libinput 1.2.1 is now available. Primarily a few typos and misc
> > minor fixes, the most visible change to distributions is that we now ship an
> > xz tarball instead of bz2.
On Fri, Feb 22, 2019 at 13:28:34 +, Daniel Stone wrote:
> Hi Thomas,
>
> On Fri, 22 Feb 2019 at 13:18, Thomas Hellstrom wrote:
> > I was trying to add Deepak Rawat as a member on the xf86-video-vmware
> > project on fdo gitlab. Turns out I have only developer privileges
> > there. Could some
On 10/02/2018 03:10 PM, Alexander Volkov wrote:
> From: Alexander Volkov
>
> This allows applications to respond to changes of power level
> of a monitor, e.g. an application may stop rendering and related
> calculations when the monitor is off.
>
> Bump DPMS version to 1.2.
>
> Signed-off-by:
+xcb@
On 08/09/2018 12:20 AM, Erik Kurzinger wrote:
> If any flags are specified in a call to xcb_take_socket,
> they should only be applied to replies for requests sent
> after that function returns (and until the socket is
> re-acquired by XCB).
>
> Previously, they would also be incorrectly ap
On Sat, May 5, 2018 at 12:33:12 -0700, Alan Coopersmith wrote:
> Introduced by commit 5222d28e8d8e5b4cc
>
> Reported by gcc 7.3:
>
> auth.c: In function ‘SaveServerAuthorizations’:
> auth.c:447:6: warning: this ‘if’ clause does not guard...
> [-Wmisleading-indentation]
> if (auths[i]->da
__libdir__ doesn't seem to actually be used anywhere in the man page,
but...
Signed-off-by: Julien Cristau
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 8c1faf8..a58faca 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -
On Mon, Mar 19, 2018 at 16:04:43 +, Emil Velikov wrote:
> From: Emil Velikov
>
> As per the protocol, the server should not return version greater than
> the one supported by the client.
>
> Add a spec quote and tweak the numbers accordingly.
>
> Fixes: 5c5c1b77982 ("present: Add Present e
I think this belongs on xcb@.
Cheers,
Julien
On Mon, Mar 12, 2018 at 12:03:19 -0700, Keith Packard wrote:
> This was set to BOOL, but the protocol headers used Bool, presumably a
> 32-bit type. We're switching everything to CARD32 as the best option
> for compatibility.
>
> Signed-off-by: Keith
On Tue, Oct 24, 2017 at 14:38:12 -0400, Adam Jackson wrote:
> Just no.
>
> Signed-off-by: Adam Jackson
> ---
> include/dixstruct.h | 2 --
> 1 file changed, 2 deletions(-)
>
for the series:
Reviewed-by: Julien Cristau
Cheers,
Julien
_
ned-off-by: Adam Jackson
Yes please.
Acked-by: Julien Cristau
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Anyone? This still looks wrong to me.
Cheers,
Julien
On Sat, Jan 7, 2017 at 18:46:57 +0100, Julien Cristau wrote:
> On Sun, Sep 25, 2016 at 22:50:45 +0200, Matthieu Herrb wrote:
>
> > From: Tobias Stoeckmann
> >
> > The memory for filter names is reserved right a
On Fri, Jul 7, 2017 at 22:41:06 +0200, Jan Beich wrote:
> Julien Cristau writes:
>
> > On Fri, Jul 7, 2017 at 16:31:48 +0200, Jan Beich wrote:
> >> - flags = fcntl(fd, F_GETFD);
> >> +#ifndef HAVE_MKOSTEMP
> >> + int flags = fcntl(fd, F_GETFD);
>
On Fri, Jul 7, 2017 at 16:31:48 +0200, Jan Beich wrote:
>
> Signed-off-by: Jan Beich
> ---
> Xext/shm.c | 9 +++--
> configure.ac| 2 +-
> include/dix-config.h.in | 3 +++
> 3 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/Xext/shm.c b/Xext/shm.c
On Fri, Jul 7, 2017 at 16:31:07 +0200, Jan Beich wrote:
> From: Jung-uk Kim
> Date: Tue, 15 Apr 2014 17:08:46 +
>
> In file included from src/xshmfence_alloc.c:27:
> In file included from src/xshmfenceint.h:32:
> src/xshmfence_futex.h:40:39: error: use of undeclared identifier 'INT_MAX'
>
> conf_data.set('_DIX_CONFIG_H_', '1')
> >
> > +
> > +
> > conf_data.set('MONOTONIC_CLOCK', cc.compiles('''
> > +#define _POSIX_C_SOURCE 200112L
> > #include
> > #include
&
gcc -std=c99 does not define the former, and it's a horrible namespace
confusion anyway.
Signed-off-by: Julien Cristau
---
hw/xfree86/common/compiler.h | 14 +++---
hw/xfree86/common/xf86Config.c | 2 +-
hw/xfree86/common/xf86Configure.c | 2 +-
hw/xf
It seems unlikely anyone still needs to build against libc4/libc5.
Signed-off-by: Julien Cristau
---
Xext/xf86bigfont.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/Xext/xf86bigfont.c b/Xext/xf86bigfont.c
index 72bb774011..529595bb75 100644
--- a/Xext/xf86bigfont.c
+++ b/Xext
On Mon, May 8, 2017 at 10:13:52 -0700, Eric Anholt wrote:
> Optional XV seems a bit silly to me. Could we just do something
> like:
>
> build_xv = build_xorg || build_dmx || build_ephyr?
FWIW the Xorg build we're shipping in debian installer images (which run
a single specific gtk2 client) hav
On Fri, May 5, 2017 at 10:08:14 +0200, Pali Rohár wrote:
> PING.
>
> I would like to know if there is some problem with this and something
> needs to be reworked or if it can be accepted.
>
> Currently xdpyinfo report bogus dimensions and resolution values and lot
> of people complain about thi
On Mon, Feb 20, 2017 at 10:24:14 -0500, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
> ---
> hw/vfb/InitOutput.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Julien Cristau
Cheers,
Julien
___
xorg-de
On 02/06/2017 03:32 PM, Antoine Martin wrote:
> Hi,
>
> I can reproduce this Xorg server crash fairly reliably using xpra and
> glxspheres simply by closing the application window:
>
> Thread 1 "Xorg" received signal SIGPIPE, Broken pipe.
> 0x757ca83d in writev () at ../sysdeps/unix/sysca
On Wed, Feb 1, 2017 at 15:02:41 +0100, arthur.huil...@free.fr wrote:
> It is legal for an application to make Xlib calls during _fini, and that is
> useful for an OpenGL driver to avoid resource leaks on the X server side, for
> example in the dlopen/dlclose case. However, the driver can not re
On Sat, Jan 7, 2017 at 19:15:42 +0100, Tobias Stoeckmann wrote:
> Hi Julien,
>
> On Sat, Jan 07, 2017 at 07:03:17PM +0100, Julien Cristau wrote:
> > It looks like we're leaking 'attr' on these error paths?
>
> confirmed. That is what I get for copying the
On Tue, Jan 24, 2017 at 01:12:23 +, James Clarke wrote:
> Hi,
> I've been debugging an issue in gtk2-perl causing it to SIGBUS on
> sparc64, and traced it back to what seems to be dodgy code inside
> libx11. One of the tests calls gdk_window_set_opacity, which calls
> XChangeProperty with a po
but for the series:
Reviewed-by: Julien Cristau
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
On Mon, Jan 23, 2017 at 14:32:33 -0500, Adam Jackson wrote:
> Hmm, this code looks wrong to me. I know! Instead of fix it, I'll put a
> comment here that nobody will look at for decades on end.
>
> Yaaay xfree86.
>
> Signed-off-by: Adam Jackson
> ---
> hw/xfree86/loader/loadmod.c | 3 +--
>
On Mon, Jan 23, 2017 at 14:32:20 -0500, Adam Jackson wrote:
> This API is dumb. uname(3) exists, feel free to use it, but ideally
> write to the interface not to the OS. There are a couple of drivers
> using this API, they could all reasonably just not.
>
It's uname(2) AFAICT :)
Cheers,
Julien
On Mon, Jan 23, 2017 at 14:32:18 -0500, Adam Jackson wrote:
> From: Emil Velikov
>
> Now that used can set the path only via LoaderSetPath(), we can simplify
> things.
>
used -> users, maybe?
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org developme
On Mon, Jan 23, 2017 at 14:32:15 -0500, Adam Jackson wrote:
> From: Emil Velikov
>
> Afaics the argument hasn't been part of the API since the documentation
> has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc
> documents to DocBook/XML"
>
The commit message seems confused. AF
On Mon, Jan 16, 2017 at 16:26:08 -0800, Alan Coopersmith wrote:
> As best I can tell, it was historically under section 1 mainly because
> the old X Consortium Imake configs only supporting installing program
> man pages there, and didn't have an option for using other sections.
>
> Signed-off-by
[resending with xorg-devel cc added which I forgot the first time around]
On Sun, Sep 25, 2016 at 22:50:44 +0200, Matthieu Herrb wrote:
> diff --git a/src/XrrCrtc.c b/src/XrrCrtc.c
> index 5ae35c5..6665092 100644
> --- a/src/XrrCrtc.c
> +++ b/src/XrrCrtc.c
[...]
> @@ -357,7 +378,7 @@ XRRGetCrtcTr
On Sun, Sep 25, 2016 at 22:50:45 +0200, Matthieu Herrb wrote:
> From: Tobias Stoeckmann
>
> The memory for filter names is reserved right after receiving the reply.
> After that, filters are iterated and each individual filter name is
> stored in that reserved memory.
>
> The individual name le
'ch' gets moved inside the allocated buffer as we're looping through
fonts, so keep a reference to the start of the buffer so we can pass
that to Xfree in the failure case.
Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak"
Signed-off-by:
elo Monfort
> Reviewed-by: Julien Cristau
> Tested-by: Thomas Walker
> ---
> src/XIQueryDevice.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
remote: Updating patchwork state for
https://patchwork.freedesktop.org/project/Xorg/list
On Wed, Oct 5, 2016 at 09:42:19 -0700, Keith Packard wrote:
> If we're never painting anything in the window, we probably don't need
> to map it.
>
> Signed-off-by: Keith Packard
> ---
> hw/kdrive/ephyr/hostx.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/k
On Sun, Sep 25, 2016 at 22:50:43 +0200, Matthieu Herrb wrote:
> From: Tobias Stoeckmann
>
> By validating length fields from server responses, out of boundary
> accesses and endless loops can be mitigated.
>
> Signed-off-by: Tobias Stoeckmann
> Reviewed-by: Matthieu Herrb
> ---
> src/XGMotio
Hi all,
Sorry I didn't get a chance to look at these before they went public...
On Sun, Sep 25, 2016 at 22:50:40 +0200, Matthieu Herrb wrote:
> From: Tobias Stoeckmann
>
> v2: FontNames.c return a NULL list whenever a single
> length field from the server is incohent.
>
> Signed-off-by: Tobi
On Fri, Sep 23, 2016 at 10:58:54 +0300, Eric Anholt wrote:
> The normal xinit is racy because it doesn't use -displayfd. This
> implements the bare minimum for testing purposes, using -displayfd to
> sequence starting the client, and avoids adding yet another dependency
> to the server.
>
> v2:
On Thu, Sep 22, 2016 at 19:12:13 +0200, Heiko Becker wrote:
> Signed-off-by: Heiko Becker
> ---
> Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 060112d..9a89bbe 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,4 +1,4
On Thu, Sep 22, 2016 at 11:45:07 +0300, Eric Anholt wrote:
> diff --git a/test/scripts/xvfb-piglit.sh b/test/scripts/run-piglit.sh
> similarity index 90%
> copy from test/scripts/xvfb-piglit.sh
> copy to test/scripts/run-piglit.sh
> index b775239e34f5..ab37ee3b92ad 100755
> --- a/test/scripts/xvfb
On Thu, Sep 22, 2016 at 11:45:06 +0300, Eric Anholt wrote:
> +asprintf(&displayfd_string, "%d", displayfd);
> +if (!displayfd_string)
> +exit(1);
I think you need to check the return value from asprintf, not
displayfd_string:
When successful, these functions return the
On Tue, Sep 20, 2016 at 01:03:33 +0100, Emil Velikov wrote:
> On 15 September 2016 at 15:12, Julien Cristau wrote:
[...]
> > For 1, 3, 4, 5, 7 (assuming 10 goes in in some way):
> > Reviewed-by: Julien Cristau
> >
> Thanks, can you push 1, 3, 4, 5 (and 7 ?). I&
on
> the topic to be an expert.
>
> As always, any and all comments, suggestions are appreciated.
>
For 1, 3, 4, 5, 7 (assuming 10 goes in in some way):
Reviewed-by: Julien Cristau
Not a fan of 2 and 6. I don't have enough context to understand what 8
changes. 9 seems to a
{xorg,dri,wayland,www}.freedesktop.org are all https now.
Signed-off-by: Julien Cristau
---
release.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/release.sh b/release.sh
index bb3f17a..6d5ac80 100755
--- a/release.sh
+++ b/release.sh
@@ -103,11 +103,11 @@ RELEASE
Signed-off-by: Julien Cristau
---
release.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/release.sh b/release.sh
index ef384de..bb3f17a 100755
--- a/release.sh
+++ b/release.sh
@@ -504,10 +504,10 @@ process_module() {
host_wayland="wayland.freedeskto
;
> Signed-off-by: Keith Packard
> ---
> config/dbus-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Julien Cristau
Cheers,
Julien
> diff --git a/config/dbus-core.c b/config/dbus-core.c
> index 3c85ad7..6d9a3f9 100644
> --- a/config
On Mon, Sep 12, 2016 at 10:53:39 -0700, Jeremy Huddleston Sequoia wrote:
>
> > On Sep 12, 2016, at 04:33, Julien Cristau wrote:
> >
> > On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote:
> >
> >> Signed-off-by: Jeremy Huddleston S
utthread.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
A possible further improvement would be to use pipe2(2) where available
to set O_CLOEXEC immediately, rather than as a separate step.
Anyway, this gets my
Reviewed-by: Julien Cristau
Cheers,
Julien
>
On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote:
> Signed-off-by: Jeremy Huddleston Sequoia
> ---
> Xext/shm.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Does anything have O_TMPFILE but not O_CLOEXEC?
Cheers,
Julien
> diff --git a/Xext/shm.c b/Xext
-by: Jeremy Huddleston Sequoia
> ---
> Xext/shm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Julien Cristau
Cheers,
Julien
> diff --git a/Xext/shm.c b/Xext/shm.c
> index 0557538..125000f 100644
> --- a/Xext/shm.c
> +++ b/Xext/shm.c
> @
ol-xiquerypointer.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Julien Cristau
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
On Tue, Jul 19, 2016 at 15:27:02 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> To allow users with multiple keys to select the appropriate one.
>
> Signed-off-by: Emil Velikov
> ---
> All the "if x$GPGKEY = x" checking looks iffy so any suggestions how to
> minimise/remove it are greatly
gt; display the actual error, rather then the -ENOENT from also trying
> /dev/vc/0.
>
> BugLink: https://patchwork.freedesktop.org/patch/8768/
> Reported-by: Chad Versace
> Suggested-by: Julien Cristau
> Signed-off-by: Hans de Goede
> ---
> hw/xfree86/os-support/linux/l
xkb/xkb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Going to the pub seems like a great plan.
Reviewed-by: Julien Cristau
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-d
On Mon, May 30, 2016 at 18:12:36 +1000, Peter Hutterer wrote:
> Pre input-thread xf86AddEnabledDevice was hooked up to the signal handler.
> libinput never was capable of running inside a signal handler, so we had to
> use AddEnabledDevice() instead which merely hooks to the server's select loop.
On Sun, May 29, 2016 at 11:35:16 -0700, Keith Packard wrote:
> Emil Velikov writes:
>
> > There's two things which I should have mentioned:
> > - How does one have poll.h when poll() is missing - Cygwin may have
> > the header, although I'm not sure about other Windows based
> > implementations
On Thu, May 12, 2016 at 14:27:48 +0100, Emil Velikov wrote:
> With previous commits we've hidden a selection of internal symbols from
> the DSO. Neither of them has been part of the API, although let's do the
> sane thing and bump the major, as we might have changed things in a
> backward incompat
On Fri, Apr 29, 2016 at 15:25:40 +, Robert Ancell wrote:
> On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote:
>
> > On Fri, 2016-04-29 at 11:11 +0200, Robert Ancell wrote:
> > > This is currently used in Ubuntu to allow X applications and sessions to
> > run in
> > > newer versions of Unity
On Fri, Apr 29, 2016 at 11:16:08 -0400, Adam Jackson wrote:
> On Fri, 2016-04-29 at 17:01 +0200, Julien Cristau wrote:
> > On Fri, Apr 29, 2016 at 10:53:22 -0400, Adam Jackson wrote:
> >
> > > gcc6 says:
> > >
> > > keyboard.c:46:21: warning: ‘linux_to
hw/kdrive/linux/keyboard.c | 441
> -
> 1 file changed, 441 deletions(-)
>
Reviewed-by: Julien Cristau
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xor
On Fri, Apr 29, 2016 at 15:54:28 +1000, Dave Airlie wrote:
> This is an ABI break, in that we now pass NULL to a function
> that hasn't accepted it before.
>
> Alex Goins had a different patch for this but it wasn't symmetrical,
> it freed something in a very different place than it allocated it,
On Thu, Apr 28, 2016 at 15:21:15 +0200, Stefan Dirsch wrote:
> From: Reinhard Max
>
> For IPv6 add a link local addresses to the end of the list passed to
> the XDMCP servers.
> Reason: for link local addresses the XDMCP server would need to either
> know the interface thru a scope identifier or
On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote:
> > From: Stefan Dirsch
> > Date: Thu, 28 Apr 2016 14:35:00 +0200
> >
> > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See
> > https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details.
>
> I think selectivel
On Thu, Apr 28, 2016 at 11:06:38 +0200, Stefan Dirsch wrote:
> On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote:
> > P.S. For xorg-devel patches please set the correct prefix $ git config
> > --local format.subjectPrefix "PATCH foo". With foo being the
> > respective project.
>
> Ok.
bmodule load.
>
> Signed-off-by: Adam Jackson
> ---
> src/alp_driver.c | 14 +-
> src/lg_driver.c | 15 +--
> 2 files changed, 2 insertions(+), 27 deletions(-)
>
Reviewed-by: Julien Cristau
for the series.
Cheers,
Julien
_
On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote:
> On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote:
> > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote:
> >
> > > From: Frederic Crozat
> > >
> > > Remove the 10x7
On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote:
> From: Frederic Crozat
>
> Remove the 10x7 heuristic, since the server has equivalent code now.
> Instead, disable "acceleration" under qemu, since taking the hypercall
> trap is really quite expensive and you're better off doing noac
y: James Clarke
> ---
> Changes since v1:
> * Added Signed-off-by
> * Added xproto component to subject prefix
>
> Xpoll.h.in | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
Reviewed-by: Julien Cristau
Cheers,
Julien
___
On Thu, Apr 21, 2016 at 15:22:36 +0200, Stefan Dirsch wrote:
> From: Egbert Eich
>
> Reenable default device when shutting down VGA arbitration.
> https://bugzilla.opensuse.org/show_bug.cgi?id=714677
> ---
> src/common_vgaarb.c | 9 +
> 1 file changed, 9 insertions(+)
>
I don't underst
On Tue, Apr 12, 2016 at 19:59:14 +0200, Carlos Alberto Lopez Perez wrote:
> * The Mesa driver uses this environment variable to override the
> default compiled search path for DRI drivers.
>
> * This is useful for testing purposes when the user needs to
> override the system default o
On Thu, Mar 10, 2016 at 13:25:03 -0500, Adam Jackson wrote:
> No functional change, just a little easier to read and harder to get
> wrong.
>
> Signed-off-by: Adam Jackson
> ---
> glx/glxcmds.c | 38 +++---
> 1 file changed, 15 insertions(+), 23 deletions(-)
>
>
by: Jonas Ådahl
> ---
> configure.ac | 3 ++-
> hw/xwayland/xwayland-shm.c | 4
> include/dix-config.h.in| 3 +++
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
Reviewed-by: Julien Cristau
Cheers,
Julien
___
xorg-dev
On Tue, Mar 8, 2016 at 18:32:27 +0800, Jonas Ådahl wrote:
> On Tue, Feb 23, 2016 at 08:54:47AM +0800, Jonas Ådahl wrote:
> > On Fri, Feb 19, 2016 at 11:53:46AM +0100, Julien Cristau wrote:
> > > On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote:
> > >
> >
On Tue, Mar 8, 2016 at 09:12:34 +0100, walter harms wrote:
>
>
> Am 07.03.2016 23:20, schrieb Julien Cristau:
> > Signed-off-by: Julien Cristau
> > ---
> > Xext/xvmc.c | 17 ++---
> > 1 file changed, 14 insertions(+), 3 deletions(-)
> >
>
AddResource will have called DrawableGone, which takes care of the
destruction.
Signed-off-by: Julien Cristau
---
glx/glxcmds.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/glx/glxcmds.c b/glx/glxcmds.c
index 0416dac..6eb3541 100644
--- a/glx/glxcmds.c
+++ b/glx
er). Plus more unchecked AddResource calls in xvmc and dri3.
Cheers,
Julien
Julien Cristau (9):
xvmc: Fix unchecked AddResource
dri3: return an error if AddResource fails
glx: don't call pGlxDraw->destroy() if AddResource fails
dmx/glxProxy: don't free the glx pixma
Signed-off-by: Julien Cristau
---
hw/dmx/glxProxy/glxcmds.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/dmx/glxProxy/glxcmds.c b/hw/dmx/glxProxy/glxcmds.c
index ddcb981..a77d556 100644
--- a/hw/dmx/glxProxy/glxcmds.c
+++ b/hw/dmx/glxProxy/glxcmds.c
@@ -2010,11
Signed-off-by: Julien Cristau
---
dri3/dri3_request.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dri3/dri3_request.c b/dri3/dri3_request.c
index 2b36221..35548b6 100644
--- a/dri3/dri3_request.c
+++ b/dri3/dri3_request.c
@@ -178,8 +178,8
Signed-off-by: Julien Cristau
---
record/record.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/record/record.c b/record/record.c
index 1caf3f1..82bb060 100644
--- a/record/record.c
+++ b/record/record.c
@@ -1878,7 +1878,6 @@ ProcRecordCreateContext(ClientPtr client)
return Success
Probably pointless, if this fails you're not likely to get far...
Signed-off-by: Julien Cristau
---
render/picture.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/render/picture.c b/render/picture.c
index 6d9c9df..9e4036e 100644
--- a/render/picture.c
+++ b/render/picture.c
@@ -
pChc is already freed through CursorFreeHideCount →
deleteCursorHideCount.
Signed-off-by: Julien Cristau
---
xfixes/cursor.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xfixes/cursor.c b/xfixes/cursor.c
index 5619aad..10f9b23 100644
--- a/xfixes/cursor.c
+++ b/xfixes
Signed-off-by: Julien Cristau
---
Xext/xvmc.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/Xext/xvmc.c b/Xext/xvmc.c
index 64eda92..7565c17 100644
--- a/Xext/xvmc.c
+++ b/Xext/xvmc.c
@@ -253,6 +253,10 @@ ProcXvMCCreateContext(ClientPtr client
This is taken care of by SecurityDeleteAuthorization
Signed-off-by: Julien Cristau
---
hw/xwin/winauth.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/hw/xwin/winauth.c b/hw/xwin/winauth.c
index 7efa1c0..7be7dca 100644
--- a/hw/xwin/winauth.c
+++ b/hw
ms_dri2_frame_event_client_gone or ms_dri2_frame_event_drawable_gone
already free the resource.
Signed-off-by: Julien Cristau
---
hw/xfree86/drivers/modesetting/dri2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/dri2.c
b/hw/xfree86
XvdiDestroyVideoNotifyList already frees the list if AddResource fails,
so don't do it twice. And set tpn->client to NULL explicitly to avoid
confusing uninitialized memory with a valid value.
Signed-off-by: Julien Cristau
---
Xext/xvmain.c | 5 ++---
1 file changed, 2 insertio
es (1/5 and 2/5):
Reviewed-by: Julien Cristau
Cheers,
Julien
> diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c
> index 875c9cc..0046e52 100644
> --- a/hw/xfree86/dri/dri.c
> +++ b/hw/xfree86/dri/dri.c
> @@ -1032,7 +1032,8 @@ DRICreateContext(Scree
On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote:
> We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever
> defined anywhere. This commit makes it so that this macro is defined if
> the posix_fallocate is detected during configure.
>
> Signed-off-by: Jonas Ådahl
Hi,
any rea
On Tue, Feb 9, 2016 at 14:23:59 +1000, Peter Hutterer wrote:
> On Mon, Feb 08, 2016 at 10:00:21PM -0200, Laércio de Sousa wrote:
> > Em 8 de fev de 2016 17:54, "Adam Jackson" escreveu:
> > > How are you in a scenario where you can pass these values to Xephyr on
> > > the command line, but can't
On Wed, Jan 13, 2016 at 19:51:55 -0500, Gaetan Nadon wrote:
> On 16-01-12 07:59 AM, Andreas Boll wrote:
> > Starting with xmlto version 0.0.27 the return code of
> > xmlto --skip-validation txt conftest.xml
> > is non-zero if conftest.xml is an empty file.
> >
[...]
> >
> > xorg-macros.m4.in |
On Fri, Jan 1, 2016 at 11:39:32 -0800, Alan Coopersmith wrote:
> Did we ever reach a conclusion on this patch? I was thinking of doing a
> libX11 release sometime early this year, and if this is ready to include,
> would pull it in.
>
> (Is http://patchwork.freedesktop.org/patch/50613/ the late
On Thu, Dec 10, 2015 at 11:42:36 -0800, Keith Packard wrote:
> Mark Kettenis writes:
>
> > Ugh. Exporting global variables as part of the ABI is generally not
> > such a good idea. Perhaps it is better to use functions to acquire
> > and release the input mutex instead?
>
> Yeah, the mutex is
On Sat, Nov 21, 2015 at 14:43:47 +0100, Olivier Fourdan wrote:
> diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c
> index ebaf05a..16d1ab9 100644
> --- a/hw/xwayland/xwayland-glamor.c
> +++ b/hw/xwayland/xwayland-glamor.c
> @@ -233,9 +233,11 @@ xwl_glamor_create_screen_re
Regression from 990cf5b2828f73dc7a07f1e38f608af39acfd81d
Signed-off-by: Julien Cristau
Cc: Andrew Eikum
Cc: Peter Hutterer
---
Xext/xace.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Xext/xace.h b/Xext/xace.h
index 3303f76..6a8d0c4 100644
--- a/Xext/xace.h
+++ b/Xext/xace.h
On Mon, Oct 19, 2015 at 11:47:09 -0400, Adam Jackson wrote:
> I don't think there's anyone currently working on 1.16 or older.
>
I'm still interested in 1.16 as that's what Debian 8 ships, but at this
point I guess it's going to be mostly CVE fixes, if anything.
Cheers,
Julien
__
When the server is privileged, we shouldn't be passing the user's
environment directly.
Clearing the environment is recommended by the libdbus maintainers, see
https://bugs.freedesktop.org/show_bug.cgi?id=52202
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83849
Signed-off-
On Mon, Oct 19, 2015 at 10:43:45 +0200, Hans de Goede wrote:
> Hi,
>
> On 18-10-15 19:26, Julien Cristau wrote:
> >When the server is privileged, we shouldn't be passing the user's
> >environment directly.
> >
> >Signed-off-by: Julien Cristau
>
>
When the server is privileged, we shouldn't be passing the user's
environment directly.
Signed-off-by: Julien Cristau
---
hw/xfree86/xorg-wrapper.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
It's possible some variables should be passed, in which case we could
On Wed, Sep 9, 2015 at 18:30:55 +0100, Emil Velikov wrote:
> In parallel to Matt's question - if we do opt for a separate library
> (libXfont2), the headers will clash with libXfont's.
>
> From a very quick look, only fontstruct.h seems to be used. If truly
> so, one can rework it (rename or fol
On Wed, Sep 2, 2015 at 00:15:06 -0700, Keith Packard wrote:
> +#ifndef _LIBXFONT_H_
> +#define _LIBXFONT_H_
Include the 2 from the filename in the guard macro's name?
Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.
Xtrans.h defines BytesReadable_t as int or long depending on whether
LONG64 is defined. We need to make sure Xmd.h is included so our idea
of BytesReadable_t is consistent across compilation units.
Debian bug#749120
Reported-by: Michael Tautschnig
Signed-off-by: Julien Cristau
---
Xtrans.h
1 - 100 of 1050 matches
Mail list logo
