libx86.
Thanks!
-Kees
On Fri, Nov 04, 2011 at 12:35:34AM +0100, Guillem Jover wrote:
> Hi!
>
> On Wed, 2011-11-02 at 14:32:01 -0700, Kees Cook wrote:
> > On Fri, Oct 07, 2011 at 02:49:03AM +0200, Guillem Jover wrote:
> > > On Thu, 2011-10-06 at 15:49:33 -0700, Alan Coopersm
ough now, so I've added
> Reviewed-by: Alan Coopersmith
> and pushed both to git master:
> To ssh://git.freedesktop.org/git/xorg/lib/libX11
>24d3ee0..feb131b master -> master
>
> -alan-
>
>
> On 07/18/13 03:52 PM, Kees Cook wrote:
> >Re-r
Re-re-ping. :) Can anyone commit these two patches please?
Thanks!
-Kees
On Sun, Jun 09, 2013 at 11:13:42AM -0700, Kees Cook wrote:
> Two users of GetReqExtra pass arbitrarily sized allocations from the
> caller (ModMap and Host). Adjust _XGetRequest() (called by the GetReqExtra
>
Any comment on these patches? Can someone commit them if they're okay?
Thanks,
-Kees
On Sun, Jun 09, 2013 at 11:13:42AM -0700, Kees Cook wrote:
> Two users of GetReqExtra pass arbitrarily sized allocations from the
> caller (ModMap and Host). Adjust _XGetRequest() (called by the
ent, but
the documentation for GetReqExtra has been updated to reflect the need
to check the value of "req" after the call.
Bug that manifested the problem:
https://bugs.launchpad.net/ubuntu/+source/x11-xserver-utils/+bug/792628
Signed-off-by: Kees Cook
---
specs/libX11/AppC.xml | 4 +++-
src
This fixes the two callers of GetReqExtra to check that "req" is non-NULL
to avoid crashing now that GetReqExtra does internal bounds-checking on
the resulting buffer sizes.
Additionally updates comment describing return values to use names
instead of only literal values.
Signed-of
Thanks for the feedback! I've split the patch into the two halves and
updated return values, etc. I'm not too familiar with the "Data" API,
so I left things as-is for the time-being. If the second patch isn't
right, hopefully the first is still useful. :)
Thanks,
-Kees
__
xserver-utils/+bug/792628
Signed-off-by: Kees Cook
---
specs/libX11/AppC.xml | 4 +++-
src/Host.c| 8
src/ModMap.c | 4
src/XlibInt.c | 8
4 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/specs/libX11/AppC.xml b/specs/libX11/AppC
Hi Guillem,
On Fri, Oct 07, 2011 at 02:49:03AM +0200, Guillem Jover wrote:
> On Thu, 2011-10-06 at 15:49:33 -0700, Alan Coopersmith wrote:
> > On 10/ 6/11 03:36 PM, Kees Cook wrote:
> > >This allows for other consumers to do single-step decoding/emulation
> > >when usin
On Thu, Oct 06, 2011 at 03:49:33PM -0700, Alan Coopersmith wrote:
> On 10/ 6/11 03:36 PM, Kees Cook wrote:
> >This allows for other consumers to do single-step decoding/emulation
> >when using x86emu. Additionally adds a stand-alone Makefile for building
> >out of tree, wh
This allows for other consumers to do single-step decoding/emulation
when using x86emu. Additionally adds a stand-alone Makefile for building
out of tree, which is very handy for doing emulation debugging.
Signed-off-by: Kees Cook
---
forwarded from https://bugs.freedesktop.org/show_bug.cgi?id
PKG_CHECK_MODULES so that
> > builders are properly notified of the version dependency.
> >
> Pushed with that change.
Thanks!
-Kees
--
Kees Cook
Ubuntu Security Team
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.
7;re good on that count, but I wanted to point it out.
Right -- I tried to be careful with this.
> On the whole, I believe this is an improvement. With the above
> corrections, I'd be happy to commit this.
Thanks, I'll send a v2 shortly.
-Kees
--
Kees Cook
Ubuntu Security
Hi, any comments on this? Seems like kind of a nasty surprise bug...
Thanks,
-Kees
On Sat, Jul 09, 2011 at 12:42:57PM -0700, Kees Cook wrote:
> Two users of GetReqExtra pass arbitrarily sized allocations from the
> caller (ModMap and Host). Adjust the GetReqExtra macro to double-check
Hi, any comments on this?
Thanks,
-Kees
On Sat, Jul 09, 2011 at 07:40:23AM -0700, Kees Cook wrote:
> This replaces sprintf with XtAsprintf to avoid crashing when creating
> various potentially large labels.
>
> https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642
>
In the ServerInterpreted case, XAddHost and XRemoveHost are capable of
failing when they lack request buffer memory. Notice this situation,
and report correctly.
Signed-off-by: Kees Cook
---
xhost.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/xhost.c b
l if
something has gone wrong.
https://bugs.launchpad.net/ubuntu/+source/x11-xserver-utils/+bug/792628
Signed-off-by: Kees Cook
---
include/X11/Xlibint.h | 28 ++--
src/Host.c|8
src/ModMap.c |4
3 files changed, 30 insertions(+)
This replaces sprintf with XtAsprintf to avoid crashing when creating
various potentially large labels.
https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642
Signed-off-by: Kees Cook
---
xclipboard.c |5 +++--
xcutsel.c|8 +---
2 files changed, 8 insertions(+), 5
Hi,
On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote:
> On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote:
> > This replaces sprintf with snprintf to avoid crashing when creating
> > various labels.
> >
> > https://bugs.launchpad.net/ubuntu/+
This replaces sprintf with snprintf to avoid crashing when creating
various labels.
https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642
Signed-off-by: Kees Cook
---
xclipboard.c |3 ++-
xcutsel.c|4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a
20 matches
Mail list logo
