[PATCH 4/7] glamor: Remove destination drawable argument from glamor_set_texture

2015-05-11 Thread Keith Packard
This argument wasn't used at all. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_transform.c | 9 +++-- glamor/glamor_transform.h | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/glamor/glamor_transform.c b/glamor/glamor_transform.c index 3036a06

[PATCH 6/7] glamor: Adapt glamor_program API to handle render acceleration

2015-05-11 Thread Keith Packard
-dependent values without using a uniform. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_copy.c| 2 +- glamor/glamor_dash.c| 2 +- glamor/glamor_points.c | 3 +- glamor/glamor_program.c | 230 ++-- glamor/glamor_program.h

[PATCH 5/7] glamor: compute GLSL version from GL_SHADING_LANGUAGE_VERSION

2015-05-11 Thread Keith Packard
This replaces a kludge which used the GL version as a proxy for the GLSL version. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index 6f4f309..641c2e4

[PATCH 1/7] render: Inline common FindGlyph case

2015-05-11 Thread Keith Packard
Provide the common path for FindGlyph as an inline function, falling back to a function for the slow case. Signed-off-by: Keith Packard kei...@keithp.com --- render/glyph.c| 2 +- render/glyphstr.h | 11 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/render

glamor: Replace render glyphs acceleration code

2015-05-11 Thread Keith Packard
This series replaces the render text acceleration code in glamor. The first two patches add some performance optimizations [PATCH 1/7] render: Inline common FindGlyph case [PATCH 2/7] Add 'likely' and 'unlikely' macros These patches change some internal glamor APIs around to eliminate an

[PATCH 3/7] glamor: Pass depth to glamor_pm_is_solid and glamor_set_planemask

2015-05-11 Thread Keith Packard
Instead of passing the destination drawable, just pass the depth, as the underlying functions need only that to check whether the planemask is going to work. This API change will allow higher level functions to not need the destination pixmap. Signed-off-by: Keith Packard kei...@keithp.com

Re: [PATCH] modesetting: Fix software cursor fallback

2015-05-11 Thread Keith Packard
Adel Gadllah adel.gadl...@gmail.com writes: Keith please merge this; has got two reviews and is already shipping in Fedora. I added one comment to the commit message as suggested by Rob. I've just merged all of the pending X server work I could find. -- -keith signature.asc Description:

Re: [PULL] randr cleanups et al

2015-05-11 Thread Keith Packard
Emil Velikov emil.l.veli...@gmail.com writes: Humble ping ? Merged. c39c3a9..0409b6e master - master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PULL] Misc fixes

2015-05-11 Thread Keith Packard
Adam Jackson a...@redhat.com writes: Brent Collins (1): shm: Fix xselinux resource initialization for xinerama pixmaps Chris Wilson (2): glx/dri2: Disable AIGLX if indirect GLX is disabled shm: Fix use-after-free in ShmDestroyPixmap Jason Gerecke (1): xfree86:

Re: [PULL: xserver] reallocarray conversion minor Solaris cleanups

2015-05-11 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Alan Coopersmith (20): Remove apSolaris.shar (old aperture kernel driver for Solaris) Remove remaining doc references to Xalloc, Xrealloc, and Xfree Let calloc handle multiplication Add XNFcallocarray() to allow

Re: [PULL] Build fixes for MinGW

2015-05-11 Thread Keith Packard
Jon Turney jon.tur...@dronecode.org.uk writes: Colin Harrison (3): os/xdmcp.c: Include Xtrans.h when building for WIN32 os/utils.c: Don't try to build os_move_fd() for WIN32 os/utils.c: Fix prototype for Win32TempDir() Jon TURNEY (2): hw/xwin/winclipboard: Link

Re: [PATCH] dix: Do not allow device transform to be set on valuatorless devices

2015-05-11 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: From: Jason Gerecke killert...@gmail.com If a device does not have any valuators, it makes no sense to set the device transformation. Return a BadMatch error to let the caller know that they're trying something stupid. Signed-off-by: Jason

Re: [PATCH] modesetting: Fix software cursor fallback

2015-05-11 Thread Keith Packard
Adel Gadllah adel.gadl...@gmail.com writes: The code in drmmode_set_cursor does not properly handle the case where drmModeSetCursor2 returns any other error than EINVAL and silently fails to set a cursor. So only return when the drmModeSetCursor2 succeeds (i.e returns 0) and disable the

Re: [git pull] second pull - randr changes + modesetting changes

2015-05-11 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Adam Jackson (1): xf86Crtc: right-of placement by default. Dave Airlie (7): xserver: add xorg.conf support for gpu devices. (v2.1) xfree86: attempt to autoconfig gpu slave devices (v3) xf86Crtc: setup tiled monitors correctly in

Re: [PATCH] xwayland: Fix error strings

2015-05-11 Thread Keith Packard
Robert Ancell robert.anc...@canonical.com writes: Fix missing newlines from error string and fix grammar. Signed-off-by: Robert Ancell robert.anc...@canonical.com Merged. d7091a2..6b65e96 master - master -- -keith signature.asc Description: PGP signature

Re: [PATCH] dix/events: Set currentTime to the given time stamp in NoticeTime

2015-05-11 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: tbh, I'm in favour of Rui's patch. That NoticeTime wasn't assigning currentTime is a bug and should be fixed. But one of the points of having NoticeTime is that we don't have to manually set the various global time fields. Even if (currently)

Re: [PATCH] xwayland: Implement smooth scrolling

2015-05-11 Thread Keith Packard
Dima Ryazanov d...@gmail.com writes: We don't even need to simulate button clicks; it's done automatically. This also fixes scrolling in Qt5 apps. Merged. 9ff89a2..81a51a6 master - master -- -keith signature.asc Description: PGP signature ___

Re: [PATCH] dix/events: Set currentTime to the given time stamp in NoticeTime

2015-04-26 Thread Keith Packard
the 'time' argument from NoticeTime, and changes the other callers of that function to stop passing currentTime. From 5f0c9fe32eebd5b3d570a6651e717101ca6f0870 Mon Sep 17 00:00:00 2001 From: Keith Packard kei...@keithp.com Date: Sat, 25 Apr 2015 23:41:12 -0700 Subject: [PATCH] dix: NoticeTime

Re: [PATCH] dix/events: Set currentTime to the given time stamp in NoticeTime

2015-04-26 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: tbh, I'm in favour of Rui's patch. That NoticeTime wasn't assigning currentTime is a bug and should be fixed. But one of the points of having NoticeTime is that we don't have to manually set the various global time fields. Even if (currently)

Re: [PATCH 1/2] xserver: add xorg.conf support for gpu devices. (v2)

2015-04-19 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: On 14 April 2015 at 00:07, Keith Packard kei...@keithp.com wrote: Dave Airlie airl...@gmail.com writes: +#define CONF_MAXGPUDEVICES 4 typedef struct { GenericListRec list; const char *scrn_identifier; @@ -276,6 +277,10 @@ typedef struct

Re: [PATCH 2/3] xf86Crtc: setup tiled monitors correctly in right of

2015-04-19 Thread Keith Packard
the right thing. I don't have a good reason to change what you've done though, so this is Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-17 Thread Keith Packard
Hans de Goede hdego...@redhat.com writes: Reviewed-by: Hans de Goede hdego...@redhat.com Keith, can you pick these 2 up directly please? Merged. 41932df..b102971 master - master -- -keith signature.asc Description: PGP signature ___

Re: [PATCH] mi: Partial pie-slice filled arcs may need more space for spans

2015-04-13 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: Signed-off-by: Keith Packard kei...@keithp.com Reviewed-by: Adam Jackson a...@redhat.com Merged. 21e7d2b..41932df master - master -- -keith signature.asc Description: PGP signature ___ xorg-devel

Re: [PATCH] Re-enable non serverfd input devices immediately on vtenter

2015-04-13 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=89756 Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Keith, please merge this directly, thanks. Merged. f1da6bf..21e7d2b master -

Re: [PATCH 2/3] modesetting: add dynamic connector hotplug support (MST) (v2)

2015-04-13 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: So we hot unplug, we remove the output XID from the server, in parallel the client does an operation with the output XID it has gotten already, and still believe is valid, and it gets BadMatch, and since hardly anyone handles X errors it falls over.

Re: [PATCH 3/5] Xephyr: Fix compile when debugging is enabled

2015-04-13 Thread Keith Packard
Egbert Eich e...@freedesktop.org writes: Signed-off-by: Egbert Eich e...@freedesktop.org Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 2/3] xf86Crtc: setup tiled monitors correctly in right of

2015-04-13 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: @@ -2121,6 +2121,7 @@ numEnabledOutputs(xf86CrtcConfigPtr config, Bool *enabled) return i; } + static Bool xf86TargetRightOf(ScrnInfoPtr scrn, xf86CrtcConfigPtr config, DisplayModePtr *modes, Bool *enabled, Extra blank

Re: [PATCH 2/3] modesetting: add dynamic connector hotplug support (MST) (v2)

2015-04-13 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: It uses the same option name as nvidia and the other DDXes to disable tearing down outputs as it is hard to avoid racing with clients. I don't think having an option here is useful -- either we figure out some way to make this reliable for clients, or we

Re: [PATCH 2/5] Xephyr: Print default server display number if none is specified

2015-04-13 Thread Keith Packard
Egbert Eich e...@freedesktop.org writes: Signed-off-by: Egbert Eich e...@freedesktop.org Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 3/3] xf86Crtc/monitors: create initial monitors for tiled outputs

2015-04-13 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This creates an automatic monitor for a tiled monitor at startup. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature

Re: [PATCH 00/17] Improved overflow checking for memory allocations

2015-04-13 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Alan Coopersmith (17): Remove remaining doc references to Xalloc, Xrealloc, and Xfree Let calloc handle multiplication Add XNFcallocarray() to allow xnfcalloc() to check for overflow Import reallocarray() from OpenBSD Add

Re: [PATCH 1/3] xf86Crtc: right-of placement by default.

2015-04-13 Thread Keith Packard
place. Been in Fedora for a few years, but for tiled monitors we really want something along these lines. This is an ABI break. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel

Re: [PATCH 1/5] Xephyr: Don't crash when no command line argument is specified

2015-04-13 Thread Keith Packard
-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/3] modesetting: stop caching mode resources

2015-04-13 Thread Keith Packard
values in the old code, making this a simple clean-up patch... Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 1/2] xserver: add xorg.conf support for gpu devices. (v2)

2015-04-13 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: +#define CONF_MAXGPUDEVICES 4 typedef struct { GenericListRec list; const char *scrn_identifier; @@ -276,6 +277,10 @@ typedef struct { char *scrn_comment; int scrn_virtualX, scrn_virtualY; char *match_seat; + +int

Re: [PATCH 4/5] Xephyr: Fix screen image draw for the non-Glamor non-XHSM case

2015-04-13 Thread Keith Packard
that at some point (ideally, by writing some kind of xcb_image_put_sub, failing that, by at least only doing the giant xcb_image_put once) Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel

Re: [PATCH 5/5] Xephyr: Fix broken image when endianess of client machine and host-Xserver differ

2015-04-13 Thread Keith Packard
, this is kinda miserable, but at least it should work now. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH] HideCursor/ShowCursor: Fix the interpretation of the window argument

2015-04-08 Thread Keith Packard
at this point would likely break existing code, and the main usage of this protocol (magnifiers) only needs the global behavior, so change the protocol to document the actual behavior. Seems reasonable to me. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description

[PATCH] mi: Partial pie-slice filled arcs may need more space for spans

2015-04-08 Thread Keith Packard
. For those, we need to reserve room for another height/2 spans. This patch just does it for all partial pie-sliced arcs to make the test easier to understand; it's just over-allocating a bit of memory, so that's safe. Signed-off-by: Keith Packard kei...@keithp.com --- mi/mifillarc.c | 5 + 1 file

Re: [PATCH] Fix XQuartz build

2015-03-31 Thread Keith Packard
Jon TURNEY jon.tur...@dronecode.org.uk writes: Subject: [PATCH] Fix XQuartz build Fix XQuartz build since commit e036cbfc Make PseudoramiXExtensionInit() prototype more generally available Merged. 7088816..d3b9c47 master - master -- -keith signature.asc Description: PGP signature

Re: [PATCH] RandR: Remove sensless checks for xf86RandR12Key

2015-03-31 Thread Keith Packard
is also correct. xf86RandR12CreateScreenResources12 also has a spurious check for xf86RandR12Key == NULL which should be removed. That's the only other place I found which needs changing. With that additional check removed, this patch is: Reviewed-by: Keith Packard kei...@keithp.com p.s. a few

Re: pull request: support for randr 1.5 tile and monitors

2015-03-31 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Dave Airlie (1): xf86Crtc: add tile prop setting Keith Packard (2): randr: Add Monitor support (v1.1) randr: Use Monitor list for Xinerama Merged. d3b9c47..e608f35 master - master -- -keith signature.asc Description: PGP

Re: [PULL] Misc patches

2015-03-27 Thread Keith Packard
Jon TURNEY jon.tur...@dronecode.org.uk writes: Jon TURNEY (13): ephyr: Avoid a segfault with 'DISPLAY= Xephy -glamor' os: XDMCP options like -query etc. should imply -listen tcp os: Teach vpnprintf() how to handle %*.*s hw/xwin/glx: Refactor parsing of the proto XML

Re: [PULL] glamor-next

2015-03-27 Thread Keith Packard
for the common GL_QUADS fallback pattern. Jon TURNEY (2): glamor: Fix build when configured --enable-glamor --disable-xshmfence ephyr: Avoid a segfault with 'DISPLAY= Xephyr -glamor' Keith Packard (13): glamor: Eliminate GLAMOR_CREATE_PIXMAP_MAP and GLAMOR_MEMORY_MAP

Re: [PULL] glamor-next

2015-03-26 Thread Keith Packard
Michel Dänzer mic...@daenzer.net writes: NAK for these changes. I'll be using the *_nf functions in the radeon driver soon, and I expect there might be interest for something similar in the modesetting driver and/or Xwayland in the long term as well. So, these seem backwards to me - you're

Re: [PULL] misc scooped up patches

2015-03-13 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Alan Coopersmith (1): Clear ListenTransConns entries in CloseWellKnownConnections Dave Airlie (1): os/access: fix regression in server interpreted auth Egbert Eich (1): symbols: Fix sdksyms.sh to cope with gcc5 Emil

Re: [PATCH xserver] config: Support multiple 'Files' sections

2015-03-09 Thread Keith Packard
Michał Górny mgo...@gentoo.org writes: Does it? Well, I didn't put much effort into that since the existing code was just dumb enough to allocate-and-replace the struct when defined multiple times. These two pieces will drop memory on the floor if invoked twice. Just calling free before the

Re: [PATCH] symbols: Fix sdksyms.sh to cope with gcc5

2015-03-03 Thread Keith Packard
Egbert Eich e...@freedesktop.org writes: Gcc5 adds additional lines stating line numbers before and after __attribute__() which need to be skipped. Signed-off-by: Egbert Eich e...@freedesktop.org If someone wants to offer to review this, that'd be awesome. If I don't hear anything fairly

Re: [PATCH] os/access: fix regression in server interpreted auth

2015-02-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This was reported on irc on Fedora when rawhide went to 1.17.1. regression occured in: 2566835b4374edb3e5a8353d4f7c9e7ec4851c57 os: Eliminate uninitialized value warnings from access.c siAddrMatch doesn't need

Re: [PULL: xserver] Compiler warning fixes for Dtrace probes, DMX

2015-02-10 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Alan Coopersmith (13): Get rid of const warnings in XSERVER_INPUT_EVENT dtrace probe calls dmx: Add _X_ATTRIBUTE_PRINTF to dmxConfigLog() dmxConfigOutput() dmx: move format strings inline so gcc can check dmx:

Re: [PATCH 0/3] present: Improve interactions with compositing manager

2015-02-08 Thread Keith Packard
Mario Kleiner mario.kleiner...@gmail.com writes: Given the variability, there's probably not much of a point in applying those, maybe at most after hiding them behind some xorg.conf option by default, so people can experiment with it if they want. I don't care one way or the other. Would be

Re: [PATCH 2/3] glamor: Don't optimize out scissor updates in CopyArea.

2015-02-05 Thread Keith Packard
that to deal with damage, I wonder how we could restructure the code so that you'd get some kind of tighter scissor, without having to recompute a bounding rectangle for every operation. Future work. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature

Re: [PATCH 1/3] glamor: Just set the logic op to what we want at the start of all rendering.

2015-02-05 Thread Keith Packard
Eric Anholt e...@anholt.net writes: If logic op is enabled, blending doesn't happen. Sure, but presumably we're almost always leaving the logic op disabled as we're using either Render or GXcopy. *not* calling glDisable for every operation seems like it might be a good idea. Yeah, I was a bit

Re: [PATCH 1/3] glamor: Just set the logic op to what we want at the start of all rendering.

2015-02-04 Thread Keith Packard
the glEnable/glDisable switch statement of doom in Mesa. Reviewed-by: Keith Packard kei...@keithp.com Could this be further optimized by not calling glDisable/glEnable in glamor_set_alu when unnecessary? If those are expensive, keeping track of the current value would seem like a good optimization

Re: [PATCH 2/3] glamor: Don't optimize out scissor updates in CopyArea.

2015-02-04 Thread Keith Packard
Eric Anholt e...@anholt.net writes: This possibly is a minor hit for immediate mode renderers (no difference on copypixin100 on my hsw, n=12), but it gives important information about drawing bounds to a deferred renderer (3.1x improvement in copypixwin100 on vc4). If you're going to set the

Re: [PATCH 3/3] glamor: Add a helper function for the common GL_QUADS fallback pattern.

2015-02-04 Thread Keith Packard
buffer and then dump the coords into the driver in the existing order. Now I can't find it though. In any case, having a wrapper function which dtrt seems fine to me. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature

Re: [PATCH] config/udev: Respect seat assignments when assigned devices

2015-01-30 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com Jonathan Dieter posted a few patches to do this inside the Xorg server but it makes no sense to do it there, just have the code we use to probe the device list at startup check seat assignments using the same code we

Re: [PATCH xf86-video-dummy 0/6] Cleanups and RandR 1.2 support

2015-01-30 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: From a quick skim of your randrproto patch, it sounds like a client should be able to call RRSetMonitor with an empty crtc list to construct its own monitor rectangles. That sounds like the right approach here. Yeah, you can list 0-n CRTCs,

Re: [RFC] [PATCH] Extend block and wakeup handling to cover writes as well

2015-01-26 Thread Keith Packard
Pierre Ossman oss...@cendio.se writes: Great. Can it get queued up for the next releases in that case? It's in my list, yes. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCHv2] dri2: Set vdpau driver name if ddx does not provide any driver name

2015-01-26 Thread Keith Packard
Adel Gadllah adel.gadl...@gmail.com writes: Currently when the ddx does not set any driver name we set DRI2 driver but not the VDPAU driver name. The result is that VDPAU drivers will not get found by libvdpau when the modesetting driver is being used. Just assume that the VDPAU driver

Re: [PATCH v2] os: Fix timer race conditions

2015-01-26 Thread Keith Packard
warning fixes from Keith Packard kei...@keithp.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com Signed-off-by: Aaron Plattner aplatt...@nvidia.com Merged. 58f28b0..fe4c774 master - master -- -keith signature.asc Description: PGP signature

Re: [PATCH] randr: attempt to fix primary on slave output (v2)

2015-01-26 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Please merge this, Merged. 62fcd36..df1b401 master - master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH xf86-video-dummy 0/6] Cleanups and RandR 1.2 support

2015-01-26 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: Yeah, I do need to look into that proposal still. But I think this is useful (in particular for 32k coordinate testing by using randr to switch dynamically between 32747x500 and 500x32767) independently. I think they go together; we need to

Re: [PATCH 0/3] present: Improve interactions with compositing manager

2015-01-26 Thread Keith Packard
Owen Taylor otay...@redhat.com writes: Sorry for getting to this so slowly. At least for the algorithms that GNOME currently uses, this isn't going to help avoid the extra frame of latency. Maybe you don't quite understand this change? What we do instead start drawing the frame at a fixed

Re: [PATCH xf86-video-dummy 0/6] Cleanups and RandR 1.2 support

2015-01-25 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: This series is a counterproposal to Nicolas's patch dummy: Add support for custom resolutions (RandR 1.2) [1] This version allows using xrandr's --fb option to resize the screen rather than having to try to create fake modes that pass validation

Re: [PATCH] os: Fix timer race conditions

2015-01-24 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: Sorry, I didn't realize you were still waiting for that. I just sent a reviewed squashed v2. Sorry for not making that more clear before; I'll get this merged for 1.17. -- -keith signature.asc Description: PGP signature

Re: [PATCH:libXxf86vm] Tell the compiler it's unlikely we're talking to an XFree86 3.x server

2015-01-23 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Hint that the current (XFree86 4.0 later) version of the protocol is most common today. I thought _X_UNLIKELY was to direct optimization? If so, it's hard to see why we'd worry about that in this extension, unless you think there's some

Re: [PATCH] randr: swap num-preferred field on RRGetOutputInfo reply

2015-01-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: On 21 January 2015 at 19:22, Carlos Sánchez de La Lama csanchez...@gmail.com wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=88614 Signed-off-by: Carlos Sánchez de La Lama csanchez...@gmail.com Reviewed-by: Dave Airlie airl...@redhat.com

Re: [PATCH] glamor: use screen blockhandler rather than dix one (v3)

2015-01-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This adds glamor into the block handler call chain in the correct place. This should fix interactions between glamor and drivers requiring damage from glamor. v2: okay don't consolidate, just leave things wierd

Re: [PATCH v2] backtrace.c: Fix word cast to a pointer

2015-01-23 Thread Keith Packard
Vicente Olivert Riera vincent.ri...@imgtec.com writes: Making the cast to a pointer-sized integer, and then to a pointer fixes the problem. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg

Re: [PATCH] Avoid possible null pointer dereference.

2015-01-23 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: On 01/20/15 04:44 PM, Carlos Olmedo Escobar wrote: Signed-off-by: Carlos Olmedo Escobar carlos.olmed...@gmail.com Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Merged. 437d2ec..f27d743 master - master -- -keith

Re: [PATCH v3 3/4] modesetting: Add support for using RandR shadow buffers

2015-01-23 Thread Keith Packard
buffers per-crtc and leave shadow_enable alone Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [PATCH] glamor: workaround a libepoxy bug in glObjectLabel

2015-01-23 Thread Keith Packard
Maarten Lankhorst maarten.lankho...@ubuntu.com writes: libepoxy doesn't handle this case well, and tries to look for the glObjectLabel symbol in GLES2. As a result, using glObjectLabelKHR with opengl, or glObjectLabel with GLES will crash. Let's get libepoxy fixed, instead of kludging

Re: [PATCH] os: Fix timer race conditions

2015-01-23 Thread Keith Packard
Nikhil Mahale nmah...@nvidia.com writes: On Monday, December 29, 2014 02:35:53 PM Keith Packard wrote: * PGP Signed by an unknown key Nikhil Mahale nmah...@nvidia.com writes: ok, here is updated patch. This patch generated a host of warnings when the type of 'timers' changed

Re: [PATCH v3 0/4] modesetting: Add RandR-based shadow buffer support

2015-01-23 Thread Keith Packard
Jason Ekstrand ja...@jlekstrand.net writes: This is my third attempt at properly adding RandR shadow support. As per my discussion with keith on my previous try, I have reworked it to be per-crtc and to not touch the old shadow code. Hopefully, the two will nicely live side-by-side for the

Re: [PATCH] modesetting: flush glamor before flushinh dirty rects to kernel

2015-01-22 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com Some kernel drivers require notification that the frontbuffer has changed, so we add a damage collector and send the dirty rects in the block handler. It appears the glamor block handler was getting called after this

Re: [PATCH] glamor: use screen blockhandler rather than dix one (v2)

2015-01-22 Thread Keith Packard
-saved_procs.block_handler = screen-BlockHandler in case the block handler chain was modified during that call. Otherwise, this is Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

[PATCH] drivers/modesetting: Save current BlockHandler on return in msBlockHandler

2015-01-22 Thread Keith Packard
If the BlockHandler chain is modified while it is active (the only time it can be modified), we need to re-fetch the current value and store it in our private for use the next time through. Signed-off-by: Keith Packard kei...@keithp.com --- hw/xfree86/drivers/modesetting/driver.c | 1 + 1 file

[PATCH] glamor: * 1/size is faster than / size in VS

2015-01-16 Thread Keith Packard
Pass the inverse of the texture size to glamor vertex shaders so that we multiply by that instead of dividing by the size as multiplication is generally faster than division. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_copy.c | 8 glamor/glamor_program.c

Re: [PULL] subwindow event fixes, capslock in Xephyr/Xnest

2015-01-16 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Olivier Fourdan (2): Fix subwindow in Xi emulated events Synchronize capslock in Xnest and Xephyr Merged. 4e12d7b..5f2e8ac master - master -- -keith signature.asc Description: PGP signature

Re: [PATCH] xwayland: Set glamor filter to nearest

2015-01-16 Thread Keith Packard
Markus Wick mar...@selfnet.de writes: glEGLImageTargetTexture2DOES only set the first level. Mesa handles this new texture as incomplete and renders a black screen. We also want to prevent linear filtering. https://bugs.freedesktop.org/show_bug.cgi?id=81800 Signed-off-by: Markus Wick

Re: 1.17 status and schedule

2015-01-11 Thread Keith Packard
Markus Wick mar...@selfnet.de writes: Yeah, I did wrote it. But meanwhile, I'd remove the MAX_LEVEL parameter as this isn't allowed in gl es. Please send an updated patch containing the bits you want, along with a Signed-off-by: line and we'll review it, merging it if it looks good. --

Re: [PATCH v2 2/6] modesetting: Use a gbm buffer for shadow if we are using glamor

2015-01-10 Thread Keith Packard
Jason Ekstrand ja...@jlekstrand.net writes: Correction, we have two completely different concepts of shadow fb going on here. One is the shadow from miext/shadow that seems to cover the entire screen pixmap. The other shadow buffers, the ones used for rotation, should be per-crtc. These

Re: 1.17 status and schedule

2015-01-09 Thread Keith Packard
Axel Davy axel.d...@ens.fr writes: Actually we went up with a solution, the final patch wasn't sent to ml for a reason I don't know or remember. Recently someone else complaint of the bug and I linked him to a preliminary patch we had, and it fixed it for him. The preliminary patch was

Re: 1.17 status and schedule

2015-01-09 Thread Keith Packard
Jasper St. Pierre jstpie...@mecheye.net writes: Well, either MAX_LEVEL / BASE_LEVEL or MIN_FILTER / MAG_FILTER will fix it. Well, we want to set the filters anyways, to avoid using LINEAR, which can end up blending just a little bit due to rounding issues. But, setting MAX_LEVEL might well

Re: 1.17 status and schedule

2015-01-09 Thread Keith Packard
Jasper St. Pierre jstpie...@mecheye.net writes: I guess I should follow up with that I don't really care how the patch ends up or which six colors of the bikeshed we end up choosing. I just want you to be aware of why that patch fixes the bug, why Eric is saying that we don't need MAX_LEVEL,

Re: [PATCH] modesetting: Update the cursor without hiding it

2015-01-09 Thread Keith Packard
Keith Packard kei...@keithp.com writes: It's unknown why the X server does this by default, but turn it off. Reviewed-by: Keith Packard kei...@keithp.com Merged. b058dec..4e12d7b master - master -- -keith signature.asc Description: PGP signature

Re: [PATCH v2 2/6] modesetting: Use a gbm buffer for shadow if we are using glamor

2015-01-08 Thread Keith Packard
-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] modesetting: Update the cursor without hiding it

2015-01-08 Thread Keith Packard
) xf86_cursors_init(pScreen, ms-cursor_width, ms-cursor_height, HARDWARE_CURSOR_SOURCE_MASK_INTERLEAVE_64 | + HARDWARE_CURSOR_UPDATE_UNHIDDEN | HARDWARE_CURSOR_ARGB); Reviewed-by: Keith Packard kei

Re: [PATCH v2 3/6] modesetting: Refactor drmmode_glamor_new_screen_pixmap

2015-01-08 Thread Keith Packard
and drmmode_glamor_handle_new_screen_pixmap so that glamor_set_screen_pixmap only gets called for the screen pixmap - Guard the call to glamor_set_screen_pixmapa with a drmmode-glamor check Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature

Re: [PATCH] backtrace.c: Fix word cast to a pointer

2015-01-08 Thread Keith Packard
Vicente Olivert Riera vincent.ri...@imgtec.com writes: Making the cast to a pointer-sized integer, and then to a pointer fixes the problem. -if (dladdr((void *)(pip.start_ip + off), dlinfo) dlinfo.dli_fname +if (dladdr((void *)(long)(pip.start_ip + off), dlinfo)

Re: [PATCH] modesetting: Copy over VRefresh to/from KMS modes

2015-01-08 Thread Keith Packard
Jasper St. Pierre jstpie...@mecheye.net writes: The kernel might want this information during modesetting. --- hw/xfree86/drivers/modesetting/drmmode_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c

Re: [PATCH] modesetting: Copy over VRefresh to/from KMS modes

2015-01-08 Thread Keith Packard
Jasper St. Pierre jstpie...@mecheye.net writes: Fine by me. I actually stopped using vrefresh in my kernel driver and instead started using drm_mode_vrefresh, so we can actually drop this patch. Oh, we should send the correct vrefresh value to the kernel; it's part of the API after all.

Re: [PATCH v2 5/6] modesetting: Add support for using shadow buffers

2015-01-08 Thread Keith Packard
; This error path will need to free the shadow data, if that was allocated as a part of this function. The rest of this patch has been Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel

Re: [PATCH v2 4/6] modesetting: Add a drmmode_bo_has_bo helper function

2015-01-08 Thread Keith Packard
Jason Ekstrand ja...@jlekstrand.net writes: --- hw/xfree86/drivers/modesetting/drmmode_display.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature

Re: [PATCH] dix: make RegionInit legal C++

2015-01-08 Thread Keith Packard
Adam Jackson a...@redhat.com writes: On Mon, 2015-01-05 at 13:54 -0800, Alan Coopersmith wrote: Same code as http://patchwork.freedesktop.org/patch/39718/ but different comments. My r-b from http://lists.x.org/archives/xorg-devel/2015-January/045096.html applies to either set of comments.

Re: [PATCH v2 1/6] modesetting: Allocate and destroy shadow_fb in drmmode_display

2015-01-08 Thread Keith Packard
Jason Ekstrand ja...@jlekstrand.net writes: This way all of the buffer allocation/destruction is in the same file. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH v2 6/6] modesetting: Return the crtc for a drawable even if it's rotated

2015-01-08 Thread Keith Packard
. Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: 1.17 status and schedule

2015-01-08 Thread Keith Packard
Michel Dänzer mic...@daenzer.net writes: On 05.01.2015 10:35, Keith Packard wrote: Ok, it's (almost) the first working day of the year, and we're supposed to be shipping 1.17. I think we're quite close, but I want to make sure everyone is ready for the release before it happens. I'd like

Re: [PATCH] modesetting: Copy over VRefresh to/from KMS modes

2015-01-08 Thread Keith Packard
Jasper St. Pierre jstpie...@mecheye.net writes: Because several functions do not properly fill in mode-VRefresh. A simple example is xf86RandRModeConvert. I figured it would be easier when we fill in vrefresh rather than fill all callers. Sounds like we should just remove VRefresh then and

<    7   8   9   10   11   12   13   14   15   16   >