Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-29 Thread Kristian Høgsberg
On Thu, Feb 27, 2020 at 7:38 PM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: > > > > Hi all, > > > > You might have read the short take in the X.org board meeting minutes > > already, here's the long version. > > > > The good news: gitlab.fd.o has become very popular

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-24 Thread Kristian Høgsberg
On Fri, Apr 21, 2017 at 5:50 AM Olivier Fourdan wrote: > > Hi Jonas, > > > > [...] > > > For that last point, I'd rather use: > > > > > > * does not guarantee that events sent to this client are > continuous, > > > a compositor may change and reroute keyboard events while the > grab > >

Re: [PATCH] xwayland: Use drm buffers for cursors if available

2016-02-10 Thread Kristian Høgsberg
On Wed, Feb 10, 2016 at 7:39 AM, Emil Velikov wrote: > Hi all, > > Just a small note: > > On 5 February 2016 at 08:42, Pekka Paalanen wrote: > >> umm, do we really want to add even more uses of the Mesa-private wl_drm >> protocol outside of Mesa? Though it seems that ship sailed a long time >> ag

Re: [PATCH] xwayland: Group multiple cursor buffers per shm pool

2015-12-04 Thread Kristian Høgsberg
On Tue, Dec 1, 2015 at 7:48 AM, Rui Matos wrote: > Each shm pool implies a file descriptor which means that currently, we > can quickly exhaust the available FDs since we create a shm pool per > cursor buffer. Instead, this patch creates shm pools big enough to > contain multiple cursor buffers to

[PATCH] xwayland: Add glamor and DRI3 support

2014-06-16 Thread Kristian Høgsberg
Reviewed-by: Axel Davy Signed-off-by: Kristian Høgsberg --- This patch comes in after the 1.16 feature freeze, but we had to wait for mesa 10.2 to come out. The mesa release brings the new gbm api that we use to implement dri3 and glamor support in Xwayland. As can be seen from the diffstat

[PULL] Xwayland fixes

2014-04-21 Thread Kristian Høgsberg
66b602474047c499b8a888267a489790fc9f9d85: xwayland: Remove left-over ErrorF logging (2014-04-21 11:25:12 -0700) Kristian Høgsberg (4): xwayland: Build without GLX extension xwayland: Build without xshmfence

Re: [PATCH 2/3] xwayland: Build without xshmfence

2014-04-08 Thread Kristian Høgsberg
On Tue, Apr 8, 2014 at 10:13 AM, Daniel Stone wrote: > Hi, > > On 8 April 2014 17:24, Kristian Høgsberg wrote: >> >> diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c >> index 5cecefd..844745a 100644 >> --- a/hw/xwayland/xwayland.c >> +++ b/hw/x

Re: Xwayland DDX: build breaks in configuration

2014-04-08 Thread Kristian Høgsberg
On Sun, Apr 6, 2014 at 8:05 AM, Gaetan Nadon wrote: > On 14-04-06 06:02 AM, Yaakov (Cygwin/X) wrote: > > Any idea how to fix this? I would prefer that the RC I'm still trying to > construct will build for most people... > > > Adding a copy of wayland-scanner.m4 to m4/ should work. > > This would w

[PATCH 1/3] xwayland: Build without GLX extension

2014-04-08 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg --- hw/xwayland/xwayland.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index c2c6481..5cecefd 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland/xwayland.c @@ -616,8 +616,10

[PATCH 2/3] xwayland: Build without xshmfence

2014-04-08 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg --- hw/xwayland/xwayland.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index 5cecefd..844745a 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland/xwayland.c @@ -573,8 +573,10 @@ xwl_screen_init(ScreenPtr

[PATCH 3/3] configure.ac: Remove check for WAYLAND_SCANNER_RULES

2014-04-08 Thread Kristian Høgsberg
This makes configure fail if the wayland autoconf macros aren't found. We don't need the scanner for shm-only xwayland so just drop this line for now. Signed-off-by: Kristian Høgsberg --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac ind

Re: Xwayland series v2

2014-04-03 Thread Kristian Høgsberg
On Thu, Apr 3, 2014 at 3:38 PM, Keith Packard wrote: > Kristian Høgsberg writes: > >> Here's an updated version of the Xwayland series. > > Thanks to Kristian for getting this cleaned up today and ready for the > merge. >3c34dd3..b4d0bec master -> master

Re: [PATCH 5/6] events: Make XYToWindow a screen function pointer

2014-04-01 Thread Kristian Høgsberg
On Mon, Mar 31, 2014 at 11:59:47PM -0700, Keith Packard wrote: > Kristian Høgsberg writes: > > > This allows DDXen to override the window picking to account for > > native windows not seen by the X server. The bulk of the picking logic > > is exposed as a new helper

Re: [PATCH 6/6] Xwayland DDX

2014-04-01 Thread Kristian Høgsberg
On Tue, Apr 01, 2014 at 12:10:09AM -0700, Keith Packard wrote: > Kristian Høgsberg writes: > > > +static WindowPtr > > +xwl_xy_to_window(DeviceIntPtr master, SpritePtr sprite, int x, int y) > > With my previous adjustment to leave the existing public XYToWindow API >

[PATCH 6/7] glamor: Expose glamor_destroy_pixmap()

2014-03-31 Thread Kristian Høgsberg
When we create a glamor pixmap by calling glamor_create_pixmap() directly, we need to call glamor_destroy_pixmap() to destroy it. Signed-off-by: Kristian Høgsberg --- glamor/glamor.h | 1 + glamor/glamor_priv.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/glamor

[PATCH 4/7] glamor: Move glamor_egl_screen_init() prototype to glamor.h

2014-03-31 Thread Kristian Høgsberg
A DDX that implements the glamor EGL functions need to pull in this prototype but shouldn't need to pull in glamor_priv.h Signed-off-by: Kristian Høgsberg --- glamor/glamor.h | 2 ++ glamor/glamor_egl_stubs.c | 4 +++- glamor/glamor_priv.h | 3 --- 3 files changed, 5 inser

[PATCH 2/7] composite: Add exception mechanism for implicit redirection policy

2014-03-31 Thread Kristian Høgsberg
: Kristian Høgsberg Reviewed-by: Keith Packard --- composite/compinit.c | 24 composite/compint.h | 7 +++ composite/compositeext.h | 4 composite/compwindow.c | 18 ++ 4 files changed, 53 insertions(+) diff --git a/composite/compinit.c b

[PATCH 1/7] events: Make XYToWindow a screen function pointer

2014-03-31 Thread Kristian Høgsberg
from a given toplevel window. Signed-off-by: Kristian Høgsberg --- dix/events.c | 99 +--- dix/touch.c | 10 -- include/cursor.h | 2 ++ include/input.h | 1 - include/scrnintstr.h | 4 +++ mi/mi.h | 3

[PATCH 3/7] dri3: Allow asynchronous implementation for dri3_open

2014-03-31 Thread Kristian Høgsberg
d the reply is moved into a helper function, which the implementation can call upon receiving its authenticaion reply. Signed-off-by: Kristian Høgsberg --- dri3/dri3.h | 6 +- dri3/dri3_request.c | 38 -- dri3/dri3_screen.c | 2 +- glamor/glamor_

Xwayland series v2

2014-03-31 Thread Kristian Høgsberg
Hi, Here's an updated version of the Xwayland series. This takes into account the patches from last series that are already upstream and adds support for glamor acceleration, DRI3+present and render nodes (when available). To that end, there are a few more patches outside Xwayland in this series,

[PATCH 5/7] glamor: Add new GLAMOR_CREATE_PIXMAP_NO_TEXTURE pixmap create flag

2014-03-31 Thread Kristian Høgsberg
This flag lets a DDX allocate a glamor pixmap without allocating the texture that backs it. The DDX can then allocate the texture itself and then set it later. Signed-off-by: Kristian Høgsberg --- glamor/glamor.c | 10 +- glamor/glamor.h | 1 + 2 files changed, 10 insertions(+), 1

[PATCH] dri3: Allow asynchronous implementation for dri3_open

2014-03-31 Thread Kristian Høgsberg
d the reply is moved into a helper function, which the implementation can call upon receiving its authenticaion reply. Signed-off-by: Kristian Høgsberg --- dri3/dri3.h | 6 +- dri3/dri3_request.c | 38 -- dri3/dri3_screen.c | 2 +- 3 files change

Re: [PATCH] mi: Hush extension initialization (#75870)

2014-03-27 Thread Kristian Høgsberg
e printing a line for every extension, whether it's enabled or > not, and b) we're not actually initializing the extension at this point. I can get behind that. Reviewed-by: Kristian Høgsberg > Signed-off-by: Adam Jackson > --- > mi/miinitext.c | 8 > 1 file c

[PATCH 5/6] events: Make XYToWindow a screen function pointer

2014-03-25 Thread Kristian Høgsberg
from a given toplevel window. Signed-off-by: Kristian Høgsberg --- dix/events.c | 99 +--- dix/touch.c | 10 -- include/cursor.h | 2 ++ include/scrnintstr.h | 4 +++ mi/mi.h | 3 ++ mi/miscrinit.c | 99

[PATCH 3/6] os: Add a mechanism to prevent creating any listen sockets

2014-03-25 Thread Kristian Høgsberg
A socket-activated server will receive its listening sockets from the parent process and should not create its own sockets. This patch introduces a NoListen flag that can be set by a DDX to prevent the server from creating the sockets. Signed-off-by: Kristian Høgsberg Reviewed-by: Daniel Stone

Xwayland series

2014-03-25 Thread Kristian Høgsberg
Hi, Here's the final patches in the Xwayland series. The first patch is a resend of the .gitignore patch that Gaeton reviewed. The next three are the os/ patches I sent out earlier to enable socket-activated DDX servers, including fixes to address Peters comment and the nolock issue I spotted my

[PATCH 4/6] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-25 Thread Kristian Høgsberg
function to set it up as an X client. Signed-off-by: Kristian Høgsberg Reviewed-by: Daniel Stone --- include/os.h| 2 ++ os/connection.c | 27 +++ 2 files changed, 29 insertions(+) diff --git a/include/os.h b/include/os.h index 90229e6..d26e399 100644 --- a/include/os.h

[PATCH 2/6] os: Always compile ListenOnOpenFD() and export it

2014-03-25 Thread Kristian Høgsberg
This function was written to allow the X server to inherit the listen socket from launchd on OS X. The code is not specific to OS X though and will be useful for on-demand launched Xwayland servers. Signed-off-by: Kristian Høgsberg Reviewed-by: Daniel Stone --- include/os.h| 4 +--- os

[PATCH 1/6] .gitignore: Add new autotools file 'test-driver'

2014-03-25 Thread Kristian Høgsberg
Automake 1.12 introduces a new parallel test framework that uses a shell script helper and generates *.log and *.trs files. Add to .gitignore. Signed-off-by: Kristian Høgsberg Reviewed-by: Gaetan Nadon --- .gitignore | 1 + test/.gitignore | 2 ++ 2 files changed, 3 insertions(+) diff

Re: [PATCH] Handle -displayfd and an explicit display number sensibly

2014-03-25 Thread Kristian Høgsberg
On Tue, Mar 25, 2014 at 9:39 AM, Jon TURNEY wrote: > On 24/03/2014 19:56, Kristian Høgsberg wrote: >> On Wed, Mar 19, 2014 at 7:26 AM, Jon TURNEY wrote: >>> Handle -displayfd and an explicit display number sensibly, e.g. use the >>> explicitly specified display

Re: [PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

2014-03-25 Thread Kristian Høgsberg
t; # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" >^ > > I've discussed this with the glibc developers and the prefered way of fixing > this is by also defining _DEFAULT_SOURCE which is the new way of stating > _BSD_SOURCE / _SVID

Re: [PATCH] Handle -displayfd and an explicit display number sensibly

2014-03-24 Thread Kristian Høgsberg
On Wed, Mar 19, 2014 at 7:26 AM, Jon TURNEY wrote: > Handle -displayfd and an explicit display number sensibly, e.g. use the > explicitly specified display number, and write it to the displayfd I don't think the two options were meant to be used together, but I can see how that would be useful.

[PATCH v2 3/3] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-19 Thread Kristian Høgsberg
function to set it up as an X client. Signed-off-by: Kristian Høgsberg --- Here's v2 of this patch, which fixes the ErrorF(stderr, ...) Peter pointed out. AddClientOnOpenFD() now returns TRUE on success and FALSE on error. It's up to the caller to log an error message and either recover or

Re: [PATCH 3/3] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-19 Thread Kristian Høgsberg
On Wed, Mar 19, 2014 at 4:29 PM, Peter Hutterer wrote: > On Tue, Mar 18, 2014 at 10:06:00PM -0700, Kristian Høgsberg wrote: >> When the Xwayland server is socket-activated, we need to connect and >> initialize the window manager before the activating client gets to >> proceed

[PATCH v2 2/3] os: Add a mechanism to prevent creating any listen sockets

2014-03-19 Thread Kristian Høgsberg
checking, since the parent process is responsible for checking the lock before picking the display name and creating the sockets. Signed-off-by: Kristian Høgsberg --- The three patches in this series were split out from one big patch and I lost the nolock detail when I split it. This v2 of the

[PATCH 1/2] .gitignore: Add new autotools file 'test-driver'

2014-03-19 Thread Kristian Høgsberg
Automake 1.12 introduces a new parallel test framework that uses a shell script helper and generates *.log and *.trs files. Add to .gitignore. Signed-off-by: Kristian Høgsberg Cc: Gaetan Nadon --- .gitignore | 1 + test/.gitignore | 2 ++ 2 files changed, 3 insertions(+) diff --git a

[PATCH 2/2] test: Don't add TEST_LDADD to list test

2014-03-19 Thread Kristian Høgsberg
The list test case is always enabled, even if Xorg is disabled. TEST_LDADD pulls in Xorg files which breaks linking when Xorg is disabled. The list test doesn't need any libraries, so just remove list_LDADD. Signed-off-by: Kristian Høgsberg Cc: Peter Hutterer --- test/Makefile.am | 1 - 1

[PATCH] .gitignore: Add new autotools file 'test-driver'

2014-03-18 Thread Kristian Høgsberg
Recent automake introduces a new shell script helper for the automake test framework. Add it to .gitignore. Signed-off-by: Kristian Høgsberg --- Gaetan, not sure what the convention is for .gitignore. You added the "Do not edit" comment, but I don't see any other mechanism f

[PATCH 3/3] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-18 Thread Kristian Høgsberg
function to set it up as an X client. Signed-off-by: Kristian Høgsberg --- include/os.h| 2 ++ os/connection.c | 20 2 files changed, 22 insertions(+) diff --git a/include/os.h b/include/os.h index 90229e6..5be3bcc 100644 --- a/include/os.h +++ b/include/os.h @@ -168,6 +168,8

[PATCH 2/3] os: Add a mechanism to prevent creating any listen sockets

2014-03-18 Thread Kristian Høgsberg
A socket-activated server will receive its listening sockets from the parent process and should not create its own sockets. This patch introduces a NoListen flag that can be set by a DDX to prevent the server from creating the sockets. Signed-off-by: Kristian Høgsberg --- include/opaque.h | 1

[PATCH 1/3] os: Always compile ListenOnOpenFD() and export it

2014-03-18 Thread Kristian Høgsberg
This function was written to allow the X server to inherit the listen socket from launchd on OS X. The code is not specific to OS X though and will be useful for on-demand launched Xwayland servers. Signed-off-by: Kristian Høgsberg --- include/os.h| 4 +--- os/connection.c | 7 ++- 2

Re: [PULL] xkb keymap loading

2014-03-18 Thread Kristian Høgsberg
d doesn't get the keymap from the Wayland server and falls back to us. Let's not pull this for now. Kristian > ---- > Kristian Høgsberg (3): > xkb: factor out xkb loading to LoadXkm > xkb: add KeymapOrDef

Re: [PATCH v2 0/5] xwayland: Refactor bits of XKB functionality

2014-03-13 Thread Kristian Høgsberg
> replaced all the tabs with spaces...) That's fine, I think I was trying to avoid a callback, but I don't think there was a good reasons for that. This new approach looks good too, for the new patches, Reviewed-by: Kristian Høgsberg > Cheers, > Peter > > > _

[PATCH 2/5] xkb: Split out code to start and finish xkbcomp

2014-03-07 Thread Kristian Høgsberg
Using the context struct from previous commit, we can now split out code to start xkbcomp and to finish and clean up after it. Reviewed-by: Daniel Stone --- xkb/ddxLoad.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/xkb/ddxLoad.c b

[PATCH 4/5] xkb: Repurpose XkbCopyDeviceKeymap to apply a given keymap to a device

2014-03-07 Thread Kristian Høgsberg
From: Rui Matos This will also make it useful for cases when we have a new keymap to apply to a device but don't have a source device. Reviewed-by: Kristian Høgsberg --- Xi/exevents.c| 2 +- include/xkbsrv.h | 4 ++-- xkb/xkb.c| 2 +- xkb/xkbUtils.c | 14 +++-

[PATCH 3/5] xkb: Add XkbCompileKeymapFromString()

2014-03-07 Thread Kristian Høgsberg
This new function compiles a keymap from an in-memory string. We use it to add a new keyooard device init function, InitKeyboardDeviceStructFromString(), which inits a keyboard device with a keymap specified as a string instead of a rmlvo set. Reviewed-by: Daniel Stone --- include/input.h |

[PATCH 1/5] xkb: Add struct XkbCompContext

2014-03-07 Thread Kristian Høgsberg
This commit adds a struct that contains most of the context for starting, running and cleaning up after xkbcomp. Reviewed-by: Daniel Stone --- xkb/ddxLoad.c | 76 +-- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/xkb/ddxLo

[PATCH 5/5] xkb: Factor out a function to copy a keymap's controls unto another

2014-03-07 Thread Kristian Høgsberg
From: Rui Matos Reviewed-by: Kristian Høgsberg --- include/xkbsrv.h | 3 +++ xkb/xkb.c| 14 +- xkb/xkbUtils.c | 23 +++ 3 files changed, 27 insertions(+), 13 deletions(-) diff --git a/include/xkbsrv.h b/include/xkbsrv.h index 5d8e409..49e236d 100644

xwayland: Refactor bits of XKB functionality

2014-03-07 Thread Kristian Høgsberg
Hi list, Here's few xkb related patches that refactor and expose xkb functionality. There should be no change in behavior in these patches, the idea is to expose new entry points into existing code. This is in preparation for merging xwayland, where the X server has to parse and apply xkb maps co

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-03 Thread Kristian Høgsberg
On Tue, Dec 3, 2013 at 1:48 AM, Hans de Goede wrote: > Hi, > > > On 12/02/2013 09:54 PM, Kristian Høgsberg wrote: >> >> On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede >> wrote: >>> >>> Hi All, >> >> >> Hi, >> >> I did

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede wrote: > Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need Xtrans patches at all. The server already has ListenOnOpenFD() in os/connection.c. It was added for launchd under OSX, but we use it for xwayland socket activat

Re: [PATCH 08/10] Add support for MIT-SHM AttachFd request

2013-11-01 Thread Kristian Høgsberg
On Fri, Nov 1, 2013 at 12:37 AM, Keith Packard wrote: > Kristian Høgsberg writes: > >> On Thu, Oct 31, 2013 at 3:43 PM, Keith Packard wrote: >>> This passes a file descriptor from the client to the server, which is >>> then mmap'd >> >> A problem

Re: [PATCH 08/10] Add support for MIT-SHM AttachFd request

2013-10-31 Thread Kristian Høgsberg
On Thu, Oct 31, 2013 at 3:43 PM, Keith Packard wrote: > This passes a file descriptor from the client to the server, which is > then mmap'd A problem we recently hit in wayland, which also affects this extension is that a client can set up shared memory like this and the truncate the tmp file to

Re: [PATCH xwayland] xwayland: Just send the bounding box of the damage

2013-10-31 Thread Kristian Høgsberg
ount < 10 or so, and fall back to bounding rect otherwise. That would let us catch common cases such as L shaped regions, while still not going all pathological on x11perf. But in practice I doubt it will make much of a difference, and simpler is better. Reviewed-by: Kristian Høgsberg

[FYI PATCH 4/4] xwayland: Use InitKeyboardDeviceStructFromString

2013-04-10 Thread Kristian Høgsberg
We can now use this new entry point from xwayland to initialize the keyboard map to what the wayland server sends. Reviewed-by: Daniel Stone --- hw/xfree86/xwayland/xwayland-input.c | 55 -- hw/xfree86/xwayland/xwayland-private.h | 5 2 files changed, 45 i

[PATCH 3/4] xkb: Add XkbCompileKeymapFromString()

2013-04-10 Thread Kristian Høgsberg
This new function compiles a keymap from an in-memory string. We use it to add a new keyooard device init function, InitKeyboardDeviceStructFromString(), which inits a keyboard device with a keymap specified as a string instead of a rmlvo set. Reviewed-by: Daniel Stone --- include/input.h |

[PATCH 2/4] xkb: Split out code to start and finish xkbcomp

2013-04-10 Thread Kristian Høgsberg
Using the context struct from previous commit, we can now split out code to start xkbcomp and to finish and clean up after it. Reviewed-by: Daniel Stone --- xkb/ddxLoad.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/xkb/ddxLoad.c b

[PATCH 1/4] xkb: Add struct XkbCompContext

2013-04-10 Thread Kristian Høgsberg
This commit adds a struct that contains most of the context for starting, running and cleaning up after xkbcomp. Reviewed-by: Daniel Stone --- xkb/ddxLoad.c | 76 +-- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/xkb/ddxLo

Re: Initial DRI3000 protocol specs available

2013-03-08 Thread Kristian Høgsberg
On Fri, Mar 8, 2013 at 3:59 AM, James Jones wrote: > On 03/07/2013 05:17 PM, Keith Packard wrote: >> >> * PGP Signed by an unknown key >> >> James Jones writes: >> >>> There didn't seem to be much interest outside of NVIDIA, so >>> besides fence sync, the ideas are tabled internally ATM. >> >> >>

Re: [PATCH] os: use libunwind to generate backtraces

2013-02-18 Thread Kristian Høgsberg
On Sat, Feb 16, 2013 at 10:45 AM, Marcin Slusarz wrote: > Libunwind generates backtraces much more reliably than glibc's "backtrace". Wow, didn't know about libunwind, it looks amazing. Do you mind if port this and use in weston? Kristian > Signed-off-by: Marcin Slusarz > --- > configure.ac

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 7:16 AM, Michel Dänzer wrote: > As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2 > drawable reference. > > [PATCH 1/2] dri2: Add DRI2CreateDrawable2. > [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Thanks, M

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 6, 2012 at 9:41 AM, Dave Airlie wrote: > On Fri, Jul 6, 2012 at 2:32 PM, Kristian Høgsberg wrote: >> On Fri, Jul 6, 2012 at 6:27 AM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> So we reserve bits 16->19 for offload device ids, this

Re: [PATCH] glx: Pass GLX drawable ID to DRI2CreateDrawable().

2012-07-06 Thread Kristian Høgsberg
On Wed, Jul 4, 2012 at 5:03 AM, Michel Dänzer wrote: > On Fre, 2012-06-29 at 19:09 +0200, Michel Dänzer wrote: >> On Fre, 2012-06-29 at 12:58 -0400, Kristian Høgsberg wrote: >> > On Fri, Jun 29, 2012 at 12:30 PM, Michel Dänzer wrote: >> > > On Fre, 2012-06-29 at

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Kristian Høgsberg
hat is all. Fixed up the maths to match reality. > v2.1: fix typo Looks fine to me. Is there a version bump that goes along with this so drivers can know they can ask for prime devices or should they just try and expect a NULL reply if it's not available? Reviewed-by: Kristian Høgsber

Re: [PATCH] glx: Pass GLX drawable ID to DRI2CreateDrawable().

2012-06-29 Thread Kristian Høgsberg
On Fri, Jun 29, 2012 at 12:30 PM, Michel Dänzer wrote: > [ Did you intentionally not Cc the xorg-devel list? ] No that was an accident... not sure why I have "reply all" as default... > On Fre, 2012-06-29 at 12:20 -0400, Kristian Høgsberg wrote: >> On Thu, Jun 28, 2012 at

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function. (v3)

2012-06-20 Thread Kristian Høgsberg
v2: Don't break ABI > v3: Paint the bikeshed blue; drop fd from AuthMagic2ProcPtr prototype Looks good, Reviewed-by: Kristian Høgsberg > Signed-off-by: Christopher James Halse Rogers > > --- >  hw/xfree86/dri2/dri2.c |   35 --- >  hw/xfr

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-19 Thread Kristian Høgsberg
On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard wrote: > Christopher James Halse Rogers > writes: > >> +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t >> magic); > > Bikeshed -- seems like the 'fd' parameter is not needed in this API? > I'll note that in the implementa

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-18 Thread Kristian Høgsberg
v2: Don't break ABI Yeah, looks good to me now. Reviewed-by: Kristian Høgsberg > Signed-off-by: Christopher James Halse Rogers > > --- >  hw/xfree86/dri2/dri2.c |   35 --- >  hw/xfree86/dri2/dri2.h |    9 - >  2 files changed, 36

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic

2012-06-17 Thread Kristian Høgsberg
On Fri, Jun 15, 2012 at 12:35:00PM +0200, Michel Dänzer wrote: > On Fre, 2012-06-15 at 19:01 +1000, Christopher James Halse Rogers > wrote: > > xwayland drivers need access to their screen private data to authenticate. > > Now that drivers no longer have direct access to the global screen arrays,

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic

2012-06-17 Thread Kristian Høgsberg
On Fri, Jun 15, 2012 at 07:01:34PM +1000, Christopher James Halse Rogers wrote: > xwayland drivers need access to their screen private data to authenticate. > Now that drivers no longer have direct access to the global screen arrays, > this needs to be passed in as function context. The way it was

Re: [PATCH 02/02] dri2: Add DRI2GetParam request

2012-05-14 Thread Kristian Høgsberg
tion intel_verify_dri2_has_hiz > > CC: Keith Packard > CC: Kristian Høgsberg > CC: Ian Romanick > CC: Eric Anholt > CC: Ville Syrjälä > CC: Michel Dänzer > CC: Jesse Barnes > CC: Chris Wilson > Signed-off-by: Chad Versace > --- >  configure.ac              |

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Kristian Høgsberg
Hi Ran, Let me just point you to this branch as well: http://cgit.freedesktop.org/~krh/libxkbcommon/log/?h=keysyms I've been talking with Daniel about this in IRC, but I thought you might want to take a look too. With those patches the API is completely self-contained. We still need xproto,

Re: [PATCH] dri2proto: Fix documented opcodes

2012-05-02 Thread Kristian Høgsberg
Kristian > CC: Kristian Høgsberg > Signed-off-by: Chad Versace > --- >  dri2proto.txt |   18 +- >  1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dri2proto.txt b/dri2proto.txt > index df763c7..7bde067 100644 > --- a/dri2proto.txt >

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-29 Thread Kristian Høgsberg
2011/9/28 zhigang gong : > 2011/9/28 Michel Dänzer : >> On Die, 2011-09-27 at 21:50 +0800, zhigang gong wrote: >>> >>> 3. Only support Intel platform currently. >>> As glamor depends on KMS + MESA/EGL + GBM, currently only >>> intel gfx device get supported. >> >> A Gallium based EGL driver (e.g. r

Re: [Mesa-dev] threads and X.org/AIGLX drivers

2011-05-12 Thread Kristian Høgsberg
On Wed, May 11, 2011 at 2:53 AM, Dave Airlie wrote: > Hey, > > So we got a bug reported against F15 where we were getting an illegal > input event type 0, after passing it around the RH X team I eventually > came to look at it. > > The problem appears to be that we are using llvmpipe as our swrast

Re: [Mesa-dev] auto generated glx code in X server

2011-03-15 Thread Kristian Høgsberg
On Tue, Mar 15, 2011 at 12:12 AM, Keith Packard wrote: > On Tue, 15 Mar 2011 13:52:40 +1000, Dave Airlie wrote: > >> a) undo ajax's cleanup, fix generator scripts to work again (not sure >> how possible that is >> since Olv's mapi changes), import latest GLX into server on a >> semi-regular basis

[PATCH] Replace malloc with calloc to initialize the buffers[] as NULL in do_get_buffers function

2011-02-10 Thread Kristian Høgsberg
From: Justin Dou The calling for allocate_or_reuse_buffer may fail due to some reason, e.g. out of memory. If the buffers[] were not initialized to be NULL, the following err_out may try to access an illegal memory, which will cause X crash afterward. Reviewed-by: Kristian Høgsberg Signed

Re: [PATCH libxkbcommon] Get rid of unneeded include.

2011-01-29 Thread Kristian Høgsberg
On Sat, Jan 29, 2011 at 8:24 AM, Cyril Brulebois wrote: > There's no need for this xlib include: > |   YACC   xkbparse.c > |   CC     xkbparse.lo > | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory > > Signed-off-by: Cyril Brulebois Yes, thanks, applied. Kristian >  src/xkbcomp/

Re: [PATCH 0/5] glx input sanitizing

2011-01-10 Thread Kristian Høgsberg
On Mon, Jan 10, 2011 at 6:41 AM, Julien Cristau wrote: > On Mon, Jan  3, 2011 at 21:08:05 +0100, Julien Cristau wrote: > >> Most of this series has been sitting in bug#28823 for a while.  It adds >> some missing checks for client-provided data in the glx code, and fixes >> a bug in the swapped-cli

[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-16 Thread Kristian Høgsberg
, https://bugs.freedesktop.org/show_bug.cgi?id=28181 v3: Just use the refcnt and don't try to free other resources in the DrawableGone callback. Signed-off-by: Kristian Høgsberg Can we just do this instead? Didn't test the patch, but this should do the same and actually simplifie

Re: where is KMS API docs?

2010-12-14 Thread Kristian Høgsberg
On Tue, Dec 14, 2010 at 9:59 AM, Jeremy C. Reed wrote: > Where is the documentation for the KMS API? > > Any man pages? > > If not written, please point me to any specifications or source used for > learning the API. There is no documentation, you can browse the API here: http://cgit.freedeskt

Re: Fence Sync patches

2010-12-08 Thread Kristian Høgsberg
On Tue, Dec 7, 2010 at 7:54 PM, James Jones wrote: > On Sunday 05 December 2010 20:31:24 Owen Taylor wrote: ... >> But I can't say that I'm at all happy the idea that we'll have two sets of >> drivers, one where flushing rendering enables an implicit fence for >> subsequent rendering from that buf

Re: [PATCH libxkbcommon 0/6] Review libxkbcommon configuration Part 2

2010-12-07 Thread Kristian Høgsberg
that have it. > > Acked-by: Daniel Stone > > Please feel free to push these patches to the repo as well. Yup, it all looks fine. For the series: Reviewed-by: Kristian Høgsberg ___ xorg-devel@lists.x.org: X.Org development Archives: http://lis

Re: [RFC XI 2.1 - inputproto] Various fixes in response to Peter Hutterer's review

2010-12-02 Thread Kristian Høgsberg
On Thu, Dec 2, 2010 at 10:46 AM, Daniel Stone wrote: ... > OK, so would something like this suit you: >  * at selection time, clients can choose whether or not to receive >    not-for-you events >  * at any point during a touch stream, the current owner of a touch can >    tell the server that it

Re: [PATCH] glx: Remove swap barrier and hyperpipe support

2010-11-19 Thread Kristian Høgsberg
ow, it is, so any implementation of these should be done with > additional DRI driver API, like the swap control extension. Yeah, kill it. Signed-off-by: Kristian Høgsberg > Signed-off-by: Adam Jackson > --- >  glx/Makefile.am          |    1 - >  glx/g_disptab.h          |

Re: The future of Xephyr and Kdriver

2010-11-08 Thread Kristian Høgsberg
On Mon, Nov 8, 2010 at 11:01 AM, Jamey Sharp wrote: > On Mon, Nov 8, 2010 at 1:45 AM, Feng, Haitao wrote: >> Have you noticed Kristian's Wayland project? In an email discussion, >> Kristian mentioned the "Xorg on Xorg" idea and discussed its design and >> implementation. Quoted from the email: >>

Re: [PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-29 Thread Kristian Høgsberg
lementation is using > DRI2 directly. > > DRI2 code in server doesn't handle DRI2DestroyDrawable that leaks > references. If client recreates rendering target EGL destroys and > creates DRI2 drawable. In that case DRI2DestroyDrawable leaks DRI2 > drawable references. > >

Re: [PATCH 00/15] xserver: cleanup and standardize startup options

2010-10-28 Thread Kristian Høgsberg
On Thu, Oct 28, 2010 at 10:08 AM, Alan Coopersmith wrote: > Tiago Vignatti wrote: >> Hi fellows, >> >> Our culture is turning "-option" the default syntax for arguments to be >> passed >> to the server. This patch set tries to standardize the rest of arguments that >> are not on such shape yet, r

Re: RFC: Use libxkbcommon in Xorg

2010-10-26 Thread Kristian Høgsberg
2010/10/26 Jon TURNEY : > > > On 22/10/2010 03:26, Kristian Høgsberg wrote: >> >> Now, it's all looking pretty promising, but there are a few open >> issues I'd like to throw to the list.  First of all, there's the issue >> of how this inters

RFC: Use libxkbcommon in Xorg

2010-10-21 Thread Kristian Høgsberg
Hello, At XDS I volunteered to make X use libxkbcommon and I've spent a few days this week trying to make that happen. libxkbcommon is a new library started by Dan Nicholson which pulls in bits and pieces from various XKB components, and primarily it provides a library interface to the xkb compil

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Kristian Høgsberg
On Wed, Oct 20, 2010 at 7:45 PM, Keith Packard wrote: > On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner > wrote: > >> In addition to the above, this commit also broke the Compiz >> "Wallpaper" plugin. > > Ok, as usual, Dave Airlie is right here -- independent of whether this > patch is a good

Re: [PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

2010-10-20 Thread Kristian Høgsberg
this commit also broke the Compiz > "Wallpaper" plugin. > > This reverts commit 8d7b7a0d71e0b89321b3341b781bc8845386def6. Sure, we can revert it. I never saw the corner case it fixes trigger, we usually never actually fill up a protocol buffer with damage events. The only case

Re: [PATCH v2] glx: Fix use after free in DrawableGone

2010-09-27 Thread Kristian Høgsberg
2010/9/23 Kristian Høgsberg : > 2010/9/23 Jeremy Huddleston : >> That seems off to me.  This is doing more than changing the c->next >> dereference.  You're now freeing it where you weren't before. >> >> Previously, you freed it inside: >> if

Re: [PATCH v2] glx: Fix use after free in DrawableGone

2010-09-23 Thread Kristian Høgsberg
) callback for. We treat that as an unbind, which triggers the context destruction. As Jon mentions, that may not be the right thing to do, but in the scope of this patch, we're just delaying the destroy until we're done touching the context. Kristian > On Sep 23, 2010, at 06:04,

Re: [PATCH] glx: Fix use after free in DrawableGone

2010-09-23 Thread Kristian Høgsberg
2010/9/23 Jon TURNEY : > On 23/09/2010 13:50, Kristian Høgsberg wrote: >> >> Signed-off-by: Kristian Høgsberg >> --- >> >>> ==2989== Invalid write of size 4 >>> ==2989==    at 0x48CE6E5: DrawableGone (glxext.c:169) >>> ==2989==    by 0x809

[PATCH v2] glx: Fix use after free in DrawableGone

2010-09-23 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg --- Chris Wilson points out that we were still accessing c->next after free. Here's an updated version that fixes that. Kristian glx/glxext.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/glx/glxext.c b/glx/glxext

[PATCH] glx: Fix use after free in DrawableGone

2010-09-23 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg --- > ==2989== Invalid write of size 4 > ==2989==at 0x48CE6E5: DrawableGone (glxext.c:169) > ==2989==by 0x809F401: FreeResource (resource.c:601) > ==2989==by 0x80845CE: ProcDestroyWindow (dispatch.c:733) > ==2989==by 0x80

Re: [PATCH xserver] config: remove --with-dri-driver-path option, use dri.pc #29740

2010-08-24 Thread Kristian Høgsberg
2010/8/24 Gaetan Nadon : > On Tue, 2010-08-24 at 12:56 +0200, Michel Dänzer wrote: > > Could just use dri.pc for the default value of the option, rather than > removing it altogether? > > Yes. I think the author of the bug report wishes to also remove the option > as it is no longer useful. > > Thi

Re: X Gesture Extension protocol - draft proposal v1

2010-08-16 Thread Kristian Høgsberg
On Mon, Aug 16, 2010 at 11:13 AM, Chase Douglas wrote: > >                            The X Gesture Extension >                                  Version 1.0 > >                                 Chase Douglas >                          chase.doug...@canonical.com >                                Can

[PULL] Flush fixes

2010-08-06 Thread Kristian Høgsberg
The following changes since commit 7e0575baf14ec4a89492fd2780f9ab5b9244afbd: ddc: Fix memory leak in GetEDID_DDC1 (2010-08-01 22:48:21 -0400) are available in the git repository at: git://anongit.freedesktop.org/~krh/xserver flush-callback Kristian Høgsberg (2): Always call the flush

  1   2   >