* On 03/14/2018 05:19 AM, Keith Packard wrote:
> I'll take that as a 'Reviewed-by', unless you have some objection.
Sure, go ahead!
signature.asc
Description: OpenPGP digital signature
___
xorg-devel@lists.x.org: X.Org development
Archives:
* On 03/12/2018 08:27 PM, Keith Packard wrote:
> This field was defined as a Bool in the protocol headers and BOOL in
> xcb. Bool is not a valid type for protocol fields. It is defined as
> 'int' by Xdefs.h, which we expect to be 32-bits on all machines.
>
> The protocol headers and xcb have
* On 03/12/2018 05:13 AM, Keith Packard wrote:
> Oh. This is pretty bad. 'Bool' is not a valid type in protocol headers,
> it should have been BOOL. And, BOOL is a single byte. But, it is Bool,
> and I guess that is generally 4 bytes on most architectures.
>
> The XCB headers define this field as
Hi
In
https://cgit.freedesktop.org/xorg/xserver/commit/?id=9edcae78c46286baff42e74bfe26f6ae4d00fe01
the swapl() call for stuff->suspend was removed. That sounds like a bad idea to
me?
xScreenSaverSuspendReq to this day defines it as a Bool, which is typedef'd to
int everywhere and includes the
On 01.07.2015 04:58 PM, Adam Jackson wrote:
On failure, AddResource calls the deleteFunc for the given type and
value. Here, that's RRModeDestroyResource, which already does
free(mode) as the last step. So this patch would introduce a double
-free.
It does indeed. But only because the ref
On 14.06.2015 11:20 PM, Mihai Moldovan wrote:
This is a follow-up to c7b7abfaa068042e396d19538215402cfbb4f1e4.
This is just a friendly reminder to please look into the submitted patch, if
possible.
Mihai
signature.asc
Description: OpenPGP digital signature
This is a follow-up to c7b7abfaa068042e396d19538215402cfbb4f1e4.
Signed-off-by: Mihai Moldovan io...@ionic.de
---
randr/rrmode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/randr/rrmode.c b/randr/rrmode.c
index a7aa433..ef90a46 100644
--- a/randr/rrmode.c
+++ b/randr/rrmode.c
@@ -90,6
